From: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
To: "H.J. Lu" <hjl.tools@gmail.com>, Binutils <binutils@sourceware.org>
Subject: Re: [PATCH] PR28972, gprofng libraries should be installed under $(pkglibdir)
Date: Mon, 21 Mar 2022 21:56:45 -0700 [thread overview]
Message-ID: <d4e7b606-d791-e4fa-a8e7-0f99d6e20999@oracle.com> (raw)
In-Reply-To: <CAMe9rOr29yy5Fx4cJFQ9-ptdPSJUsC2qUumvXZLADTfAyswezg@mail.gmail.com>
On 3/21/22 19:42, H.J. Lu wrote:
> This is the patch I am checking in.
>
> Thanks.
>
> -- H.J.
Hi H.J.,
The fix is wrong in gprofng/libcollector/Makefile.am:
% diff --git a/gprofng/libcollector/Makefile.am
b/gprofng/libcollector/Makefile.am
index 901d9a5f0ee..ffb4f977aa5 100644
--- a/gprofng/libcollector/Makefile.am
+++ b/gprofng/libcollector/Makefile.am
@@ -54,7 +54,7 @@ myinclude_HEADERS =
$(srcdir)/../../include/collectorAPI.h \
$(srcdir)/../../include/libcollector.h \
$(srcdir)/../../include/libfcollector.h
-lib_LTLIBRARIES = libgp-collector.la libgp-collectorAPI.la libgp-heap.la \
+pkglib_LTLIBRARIES = libgp-collector.la libgp-collectorAPI.la
libgp-heap.la \
libgp-sync.la libgp-iotrace.la
libgp_collector_la_SOURCES = $(CSOURCES)
@@ -77,3 +77,7 @@ libgp_iotrace_la_LDFLAGS = $(AM_LDFLAGS)
libgp_collectorAPI_la_SOURCES = collectorAPI.c
libgp_collectorAPI_la_LIBADD = -lc -ldl
+.PHONY: install-data-local
+
+install-data-local: install-pkglibLTLIBRARIES
+ rm -f $(DESTDIR)/$(pkglibdir)/*.la $(DESTDIR)/$(pkglibdir)/*.a
We may not remove libgp-collectorAPI.a, libgp-collectorAPI.a and the
library that was built in the gprofng/src directory (libgprofng.la).
The following fix was in In my patch:
+.PHONY: install-data-local
+
+install-data-local: install-pkglibLTLIBRARIES
+ for f in libgp-collector libgp-heap libgp-sync libgp-iotrace ; do \
+ rm -f $(DESTDIR)/$(pkglibdir)/$$f.la
$(DESTDIR)/$(pkglibdir)/$$f.a ; \
+ done
+
-Vladimir
next prev parent reply other threads:[~2022-03-22 4:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 17:00 vladimir.mezentsev
2022-03-20 23:09 ` H.J. Lu
2022-03-20 23:45 ` H.J. Lu
2022-03-21 1:29 ` H.J. Lu
2022-03-21 15:48 ` Vladimir Mezentsev
2022-03-21 19:02 ` H.J. Lu
2022-03-21 20:51 ` Vladimir Mezentsev
2022-03-21 21:05 ` H.J. Lu
2022-03-21 21:15 ` Vladimir Mezentsev
2022-03-21 21:49 ` H.J. Lu
[not found] ` <d585b1f8-f3d0-7a0c-ef9f-1dcaff9c7307@oracle.com>
2022-03-22 2:42 ` H.J. Lu
2022-03-22 4:56 ` Vladimir Mezentsev [this message]
2022-03-22 19:04 ` Vladimir Mezentsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4e7b606-d791-e4fa-a8e7-0f99d6e20999@oracle.com \
--to=vladimir.mezentsev@oracle.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).