From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by sourceware.org (Postfix) with ESMTPS id 34A153857C6F for ; Thu, 14 Apr 2022 16:37:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 34A153857C6F Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2058.outbound.protection.outlook.com [104.47.13.58]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-7-5qAK462MNTWjR5Gio0si6A-1; Thu, 14 Apr 2022 18:37:24 +0200 X-MC-Unique: 5qAK462MNTWjR5Gio0si6A-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZjHGgkegDPOvWFSMf2sSfGDFfHmq+U6+lXvhs7BzKQEWCvqHs8BoXvXkVKB24j/rottYp2Dhea6h+7i+7hXXlRcsQmWi8xT1LKG+rtMXj6VP3HlPwnI96OfedpGf+wTh7rCks/7JtIgZ/zXll9h0+xy19QIl1dAraDfU1PDHoq/KkuvhWF6HOZOsM1G5RlqzvRgUNwouTgsQA5yUB+4Sd0TVjcKI3TuMYblHiv/eZo5SOSQTjZ3xIdJaDkGp+yNcBc7DvF3xWabcJDvbt2VAb0mTgY1AiWgYf/+rI2IMn+spuRLo6YCzKyU7wSEeBFxklivlcffzYU8KIdBU3C21xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pCi3xhCYXfU+NwkjnjZUu37x942aZCKcQChDG4M+mYM=; b=XCuItqiboCutKeCbtMBczdPU7J3R38MkBwpE0al9C4odYFV2VSlDT9qJ4N85bP0bWBB8nuHImnXX9qt+uFbWmNzEF+gMVDCWnamirJFSgPsqGrEH5HCufB8omzY9HlOwKbRyT1lfBrUMkqFlyWoUdTdbKhdrpKpcLVXYw32/B7BLFZTnSWHzVltFyG5fkzePRVWxaQBJ6TtgkANzRyOTPOThL7AclBnY7qY7pZLdy1Br3cEkT/H6W0y6frCetWW0O5+qxr+fbYGQ6FN8OQIxV7wx73ynLaBWPTT6msjDaNw2lCGffqP+Tyy2moiVXEQpRI7mmefBbHgHzRaNM5aq2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by VI1PR04MB3295.eurprd04.prod.outlook.com (2603:10a6:802:f::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Thu, 14 Apr 2022 16:37:22 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5164.020; Thu, 14 Apr 2022 16:37:22 +0000 Message-ID: Date: Thu, 14 Apr 2022 18:37:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] x86: VCMPSH is Evex.LLIG Content-Language: en-US To: "H.J. Lu" Cc: Binutils , "Cui, Lili" References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8PR05CA0002.eurprd05.prod.outlook.com (2603:10a6:20b:311::7) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: defcffc0-e84c-44a7-3361-08da1e350cd9 X-MS-TrafficTypeDiagnostic: VI1PR04MB3295:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZuS2YxmtPuJvTjl54PvNZWjSKyVdjBdK7ERvDhw03C/6V034hjSZwT/TXmB57bLZ681eEWvahXdSRLSYQYhgoDYMfwVb+Rcl0Se0sXzfVE9adjWFC38bg+5Xr9Rbvxcvg9gyCBRzr83yYk6tGtVbpUHHssDOx0MrkT8+e3DtLyxHKsS8JI82wA1Y7/GKBhv4nQFUBMgkN6fJNYYZQLf+DdwsRTDx1krt11GdJlFkqG2r8UfnVSt+UcArZlSuo1FLX6+B2tPXe1qkLd/EykDyIv95UY24rtpIg2o578Ut7IVKzyxiwE1thn/6tNFSCkJ5GItbZ62c+ehNhO1wpfP5Sz105x62z71y4owgMRNvSMz1krKpWdpE98CO/MkD6CNX0+ohMbDqpmIvVdMmhTkq3linbeVeJLljMykVAmYwkDdisE1TmMvOggPdZltwgo0IzQqSusfz0auEVON2vlqnwyudsvTcao+cyFARvGjLbdsIXXxtdxMfHAhWYEkXc4T/1E3YLn6W1GMl+eJ78rvTAOe6BY7HQ50EEAyR5hcI5sHKCbK75U2o68dFcWo88/+6tnlFFCWf95ZIcXdElcmh/AnSQ9xdxs7nta/Yjetd3StU9LrNwSoz/hj2rGHI2NxVGE/LbwEQPNDPaEQ1RqsjexwFfvD9NPbO+xd5JdFoJsxcGE/0NfqNPqgxysYrcyVpjzUqoYa7vSQg5rgpcYaoOPxLk5Jbz8NNa5asbn27fxU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8616.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6486002)(508600001)(6506007)(53546011)(36756003)(83380400001)(31686004)(66556008)(66476007)(8676002)(66946007)(4326008)(316002)(6916009)(38100700002)(86362001)(8936002)(31696002)(30864003)(6512007)(54906003)(26005)(186003)(5660300002)(2616005)(2906002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NHpnRTlNRHpEWmdKN2hwejFnSVNhWE1GRllmYUtDd1lZRHhyT0QxNUpjWS9a?= =?utf-8?B?VGNSb1hWOXZzQXJ1RVdNcEZuQ1hJeVJpTjEwbWZHM1FqSkJxNHRjVFBYdzUv?= =?utf-8?B?blBFa2VNTnJFYW9uVWt0ckc2SnVpR28vekQ5L3NxMjU5SkRHUUdFci9yN2Va?= =?utf-8?B?Y1NQUlhpaTA5SVg0U1R3SlBWaWd0RFFzeUpZYlk0aVBhUG0wZVBkZ0lpVTBW?= =?utf-8?B?VzE0OWliU0JPMEVoYUU2RDlPK3ArVXRFSUR0cXhvWFNrNlp4SDMraVlRaW9F?= =?utf-8?B?dUdHdU9iM3BMMEREUzBoeStsUS9GTHllcURFRXZpajRxZThWV2pyTzRpK0xG?= =?utf-8?B?cnNUUzAzbTRHdGt6SW1MS2tFOWlxTVUwaWVrSnNXZkxIYlFsNW9pUGR5ZmR3?= =?utf-8?B?N2wvWnlVeWNEYUg5SWloWEdjL0hPRXRPQnNBWC95eXFCZklPY1NneTJzMGNs?= =?utf-8?B?UGFzcXMxVGdVd0JaZGpkK0xKbWgrTTJ6MndUMlN0TTRENDJwb3pPS1RmQ0xl?= =?utf-8?B?eFZ6cWR1RGJkMTVVMDBsaDkzb01DN0FmWFUybERrK3RYa0RRWnQ0cTFiZnJh?= =?utf-8?B?R3hWczBad2lZTkpZd1l1ZllYeU1sYlJ6Uk8wRXd0QzdTOGdaVmRPbHQrTmR2?= =?utf-8?B?VWoycm14Umh5VDdudUhXaW9XQjQ3cld5V0hWVndvbFFwR1RFWmVKcHkxdTVG?= =?utf-8?B?TmFWZUs2SnJuTjRrdE9jQ1FBNUd2ZlpjRVJwQ2hIN1hhVzlKZkFUeGdUVE9Q?= =?utf-8?B?RVFZRFk0ZXpYYVZlUXAyckhSYnJGNG03eUlkODBuQjh4TVdUMDExRU1rbjVv?= =?utf-8?B?UUpoVnJuKzFnekI5NTg2d3E1VHpwQlZtSFFscEhIWlp1RWdObGk3QzY2OFJX?= =?utf-8?B?N090Y0FpUkV6Z2VPSHN2eFhDTkt4WFA4czQ4WFVXS2MrNkVHcTk4aFVQTzFM?= =?utf-8?B?RzV6SGxKLzRxSzNWMFY5bTR2SGdMcGR1d0JzN0k4ZW9HYzhRelIxa3VkZTNK?= =?utf-8?B?c0ZPN2Rva1VJU2NtbzdxUzFKTlB3YzllS01IeHVRdEkrd3FRejVyZnd3SHVK?= =?utf-8?B?WGRSR0pDc3JUZkRuZjc1T1NITFd2dml5b2lQWlNHVFg2NmpJWWRJSGNveUJL?= =?utf-8?B?WG9aTklZK0dvNW1LUVFHOVBueTVzL0ZCQWVEVW5FaFRFeGFxWncyUUs0VnVQ?= =?utf-8?B?VVJmMGZaZTVWZVpTNHJaQnFmZnJYZWdqTW9tb09uSW56U21TU3k5aEVkSnhD?= =?utf-8?B?YmRSQzg2VVIxYXIrY25nZ1BUY1dIY0JaQkJ4OGs0eVJpT2JKeGIwVExnQTd2?= =?utf-8?B?MmdCZ0YvRkRYanhCTDh0UEl1eGVmNFgzNU5XcEptdUlDYXNaOTBvZDNnWmdn?= =?utf-8?B?N3hmYWZsb2M3MXNQd2tHa1lFVnFPb01CUkZscWpxZXAyclBNNHh6TENraTRE?= =?utf-8?B?Vm5Zbmt6eVJvN3BqUEJqUFJhOVhxS01TclZrSU9UYUxPUUFrUmtZSmFka25M?= =?utf-8?B?b3B4V0FsRFhER2FPdTljNzEyZ1piOWhidDNxeWZDVUZLdGVUaUJUODMzS0wy?= =?utf-8?B?UnNjK0hld3kyMDNydTVaVElwQzBHdGZ5UldnNWNUa3dXT0lxb1FKTVhXK3Bm?= =?utf-8?B?dHFPdldyN3pKd1VLaFZLR2IvZE90VExnY3kwcDlwWFBJajNLSjRkODlaUUVt?= =?utf-8?B?MkZoYzVDZk1SclVjbFNMMmJFSk0wekkzV3Jjd0hRdW9Za3RINmdYZVd1WDgx?= =?utf-8?B?cVJzMms2OHF5K1VjWWJQUTFGV3BNOE5HRnh6ajVpeERTMmJyMWI4Uk1TTmVi?= =?utf-8?B?YUp6UEdvZ20rRTNaamRhOEFyc1dDMmxTY0ZzSThpbllnODk3YWtVNW4zSUhQ?= =?utf-8?B?ejJhOEt1bG92MGh5UlRFWkNoeWtmczdpV29VUkVjbG9XSGQrMlhnUlNCV1BU?= =?utf-8?B?citBMnVLUytZMFl5SFRLZGVJQW94L1hsQXZkMWRCaGxEb3BJeTgrMzR0YS9l?= =?utf-8?B?U2YvQzVkWkJuK1FZc3hhaFdhM05Lcm50MDNPT3V2Nm5heEhXTUxRdEF6V21S?= =?utf-8?B?bm1kUzNvNmMzcFNaS2xKK0tSLyt0OElmdUx3bkZjZDlwQUNiVFpmNDJ1ZjhN?= =?utf-8?B?eDA5bFhPY21JOG1tY1hIMzlHV0ZXbC81bUxKR2NOVC84RzNYRDEzZTBUZTk0?= =?utf-8?B?WTZmWEI0eUNielRhd3RPYVYybWhCekZnY25QTW0yV1pVRGgyR0VEZWRtTERE?= =?utf-8?B?SW12MTgvWmhZbC9GcDdCZFA1MHp5ZEhpYStFZE5uMGZkdWpWZVJYY0l4ZitE?= =?utf-8?B?SWJURlNmNkR5UStrMloxNmxkNjR5UVozOUFVTmozMFg0NUFjTHFCZz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: defcffc0-e84c-44a7-3361-08da1e350cd9 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 16:37:22.5257 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jpf9e+R71nVcxVJiY4YcZp5eHns4fMxDatn/6D2wiwFcJ9Mpsjf0ghtemtCogwW1H6BfyVlaQ5L2rKvo1rRTiw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3295 X-Spam-Status: No, score=-3031.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, LOTS_OF_MONEY, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Apr 2022 16:37:29 -0000 On 14.04.2022 18:34, H.J. Lu wrote: > On Thu, Apr 14, 2022 at 9:24 AM Cui, Lili wrote: >> >> >> >>> -----Original Message----- >>> From: H.J. Lu >>> Sent: Thursday, April 14, 2022 11:22 PM >>> To: Beulich, Jan ; Cui, Lili >>> Cc: Binutils >>> Subject: Re: [PATCH] x86: VCMPSH is Evex.LLIG >>> >>> On Thu, Apr 14, 2022 at 7:12 AM Jan Beulich wrote: >>>> >>>> These were mistakenly flagged as Evex.128. Getting the LLIG status >>>> right for insns allowing for SAE is a prereq for planned further work. >>>> >>>> --- a/gas/testsuite/gas/i386/evex-lig.s >>>> +++ b/gas/testsuite/gas/i386/evex-lig.s >>>> @@ -1703,6 +1703,13 @@ _start: >>>> vrndscaless $123, -512(%edx), %xmm5, %xmm6{%k7} # AVX512 >>> Disp8 >>>> vrndscaless $123, -516(%edx), %xmm5, %xmm6{%k7} # AVX512 >>>> >>>> + vcmpsh $123, %xmm4, %xmm5, %k5 # AVX512-FP16 >>>> + vcmpsh $123, {sae}, %xmm4, %xmm5, %k5{%k7} # AVX512-FP16 >>>> + vcmpsh $123, (%ecx), %xmm5, %k5 # AVX512-FP16 >>>> + vcmpsh $123, -123456(%esp, %esi, 8), %xmm5, %k5{%k7} # AVX512- >>> FP16 >>>> + vcmpsh $123, 254(%ecx), %xmm5, %k5 # AVX512-FP16 Disp8 >>>> + vcmpsh $123, -256(%edx), %xmm5, %k5{%k7} # AVX512-FP16 >>> Disp8 >>>> + >>>> .intel_syntax noprefix >>>> vaddsd xmm6{k7}, xmm5, xmm4 # AVX512 >>>> vaddsd xmm6{k7}{z}, xmm5, xmm4 # AVX512 @@ -3403,3 +3410,9 >>>> @@ _start: >>>> vrndscaless xmm6{k7}, xmm5, DWORD PTR [edx-512], 123 # >>> AVX512 Disp8 >>>> vrndscaless xmm6{k7}, xmm5, DWORD PTR [edx-516], 123 # >>> AVX512 >>>> >>>> + vcmpsh k5, xmm5, xmm4, 123 # AVX512-FP16 >>>> + vcmpsh k5{k7}, xmm5, xmm4, {sae}, 123 # AVX512-FP16 >>>> + vcmpsh k5, xmm5, WORD PTR [ecx], 123 # AVX512-FP16 >>>> + vcmpsh k5{k7}, xmm5, WORD PTR [esp+esi*8-123456], 123 # >>> AVX512-FP16 >>>> + vcmpsh k5, xmm5, WORD PTR [ecx+254], 123 # AVX512-FP16 >>> Disp8 >>>> + vcmpsh k5{k7}, xmm5, WORD PTR [edx-256], 123 # AVX512-FP16 >>> Disp8 >>>> --- a/gas/testsuite/gas/i386/evex-lig256-intel.d >>>> +++ b/gas/testsuite/gas/i386/evex-lig256-intel.d >>>> @@ -1536,6 +1536,12 @@ Disassembly of section .text: >>>> [ ]*[a-f0-9]+: 62 f3 55 2f 0a b2 00 02 00 00 7b vrndscaless >>> xmm6\{k7\},xmm5,DWORD PTR \[edx\+0x200\],0x7b >>>> [ ]*[a-f0-9]+: 62 f3 55 2f 0a 72 80 7b vrndscaless >>> xmm6\{k7\},xmm5,DWORD PTR \[edx-0x200\],0x7b >>>> [ ]*[a-f0-9]+: 62 f3 55 2f 0a b2 fc fd ff ff 7b vrndscaless >>> xmm6\{k7\},xmm5,DWORD PTR \[edx-0x204\],0x7b >>>> +[ ]*[a-f0-9]+: 62 f3 56 28 c2 ec 7b vcmpsh k5,xmm5,xmm4,0x7b >>>> +[ ]*[a-f0-9]+: 62 f3 56 1f c2 ec 7b vcmpsh >>> k5\{k7\},xmm5,xmm4,\{sae\},0x7b >>>> +[ ]*[a-f0-9]+: 62 f3 56 28 c2 29 7b vcmpsh k5,xmm5,WORD PTR >>> \[ecx\],0x7b >>>> +[ ]*[a-f0-9]+: 62 f3 56 2f c2 ac f4 c0 1d fe ff 7b vcmpsh >>> k5\{k7\},xmm5,WORD PTR \[esp\+esi\*8-0x1e240\],0x7b >>>> +[ ]*[a-f0-9]+: 62 f3 56 28 c2 69 7f 7b vcmpsh k5,xmm5,WORD PTR >>> \[ecx\+0xfe\],0x7b >>>> +[ ]*[a-f0-9]+: 62 f3 56 2f c2 6a 80 7b vcmpsh >>> k5\{k7\},xmm5,WORD PTR \[edx-0x100\],0x7b >>>> [ ]*[a-f0-9]+: 62 f1 d7 2f 58 f4 vaddsd xmm6\{k7\},xmm5,xmm4 >>>> [ ]*[a-f0-9]+: 62 f1 d7 af 58 f4 vaddsd >>> xmm6\{k7\}\{z\},xmm5,xmm4 >>>> [ ]*[a-f0-9]+: 62 f1 d7 1f 58 f4 vaddsd >>> xmm6\{k7\},xmm5,xmm4,\{rn-sae\} >>>> @@ -3063,4 +3069,10 @@ Disassembly of section .text: >>>> [ ]*[a-f0-9]+: 62 f3 55 2f 0a b2 00 02 00 00 7b vrndscaless >>> xmm6\{k7\},xmm5,DWORD PTR \[edx\+0x200\],0x7b >>>> [ ]*[a-f0-9]+: 62 f3 55 2f 0a 72 80 7b vrndscaless >>> xmm6\{k7\},xmm5,DWORD PTR \[edx-0x200\],0x7b >>>> [ ]*[a-f0-9]+: 62 f3 55 2f 0a b2 fc fd ff ff 7b vrndscaless >>> xmm6\{k7\},xmm5,DWORD PTR \[edx-0x204\],0x7b >>>> +[ ]*[a-f0-9]+: 62 f3 56 28 c2 ec 7b vcmpsh k5,xmm5,xmm4,0x7b >>>> +[ ]*[a-f0-9]+: 62 f3 56 1f c2 ec 7b vcmpsh >>> k5\{k7\},xmm5,xmm4,\{sae\},0x7b >>>> +[ ]*[a-f0-9]+: 62 f3 56 28 c2 29 7b vcmpsh k5,xmm5,WORD PTR >>> \[ecx\],0x7b >>>> +[ ]*[a-f0-9]+: 62 f3 56 2f c2 ac f4 c0 1d fe ff 7b vcmpsh >>> k5\{k7\},xmm5,WORD PTR \[esp\+esi\*8-0x1e240\],0x7b >>>> +[ ]*[a-f0-9]+: 62 f3 56 28 c2 69 7f 7b vcmpsh k5,xmm5,WORD PTR >>> \[ecx\+0xfe\],0x7b >>>> +[ ]*[a-f0-9]+: 62 f3 56 2f c2 6a 80 7b vcmpsh >>> k5\{k7\},xmm5,WORD PTR \[edx-0x100\],0x7b >>>> #pass >>>> --- a/gas/testsuite/gas/i386/evex-lig256.d >>>> +++ b/gas/testsuite/gas/i386/evex-lig256.d >>>> @@ -1536,6 +1536,12 @@ Disassembly of section .text: >>>> [ ]*[a-f0-9]+: 62 f3 55 2f 0a b2 00 02 00 00 7b vrndscaless >>> \$0x7b,0x200\(%edx\),%xmm5,%xmm6\{%k7\} >>>> [ ]*[a-f0-9]+: 62 f3 55 2f 0a 72 80 7b vrndscaless \$0x7b,- >>> 0x200\(%edx\),%xmm5,%xmm6\{%k7\} >>>> [ ]*[a-f0-9]+: 62 f3 55 2f 0a b2 fc fd ff ff 7b vrndscaless \$0x7b,- >>> 0x204\(%edx\),%xmm5,%xmm6\{%k7\} >>>> +[ ]*[a-f0-9]+: 62 f3 56 28 c2 ec 7b vcmpsh >>> \$0x7b,%xmm4,%xmm5,%k5 >>>> +[ ]*[a-f0-9]+: 62 f3 56 1f c2 ec 7b vcmpsh >>> \$0x7b,\{sae\},%xmm4,%xmm5,%k5\{%k7\} >>>> +[ ]*[a-f0-9]+: 62 f3 56 28 c2 29 7b vcmpsh >>> \$0x7b,\(%ecx\),%xmm5,%k5 >>>> +[ ]*[a-f0-9]+: 62 f3 56 2f c2 ac f4 c0 1d fe ff 7b vcmpsh \$0x7b,- >>> 0x1e240\(%esp,%esi,8\),%xmm5,%k5\{%k7\} >>>> +[ ]*[a-f0-9]+: 62 f3 56 28 c2 69 7f 7b vcmpsh >>> \$0x7b,0xfe\(%ecx\),%xmm5,%k5 >>>> +[ ]*[a-f0-9]+: 62 f3 56 2f c2 6a 80 7b vcmpsh \$0x7b,- >>> 0x100\(%edx\),%xmm5,%k5\{%k7\} >>>> [ ]*[a-f0-9]+: 62 f1 d7 2f 58 f4 >>> vaddsd %xmm4,%xmm5,%xmm6\{%k7\} >>>> [ ]*[a-f0-9]+: 62 f1 d7 af 58 f4 >>> vaddsd %xmm4,%xmm5,%xmm6\{%k7\}\{z\} >>>> [ ]*[a-f0-9]+: 62 f1 d7 1f 58 f4 vaddsd \{rn- >>> sae\},%xmm4,%xmm5,%xmm6\{%k7\} >>>> @@ -3063,4 +3069,10 @@ Disassembly of section .text: >>>> [ ]*[a-f0-9]+: 62 f3 55 2f 0a b2 00 02 00 00 7b vrndscaless >>> \$0x7b,0x200\(%edx\),%xmm5,%xmm6\{%k7\} >>>> [ ]*[a-f0-9]+: 62 f3 55 2f 0a 72 80 7b vrndscaless \$0x7b,- >>> 0x200\(%edx\),%xmm5,%xmm6\{%k7\} >>>> [ ]*[a-f0-9]+: 62 f3 55 2f 0a b2 fc fd ff ff 7b vrndscaless \$0x7b,- >>> 0x204\(%edx\),%xmm5,%xmm6\{%k7\} >>>> +[ ]*[a-f0-9]+: 62 f3 56 28 c2 ec 7b vcmpsh >>> \$0x7b,%xmm4,%xmm5,%k5 >>>> +[ ]*[a-f0-9]+: 62 f3 56 1f c2 ec 7b vcmpsh >>> \$0x7b,\{sae\},%xmm4,%xmm5,%k5\{%k7\} >>>> +[ ]*[a-f0-9]+: 62 f3 56 28 c2 29 7b vcmpsh >>> \$0x7b,\(%ecx\),%xmm5,%k5 >>>> +[ ]*[a-f0-9]+: 62 f3 56 2f c2 ac f4 c0 1d fe ff 7b vcmpsh \$0x7b,- >>> 0x1e240\(%esp,%esi,8\),%xmm5,%k5\{%k7\} >>>> +[ ]*[a-f0-9]+: 62 f3 56 28 c2 69 7f 7b vcmpsh >>> \$0x7b,0xfe\(%ecx\),%xmm5,%k5 >>>> +[ ]*[a-f0-9]+: 62 f3 56 2f c2 6a 80 7b vcmpsh \$0x7b,- >>> 0x100\(%edx\),%xmm5,%k5\{%k7\} >>>> #pass >>>> --- a/gas/testsuite/gas/i386/evex-lig512-intel.d >>>> +++ b/gas/testsuite/gas/i386/evex-lig512-intel.d >>>> @@ -1536,6 +1536,12 @@ Disassembly of section .text: >>>> [ ]*[a-f0-9]+: 62 f3 55 4f 0a b2 00 02 00 00 7b vrndscaless >>> xmm6\{k7\},xmm5,DWORD PTR \[edx\+0x200\],0x7b >>>> [ ]*[a-f0-9]+: 62 f3 55 4f 0a 72 80 7b vrndscaless >>> xmm6\{k7\},xmm5,DWORD PTR \[edx-0x200\],0x7b >>>> [ ]*[a-f0-9]+: 62 f3 55 4f 0a b2 fc fd ff ff 7b vrndscaless >>> xmm6\{k7\},xmm5,DWORD PTR \[edx-0x204\],0x7b >>>> +[ ]*[a-f0-9]+: 62 f3 56 48 c2 ec 7b vcmpsh k5,xmm5,xmm4,0x7b >>>> +[ ]*[a-f0-9]+: 62 f3 56 1f c2 ec 7b vcmpsh >>> k5\{k7\},xmm5,xmm4,\{sae\},0x7b >>>> +[ ]*[a-f0-9]+: 62 f3 56 48 c2 29 7b vcmpsh k5,xmm5,WORD PTR >>> \[ecx\],0x7b >>>> +[ ]*[a-f0-9]+: 62 f3 56 4f c2 ac f4 c0 1d fe ff 7b vcmpsh >>> k5\{k7\},xmm5,WORD PTR \[esp\+esi\*8-0x1e240\],0x7b >>>> +[ ]*[a-f0-9]+: 62 f3 56 48 c2 69 7f 7b vcmpsh k5,xmm5,WORD PTR >>> \[ecx\+0xfe\],0x7b >>>> +[ ]*[a-f0-9]+: 62 f3 56 4f c2 6a 80 7b vcmpsh >>> k5\{k7\},xmm5,WORD PTR \[edx-0x100\],0x7b >>>> [ ]*[a-f0-9]+: 62 f1 d7 4f 58 f4 vaddsd xmm6\{k7\},xmm5,xmm4 >>>> [ ]*[a-f0-9]+: 62 f1 d7 cf 58 f4 vaddsd >>> xmm6\{k7\}\{z\},xmm5,xmm4 >>>> [ ]*[a-f0-9]+: 62 f1 d7 1f 58 f4 vaddsd >>> xmm6\{k7\},xmm5,xmm4,\{rn-sae\} >>>> @@ -3063,4 +3069,10 @@ Disassembly of section .text: >>>> [ ]*[a-f0-9]+: 62 f3 55 4f 0a b2 00 02 00 00 7b vrndscaless >>> xmm6\{k7\},xmm5,DWORD PTR \[edx\+0x200\],0x7b >>>> [ ]*[a-f0-9]+: 62 f3 55 4f 0a 72 80 7b vrndscaless >>> xmm6\{k7\},xmm5,DWORD PTR \[edx-0x200\],0x7b >>>> [ ]*[a-f0-9]+: 62 f3 55 4f 0a b2 fc fd ff ff 7b vrndscaless >>> xmm6\{k7\},xmm5,DWORD PTR \[edx-0x204\],0x7b >>>> +[ ]*[a-f0-9]+: 62 f3 56 48 c2 ec 7b vcmpsh k5,xmm5,xmm4,0x7b >>>> +[ ]*[a-f0-9]+: 62 f3 56 1f c2 ec 7b vcmpsh >>> k5\{k7\},xmm5,xmm4,\{sae\},0x7b >>>> +[ ]*[a-f0-9]+: 62 f3 56 48 c2 29 7b vcmpsh k5,xmm5,WORD PTR >>> \[ecx\],0x7b >>>> +[ ]*[a-f0-9]+: 62 f3 56 4f c2 ac f4 c0 1d fe ff 7b vcmpsh >>> k5\{k7\},xmm5,WORD PTR \[esp\+esi\*8-0x1e240\],0x7b >>>> +[ ]*[a-f0-9]+: 62 f3 56 48 c2 69 7f 7b vcmpsh k5,xmm5,WORD PTR >>> \[ecx\+0xfe\],0x7b >>>> +[ ]*[a-f0-9]+: 62 f3 56 4f c2 6a 80 7b vcmpsh >>> k5\{k7\},xmm5,WORD PTR \[edx-0x100\],0x7b >>>> #pass >>>> --- a/gas/testsuite/gas/i386/evex-lig512.d >>>> +++ b/gas/testsuite/gas/i386/evex-lig512.d >>>> @@ -1536,6 +1536,12 @@ Disassembly of section .text: >>>> [ ]*[a-f0-9]+: 62 f3 55 4f 0a b2 00 02 00 00 7b vrndscaless >>> \$0x7b,0x200\(%edx\),%xmm5,%xmm6\{%k7\} >>>> [ ]*[a-f0-9]+: 62 f3 55 4f 0a 72 80 7b vrndscaless \$0x7b,- >>> 0x200\(%edx\),%xmm5,%xmm6\{%k7\} >>>> [ ]*[a-f0-9]+: 62 f3 55 4f 0a b2 fc fd ff ff 7b vrndscaless \$0x7b,- >>> 0x204\(%edx\),%xmm5,%xmm6\{%k7\} >>>> +[ ]*[a-f0-9]+: 62 f3 56 48 c2 ec 7b vcmpsh >>> \$0x7b,%xmm4,%xmm5,%k5 >>>> +[ ]*[a-f0-9]+: 62 f3 56 1f c2 ec 7b vcmpsh >>> \$0x7b,\{sae\},%xmm4,%xmm5,%k5\{%k7\} >>>> +[ ]*[a-f0-9]+: 62 f3 56 48 c2 29 7b vcmpsh >>> \$0x7b,\(%ecx\),%xmm5,%k5 >>>> +[ ]*[a-f0-9]+: 62 f3 56 4f c2 ac f4 c0 1d fe ff 7b vcmpsh \$0x7b,- >>> 0x1e240\(%esp,%esi,8\),%xmm5,%k5\{%k7\} >>>> +[ ]*[a-f0-9]+: 62 f3 56 48 c2 69 7f 7b vcmpsh >>> \$0x7b,0xfe\(%ecx\),%xmm5,%k5 >>>> +[ ]*[a-f0-9]+: 62 f3 56 4f c2 6a 80 7b vcmpsh \$0x7b,- >>> 0x100\(%edx\),%xmm5,%k5\{%k7\} >>>> [ ]*[a-f0-9]+: 62 f1 d7 4f 58 f4 >>> vaddsd %xmm4,%xmm5,%xmm6\{%k7\} >>>> [ ]*[a-f0-9]+: 62 f1 d7 cf 58 f4 >>> vaddsd %xmm4,%xmm5,%xmm6\{%k7\}\{z\} >>>> [ ]*[a-f0-9]+: 62 f1 d7 1f 58 f4 vaddsd \{rn- >>> sae\},%xmm4,%xmm5,%xmm6\{%k7\} >>>> @@ -3063,4 +3069,10 @@ Disassembly of section .text: >>>> [ ]*[a-f0-9]+: 62 f3 55 4f 0a b2 00 02 00 00 7b vrndscaless >>> \$0x7b,0x200\(%edx\),%xmm5,%xmm6\{%k7\} >>>> [ ]*[a-f0-9]+: 62 f3 55 4f 0a 72 80 7b vrndscaless \$0x7b,- >>> 0x200\(%edx\),%xmm5,%xmm6\{%k7\} >>>> [ ]*[a-f0-9]+: 62 f3 55 4f 0a b2 fc fd ff ff 7b vrndscaless \$0x7b,- >>> 0x204\(%edx\),%xmm5,%xmm6\{%k7\} >>>> +[ ]*[a-f0-9]+: 62 f3 56 48 c2 ec 7b vcmpsh >>> \$0x7b,%xmm4,%xmm5,%k5 >>>> +[ ]*[a-f0-9]+: 62 f3 56 1f c2 ec 7b vcmpsh >>> \$0x7b,\{sae\},%xmm4,%xmm5,%k5\{%k7\} >>>> +[ ]*[a-f0-9]+: 62 f3 56 48 c2 29 7b vcmpsh >>> \$0x7b,\(%ecx\),%xmm5,%k5 >>>> +[ ]*[a-f0-9]+: 62 f3 56 4f c2 ac f4 c0 1d fe ff 7b vcmpsh \$0x7b,- >>> 0x1e240\(%esp,%esi,8\),%xmm5,%k5\{%k7\} >>>> +[ ]*[a-f0-9]+: 62 f3 56 48 c2 69 7f 7b vcmpsh >>> \$0x7b,0xfe\(%ecx\),%xmm5,%k5 >>>> +[ ]*[a-f0-9]+: 62 f3 56 4f c2 6a 80 7b vcmpsh \$0x7b,- >>> 0x100\(%edx\),%xmm5,%k5\{%k7\} >>>> #pass >>>> --- a/opcodes/i386-opc.tbl >>>> +++ b/opcodes/i386-opc.tbl >>>> @@ -3739,10 +3739,10 @@ vcmpph, 0xc2, 0x >>>> vcmpph, 0xc2, None, CpuAVX512_FP16, >>>> >>> Modrm|Masking=2|Space0F3A|VexVVVV|VexW0|Broadcast|Disp8ShiftVL|C >>> heckRe >>>> gSize|No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf, { Imm8, >>>> RegXMM|RegYMM|RegZMM|Word|Unspecified|BaseIndex, >>> RegXMM|RegYMM|RegZMM, >>>> RegMask } vcmpph, 0xc2, None, CpuAVX512_FP16, >>>> >>> Modrm|EVex512|Masking=2|Space0F3A|VexVVVV=1|VexW0|No_bSuf|No_ >>> wSuf|No_l >>>> Suf|No_sSuf|No_qSuf|No_ldSuf|SAE, { Imm8, Imm8, RegZMM, RegZMM, >>>> RegMask } >>>> >>>> -vcmpsh, 0xf3c2, 0x, CpuAVX512_FP16, >>>> >>> Modrm|EVex128|Masking=2|Space0F3A|VexVVVV|VexW0|Disp8MemShift= >>> 1|No_bSu >>>> f|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|ImmExt, { >>>> RegXMM|Word|Unspecified|BaseIndex, RegXMM, RegMask } >>>> -vcmpsh, 0xf3c2, 0x, CpuAVX512_FP16, >>>> >>> Modrm|EVex128|Masking=2|Space0F3A|VexVVVV|VexW0|No_bSuf|No_wS >>> uf|No_lSu >>>> f|No_sSuf|No_qSuf|No_ldSuf|ImmExt|SAE, { Imm8, RegXMM, RegXMM, >>> RegMask >>>> } -vcmpsh, 0xf3c2, None, CpuAVX512_FP16, >>>> >>> Modrm|EVex128|Masking=2|Space0F3A|VexVVVV|VexW0|Disp8MemShift= >>> 1|No_bSu >>>> f|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf, { Imm8, >>>> RegXMM|Word|Unspecified|BaseIndex, RegXMM, RegMask } -vcmpsh, >>> 0xf3c2, >>>> None, CpuAVX512_FP16, >>>> >>> Modrm|EVex128|Masking=2|Space0F3A|VexVVVV|VexW0|No_bSuf|No_wS >>> uf|No_lSu >>>> f|No_sSuf|No_qSuf|No_ldSuf|SAE, { Imm8, Imm8, RegXMM, RegXMM, >>> RegMask >>>> } >>>> +vcmpsh, 0xf3c2, 0x, CpuAVX512_FP16, >>>> >>> +Modrm|EVexLIG|Masking=2|Space0F3A|VexVVVV|VexW0|Disp8MemShift >>> =1|No_bS >>>> +uf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|ImmExt, { >>>> +RegXMM|Word|Unspecified|BaseIndex, RegXMM, RegMask } >>>> +vcmpsh, 0xf3c2, 0x, CpuAVX512_FP16, >>>> >>> +Modrm|EVexLIG|Masking=2|Space0F3A|VexVVVV|VexW0|No_bSuf|No_w >>> Suf|No_lS >>>> +uf|No_sSuf|No_qSuf|No_ldSuf|ImmExt|SAE, { Imm8, RegXMM, RegXMM, >>>> +RegMask } vcmpsh, 0xf3c2, None, CpuAVX512_FP16, >>>> >>> +Modrm|EVexLIG|Masking=2|Space0F3A|VexVVVV|VexW0|Disp8MemShift >>> =1|No_bS >>>> +uf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf, { Imm8, >>>> +RegXMM|Word|Unspecified|BaseIndex, RegXMM, RegMask } vcmpsh, >>> 0xf3c2, >>>> +None, CpuAVX512_FP16, >>>> >>> +Modrm|EVexLIG|Masking=2|Space0F3A|VexVVVV|VexW0|No_bSuf|No_w >>> Suf|No_lS >>>> +uf|No_sSuf|No_qSuf|No_ldSuf|SAE, { Imm8, Imm8, RegXMM, RegXMM, >>>> +RegMask } >>>> >>>> vcomish, 0x2f, None, CpuAVX512_FP16, >>>> >>> Modrm|EVexLIG|EVexMap5|VexW0|Disp8MemShift=1|No_bSuf|No_wSuf| >>> No_lSuf|N >>>> o_sSuf|No_qSuf|No_ldSuf, { RegXMM|Word|Unspecified|BaseIndex, >>> RegXMM } >>>> vcomish, 0x2f, None, CpuAVX512_FP16, >>>> >>> Modrm|EVexLIG|EVexMap5|VexW0|No_bSuf|No_wSuf|No_lSuf|No_sSuf| >>> No_qSuf|N >>>> o_ldSuf|SAE, { Imm8, RegXMM, RegXMM } >>>> >>> >>> Lili, does it look OK? >> >> Hi Jan, >> I confirmed it with software developer manual, it really should be LLIG. And by the way I checked all AVX512_FP16 instructions, vfpclasssh has the same issue, could you help fix them together, thanks! >> > > Thank you, Lili. > > This is OK. Thanks, but I'm afraid I'm a little confused by the reply: Do you mean "okay with the requested addition" (which I was intending to do) or "okay as is" (leaving it to a subsequent patch to also fix the other insn)? Jan