From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2077.outbound.protection.outlook.com [40.107.22.77]) by sourceware.org (Postfix) with ESMTPS id 197BC3858D39 for ; Wed, 19 Oct 2022 14:10:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 197BC3858D39 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W/hlYzxV+SyysG7DJKgd+GrNbzbsDMJJDPVt4OyXGQgBjyctXg7hYcIR2GzYqQV88dDKFtw9Yx3Cfeby+RKJsfILOz/O0PsWmc8ZIiJ7jGJs5TCcaLguuGb55GswGJXhnMtkuX5JHfUmNNjuSJSKRXjlP+uMxKbKIaqRMHmPw3V3o+TZg4FOiLSuORXoO9rZXKYBdxcwVwijwl2ndhqGuk6qMtk067hQ+A3eXOZU8ddLePNf/Xof8ckjZtlNCyzJ4U6s/oRCtgeLRAdJwQ3qy8AX5mhyZels5p8LuLbtrNKjQ46e9vIwpCyrsv19QSdQr7IeO+howEzEcl4i+pDokg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S0hKdD0IPHKcgRsgit7jCJOVYVAoiEefBuTV6dYb8/Q=; b=C7r90omsRXsav0FthXF9tvGvO8F4JNlcSLVCcHMQhxdd0vfoxnlIVR2IAkJoHurijlNK6krndA28f2+m++IKWYOddiJaHC/NHMrpdyWnGAYU44tvFRDCIVLBLcQ6PX8wzB5nDspXxJkR6+CiuaQprHgizzuXT0On3mlqRLRfMs8sEQHy71H2rBwF/4Mm0ge1uHeYy3XPJ57r4kgTMhT+a1n+Soe4ah4CCX8ihxxGrNEt/+9AweXC2Xv4ljPcSE+aSRwK23cCEXkmxf64nJqx7g4O/GfNUD3oJMtKYm3UiC63eY9gF37YaQIVTzpAoCTmZxp1LzMKHD2S2YZzOMyAZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S0hKdD0IPHKcgRsgit7jCJOVYVAoiEefBuTV6dYb8/Q=; b=SH63UW/rd+yr/V+iJmnHUv3BKjMhC4DZKFjijwxb2s0WwOVijlzD2cwGLTrsdRVHEF/KhWQ3ZRhVyFNep5B7ImCMkrnmhr++Ic0on+cfz11n5HohDBNmAxixyraw+T4oaVz9yvFgopKLIppsyQgi0uCC0iXzvj6K476jkx3mxCfEOtUlHlIOVN1azUxJTc9+j0eEFn4Y7CfxWP/cEhF2PR+n9n2GwkEiIULqN11IHwOd4/RM9y4hcibFxREENAJH1cAjPSFmA3Y8v4i89sgo0O0w6zja6ESGqNAtVXtgSEmg42iAQcCDyD+gMMrPMNqUJqx/Ydm/0VxB9YIqsWlfWw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7474.eurprd04.prod.outlook.com (2603:10a6:20b:1d9::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Wed, 19 Oct 2022 14:10:01 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022 14:10:01 +0000 Message-ID: Date: Wed, 19 Oct 2022 16:09:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH 09/10] Support Intel AMX-FP16 Content-Language: en-US To: "Cui, Lili" Cc: "hjl.tools@gmail.com" , "binutils@sourceware.org" , "Jiang, Haochen" References: <20221014091248.4920-1-haochen.jiang@intel.com> <20221014091248.4920-10-haochen.jiang@intel.com> <8e2d8a02-1521-5fa2-d97f-3de4c997818f@suse.com> <5b7c68cd-3e39-7b5a-bff6-3b966ab33be7@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0059.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7474:EE_ X-MS-Office365-Filtering-Correlation-Id: d14ed785-f078-42ea-93d3-08dab1db9c92 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rEA+LUV2J/D6Qnnz+e2FA+I20Gw6rTYnQ9XbN6fdYJCQY2YpmtATR4PjXUZIWLwxESqZdqwFOaCUgg/vcJ4I8tlloCISBNX651AkD9r27uPHXYcHJxoEWjVwW5mD6sxQrUwAZkgvYLBWsy03Zd/pn4uDcI8UoQ58lc9Mn/kHtX77hgch6VKH8NLZIt0oqTuPgCZbfbVJ3tb6wzBRpIK3w0Q5Z412jnnwPSyDi0G8kK5DcSS09P3OmIbbrcIBT38XZbPLYcqkJH0WaVcTPy7HHuEaVxAuhNA0+vcxPTjs5eU4eAVXfM0a+piLKUXnPJyWL1kgfJouNbuMUepLW+NYDh8Y/GX0KCPST8ex+he+vwG44d8PLO5Es5T7cfzqc8RTGN87AIUUHbF3zjNxx6LoDsXDD2kg8CZWARNPy5IFVdvGx9dyyBLX8y6VxdBT6NSBXj9Uk4OYxWCwb4wqHAq1ULhl1B8/So0RW4zTjM9SGHyfExtnwvLzl6nF7Rd00R0ErVGgU928g7rpmU6CVRTSKs1A0mm8L8r8qBIpZYT5HGGwAyvpqvIFfcrBYVNd4+RI3D6G4/v+safy7TogXb+risG5ZLQNohlZ7+r+tgxtSSOs+iXFg2uVfvIDDy2IYhU4fulsGxYxIwAisfq/HlWWF/xMF1pceCyOJMcALt136wmNiL00ZCYgzdPo95uGDDsZIPsyghglts1qs9LJ9hPeTM2NokrIkq09C2g9RyqvgKvw5dFK5lsCOOH2p/dhiKP1JOiA7XwuCl9Lnf8dpa+MkUvC+qOT2u86U4oRch2nN+I= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(396003)(346002)(366004)(39860400002)(376002)(451199015)(31696002)(83380400001)(86362001)(54906003)(66556008)(6916009)(66476007)(186003)(38100700002)(8936002)(66946007)(5660300002)(53546011)(4326008)(2906002)(41300700001)(8676002)(6506007)(26005)(2616005)(6512007)(6486002)(478600001)(316002)(36756003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MVd3ZkhTWEZWR3IxQVZoeHovT2t6NWxraGdpRXJCQ21SM2FyYWx1WFIxT2hC?= =?utf-8?B?UURJeW53MGJGVFdrRFRqRFplYnIwaUFTYkRVL1I5bE9xVkdRNWJUTlhwQ2NT?= =?utf-8?B?VVlUVllCcnBObzlLc3dCTmp1MG54eitHMW9ZS3VxNnI1ZDNFL0FjeEIzdyt6?= =?utf-8?B?dy9RNXM3b1VFRnI0NjNCSWFRVVJYcDRhanRFM0FzK0FwN3Z4aG9CRXI5aUVi?= =?utf-8?B?MzRoRzlnU3JQUjl6Nlc5bzdVNFc0OFkzNUk5VUVJVUsxdjdPS1dNeFVUVVAz?= =?utf-8?B?dm1hOE51T1I5eTVaNHR4eXFzWS9MVHAxNXIwbm1RVVNaRFRiSW5BaXhkY0RP?= =?utf-8?B?TVlIS1RWYzlmVGZMbDRkR0FnbXJHTHJWc2Q5L1NkcXROcXc5ZTVEUHJ0WEd6?= =?utf-8?B?MkZlQXNDeFUzeVVYZCtJUitoai84TTR0ZGw1L2E4ZUVkZTUyMC9SaGJKUXZQ?= =?utf-8?B?SkJRMG91ZDN5NUtxc29yVHdFNmVPZi92Yk4zRUd3UmxnOUZsSjJJN2I2VVRt?= =?utf-8?B?RWFqN3FPTjh1T3VzaU16dlMrbEd0UXFKcU1wMjFGNzlHeHdrcTZGdlZ6MlBQ?= =?utf-8?B?U1ZCbTZTSmhwOGR4Rk9sN2trcTR3VnhSVWhZc0M3djRuaVcxajh3dTBVUURG?= =?utf-8?B?a1dCRXRqdDBxbDBvYlJiM2FkRU1jdFhTN2NXNHlZR3NIV0EyVEFGT3NSQUtN?= =?utf-8?B?N1BQZjRqb001bmJmN1Zad1owaWFIVEozOUgxR1FjSGRNY09LM1pERUFuTHBN?= =?utf-8?B?S2ZFMjF0Uks0aWpUdWpVakU5RHpGODdaZ3BhQ2t6WXpBU3hERlA0VHdDNmRk?= =?utf-8?B?d0cyTXdncC82SWp6c3pSUDJjZktQSW92djRIT1hOL1RRZ1VTaUFROVpKYnZI?= =?utf-8?B?dndwSHFSSUo2VnhrZ1JjV1Q0MktORG1MYkFHL3hiendQdkE4M09wZTJqMFBU?= =?utf-8?B?MmsxdkJTQ29jcnBRSDNmMjJUSzRZUzVaRnJjYmIvclZ2bnozNWZFUmhNRG5n?= =?utf-8?B?NVdCSW1RWnI5QnlvbnRWUkk5WDV2MzFHTlZqNEpHSTNRNEFYeTlXdDZQNGdu?= =?utf-8?B?SnltNFA4K0NhelkyQzJRdFpyWTN2NkdURDR6UDZ4VlRPbmhlWWoreXpSSzVy?= =?utf-8?B?RHZ4OGdwaktsNGhtdUpXUW5XSWNobjJUNE1yczk4NVVTM2tmVlZDeTVsT1Nt?= =?utf-8?B?OEtySWlMaDFROHNXZHFqaW1uN0hacUJVdU9Xd2I4VWVjRUtrOUpaTG9ZdTNk?= =?utf-8?B?bFEvMmlmYW1WbEVLYmtGZmY0NlBGUjFYR0FkUVhBeHU0SUIvQjVaeUYyNUtO?= =?utf-8?B?cjBOWGRBdUxlNnBhOUcvTWZSWFJycHlRYmVpS3RRK3hmZ093WXJKTmZuYUc1?= =?utf-8?B?aXRwRGZXcGlobmNBNEp2NDJ5QmpiY3NRaTgxK25LcGJ5akVCaUNFWG1yWVR4?= =?utf-8?B?NlJBaUdtUVFUcnhYOWFSMTZLWmxaVnY2SzFPZXBKdXI0Qk1GcXZUUFBlMS9N?= =?utf-8?B?ZWxEekFJLzltNExiN1ZrM202a3FoZUxXdUkrdUN2b3k0Z3dsd3lyVFU0M040?= =?utf-8?B?QlZtT0ZwdkhRdzY5RWw3OHhFTTF5MFYrWlgxV24vK2pDMTdaZkgwcDNEWUsv?= =?utf-8?B?WjNEbE1OY2NPSldqS3hVMDBZMm5KM1VXa1NMaHlpTTRCTmw3MUNMTUxGSHJP?= =?utf-8?B?cW5aNnBKUWQ5Y3gwTHh5d2hWWjlWNjhlOFh4RzE2NGk1Z254aHE1S1c2M1Js?= =?utf-8?B?aHRETyswNG9lUVoxcnBmTzNldElGYURaa2s3a1JtWjBmKyswenp5cGN2WU96?= =?utf-8?B?TXBIcmxySmJUYjBuNDh5KzdNcWVvcVFPTUVaTVRXM2pmY0tkOGZFRi9lTGUr?= =?utf-8?B?RnhRTlJQZnFkSnRHTnA1UVJBeDA1cWJVUjd6QW8xOU9XUlJIQWN2Q2VkTmR1?= =?utf-8?B?OFBxbTAwZm9wOEpKMkZ0ZkFhY0VrZnQ1QVN6N2pMTVRIMW5jcVZuOW8yTXVM?= =?utf-8?B?YUJTRmlWVm5xV0IrS0lBSk1CZGV2aGFyQmI0WmZRb3M0ZGlmWjNhdytxL3dS?= =?utf-8?B?TS80NlIzOFNveWFQYmxHQUJ6eGJBZXNVdzVPdDN4NW5TSUdjMHRNSHhwQWx2?= =?utf-8?Q?3Hwkig6B1MTvYvPixFSHezCm9?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d14ed785-f078-42ea-93d3-08dab1db9c92 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 14:10:01.0402 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: u3Pc2ZWZYMK0B9aVWGJW+UV/sgREGvLu3z89Jm+ttMAjnLM9M8VNw+Dv12dllqXwTqg/I6s1dIbd/KTfie4tOQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7474 X-Spam-Status: No, score=-3029.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 19.10.2022 16:05, Cui, Lili wrote: > >>>> I guess my comment here was a little misleading (I'm sorry for that), >>>> in that in addition I was expecting you to consider the comment >>>> regarding the need for the *_ANY_* constants that I did give for several of >> the patches in this series. >>>> I think the question applies here as well: Are there dependent >>>> features known to appear? If not, there's no need for the extra constant. >>>> >>> Get you, there are no known dependencies now, and I will pay attention on >> it in future ISAs. >> >> Despite this reply, ... >> >>> --- a/gas/config/tc-i386.c >>> +++ b/gas/config/tc-i386.c >>> @@ -1076,6 +1076,7 @@ static const arch_entry cpu_arch[] = >>> SUBARCH (cldemote, CLDEMOTE, CLDEMOTE, false), >>> SUBARCH (amx_int8, AMX_INT8, ANY_AMX_INT8, false), >>> SUBARCH (amx_bf16, AMX_BF16, ANY_AMX_BF16, false), >>> + SUBARCH (amx_fp16, AMX_FP16, ANY_AMX_FP16, false), >> >> ... you still use ANY_... here and ... >> >>> --- a/opcodes/i386-gen.c >>> +++ b/opcodes/i386-gen.c >>> @@ -319,6 +319,8 @@ static initializer cpu_flag_init[] = >>> "CPU_AMX_TILE_FLAGS|CpuAMX_INT8" }, >>> { "CPU_AMX_BF16_FLAGS", >>> "CPU_AMX_TILE_FLAGS|CpuAMX_BF16" }, >>> + { "CPU_AMX_FP16_FLAGS", >>> + "CPU_AMX_TILE_FLAGS|CpuAMX_FP16" }, >>> { "CPU_AMX_TILE_FLAGS", >>> "CpuAMX_TILE" }, >>> { "CPU_MOVDIRI_FLAGS", >>> @@ -425,8 +427,10 @@ static initializer cpu_flag_init[] = >>> "CpuAMX_INT8" }, >>> { "CPU_ANY_AMX_BF16_FLAGS", >>> "CpuAMX_BF16" }, >>> + { "CPU_ANY_AMX_FP16_FLAGS", >>> + "CpuAMX_FP16" }, >> >> ... you request it to be constructed here. > > HAHA, you mean if there is no instruction that depends on CpuAMX_FP16, we don’t need to add *ANY* for it in arch_entry cpu_arch[]? Maybe when the dependency happens, we need to change it back. Right, that's why I did ask whether there are dependent features known to appear. If you go look you'll find that we don't have ANY_* for a fair part (if not a majority) of the features). Jan