From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by sourceware.org (Postfix) with ESMTPS id F3C3738560A1 for ; Wed, 25 May 2022 06:18:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F3C3738560A1 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03lp2058.outbound.protection.outlook.com [104.47.8.58]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-35-eTCqTkK0OgSWkRuCdtlszA-1; Wed, 25 May 2022 08:18:52 +0200 X-MC-Unique: eTCqTkK0OgSWkRuCdtlszA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KOB5oG9N+rUgJPBZ2CPaBfCBLa6hM8X+qQFWlbTsJZFGvxM3MakRr6KOfQjiXClg7i0rjRc87QK5+Ez5y+jN0Va/eqE0G+QsmrLOyfz480bEls49Tno0vJ+TZ0n1FrA0EyGqoNc+TT62yTTI+hc8K7eMTjZqtxEFYFuaZZdDgQLKme3VJ7UufhE2XHzjlyQFB3sSm+4zOu7c5ZC6ZQu03AHu5QMy9fsNbkDCK+hSG+5fw2OpyKYKVwmxXBJz96T/x9+xarIstNSCnZeo/hycuPF7/OhP8RlCBS1VzAJt4dC4EAO8idB9027BriDeVbOZLNR3VB4hz+x8tHsG62vVDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=to+2V18rdtLhnaUDsV8OMSQLA9Uw3aiEjf5XU/MCK8o=; b=TLtySpBg0sXpPPuvvOnlzqUsg7HlmzhF2npZqsUpn1vUjFcj2qy/HYwUHsTDwn6ERJ+uuI1PyK7McJJOkpIWnXJZ8eIgfXbwN3ksQ6VZLvcq57pDFVKTQCkN/LVtnSfuijZLOQOGlXAeIc8XqiAz12vK1Rp8WTYyZ2fHIVu+uExRFZ7KCise/V5GRsWogp+HysrS59DfBbPUZybXiyR8o9nf/AP3omx7m7GLJ7SdQyLtJ7cR4eiZ405wbn0SKx43YCkM3WlAnmmAho9w8NbLTROqo980X3HqGTXnOwEX/Gww82gAuWz8DBJNet59gkHIohm8gHx1UP0JzSBTst5p3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by VE1PR04MB7277.eurprd04.prod.outlook.com (2603:10a6:800:1b3::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Wed, 25 May 2022 06:18:52 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::85f7:b203:1f7c:c78e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::85f7:b203:1f7c:c78e%7]) with mapi id 15.20.5273.023; Wed, 25 May 2022 06:18:51 +0000 Message-ID: Date: Wed, 25 May 2022 08:18:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] bfd: Fix issues with files in debug_line table with dwarf5. Content-Language: en-US To: "Potharla, Rupesh" Cc: "George, Jini Susan" , "Parasuraman, Hariharan" , "Natarajan, Kavitha" , "Potharla, Rupesh via Binutils" References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR04CA0033.eurprd04.prod.outlook.com (2603:10a6:20b:46a::8) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c6602e24-9183-4560-6a73-08da3e167019 X-MS-TrafficTypeDiagnostic: VE1PR04MB7277:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VzlNsXzoOd4gzmh4tu6rMro4GatAvI58W8m5GOASf8i2YiSVY0rd8QBF8bhWdCMe4eztRsl7x+oB2ucPPlEUW1qxTYxqXesJOO9bB2GsoZicTiXsoIqetulNejjt58VWFy4BGV8XnHtGhy6nOAjviH8AooZXIea/GI08VCLOFfjXY94gWlSSJZBnKwqyXhZSmEXxSFr42m9uRH/qRAQJMc6S0nRB7WF9+25wVJKtn1z8bOLQjN6fQnMoBlJAnaJ80tcas+uLjHcv/k1RSj+2RFlM6bTXpSHicUs306z26Hp3Z4JdjfcYvhZrSfnsn5S7M4fuxr3aj6XuUlIu7Ncb4SjpG7xgLGRVQbU66tzc+dApVUIKtnNuPROdCqUWMlRXuYp8QCkHoCtjPdvM/NwQLqVK9e/Qa/znLqpKfiyuiv9ctENKUmHnEpQYL3nDziaD04fbl8f9/0KzvoNf+QdkhDWHLCX5iAjIICAXWS8HwGV6NGIJ5T8ulzKHor3AMDnxfq5HuWmPfSTMtbAgfv+GcZ/Z+aFdUfNv9h0oXPCm5bXt7gOpAFkMxsi/1kzzaj1+Tuw9rty1oWnuTKxLaa3uK6zFwypYXn6M0pKLJIVk6X7/Q0PYaF6ej5sMcCbp8hV36I2x01KDZbivYyTzdjsOaCwJxpG9MIdv8zSzLaDH+suN7U7Cv0IX0+0gBXPD6O0t0PtMu1pcpjG9TT3zLkhJWKTAeb1ZeHSgEavJFE5UnMZemgy3zkxk44xKt/NhCBlg X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR04MB6551.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(2616005)(54906003)(5660300002)(83380400001)(186003)(38100700002)(6916009)(66476007)(2906002)(6506007)(8936002)(31686004)(316002)(86362001)(31696002)(36756003)(6486002)(508600001)(6512007)(26005)(66946007)(53546011)(8676002)(4326008)(66556008)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eEd0bTJyYiszRDJxRlBMZ1JMQWtRdC95a2E1b0hkUDhadjlDcEo1ZHoreUpF?= =?utf-8?B?cFV0VlRCN2I4Z3pjSWR2VG1LNVY1M0VuN1hGYlZ5cW96bjB5anlTS2R6MTBY?= =?utf-8?B?S2Rma3lNYkIyTjhlVjBWR2VwMDgwbnpvRU5HL010ZHpMbXlyTlJFVnE2cUoy?= =?utf-8?B?MGV0bW5QclQ2d0VFSnZjOFEvT0pYa29ZR3U2bG1mek13d29jamtrbDdWSTNy?= =?utf-8?B?QktWYVBXTkhNMWNmd08yQlI0emlEVkljQkRxb29NMlhQUmUzUjJsM3NhWm9N?= =?utf-8?B?YW4vakhCTE42WDlVT0dxUkdQem9rZFpuSGR5UFdTSlhIY3ZxKzdqaGR4WFM1?= =?utf-8?B?a01TSUZoZUc1VUROcHp1eEljS2dWUHpBa3RHWFJNY3YvZmJTbDBzOEkzTjZk?= =?utf-8?B?b2hBZExjbWFiUCthYjN6WWtrRC83MmEyb1RicTFHblNQT2wvM2JWUUZoMEVt?= =?utf-8?B?elRzeHRjd3pYQUkxb3pnMk94ZUE3N3lrK1pmdERWRzRMVWx0bjk5TGhMT2hR?= =?utf-8?B?TVRuWnpQc3hSNzM3KzNaQk1maDV4aENOUDBGY2RaWk9lSFFtYnA4ay9jQWRE?= =?utf-8?B?RXVxL1FTbDF2NExjV213bHFDTXl2TmZXVVk1ZkNzNVB4R1U3SHhuZlRESEox?= =?utf-8?B?Z3VmY29URHRqWE9FaGNtNWpnQ0phWmxiTUoyNHdJcVdkU3IwakRLaGhvcDda?= =?utf-8?B?Y1ZqYXc1aDRwUjhuME9pZ245VUFLWWdHZXpvL3RQL1NPTXdBajhKa0lwSmFr?= =?utf-8?B?R21VMmJhaVJjRFdJV29Qdm5jcS90UUk0L1dGNVR0QTNxMkNWTU1OeFFxVTlV?= =?utf-8?B?UVdUOW9tbCtGSmdEdFpMb1RucWtxS001MGVYZk1zYlI2bmNYbmhnMkMwdC9t?= =?utf-8?B?N0l1ZUhmdXZkdjRHN3JMOC9wYWFNVWtndk5uZHZ4clRET1V2VlZCcGJLRE9m?= =?utf-8?B?RFF1TzJ4cENHbHRsckxjdk1lNmhnRXMvelpTbVlWdDNGL3N4cFM2cVJVTVR0?= =?utf-8?B?U0FvQVZsWWg1SHFCQ0U4Z3pDR1pzanVxM2JseWorbHdqekFqNFV4UGV1Q0M1?= =?utf-8?B?TUhYWFc5QXdrdzlGeTZEOFdXblB5TVdnNGpJK2o4VU9DNFZIYTY2ejVsZGVR?= =?utf-8?B?cExvZjl2Z0RTbGlSREczU2pHUzViVDhiV1pGeG83STVPeGx6L0ZFOE5OTFhP?= =?utf-8?B?VFJxSnljbHRZMURXSElWZWQwcWl5a05QZmUwc1BnZGsvU3pBbDhsNWNheWxi?= =?utf-8?B?TzdEUnVDcmxLSG9SM0FRMEFSQ2N5RWRFVjNJdWxBakwrczFxeldZUmxEYmhk?= =?utf-8?B?RDUwRHNBbHZnUFZaekZtc1BpdEs1QjBKS0ZkbDc2VmtVd2FRSkJUVHVoRk5H?= =?utf-8?B?dE12VVdCZzk0L0xjTi9ZVU03eEZVWG4va3YweXdVTVVTbnVDbHA4eEtRV1Ry?= =?utf-8?B?OVF5TkNEVmNKUWJjSEV2NkZMT0hQQ3gyU3FGaFBnR2IwNmNwemk5TjRGQWNp?= =?utf-8?B?M1dQQXBZRGZad25xWFlpZEdiRUphS3pjVlR4Y2dSZkJvb0NZcm12ZUl3OEdR?= =?utf-8?B?clhCMkVxNy9KK3dXMmppNWhrczM4aDMvTGxETDBEbUo0ZksvSFEreGJvcmR0?= =?utf-8?B?V202Smt5UUY3ckk5amtOZEVCUTJtODFXREdBRTVJVDFYNkJaMTRoV2dGaFly?= =?utf-8?B?d1BvQW1lNWxPc0RmNWZZRitXazgrNFgrTzBUT0JJRHhBeUYrUWw3cWg2SU9J?= =?utf-8?B?K1REWmlPYS9yVHFqcldQSHJ4OFNzVWZDYVNJVytCUVFEQldNMjhGRkhNelgv?= =?utf-8?B?TWlKYXZuYStvbmZZNUlnOTM5RDBHbzdpajk1MjFGT2xrYm5CbXg0MDdhamhF?= =?utf-8?B?MGxsd25mOEt0UmZMVURnSVN3NnpYWmhsT2k5bUdGcjdVUFVEVWhINmVQOVJj?= =?utf-8?B?ZUhWaG9CNjBLZ0Z3UlQwbVdIZkVmbGZReWo4aGJpRklLcmc3WEREYTBaR2lB?= =?utf-8?B?ZjVqdEVRdlRxVmlKTEcwLzhZQ2htVEpFMk9ad0lnSWRJaFlzQ0Fqc1UvVWpt?= =?utf-8?B?YVpPVHNXVWhjNVZCZ0tnWEpLdnB3bG8vYkNXYnI0QlBOSUJCY29KUlRjeXZW?= =?utf-8?B?R2NNMWxCWFRQbkFRRzByTjAzRWUyUytNUmQ2SHczcjVvYWJtUXdSU3ZFMXNy?= =?utf-8?B?ZFJVSXRiekVkWDJjTkRmcHNGZzFvdGZzb2dQdGlqbHprdi9laUZpL3VUTTZt?= =?utf-8?B?Tkx4cEE0MFlwRHgwUThtLzJOaWkvdW1jcm5PRUpiTXBxNXN2dTRId1ppVnhk?= =?utf-8?B?ZWdqRGZ0bmJWc1R4Q2JKc1cwQ0YvVkp5ZlpqVlF0Q3c3RXBoK3B6QT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c6602e24-9183-4560-6a73-08da3e167019 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2022 06:18:51.8512 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iTtAmoW+N3M3gtugnGmw6zJpZ/QCs5OILDv6+4gchggptB22ITPdz3lRe8Vu1z2VvIAPC9dm4ZM3R3nxQpUN2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7277 X-Spam-Status: No, score=-3031.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2022 06:18:56 -0000 On 25.05.2022 06:20, Potharla, Rupesh wrote: >>> - /* Skip the first "zero entry", which is the compilation dir/file. */ >>> - if (datai != 0) >>> - if (!callback (table, fe.name, fe.dir, fe.time, fe.size)) >>> - return false; >>> + if (!callback (table, fe.name, fe.dir, fe.time, fe.size)) >>> + return false; >>> } >> >> How come this change doesn't add a version check? >> > Since the function read_formatted_entries is only called for version 5 in the file, I thought the version check is not needed. Now I have added the condition and updated the patch. Oh, I'm sorry - I hadn't noticed this aspect. I don't think a version check is needed then. >> To help being certain this is the right way of changing things, can you please >> add up to two testcases (readelf and/or objdump), one for a version < 5 >> (unless one such already exists and hence it would be visible there that you >> don't unduly alter handling of those older versions) and one for version 5? >> > > Readelf and objdump are not using dwarf2.c file under bfd directory these tools are using dwarf.c under binutils directory. Argh, yes - too many dwarf*.c in the tree. > Currently I am using addr2line to test and validate my code changes manually. There are no testcases for addr2line and I did not find any testcases for bfd library as well. Please let me know your suggestions . Is there a reason speaking against adding an addr2line test? The generic framework looks to know of addr2line. (Perhaps ideally the same source would be used for both an addr2line test and a readelf or objdump one, as to prove that the two forms of Dwarf reading are actually in sync. But I guess that's asking for too much.) Jan