From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2050.outbound.protection.outlook.com [40.107.8.50]) by sourceware.org (Postfix) with ESMTPS id D01203858D28 for ; Thu, 26 Jan 2023 07:41:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D01203858D28 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RW0G04//T9ZXw71Utg0gQmZ62skvXBFIwYmJ3Xkr3Q3JQTVXHZVFSegIimVOupKRSAj7jWGA96zTDJVuFHSPDxjtXVzgiz5c3swOasBB4eZvFC9XUWoUYoHVf8pPIKSvJ4tmOkwQrLHiPN9Jea+UFbYFcmvnHyUr808SP0nW9nkAa6DVsrzlS8S48RdXN3Rwgay4z8RhxAS08B+6iAxrG9WhV83ZyxOzDkD9GWkxKW51HsVuZkXTAp2lAcDeqf8nF9TVsoZ0ehLCB7kmYipknvMQhyOdmPkKEepIgnZfr2dzbdkHqTXsVLol8sQhN+sgKE8wM0OixWeCjjTRDhpnIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AzOCJB1gyx2uD+xj8TnQN7WJl9FVOgO4xJSYNfIzpOM=; b=T4QBJot40r5UFQvtKEEuIN49Ee8GneTY9ObfsAvOuiqEcqvpFTvHhR+DZWnXHs/+6df6zXrBWzSyFIzxGQzzPIrl6lOdGdRMYtYmVEIQUDgvwQ/nWhffz8JXI42ljF6mMYqGXQo6inM+k3rTCfpSb3aNoafRCp/amfP2roCDBWgww28hBXlfpxwpg8egCJKwb5Bx0ONsLeo5kQ26MlzYjuYSOeMZL/d/CxMsOoCXp05DZaJn3a34gvPv42/On2nRHNfXnRnB5n9WMWScC9n3SkhiJJHsZX5u2HfcoJiRRvGs+mPKjzJtK3xAyB//XEHD8ESOMN+SERCFIYEaQgQs3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AzOCJB1gyx2uD+xj8TnQN7WJl9FVOgO4xJSYNfIzpOM=; b=sMO74yWnkS/1He6EkJxryJJesaRAYKimkpPmXsaI7jfsvlAJobkHxGE8p05bw7sU/OUM76EXr1uISTwRFL2ncmJb7Q7qeB0Tl8LL/lV2DUTriV1JoXeDnad2ueINP71mi7zvVeI9Oy0WajUBopqSlHz9Wur8smOM4hpauEV2ZoibT4F0VFf03oYLs37FIm5WpNYeYr39YJw/NKNw1CqU6uhBMGIdaTWA7MGrpxQEOnAFaigySfXMucJ7aKr+bXFfAgobHNNxfjYxQg1oxISFnHkRSOli+qtdpUbDbnfK2oUOHExeh2sSIGwsF82lW9BU4Mh1NlHUC+NCUFHjd3X/hg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by GV1PR04MB9071.eurprd04.prod.outlook.com (2603:10a6:150:22::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.22; Thu, 26 Jan 2023 07:41:21 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6043.022; Thu, 26 Jan 2023 07:41:20 +0000 Message-ID: Date: Thu, 26 Jan 2023 08:41:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] i386: Pass -Wl,--no-as-needed to compiler as needed Content-Language: en-US To: "H.J. Lu" References: <20230125170725.386430-1-hjl.tools@gmail.com> Cc: binutils@sourceware.org From: Jan Beulich In-Reply-To: <20230125170725.386430-1-hjl.tools@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0154.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|GV1PR04MB9071:EE_ X-MS-Office365-Filtering-Correlation-Id: f8c5ddef-ab28-43fd-33f9-08daff70b742 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 64Owjo62kdsRXWJsHKj+qSivgoggLKjRbGu970rsGf5gIxTTmFjOsSctCBA1KMlf80VCmHYrl9C8A7ClP6QrB9iroPBMZwRflGr7qLTdz1oL1v4VTI0nrKK+kr01kLXu8iSN0Ab+Bb9OHz9TThd+ebjqA9uc2lnJR8pjVwKh+2nl1STeL9qE2kfXF3uTAnWN6hrTLWx6ghPptfKKksqeG58o6wo71k7qUQ7IVBju2uT3dmgu8PLJoKN1i3Lz1gYz0WEN675XN+sR/sKZKIGVJMrdJeAHzewQSmZpXos+TXGs5HYAsnRcDPGPwJxirV9y0fK11nYQAgBCTlPoX+7KHECm4Fh8i9CSbFt0rOAz1IbGuth13zBlc+oqAMj4B4buydYxswOKM5xFUefTkJYZe+i0Ya0JRT8T8bUnowg+0i1MH1YGGv1k0aF9CB8d8BjVXH0qmbDxa5Vj3+kkZZNFui9ZztQepH4LI3AEfRu7GIB9/r16o4NJtw+cpzcSIQNY+cLwfrQFteQVyKpas6y1sev76g/ZwvBYq87csHwrV60T6DcWCe5j/yghxueOwLfCePwHJdZIG7DFdx5P7/JB3rZcn1+4Qxh4YUNJVtuytZVCPq9BuGq521saubDIV50NucxyD/CVqfVW0XoDBZ4nIAVe6qmyBKWrIAQzwwA3w36K0I3IOCK7gpOzO2Kjb59QvDl84OT5AmwQX7tZ47zkCQ3/iHqbPOV+96EwGg0kmjM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(376002)(136003)(396003)(366004)(39860400002)(451199018)(86362001)(38100700002)(36756003)(31696002)(41300700001)(66556008)(316002)(5660300002)(4326008)(8936002)(66476007)(8676002)(66946007)(6916009)(2906002)(2616005)(478600001)(6486002)(6506007)(53546011)(6512007)(26005)(186003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d25KeEE2WGpMWTZWVHd4Uk1DS2xQU0VUWWx4NHpqUUVCUXVhTjlRcHVKaXZ3?= =?utf-8?B?VVZIMGJ3TjBmcGVCWHBjZlFLRGVsZmMwMEJDWWYyY2lXRy9sWm5DbU5paWg1?= =?utf-8?B?WVFOR2JXVGtJVE9ZR3lyZ3poT0Q0RkJscGtsTEV4K1BYYnNDSUpSYjU2V0xp?= =?utf-8?B?MzhJNzRoOUIrRWc2TG1sMG5kTm1uN2Z3OEpVYWtPRjJYeC9oOTY4SmtlSjk1?= =?utf-8?B?aEl2ZzlQVDBFK0hkRmkybmVoZ2psakhYUW41QXY2RDl5YjV4dnVnM2gxRTVF?= =?utf-8?B?akZBeGNqN1pDZTdwZTF2a3lmbSs3QUQvTnBNSVhOcnRXNFVhbTM5VXhlM2U3?= =?utf-8?B?Q3BLaW1lOGxpRnVod1JaUzB0c2pTNXF2VVQ4U0Y1SnBtZXA4L2d4Q1RLeGpQ?= =?utf-8?B?TndJNVZvQjBTRXlkcGx1TkxXa2VPcVpDbXVhT3F5U3p5TTY4SnNvalFtSllO?= =?utf-8?B?cUcwRWN5WWlTUFNoVisyOUgrVE1XUmwyUUVCNURqS3VkeG1xdExIZVdYcWxs?= =?utf-8?B?bm5RM08xS1BwT2M1TEk1U1pMS3FOZHlaS0dtRUNzd1hRY3BPQU1wU2Zpa0t2?= =?utf-8?B?VVZzNnphSmM3QkJCQ1FDWTRWYko0QTdyS2MrYlBnTENIWUpSQnV5MjBQT1g4?= =?utf-8?B?MENuR25PSUFMOWlGVFlmUDloUzhnUjdDckl6T3FXclVwZXc0SmJrcmd3ZUor?= =?utf-8?B?RThKZjkzazgrZmlZVEZ2eWJDNTBHYTRwM0M3TDNlSGdmT05sU3J2OGRGUjQ0?= =?utf-8?B?Y1VFa0d4YmV5K2htSHNBbXQ3bDV1eWlhakxGMEZTYjFETEVOM3NGUnplaDg0?= =?utf-8?B?Y1FGeUh4Z1FsVjJLZDIxZ1pMemlZOGFnY0dYTnk3MW1xY0xqTWdwcXNSdkhB?= =?utf-8?B?QlR5WUF5MFdxWWNqRUluWEtoM1pvdVBqTGtBZzczU1ZuZFlYMjlWNE1QVVVn?= =?utf-8?B?MTBqUXlJcm4xR1hOS1JhWnJvYW5uZWszVjY3aHhSRWRmL3M0eExlb1dLVUo5?= =?utf-8?B?ZW1jenY2REVYWitseVE2YXpCZjYyWVRRc3VSTG5Cc0lkTjh4eXNHZnh5MmZL?= =?utf-8?B?UUhIMGF6MmlIeGllbnJIL0MzU3lPOWFIMVBLT3pJUitPM2JKekxLc0syQ0x4?= =?utf-8?B?U05ZbWFXdW1MY0dWN3ZxcG9tQ3pvYzJoVk1TbUpDQ2orYkZiYUZjTHdZYVFm?= =?utf-8?B?bVNDU2kveStPSW4zQTNKUHBCYjl6TkhDbWI2aEFsVmpYRmxpK3gxdmJEcmJl?= =?utf-8?B?SjljdnV5YlVpZkFtNGZKVFlDdnc5Rkc1Nk01N1pJaUl1cExvNG9laUFENnND?= =?utf-8?B?M0VUbXY2Nko1WHBQNWduMXlYd01XNmN6dmFhT2FBVFZMTzVGVDlRUDJxaGtn?= =?utf-8?B?cUt1UHUwSUtJNTJWbHlFSVlNWGNaVU04T0VaTGFUWk9BUG5Pc1hnUUZzQjRC?= =?utf-8?B?SEU3TEpWajRLcWhIRjBvNGtVVDZQUTduTkFHRDdRNDd2bUtaNDltaEJhZVly?= =?utf-8?B?Y0N5S3lmakJLRFVGRG9NTDUzRjJmWlVPNnI1NC8vSWZkN2Zna1E2U3dkWW9C?= =?utf-8?B?NzZpK1BCUjRqb0hDQjlGWlIyclVSbXBNK2l3MEY0UUE0ZGNxTWR2NGRMenhZ?= =?utf-8?B?a3B5bXF3TzE0VmJPeWxvTXBzMi8veURESHFTNzViUzlCV0QrS2VYaVlwa2Z3?= =?utf-8?B?aGU4aEowK2FiMnRoTFdxSk1NMkdWWm5LS3VxNG90MUtEam1VVHN6dHRQQ1hs?= =?utf-8?B?QjNyNXp0STFyRjA2VmhTcWUxNEhZcW1WTDZSdXdhSW1BdnRhK1ROQ0tZUTIv?= =?utf-8?B?eVNsYkkrRnRZaHRCVkwvc2kvTnZZV2xaVDUwUHhIRWVFRENFMDhKbTh3ZEtt?= =?utf-8?B?TE8xVy9LeGNVMTR6ZUY4dzZTMFp0Tm9WVnlocDYwSGpCWkU3aUVTanMyUWVU?= =?utf-8?B?L2FZaFFkbjk1SW5HRG8rYTBGMDhpRG1wT244dm9YVHVNelB3NkFuRW85V2hl?= =?utf-8?B?MW4yOTd2cGc2a1VDSWd6Q2RzUEk0RkFEczNQbi9UM1pBWElKSS93cEVkYjd0?= =?utf-8?B?N2thalhueWtuN1ZHSDMvQjRTbnhwVFFoNTQ0dUpHVnduanFtMlpVSkRscEE2?= =?utf-8?Q?kia6aCs405g8vND+lsqWJ9eY2?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8c5ddef-ab28-43fd-33f9-08daff70b742 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2023 07:41:20.4210 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YRK2iMXl0w/RpVkXbrZFBFCwt7L4KgvYmneNLh9sxwT11m/T7oGbXWo01Ay3PArn6BJsr8F823EFwuugpr2jDQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9071 X-Spam-Status: No, score=-3029.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 25.01.2023 18:07, H.J. Lu via Binutils wrote: > Pass -Wl,--no-as-needed to linker tests to fix > > FAIL: Run pr19031 > FAIL: Run got1 > FAIL: Undefined weak symbol (-fPIE -no-pie) > FAIL: Undefined weak symbol (-fPIE -pie) How come these four don't match (even in count) ... > --- a/ld/testsuite/ld-i386/i386.exp > +++ b/ld/testsuite/ld-i386/i386.exp > @@ -577,7 +577,8 @@ proc undefined_weak {cflags ldflags} { > run_ld_link_exec_tests [list \ > [list \ > "Run pr19704" \ > - "$ldflags tmpdir/libpr19704.so -Wl,-R,tmpdir" \ > + "$ldflags -Wl,--no-as-needed tmpdir/libpr19704.so \ > + -Wl,-R,tmpdir" \ > "-Wa,-mrelax-relocations=yes" \ > { pr19704a.c } \ > "pr19704" \ > @@ -1078,7 +1079,7 @@ if { [isnative] > ] \ > [list \ > "Run pr19031" \ > - "$NOPIE_LDFLAGS tmpdir/pr19031.so" \ > + "$NOPIE_LDFLAGS -Wl,--no-as-needed tmpdir/pr19031.so" \ > "-Wa,-mx86-used-note=yes" \ > { pr19031b.S pr19031c.c } \ > "pr19031" \ > @@ -1087,7 +1088,7 @@ if { [isnative] > ] \ > [list \ > "Run got1" \ > - "$NOPIE_LDFLAGS tmpdir/got1d.so" \ > + "$NOPIE_LDFLAGS -Wl,--no-as-needed tmpdir/got1d.so" \ > "-Wa,-mx86-used-note=yes" \ > { got1a.S got1b.c got1c.c } \ > "got1" \ ... the three tests (with the "Run ..." even visible in context)? Also it would have helped if you said a word on what it is that breaks with --as-needed. After all there might also be the option of adjusting overly strict expectations. (It is always somewhat questionable to "fight" compiler defaults by further command line overrides. That's not to say it's always the extra override which is wrong; sometimes it's also the compiler default which is to be put under question.) Jan