From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2075.outbound.protection.outlook.com [40.107.22.75]) by sourceware.org (Postfix) with ESMTPS id 86309385B83F for ; Thu, 23 Nov 2023 10:58:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 86309385B83F Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 86309385B83F Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.22.75 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700737085; cv=pass; b=uQKiESjUQ7NiXhunn/B9r9yUVq7oBSfmrq5TrO4amOg5EW9X8kardaNBQQ0EpvUA/4d/fi/9+w8hc/PUGZv+vtR8R3snNW4dT7+VIo0D5Dyh7iWBVEpNeW7u/RpIYjhWj5pDwRfXwsPTngsErCC4gkYSEeBcut0onBcYXsMiizU= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700737085; c=relaxed/simple; bh=bJvRO83eDVnnX30LHJDDD8i0bnP734BVCG8nJL66V7w=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=BsBPfCZHPiHDKOB6Pulo3UeswfhIP1xseUT8MWPJ76nmP5EPNEA7xEXnVDV2Ydy3JGumOKu1i85hHe/2ep2IA+4+MQxNU7xBq2F4+Bn7FowGM6qloZN9FqdLzKzsPwb29O+TVD5S6t7Qf2MLG49aTiE8AktN+Ocn6VsV0+A8pkw= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V0eMdT9mb52rBOKMgw0CBl9aXI/ARen6oKWoeuK3irdlkajiNjV8mZOZlkXKWWU1bUd86GWqGAriHaGRWopeO27tl8/ose6obd16ORNYjtZFz+YGA2kVsV7n53/3e5PetFwS+dJYMkOB45xiQFY7HmykPp0AfakQc/m8ArrXCPftov28vynoFG4qx7LD92SCTJL8PIHQqgT7ydzyF7rmb3L53vh7NBz2zyY2ZbvJYwR17LmVBqVL1ZFHi8ymZ+Fqy/BNFzc7MXrDhDxXEhZ1N8KVSd71DrfifuIlY6Xj4X3hzs3YEOD3EzG8A2uf4Wx3UEgACdH7YNSyDFGEMLxiOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cMAzRvdpM0DtJKcnXs+uesxJeqDjteZFYnSrLqJB8PE=; b=fZKjzbPoKhdqMVmt6grTQUi800OLXC9NVCdsZXHen5uNAk0kJgd4XsQY6+P4sXRMBw/voDZmw8Q+/rljY2vWMnyUhZIFu4K0enwY3Lu7U250sMYO9f85cyjaqtzSzBH3xAmG3IeMJ3vV61Td7nOY2euN+7lqfPdpfJgrrOqPN5C9XOtKARZfOMTO0gcKVIQq0cRYx3GfmUBDv4ehQcGLABywS7JTtJlHe9adMyOdauhesktIFgKzKTCJBSsrArd51Nt4Zi5/QKaFWQpZmlA23/XMGMqp1M3yM1BN7zAnUI/esiNckD/v6GAAZkFn7R1H+N4o+nkU6JEwmWFT9hbo5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cMAzRvdpM0DtJKcnXs+uesxJeqDjteZFYnSrLqJB8PE=; b=b+0mfCqYXQEtl1DLLJxKXqOX8Xnti+JsV2b+eSN1lB+BzjOS/USGG2uutquFWOXzOl8hLush9LxYnNo6HNoxxlzT4ifzlZmYPrzulBdqdjfQriI97iCdhBbf28biFZSXPGYZBKM//ZzyHd5v0BPpZU/fY/aKG84i55uC4G3uuodhXndmqPx1Dh6aqI76uPKl/qsGkOSVVx2c6DEgkUAqvXfKXNyms1CzxOScuLVPokjBKLTc0XypeH1UPWOZzfX1OSDeM9S+raA1Qa8T/jST3KOQNZ3RtqJRJBq36DtecFfHhvJ3ExOxQ1yOeUGSwCX3DkhTFUs/eW+kX3SD2lfSlg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS5PR04MB9827.eurprd04.prod.outlook.com (2603:10a6:20b:652::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.12; Thu, 23 Nov 2023 10:58:00 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44%3]) with mapi id 15.20.7046.012; Thu, 23 Nov 2023 10:58:00 +0000 Message-ID: Date: Thu, 23 Nov 2023 11:57:59 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/8] Support APX NDD Content-Language: en-US To: "Cui, Lili" Cc: "Lu, Hongjiu" , "ccoutant@gmail.com" , "binutils@sourceware.org" , "Kong, Lingling" References: <20231102112911.2372810-1-lili.cui@intel.com> <20231102112911.2372810-6-lili.cui@intel.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR4P281CA0352.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:f4::6) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS5PR04MB9827:EE_ X-MS-Office365-Filtering-Correlation-Id: 9f38ccf2-e743-418a-2877-08dbec130f1f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mGe8IF9+iN7OcLA3yUz+oecAW0WDnXYPrw4IaSB0oQfrWbFfxSfFXam9nFQZsQMWsPz/rkkXvWHALEw8VwDWiYG/diB3cYQMWcmN+PBuMYWtTim8EMMgnV53jJN346yGb2vo+inZXq597T//LVBnxKQCOqfNyLT34RLfA9O9qV4L7ifU52MxTzGgJ8B8IedUf5yJsegobdyoLebnUIKgZD6hooW+tijJ7YigkRnl7Nep/fctm49IDiXEfUi8SiKM/fBitIBt86oMW30UPAbbu3iS2Z91NRfYBh7SUDAgv6juG7hUS7QYxxL8g85ytnPa15KCciDG0lKeqtnVDsUTh8Z0vPMr84IDrh3A3fTYGQFay9Z5LeqqHK6xCBCMXwRyQblaxDVuRBoiYgj46FwNWQ0UwpXL1/Jya5OTl4XUaM6nQ58q5LSO3/M7VeDr8oGPpoYUD9jQU54Y9DKyyEsp5NlzpCxhiplkQIagcWz2SNSpD09HJd/eazFE3klnnakUOSC+nwpMrKD+uYAOcKLjpRYtSpCFUs/xJn/Z9ExrQmTI2ttUUxc6TMV862Q1rPHNYrZQR6G7gm6VEfA7T6SfqHetpy8acnJlSo2WUnFXgUdlMiCkGOf+vnrHrhsEsVlWXOaI9Pm0jDbRxhIqIG46FQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(396003)(346002)(366004)(39860400002)(376002)(230922051799003)(451199024)(1800799012)(186009)(64100799003)(26005)(83380400001)(53546011)(6486002)(6506007)(6512007)(2616005)(8936002)(8676002)(5660300002)(4326008)(41300700001)(2906002)(478600001)(316002)(6916009)(66476007)(66556008)(66946007)(54906003)(31696002)(86362001)(36756003)(38100700002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dXRkTlliYk5kQmxKYVV5eHhDbHpLSGN2Y2o4WDRZZFloZk1WQUhIc3NpSWJh?= =?utf-8?B?Nko3MUduVEVuS0dqaVF2SUFROElzWmdVL1dlUytVbE5pUGNvNHFjTkxjNXEz?= =?utf-8?B?MVhOdFNrbEgvRGsxWW9iTkNsMWgrWmIxZy9YTVIxTFVXOWhJUzU1bmtrUWtu?= =?utf-8?B?M2xvTy8zeHRCdFFMVEgxT2VoZGZzbXNYVnFreStoYjFFOVZncGdoUGhCLzdY?= =?utf-8?B?dzYzSXczWnpXb3AzcXVCcE5tRnNtUlhvY0J0WnZRekJaTVZobDdmbUt3NENq?= =?utf-8?B?UGRjQ25VVjVYczFYV2ZxZEt0c1NwR201QkRtZFdWdVhoR2xZMkUrdHJUNSsw?= =?utf-8?B?d1d1elAwK2dCeG00VTBFWHByTnphRjZpU0F0YU9GSHp4TzY3UW9TUVZhME02?= =?utf-8?B?MGIyMjJuZTRFQkxQWnRrYjhDS1I0Z0hBei8vaVJoQTNtQmpTM004V2xHSEp2?= =?utf-8?B?ZFhpRk9IaUtNcDlTR21mMzUxaGNhYVU5TWFmOVFOV0VmT1N1NkJubldjbzVX?= =?utf-8?B?OUZVbzljMVVmMU9BdWZvS29DOEtwU1h4eHNkS2kvRFgwNmIxcGp1RE1BMGpw?= =?utf-8?B?Ti9tTW93Vk5BQk5iU3BLaEQvMmxBdGhXUVIxdE1TaENpZlV0U0EvQ2g1Smdx?= =?utf-8?B?aGl1WExudFJZOXpxZWllNjNUdlZJR0Z2M0FRdzhxKzlOSFhQZmdZUHl1bXhr?= =?utf-8?B?S1NFRm1xZ3lIOEROcUg1T2Y5K3laV1lETStvb1psT3ltNkM1T1NxRGVQK2NT?= =?utf-8?B?c1haMTdVZWs1OURsL2hxa0Yrd1dyQTJpdmZwaUlydmxML1c2SUExTzNJK205?= =?utf-8?B?MmxCVWxPS0wySTZoT08rNWtudE1Mam9xWkVKeXNFTzRKQmsvTldZUC8vaHZt?= =?utf-8?B?aGh5NGNZc2xXTjlObnNYUnl5cndiUmszNmFrZU1VTUtNNTlMa1VSYXJydy9M?= =?utf-8?B?QjBVcmxTL296ZkQ1OTdUZzBlNXl3Y21ReHpIR3pTbU9GZ1JwdU9YMCtWNk12?= =?utf-8?B?ZCs2OVBpWEJzRkpMQWRvVkQxQTdGM2REdkJpOWE2S1RVUzFJQzBGdUFXN2l0?= =?utf-8?B?Lzg3eXNsMFNWYWwyY2xaT2ZkQmtuMDNXMXBrQVc4TFF1Zy9CaDVMcWxkbkw4?= =?utf-8?B?cm8vS3lEbTk1ZXFmY21xU2JmTHZhTjdaN3lxeHhZM3NVY2NPOCswZTlxSDdT?= =?utf-8?B?L1JLaldRL0c3TTZyVWRrTkdUVWw0TkV3WGpHRmliVGpjTSswcFVzdTNxRFpC?= =?utf-8?B?NHFSbU92dGRLeERFaHIvUUViQzdqYzN6c0lidEFvMXp3Y29PTjdVK3ZBMTF2?= =?utf-8?B?MTFkaEI4N0FTSVVZZTZxRXJuU3NNT0hZQVRWVDZYa1RtM0hRcXFld3dPTy9n?= =?utf-8?B?YURVSUJSaTRYRTJrUVVUMTgyWFVKTlljN1g2aS9acU9GTlJveVVaMGNLRDRr?= =?utf-8?B?SHNJeFVCUXV4QkhrMG5HUTM0STdrY1lCa1JYanBqcnlhTEhvcFVLUlRPakt5?= =?utf-8?B?bkg5SElkOGh4OEhkZThXRVZlWlF5d21qbDZFYi9jOS9aSWxUVStYTjZTN0RS?= =?utf-8?B?MXpRc2QreXVTeWNEV2ZXRkVVS05uQWhhWUpWQjkzQ09lay9jQmwzbzZ3dHpp?= =?utf-8?B?Mk0zS0Z0Mm1IdGdwTVM2WVVPbEpwRjh6dEVZNm1GMFl1NFMyYjQrWHErSHFi?= =?utf-8?B?RHdGeXJpWUhFVUt2Rlh4UCtGQ0JWaWIwanNtS3pkYlN2RXRZQnVhVGRsSm5Y?= =?utf-8?B?aThFZksvT2NKdE9Ha0s2V3gzZlJBcWZqeTdseDVlSzJEeHZuSGZLc0pCQmlw?= =?utf-8?B?WXR0aXNWQ3JIcDZMaE5tYUpIMTNMZVBveDh1WHdOY2hYbUo3U2tQQlVHV0ha?= =?utf-8?B?NnZIa09zOWlFVDRJZUUzWHJ2ZW40WC8xK01DeXBpUUZYbDZSYSt5aVUvQjRH?= =?utf-8?B?ZnRZb1hYazRwQkg5STJnVEhmblpLWEZKWmVEY3JGVnh5WGQvblNPekZyRjNX?= =?utf-8?B?ejlrZGM2VGtMY0MrWGx4V2N2SXJ5TmJKYk9Fek4zYUlZckVHUzd6aFpxL3Js?= =?utf-8?B?STFxZVd0YWVtTzBNUGNDTmFIWEQySkhhK0kyUHpnQktEOVNKNklXQVV5U2JZ?= =?utf-8?Q?zE0PsjNBQUhp42NfrpijTKwSk?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f38ccf2-e743-418a-2877-08dbec130f1f X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2023 10:58:00.6464 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q9HVEjw5HFmF4pLYQEWW7ISzZxho6B5ytsv/mFDgCMnWmroeNmJNjKLWPfgbbPDnMf6MWzMXZ5vaonxeGdNkVA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS5PR04MB9827 X-Spam-Status: No, score=-3026.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 22.11.2023 11:45, Cui, Lili wrote: > > >> -----Original Message----- >> From: Jan Beulich >> Sent: Wednesday, November 22, 2023 4:48 PM >> To: Cui, Lili >> Cc: Lu, Hongjiu ; ccoutant@gmail.com; >> binutils@sourceware.org; Kong, Lingling >> Subject: Re: [PATCH 5/8] Support APX NDD >> >> On 22.11.2023 08:46, Cui, Lili wrote: >>>>>>> @@ -9087,7 +9104,7 @@ get_valid_dis386 (const struct dis386 *dp, >>>>>> instr_info *ins) >>>>>>> return &err_opcode; >>>>>>> >>>>>>> /* Set vector length. */ >>>>>>> - if (ins->modrm.mod == 3 && ins->vex.b) >>>>>>> + if (ins->modrm.mod == 3 && ins->vex.b && ins->evex_type == >>>>>>> + evex_default) >>>>>>> ins->vex.length = 512; >>>>>>> else >>>>>>> { >>>>>> >>>>>> Is this change really needed for anything? >>>>> >>>>> If it's NDD and ins->vex.b ==1, we need to avoid giving NDD a wrong >> value. >>>> >>>> But this is recording ->vex.length, not anything NDD related (afaics). >>> >>> There are some instructions that use OP_VEX, which will use ->vex.length. >>> >>> For example: >>> "addB", { VexGb, Eb, Gb } >> >> But that's a GPR, for which ->vex.length is not supposed to have an effect. >> > > For EVEX-promoted instructions, evex.ll == 0b00, which has the same encoding as vex.length == 128 and they can share the same processing with ->vex.length, ->vex.length also handles GPR in OP_VEX. > > > switch (ins->vex.length) > { > case 128: > switch (bytemode) > { > case x_mode: > names = att_names_xmm; > ins->evex_used |= EVEX_len_used; > break; > case v_mode: > case dq_mode: > if (ins->rex & REX_W) > names = att_names64; > else if (bytemode == v_mode > && !(sizeflag & DFLAG)) > names = att_names16; > else > names = att_names32; > break; > case b_mode: > names = att_names8rex; > break; > case q_mode: > names = att_names64; > break; > case mask_bd_mode: > case mask_mode: > if (reg > 0x7) > { > oappend (ins, "(bad)"); > return true; > } > names = att_names_mask; > break; > default: > abort (); > return true; > } > break; Hmm, okay, I see that this is then down to an anomaly in pre-existing code. I don't think any of what's quoted above should actually depend on ->vex.length; it'll surely need to change once the first VEX/EVEX-encoded insns appears while has .l / .ll != 0 but still encodes a GPR. Yet then nothing I can sensibly demand you fix up front. Without which what I'd like to ask for (re-iterating earlier remarks): For anything not obvious (which this falls under), please add some explanation to the patch description. The general issue there is that while ChangeLog entries enumerate what is being done, they hardly ever say _why_ certain changes are needed. Jan