From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2041.outbound.protection.outlook.com [40.107.20.41]) by sourceware.org (Postfix) with ESMTPS id 4AFF53858425 for ; Fri, 2 Dec 2022 07:17:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4AFF53858425 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AoCerZgw/WeK1wgrUoYsVPI6N+0SM/fwhOBBkjQce8CqaEtyMOi7LtX8XQQwlLvORYd454GnQtEcQIZBNMDooxRbWTa5Oj/dffb4EgwsvXX7P3O7PcvtJubv1iv/zEmDcmNGx8jlNpNjL2mI4GvJz9rlec0fzE9GNw3G7U47kogrAKT9GXX+uzYOu0PMspJhtnut6nCD3Sn51/H++M/UV0mrY2NUcq9cpuZSSMUCQEONeS+eEdc1ia88ATW43Omf+1PCJ8dTRmwMriaMNwlOEZkM3dfCpqF+jYJlN49qQe8wC5yJBq+fm9Q8hSATIXW7wilvxP9RNuFHItY7+oNTGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bzxlW1DZPZdHTivtZuTZdvtJ7RbZS7LNqcoBBiqS+G4=; b=by+ZgYHw/Mt58dshTIzNHOGjqE3vB+D1SegqXoG8JAUmA1CyRawrOaBf33lWwbqcN0jwLIzllA385uH6EX3JAivU1XJZuT+xXt/KFFIqR6E7Lodk7Uybs39bBMpSbs/Uc3YlB/Qee65lTOdMZh//og7+wooHUX+FuGyjvSA2sIs+7+VJYIoQv95ISgoI0CuRnF/9gVxhDkydm+kkuFatlxYE5qBYCH5pKh3Ay0ptuWQF235dc2/JjCZhesCYLwI4ujuT3z4SeVxqos1d0CykGybnOlBrL3DUuxLWfwTadHyftwNzvgQ697is41VhqTCwwrrSZscMJZjy2VLCiJxEPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bzxlW1DZPZdHTivtZuTZdvtJ7RbZS7LNqcoBBiqS+G4=; b=H2TFcC5ninyCmKeqEIyTZmRBuRrkdghVCpzzCJduCLd2kIU+WJhuPQEaSE6Hh9yFKeEUWe9QvcjM1cq1LiKGxRV85IsdEICEWRyP+jDDMZ5nF/X6YYjn0+D0kgJ2JM9t0aBFCQJLvRqnvcxSyHy6cJAXmZ/y4PhPw3QlvZhfXuXq4kM9IUYxVnPD13GrvMLZaznwSMTWIp3Y8VzQR1fg8n9+6G8b9w9zLv69JgDHGXXy/4eRGZCZivLtrRync/idSz3E8fD/nUH0l/qyejGri3o16FlsNe7D+8gHGRlmT0e7oPT6/ip832xX20noxmfCjh/LY7NPNrhH2KimR8o/Lg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8481.eurprd04.prod.outlook.com (2603:10a6:20b:349::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.20; Fri, 2 Dec 2022 07:16:56 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.023; Fri, 2 Dec 2022 07:16:56 +0000 Message-ID: Date: Fri, 2 Dec 2022 08:16:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v3] x86: Remove libopcodes dependency Content-Language: en-US To: "H.J. Lu" Cc: Binutils References: <20221122181927.251937-1-hjl.tools@gmail.com> <6a5d4918-919a-8b6b-822b-17ce38488629@suse.com> <63e51eee-e9f4-5332-d69e-feca3421553b@suse.com> <8bb7a0f0-5809-af64-7fc8-1aabe1047dc0@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0037.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8481:EE_ X-MS-Office365-Filtering-Correlation-Id: 59c0f4de-196c-4380-ea24-08dad43531ce X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ua/oGUHJminX8J1pn0dcY7nXPmNnRoo99BgtcsNAAXccn4H0T2bKUnDWLatIL/UbsqK6kZQUIr+JLcBBTTmg6hxNcpi8hxM9wRWnSCwxzUTHV8CyRsJlUkRYK39sfm/33DYhg+TsxN0FGDYdcuC6FFgvex5MEdke1ZzRUednolOlaB5JBgCxDr9r6TxAMi8g9wzP+bR3bA+62W7MsXbuBYKTx3tzEykrAqNFpiO1dTdOQc4WNX8b3NSJWH/1IktpOJoX1VdwpP5VmkjxmwTmHofgI5XZwXOFOVmLKAimW9JzC6DtQthjlGyA2z7P4QKZSzPHGb83mTKOKrTbGBY8eoOLnrpfHMn8J/l8Dp2LICEpgrgI7U+/M4AMlYx+0V2NSZEAO/HSBUwXSlJ4O3btwNgAYi6UEjVxPHeWXjGzjFe8gXbaZp8KWgxLTzmwbheI0wxT0nn+xqDAPjfJYTTBdNagN+Qd/crW4kW4S/J3+/cSpCvs0CjcAx+RDAFcM+fN3uaFjzgdqb9Neq4FMZW7IrMeHdjhXDgD3LB74v/iL2fL9O/FAlEE8olKu4VI3bdYor6p2DPQTSOm5/t4BpbdUv3WJ2O06FOtWDYAOJnRnMRnGk6c4wGZM+nsc/WQ95OhQ66VrYK2fYkYKJYg0inVrzXSjE9dqfLblXg6OUcj8NNW97L1n81Ea5T8CRK9k4Kt1tfsmZu+3T8YxhBeQgP+tWAUKLP+qVdT0LgfPqf8jYk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(39860400002)(376002)(136003)(346002)(396003)(451199015)(36756003)(2906002)(31686004)(186003)(6512007)(26005)(5660300002)(2616005)(53546011)(4326008)(66946007)(31696002)(6506007)(8936002)(41300700001)(86362001)(66476007)(6916009)(8676002)(478600001)(6486002)(38100700002)(316002)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bXV0dTB1ekdxMTROQzdwS1hvSnkrbVQveFJHRnJLOFhOL0RwaFBSN1VTZ3Jr?= =?utf-8?B?Nll6YlFoNUEvam9kV2NFNDBqL21iZzFpWmh1QkRwemVVK1JGVTY5YjI1YmdY?= =?utf-8?B?TmFXNXZicUwvdERVc1BGZFJFYmNBU3ZLbzFtcGtKNTJZQkhTQXc4a1pwTmEx?= =?utf-8?B?VFAxYWhDYnpRY0tuT2xBZUtBblZSa0lqUU1ZTHBIMjM5RTlhRlNCVmFDdHBh?= =?utf-8?B?WERmVzVtYzg5bm5teElVWktBSlFxajJlUWRHZEVPblRla1FVMXBlZWFueDI1?= =?utf-8?B?YmN3QzkvcU1vM0Zhd3Z6TU11a1VJYTFzTzNmdVNKZWwzZTRUN20yZGp5Z01S?= =?utf-8?B?c1pPclRmOWZNenY5d1BmOGhtbEdxMlM1cngzZ3ZNS1AyQXhoV1hMVGpwalNV?= =?utf-8?B?RG5KVDNkMjhSQ1dYeFY0dXNEQVNsNFNIU2UyWi9EWklDRzdHRnQvNzVWMmFC?= =?utf-8?B?aDU3SDVFaVBaU3lHdTVRUWtKc28wN1ZaYy90eWV6MkZoTDhBMGdReHRaZ3Vt?= =?utf-8?B?THlNdXRPblNBQjk5ZnlnSjdnTW1VZzNReUw3N0EvS3dMdkRmMzE1TFhQenU3?= =?utf-8?B?NU82dEllNGZCREdPYmFNcDNaVTU0VHg4anlQcVpxdVU2RTdhQlhtVk9jRzU1?= =?utf-8?B?SGNaeTdjUnQvQXdUWUUxNHNjNGF4amxDTUlNTHRkVE5NVVlOcVZIQ0k4a2tH?= =?utf-8?B?UUZQaG4rMURIdnkyOGpSYUJvU0t4eDIvS0FVZzlpRTVTK0l5Q0J4cGNIR2VE?= =?utf-8?B?V3BCNDd2UWpVMGR0dGJXdlVaOFN3bVlpbHpVWktSV0VoL3Y3T284QzZ1TXk2?= =?utf-8?B?MCtCbUZhN0tkaC80U2pyRnlRcklIOXlCVTdVaHlWRU92dGdYZk1LZmhnWUg0?= =?utf-8?B?NWZLR3Y4UFN4YXpnZ0xDRkI2Yy9uYzhFSTZNbXhSYk9STmhSUG9iM3lrSW5E?= =?utf-8?B?NVRuMXJLUUtOR2JRTUtLZjdIVlljOWYxS1FiYW5ZL3p6NFQ5OGJ0di9CRHR4?= =?utf-8?B?bmF2b0NEVXVPZDFmMVRIVlJXeTRxYkVUaHJ3MGdNZnIvRzUzT09Xc2tzVEgv?= =?utf-8?B?blFTTWFtYWFnS3lHVGdXcXJoK1J1ZEVHSndFdndEK1dubTZ1RTI0clNMMXBq?= =?utf-8?B?cUJKZzc5eVcxMjBSTUZIL1h5alp2SnRvU3poMWEvMmJEaDY3UHRmVFpVMGNp?= =?utf-8?B?MTNmdERvSTF4YmdMMGtsMTY3aTZxK2oxRERkUVM0NDZGcm9FSnFrVWdkeUVr?= =?utf-8?B?V2xZMW5vSXpxQU4zSHo2QWM0cU1KVFhxV0xhYzdsR2had0hLcnFWSFk0WkFm?= =?utf-8?B?M21uY3hndGhBWGJtcmc1ajVqUFFIZllXQXovRVJtVEtuaU9qUW1OYXNka3Y3?= =?utf-8?B?cVd0VFRCMnRmcTVqemxOdlVVc1drUGhyekdTS3gycTdDTFRiQVc3bDVzZ1BB?= =?utf-8?B?a0RkRHdoWjNOeEdPSE8zaG1aUWpLUzh3QTZCNHhoRmtVajdmdGtOSTlMZVJY?= =?utf-8?B?QklRNzhsRTl0Uk5VVXQzeEZQNXFGck0rNWpJKy9QYXl3ZmFyOGhXUkg0b2hD?= =?utf-8?B?b3kzY3YxOTRabjFyRDBRQVpWSVI2MXo4WXdmWkJwak1mMnVmalV4Q3Rjc1hI?= =?utf-8?B?Rms1ZHczSG9IMjg5K0lyTU8xWlY5czJUbG9IL24vWm1Vcjg2VE53aDJyUzR3?= =?utf-8?B?aUt6VldoV1RVS0hJcnZlcDZUcWZ6d3dXUVQ1dUNvZzVFSTN1QmtiL3FGU2Na?= =?utf-8?B?eUJvdk1lUlVVWTRoUDVXVDJQRGs0WFlpYlVTMWRKU2g3bkNkSm10V255TXlL?= =?utf-8?B?T2Q3dy96ajVydzVSOTI0c1dISysreFM3UU9kVTJjSVRHMi9mSWZNbExJOE5W?= =?utf-8?B?ZTRURTh6RW05SXI4SjlKOGV2amticHhnVmZMUWVFOEIyZ0dkSGN0bmxJNUVp?= =?utf-8?B?bjUyU2tvakd6LyttK3p2Zm5XQS9WS3g0L1M2WXJMTy80ZDB1b0ZubFE2dnRI?= =?utf-8?B?ZnFoMFNmRElDeCtjeWsyMyt4ZlNqUUJCdC83SVpqWDZBcXBmTjIyYS9vNDdh?= =?utf-8?B?dXVzYUdXUi8zVFFnbTBYKy8vZ0piamJtelc4eG8rSllOL1RPemErWlVQYWIw?= =?utf-8?Q?n0IjhIEoTjsQX3MyBlzlOhB86?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 59c0f4de-196c-4380-ea24-08dad43531ce X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2022 07:16:56.1595 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: E4LfCGq8tSs95os2DOYlKJw3Xe0IlULpyh88Dl1iYiVfzJ+WOsicdF31rdTDJjh/dasJ4HCEy8e65Uv4F8Q8HA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8481 X-Spam-Status: No, score=-3029.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 01.12.2022 19:26, H.J. Lu wrote: > On Thu, Dec 01, 2022 at 08:41:28AM +0100, Jan Beulich wrote: >> I understand you prefer it, but given you've found what's wrong >> yourself, I'm puzzled by "I don't see anything wrong with my >> approach". Or wait - looks like I misread what you pointed out >> above: That looks to be something from the top level Makefile. >> Yet then again I can't spot any such in my build trees. Where is >> that excerpt from? (I can spot somewhat similar patterns, but >> they're used strictly to recurse _down_, just like looks to be >> the case with what you've quoted.) >> >> In any event, a practical manifestation of the issue I've said >> I'm concerned of is this: If a 2nd party anywhere in the tree did >> the same you do, and if the two $(MAKE) invocations then raced >> with one another, then it's plain undefined what would happen to > > Fixed. In which way? You still ... > --- a/gas/Makefile.am > +++ b/gas/Makefile.am > @@ -448,6 +448,18 @@ development.exp: $(BFDDIR)/development.sh > $(EGREP) "(development|experimental)=" $(BFDDIR)/development.sh \ > | $(AWK) -F= '{ print "set " $$1 " " $$2 }' > $@ > > +config/tc-i386.@OBJEXT@: $(srcdir)/../opcodes/i386-init.h \ > + $(srcdir)/../opcodes/i386-tbl.h > + > +# i386-gen will generate both headers in one go. Use a pattern rule to > +# properly express this, with the inner dash ('-') arbitrarily chosen to > +# be the stem. > +$(srcdir)/../opcodes/i386%init.h $(srcdir)/../opcodes/i386%tbl.h: @MAINT@ $(srcdir)/../opcodes/i386-opc.tbl \ > + $(srcdir)/../opcodes/i386-reg.tbl \ > + $(srcdir)/../opcodes/i386-opc.h \ > + $(srcdir)/../opcodes/i386-gen.c > + $(MAKE) -C ../opcodes gen-i386-tbl ... wrongly recurse from gas/ into opcodes/. In fact I can't spot any change in regard to the cross-subdir operation that I continue to object to. I'm afraid I'm unaware of ways to address this other than by avoiding the recursive $(MAKE) invocation altogether. Jan