From: Indu Bhagat <indu.bhagat@oracle.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH, V2] gas: gcfg: fix handling of non-local direct jmps in gcfg
Date: Thu, 28 Mar 2024 16:03:22 -0700 [thread overview]
Message-ID: <d822c7de-0d6e-480d-bf3e-627f08b8d042@oracle.com> (raw)
In-Reply-To: <aed69df8-62d7-4721-9d72-432a4e65dd3c@suse.com>
On 3/28/24 09:35, Jan Beulich wrote:
> On 28.03.2024 17:26, Indu Bhagat wrote:
>> On 3/28/24 03:10, Jan Beulich wrote:
>>> On 28.03.2024 08:59, Indu Bhagat wrote:
>>>> [Changes in V2]
>>>> - Add function level comments for ginsn_direct_local_jump_p.
>>>> - Add a jmp to locally defined label in the testcase to make it more
>>>> complete. Also, add a jmp to label defined in another function.
>>>> The testcase now generates an additional warning (as expected):
>>>> "Warning: GINSN: found unreachable code in func 'bar'"
>>> For this - can't you simply omit the unreachable pair of insns?
>> We do omit those instructions from GCFG and SCFI. GAS does, however,
>> warn for now. Do you mean skip this warning too?
> No, I'm talking of only this one new testcase.
OK. I removed the unreachable pair of insns and the warning from the
testcase, and pushed.
Thanks
prev parent reply other threads:[~2024-03-28 23:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 7:59 Indu Bhagat
2024-03-28 10:10 ` Jan Beulich
2024-03-28 16:26 ` Indu Bhagat
2024-03-28 16:35 ` Jan Beulich
2024-03-28 23:03 ` Indu Bhagat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d822c7de-0d6e-480d-bf3e-627f08b8d042@oracle.com \
--to=indu.bhagat@oracle.com \
--cc=binutils@sourceware.org \
--cc=jbeulich@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).