public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Jim Wilson <jimw@sifive.com>
To: Kuan-Lin Chen <kuanlinchentw@gmail.com>,
	"binutils@sourceware.org Development" <binutils@sourceware.org>
Subject: Re: [PATCH] [RISCV] Support subtraction of .uleb128.
Date: Mon, 02 Dec 2019 22:27:00 -0000	[thread overview]
Message-ID: <d86c7a5b-6068-9717-d4f4-c9221efc83e0@sifive.com> (raw)
In-Reply-To: <CAJr6u0h3bsoK+-WXzs+ZHUi-GNb06MY8nDKD9=1JRFEGRp5r=A@mail.gmail.com>

On 11/27/19 12:11 AM, Kuan-Lin Chen wrote:
> The data length of uleb128 is variable.  So linker must recalculate the
> value of the subtraction.  The patch leave relocations in object files
> so that linker can relocate again after relaxation.

I think we should have some agreement on the psABI change before we 
accept binutils patches.  We should give the LLVM/lld folks a chance to 
comment.  I see you did file a psABI pull request, and that there is no 
discussion on that yet.
https://github.com/riscv/riscv-elf-psabi-doc/pull/124

I haven't reviewed the patch yet.  I took a week off, and am now trying 
to catch up on the backlog.

Jim

  parent reply	other threads:[~2019-12-02 22:27 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-27  8:12 Kuan-Lin Chen
2019-11-27 10:36 ` Andreas Schwab
2019-12-02  1:18   ` Kuan-Lin Chen
2019-12-02 22:27 ` Jim Wilson [this message]
2019-12-06 23:48 ` Palmer Dabbelt via binutils
2019-12-10  5:43   ` Kuan-Lin Chen
2019-12-17 23:59     ` Jim Wilson
2019-12-18  1:50       ` Nelson Chu
2020-01-06  8:18         ` Kuan-Lin Chen
2020-01-06  8:37           ` Kito Cheng
2020-01-06  8:44           ` Kuan-Lin Chen
2020-01-09 23:20   ` Palmer Dabbelt via binutils
2020-01-22  7:26     ` Kuan-Lin Chen
2020-09-25  7:14       ` Kito Cheng
2020-09-25 15:55         ` Jozef Lawrynowicz
2020-09-01 12:56 Jozef Lawrynowicz
2020-09-02  1:29 ` Kuan-Lin Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d86c7a5b-6068-9717-d4f4-c9221efc83e0@sifive.com \
    --to=jimw@sifive.com \
    --cc=binutils@sourceware.org \
    --cc=kuanlinchentw@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).