From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 6D29C384AB5D for ; Thu, 18 Apr 2024 20:38:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6D29C384AB5D Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6D29C384AB5D Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713472688; cv=pass; b=s4MlcdO6KNUZV57MLmxqNMpJTPJfTxOLfQkN5HjZd0AzziBBwmpY3EvQnT7aWZlW3v20xru83EIWurBgvAiY/G/H65s764YmSUHIv96nfG3AOevx9XBnYARzk84MoLX7iiTLcPjrwTHm1tHVsRDgVek3HELP7a7g9Zs3MT6JUk0= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713472688; c=relaxed/simple; bh=4yn7h6wnGCmvKy9qlGJm680RGdAsq6qwdO83MX07LYU=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=nZbEMi2VNrN02kyuwzB1WcbwGdzUCWopQ5Gxdpp11PNx7TrieRnMWsk6r2Bmj/wtAonAZ66QZcw8E4KIUEwWXvqgiBuBKA9KD/cyiBU2GsVWQ3SHu8PRrYlgeOmPoaSJb7kLtn/A7SpnAWCtSYnYP6z054NLoQrrwaTP5UQ/DZc= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43IJiC9A029107; Thu, 18 Apr 2024 20:38:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=Hymn0+WU/oRAzCIg5BhVL6c4VHwTXg4GnVg5sHRhahk=; b=NJ9f3gqggEWSAPGmaydz/LgkvBS85ppcLtG0heJ41hjUyiCxQ+FkjanPNYhAotU4XPZm tLd0RTMUUS6Aqw7HQS4FcmePYbJPXAS1iweQJWLbpf+147nBf732MGD4CEjcAqKysYYA 4VaLk5xoCjOLd9vx8ahWmQq9ZcTMNsEdhITH8Bj/Um2Szhv4zMzSRSB4LKuLDXnPAhlX bjO3WU/jMThXk19G6cMPLJjy+k8cRFd/jpkYFOXefx+EAAZG+QO8ypWluF/Ip10gikgW 8z85dv2i9o6sQ8+y26pcdQnUnpBuft3pFFGeo4dxjUv6r4or1KlETDCO3EF9V9qAiNeG Ng== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3xfj3ebqdg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Apr 2024 20:38:05 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 43IJdu0n028938; Thu, 18 Apr 2024 20:38:04 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2168.outbound.protection.outlook.com [104.47.55.168]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3xfggayatt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Apr 2024 20:38:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TGU9gfYIFM3J1BCJEokeDNcgaidMNzZjk9yrYNDeySNkn8YlnetPD/+cncdTy5Pjm+h6ZpJ7oeHzee7wYQjxHnR00UDdYh9r2uNOKrhDczHLGpGUHm73Mt5jNFXX24l0qcC+oDmDrdlglyWemAQ9Xyy1v3pRQ4KPKOBPPHwAsPs1hgQuhy0U3+n8am6ApSabH2ius5O3M5W/lQUM9cCTedT1iLNYJKNZxn551iP4+tAt1zk4oXxUICZXOnMuXocSHBVN2yft8uyjU/vNL6j5wEcdgJyP4cyIEKm9plhDd0qRAHkIahGE5m/nwuJhGnBDypUgWPvOmfBYHH24XF458w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Hymn0+WU/oRAzCIg5BhVL6c4VHwTXg4GnVg5sHRhahk=; b=Bs1avD2V89lzcSXUmNXkgXPMi93AKmc8aOQ9imu4DHM5yquUNM2ixi2UWWir6XQYyzV8Or8uSkCIgUEIHZnToXsqlMNVQDazW4VNKjdTEsL8/qYEC/f8/bXEA2HRK2fLs6ZM9BUSOvmDnvxR1lzYYonB12pRK0Xe9jAIXkZ9jI5Pb5400hOq2N33eRa7WB8/xO22vk3/yazO5V+otXi+sCg1mSbKieIbwdQA4Rpyj4a46RAhNbjb5oRM7TTMliHdsU8QFUTkUP0nLjrg0/J0k+KZuDkDA2a1tAi8SC8Q5gPs7Y4b/vZQwu18yaZblw7NysAjI/UsaqpcT1iQOQCOWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Hymn0+WU/oRAzCIg5BhVL6c4VHwTXg4GnVg5sHRhahk=; b=TR5SEj+B3xqVT4jG9lyoPy0flvbfSZQksAaEFZU+q8tIQbwJwzjEqh2tEDHLFLfiUARbq9+OyaqlggsKBtfhRA3YnRTY1mhGsVyADF+7bTCaSl3Jj7QPwA7m91IKuvMPZjklxPZj15K1A3Ds9SlVwNDNB0y3QA/oTFdmaa16xvI= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by CY5PR10MB5913.namprd10.prod.outlook.com (2603:10b6:930:2f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.42; Thu, 18 Apr 2024 20:38:02 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::6f0e:742a:270:889]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::6f0e:742a:270:889%5]) with mapi id 15.20.7472.037; Thu, 18 Apr 2024 20:38:02 +0000 Message-ID: Date: Thu, 18 Apr 2024 13:38:01 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 15/15] gas: Validate SFrame RA tracking and fixed RA offset Content-Language: en-US To: Jens Remus , binutils@sourceware.org Cc: Andreas Krebbel References: <20240412144718.4191286-1-jremus@linux.ibm.com> <20240412144718.4191286-16-jremus@linux.ibm.com> From: Indu Bhagat In-Reply-To: <20240412144718.4191286-16-jremus@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR03CA0162.namprd03.prod.outlook.com (2603:10b6:303:8d::17) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|CY5PR10MB5913:EE_ X-MS-Office365-Filtering-Correlation-Id: 591cf165-e55c-48c9-affe-08dc5fe77130 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: coApKhkVTehtytdSM/MwWu3N60JOFj75cfuyHGxeiMWnfpgKGUQkPIAN+T1eIUH8UTUcRGVzwuWMCkYI+VWXiJBpgR30JwLtrfRyvtBJxHgXQDTOhkuSVHFMv0zmogv88uHTm0IcDui0d2lx6EJsD8IHR8oAynYep3R9Cxl/P0xAj6t+GBHvEuUigDmldImQJP5rNvnD95QUwH88sbwO/UXW6ljwmza3pxdEQkrwHCGHfF0YofL/lEyLO6AY7z60CdSo72qAQRZdIuJDWKdbrFJpS7+WfrdiZCT+z38/BFrJW26l0sMO+5c5rD+nhyZYRVndGqmT0FXdGSiBxQkFAJ9dxaiVO1OaIYlvq8QB6Ap73wUXsTC9pa6RZI59TgVJPzHCjuXaVl10R7sDArG9LYqXkY625xQUQAhB2cUD+vG+WBBN81tODiX5S/bLZ12KDL4OccV5BrBkIxx6+CXcSnDVqTwspMtLiO7yKRnwIw72fFPY51CKkKIbM/Q07huXyicILFsRiWfVIeRmwHdcvMxMIvPbKr0rMnVPRUFbdtd/22QpNyUtt3fBzkyGV2+JqhnxAIXGh1FoN0ug/Lu2UzWeV9t1czx+Hrw6EIQw/00/6+eUs+SWq2Xrg+IU/MLZjDcJiv0i2nnC/LDYCmXQFi85Cmx+ppsFFNFVUROwxaA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(376005)(1800799015);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Mlo4cjNVVDZGcnh1MnpxcENTdUpHaHZTYUhnTjAyeDQ3M0VSSlVjd2ZxSzZ2?= =?utf-8?B?MGNiL2NvcW5uR1I0OHJ5QWM0M1YyaStvUFYyb3ZmRVhPSDREUm9iK0JVWjVs?= =?utf-8?B?T3JHOFdYajBROXRoenhqLys0MVY0V3NNLzBtL09wOUhIdW5ObHBLbDBaeE1r?= =?utf-8?B?K1JwRXlaMXV3QzlySTArV0pYSU12cGZrU2pUaUpmQSsrenZvSHNqYktjUjd2?= =?utf-8?B?WVVDOWtyNFV5NlhyTmV1bnByb0V6dytzTHRKTXFjZG95VE1KUy9DZi90eGFk?= =?utf-8?B?Rit4Q2NUN1lZY0dVb1VBTGhsRUc0R0J5aE9tbk5QYWZoVWgvVS9vZXlveVR2?= =?utf-8?B?MHNjWGN0M3NlTy8xaFJoK0d0OS9lWEJwN3R5R21BbmpZa1hyYlRYRFd3ajNy?= =?utf-8?B?bnlDV0RIeXhvQUc5dkhjTEdJemlBU1hkL3U1NU5xamw3T3pGazJVRzBvUzdw?= =?utf-8?B?YjNUOHlYWW1MTnl6d3FXeEh4VGFIV1Y2WlBRNVJrNExTZG0yZXB3OGFDL3F5?= =?utf-8?B?T3ZnVEoyWE9sL2piMThlK0tvVVY2Q2lNb1IrWExITnpZNzVJL2JPRkk2WGJ3?= =?utf-8?B?cVVnT2syV3dGWEVLRDhKZFV5WWdYOUhCaG1UMmxnWGJ5UWEvbExnM0NpNW0x?= =?utf-8?B?cTMyR1VKanhjWDF1UmY3V0ltY0QvMHdIcEZHOHpXNWR4eEtJdU80ZDRkTUt4?= =?utf-8?B?c2cwRGFNYkR0V1hhRG9SU015ekR3Z3IxNjJKOUw5KzhuR2hEV3JMTjQyQVhV?= =?utf-8?B?NUVteDZGNDduZnVFcGlBdUhCWkR3Z1NQU2VYbkpvT29ncjFtcXpub2M0Kzk4?= =?utf-8?B?a0dyd1BlWUU5R2p1bWNoN1dvN1NvSGV4T0pXWU8rS2pSRlhUaUxHaGZ3RGlV?= =?utf-8?B?c1o0YWJ4R3hnS0FFR3RmMDBQbi9ObkFEZE5IUTZXQmFaSEpEZWV1alhUWmth?= =?utf-8?B?L1oySkxzVllMTjd2YnU5RjA4WUxHdjhPZzFFNzdhKzMwZ0dWaklkMGJhd2Vw?= =?utf-8?B?NnVsdVV1b2hXZjRHQ3JaVVo1M0U3MkN0aGlURk1YU3ZsVFQ1SjBxQzl3SU9t?= =?utf-8?B?VnA2dnlvOFVncTV5RmxhRVBWbHZmeHBTdjk3em9ScjQ3Z2dSSGV0WGZ0VHVX?= =?utf-8?B?eU1ZekpzUDJwUEFUYkROaXJ2SEplVXdzVE4wOU05VXRwN1VNakd3a21MK0NK?= =?utf-8?B?aWo2R3hCWWZKNEVIQmNVL1l5ajlOOG53T2tGVCtNUHNld2krRncwbDBPRDBr?= =?utf-8?B?bWpvdi91ZG1zVzd0QkZsejZMZWtZaGpTZlU5ZzRSbEhwTWtLeVRtRFBxOFZo?= =?utf-8?B?UUZhME1La1JSWVhLRW5ucTZtT0VlQk4rUkw2UEFkUjRMem5Nbk5YZzNNOGNM?= =?utf-8?B?aEU0WnhJUlJJTDBnY1ZWdWtSOExWWG8xYS8zL1gwbzJGcmJVU2lVWkVsQ0FW?= =?utf-8?B?ZkFXSGM5Q0dSSXVIQ0hNSm9xNVd4cEpNS1JNeEgrTk1VOEUyVUpLbHlHa3Qv?= =?utf-8?B?SjlBL01USERsNXRnMEJScEk3Y0xaTGNtMVhmMWFsbmlNWXBjbFptSkhTS2pG?= =?utf-8?B?SU5XUTlOTlhKWHBFOWhPOE5YSEM3ZFRnQk9vRE5XajNiSFhXVmRTNUx4Mld2?= =?utf-8?B?c004WjZOSU9yQlhJUTc4T0xxbjJvYlhXUkZ3QlNLaVAzSytXaXRWRDExWnRW?= =?utf-8?B?ZGkyenJYQTh1ZzAxdEFlRGYzcjFlWmt1QkhibXAwM29JSDVldHB3QlpiNWRQ?= =?utf-8?B?V28vM0o0dnZIWFhQTDhRcE82cUcrTXhjblduSFhwUEtBN3B6SWdIclY1ODdu?= =?utf-8?B?UEhrdEw0YlNTNlhTOGFod244ZzBOcnVkNEtFRkowV1ZEMFRPQzJNUTQ3dlkr?= =?utf-8?B?aEFvZFRtQjZyY05HQW10TzhLMnE0Z0hnMnlia29qWEtXanI5UDZ6amFLam5U?= =?utf-8?B?MUVESEN2VzdoT0RjRVZXMHp5Yzd1Nm90dWJ2LzZEQkRseGp1cks5K0JxSHRB?= =?utf-8?B?Y1piUVJQMXpFWDVQVElWQkhMRllYU0dOR2JoZTBxVWtEQXFCY2taNUI2K2xJ?= =?utf-8?B?d1dsUm1BbE5jSkVJV3lmc0ZzTm9tblhuM3B5RmhvSXF1OU0zZDExclhhRE9j?= =?utf-8?B?V1pjMjFCWU5yVWZUdWRmS09Md09DOFpsZzB6S2FJdG03OXl4YWw2YVZaQ255?= =?utf-8?Q?UQT9o6AptDZNAnZqNos3wtE=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: /xAAASpan2C97F7daNy/Bk5LicwTbenSf95k3xe/+M8adLAIeVklxIfhSzCLVnHAQpnW8JywdleIOwWvcvfmMLZ5vh96Wegq1Sk2zab6299N44DRdLPSLhQk/5qIlY5R0l0SyHWic4QRaclXijuBLqP5pgZ02VA1jtN+xYE0ePd6KrqPSGmoDMf57qXPKJ/16OCeGHsW8dnVTMC2BEbqxSHKOeW64oLd/m1MnRbquAUtGJdRGn+f7D1kNGHRKmBk92g5jaIIDctvZW34WF2//YOMGRukTI6hI7A5+AR8JAyuvx8v5wS9wpwL4eeAkjjRI6hLi7W69tEcy6ZcQMNhFQRzjrmwRqKtg3GbeZ1pN08ze+9trg6u1TJFUwrokRBrSl8C5fyGrDaSZa+3cBAwJTrCCE2JT0e36wChrLADN1GmWjUSwH6Mp1aV7hjdNoHpSgOlJ8z2fpF8MXvuawl+uvfZ8P46urAThcU5Y5rKpOnvVG00HOMm83Y1ijK/XnkxNooew/03SAZmMT7g4Kgp8+pGALQ51eYSLJAEpXxRB6HhV66XTV6o8DdA90J6QR7Zs7Q/A79/Eg8oW18p9k18cxDWaSjs1CwleJ7e6kaxhXY= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 591cf165-e55c-48c9-affe-08dc5fe77130 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2024 20:38:02.1561 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KlSvqLTxFzFC0+KrYnm04BKy6fQqCcUVJWk4xjck8TfNNws3L/Zn0/yi3CWb8feZAUM3b05BkjFgnDyXteT1yA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR10MB5913 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-18_18,2024-04-17_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 mlxlogscore=999 mlxscore=0 adultscore=0 phishscore=0 malwarescore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404180149 X-Proofpoint-GUID: 9NGUtgstkPClRAibWNZ5VUjY5FE5Bjnk X-Proofpoint-ORIG-GUID: 9NGUtgstkPClRAibWNZ5VUjY5FE5Bjnk X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/12/24 07:47, Jens Remus wrote: > If an architecture uses SFrame return-address (RA) tracking it must > specify the fixed RA offset as invalid. Otherwise, if an architecture > does not use RA tracking, it must specify a valid fixed RA offset. > > gas/ > * gen-sframe.c: Validate SFrame RA tracking and fixed > RA offset. > > Signed-off-by: Jens Remus > --- > > Notes (jremus): > Changes v2 -> v3: > - New patch. > > This could be made dependent on ENABLE_CHECKING (configure option > --enable-checking). > > gas/gen-sframe.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/gas/gen-sframe.c b/gas/gen-sframe.c > index ca6565b0e45e..7e815f9603ef 100644 > --- a/gas/gen-sframe.c > +++ b/gas/gen-sframe.c > @@ -1532,6 +1532,18 @@ output_sframe (segT sframe_seg) > /* Setup the version specific access functions. */ > sframe_set_version (SFRAME_VERSION_2); > > +#ifdef SFRAME_FRE_RA_TRACKING > + if (sframe_ra_tracking_p ()) > + /* With RA tracking the fixed RA offset must be invalid. */ > + gas_assert (sframe_cfa_ra_offset () == SFRAME_CFA_FIXED_RA_INVALID); > + else > + /* Without RA tracking the fixed RA offset may not be invalid. */ > + gas_assert (sframe_cfa_ra_offset () != SFRAME_CFA_FIXED_RA_INVALID); > +#else > + /* Without RA tracking the fixed RA offset may not be invalid. */ > + gas_assert (sframe_cfa_ra_offset () != SFRAME_CFA_FIXED_RA_INVALID); > +#endif > + I am not sure if the detailed checks are worth it here (simply because of code patterns that follow). We use the sframe_cfa_ra_offset () function later and only in output_sframe_internal () (shown below). How about we simply put an assert there (and get rid of the proposed thunk above): #ifdef sframe_ra_tracking_p if (!sframe_ra_tracking_p ()) { fixed_ra_offset = sframe_cfa_ra_offset (); gas_assert (fixed_ra_offset != SFRAME_CFA_FIXED_RA_INVALID); } #endif out_one (fixed_ra_offset); fixed_ra_offset is initialized to SFRAME_CFA_FIXED_RA_INVALID in output_sframe_internal (). > /* Process all fdes and create SFrame stack trace information. */ > create_sframe_all (); >