From: Jan Beulich <jbeulich@suse.com>
To: YunQiang Su <wzssyqa@gmail.com>,
YunQiang Su <yunqiang.su@cipunited.com>,
macro@orcam.me.uk, paul.hua.gm@gmail.com
Cc: binutils@sourceware.org, amodra@gmail.com,
Nick Clifton <nickc@redhat.com>
Subject: Re: [PATCH v4 7/7] MIPS: Fix Irix gas testcases
Date: Tue, 15 Aug 2023 08:13:16 +0200 [thread overview]
Message-ID: <da0dfe4c-f161-aa22-8ca7-83fabe001a70@suse.com> (raw)
In-Reply-To: <CAKcpw6VkvZE1c=ntgYjK0k+QdH4YjE3jY6U-kuQDA=WL9F=SNw@mail.gmail.com>
On 15.08.2023 06:40, YunQiang Su wrote:
> YunQiang Su <yunqiang.su@cipunited.com> 于2023年6月16日周五 14:41写道：
>>
>> 1. Add -mpdr to some cases.
>> Gas doesn't generate .pdr section for Irix objects by default. See
>> `int mips_flag_pdr` in tc-mips.c.
>>
>> 2. Add irix-no-pdr.d.
>>
>> 3. Add and use call-nonpic-1-irix.d for Irix targets.
>> Gas doesn't set O32 flags for Irix objects in e_flags. See
>> `use_e_mips_abi_o32` in gas/configure.ac.
>>
>> 4. Add mips16-e-irix.d: g1 is marked as O on Irix.
>> The Irix 5 and 6 assemblers set the type of any common symbol and
>> any undefined non-function symbol to STT_OBJECT.
>> See `mips_frob_symbol` in tc-mips.c.
>
> @Maciej W. Rozycki ping.
From what I can tell, you've addressed all of Maciej's comments on v1.
On that basis this patch is provisionally approved in case he or
Chenghua don't respond within another two weeks time. Btw., it often
helps to send pings To: the person(s) pinged, not just Cc-ing them.
Jan
next prev parent reply other threads:[~2023-08-15 6:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 6:34 [PATCH v4 0/7] Some MIPS changes and testsuite fixes YunQiang Su
2023-06-16 6:34 ` [PATCH v4 1/7] MIPS: Gas: alter 64 or 32 for mipsisa triples if march is implicit YunQiang Su
2023-06-29 10:12 ` YunQiang Su
2023-06-16 6:34 ` [PATCH v4 2/7] MIPS: Set r6 as default arch if vendor is img YunQiang Su
2023-06-16 6:34 ` [PATCH v4 3/7] MIPS: Fix r6 testsuites YunQiang Su
2023-06-16 6:34 ` [PATCH v4 4/7] MIPS: Fix -gnuabi64 testsuite YunQiang Su
2023-06-16 6:34 ` [PATCH v4 5/7] MIPS: Fix some ld testcases with compiler YunQiang Su
2023-06-19 6:44 ` Alan Modra
2023-06-19 10:43 ` YunQiang Su
2023-06-20 0:00 ` Alan Modra
2023-06-20 1:40 ` YunQiang Su
2023-06-20 2:34 ` Alan Modra
2023-06-20 3:17 ` YunQiang Su
2023-06-20 3:57 ` Alan Modra
2023-06-21 5:05 ` YunQiang Su
2023-06-21 10:53 ` YunQiang Su
2023-06-21 10:59 ` Xi Ruoyao
2023-06-21 11:03 ` YunQiang Su
2023-06-29 14:17 ` YunQiang Su
2023-06-20 2:58 ` Alan Modra
2023-07-03 4:00 ` YunQiang Su
2023-06-16 6:34 ` [PATCH v4 6/7] MIPS: Disable fix-rm7000-2 and llpscp-64 if not has_newabi YunQiang Su
2023-06-16 6:34 ` [PATCH v4 7/7] MIPS: Fix Irix gas testcases YunQiang Su
2023-08-15 4:40 ` YunQiang Su
2023-08-15 6:13 ` Jan Beulich [this message]
2023-08-15 10:14 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da0dfe4c-f161-aa22-8ca7-83fabe001a70@suse.com \
--to=jbeulich@suse.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=macro@orcam.me.uk \
--cc=nickc@redhat.com \
--cc=paul.hua.gm@gmail.com \
--cc=wzssyqa@gmail.com \
--cc=yunqiang.su@cipunited.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).