From: Tsukasa OI <research_trasio@irq.a4lg.com>
To: Tsukasa OI <research_trasio@irq.a4lg.com>,
Pedro Alves <pedro@palves.net>,
Joel Brobecker <brobecker@adacore.com>,
Enze Li <lienze@sourceware.org>
Cc: gdb-patches@sourceware.org, binutils@sourceware.org
Subject: [PATCH 4/4] gdb: Suppress "unused" variable warning on Clang
Date: Thu, 15 Sep 2022 03:10:26 +0000 [thread overview]
Message-ID: <da28980e3beaa4ecfa4effc3d56981b4e224eb42.1663211419.git.research_trasio@irq.a4lg.com> (raw)
In-Reply-To: <cover.1663211419.git.research_trasio@irq.a4lg.com>
Clang generates a warning if there is a variable which is written but not
read thereafter. By the default configuration (with "-Werror"), it causes a
build failure (unless "--disable-werror" is specified).
Because the cause of this error is in the Bison-generated code
($(binutils)/gdb/cp-name-parser.y -> $(srcdir)/gdb/cp-name-parser.c),
this commit suppresses this warning ("-Wunused-but-set-variable") by placing
the DIAGNOSTIC_IGNORE_UNUSED_BUT_SET_VARIABLE macro at the end of user
prologue on cp-name-parser.y.
gdb/ChangeLog:
* cp-name-parser.y: Suppress -Wunused-but-set-variable warning on
the Bison-generated code.
---
gdb/cp-name-parser.y | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/gdb/cp-name-parser.y b/gdb/cp-name-parser.y
index 34c691ddabb..21ba51679d3 100644
--- a/gdb/cp-name-parser.y
+++ b/gdb/cp-name-parser.y
@@ -248,6 +248,10 @@ cpname_state::make_name (const char *name, int len)
static int yylex (YYSTYPE *, cpname_state *);
static void yyerror (cpname_state *, const char *);
+
+#include "diagnostics.h"
+DIAGNOSTIC_IGNORE_UNUSED_BUT_SET_VARIABLE
+
%}
%type <comp> exp exp1 type start start_opt oper colon_name
--
2.34.1
next prev parent reply other threads:[~2022-09-15 3:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 3:10 [PATCH 0/4] gdb: (includes PR28413), Suppress some general warnings if built with Clang Tsukasa OI
2022-09-15 3:10 ` [PATCH 1/4] include: Add macro to ignore -Wuser-defined-warnings Tsukasa OI
2022-09-20 16:36 ` Nick Clifton
2022-09-21 6:13 ` Tsukasa OI
2022-09-22 13:02 ` Enze Li
2022-09-15 3:10 ` [PATCH 2/4] include: Add macro to ignore -Wunused-but-set-variable Tsukasa OI
2022-09-15 3:10 ` [PATCH 3/4] gdb/unittests: PR28413, suppress warnings generated by Gnulib Tsukasa OI
2022-09-15 3:10 ` Tsukasa OI [this message]
2022-09-22 8:25 ` [PATCH v2 0/4] gdb: (includes PR28413), Suppress some general warnings if built with Clang Tsukasa OI
2022-09-22 8:25 ` [PATCH v2 1/4] include: Add macro to ignore -Wuser-defined-warnings Tsukasa OI
2022-09-22 11:26 ` Nick Clifton
2022-09-22 8:25 ` [PATCH v2 2/4] include: Add macro to ignore -Wunused-but-set-variable Tsukasa OI
2022-09-22 11:27 ` Nick Clifton
2022-09-22 8:25 ` [PATCH v2 3/4] gdb/unittests: PR28413, suppress warnings generated by Gnulib Tsukasa OI
2022-10-18 13:44 ` Enze Li
2022-09-22 8:25 ` [PATCH v2 4/4] gdb: Suppress "unused" variable warning on Clang Tsukasa OI
2022-10-12 17:36 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da28980e3beaa4ecfa4effc3d56981b4e224eb42.1663211419.git.research_trasio@irq.a4lg.com \
--to=research_trasio@irq.a4lg.com \
--cc=binutils@sourceware.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=lienze@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).