From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2078.outbound.protection.outlook.com [40.107.21.78]) by sourceware.org (Postfix) with ESMTPS id B68F03858D35 for ; Wed, 22 Nov 2023 08:53:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B68F03858D35 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B68F03858D35 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.21.78 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700643201; cv=pass; b=pyUyLmtb0ET66NSyGeFj7C4SU5agiCQxm6h2eoVttfT5oCGghz9QnzisWnl+iDb1YVK7ng7p8KXp4aEJUSH8Ca5YbpD0NG7yzeRnv1BSKogq1/eTXizueOLTMbpxGWeoTRwV9qLSatcaTzRyBhkeGFQj0D/wmA/5Z3Xc2Znl8zY= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700643201; c=relaxed/simple; bh=3i/t6Umdl0k6UjMk3T/x+gSyhUMbINH2ERYLc4Yd23c=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=naVs9mh9JuGpUA2kKU8JWodadqBbWktb+CL6DRXdGcQ0Kl+yVH5zF5tDQn8Pq9kBpSBUt4jdhII6ohDklM26Psgbqbhl8cPS83lVNA9DIzv2IcVuCbglqKcunCj0J2uv39j3SklzEzABFAT44R00WU49i6WVvV9q4D3xe5va6Z8= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YMveSW48WTsohQE+kY64Ktfy7BXJfFgEmXAvii3TQxXVEWSY/fiRw7i230xyAzcvReJb3y1BvQpRPVd7FvJElMQoZnpvfAi+pWFityJh8bOGz77pxNhZDX0Da8jsQFog/FWUgy17NxRhy8lgxrKWVMbtgc6z2z5JJh8oBdbP0N2F+f2RVr5PCXBqzkmiHlc4EDCHCVR1ZltcsxHVrN8JXzyHGNRDynLNmZrv/tbeZ2FpPsv/WDce20EL1XL34miKSIy2mSw86V3Icbgifpvynu2rzTu179LGH1tHlXZJP0pd0/6P+DfDXg6hA8T1ldOSNqpgeBieHX7AzUSat87Afg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2vRuOU/xI1EfXdgb0qCIV/aeeNnkNyZT1stg9fTIaWc=; b=I2+g2braghi3lFH393j2JrIHlNgqLLa3whHoYwTS3Vtfke4sElKQ95oQC9288h6AX0l9RYoAjgrwLeodc1QmnJ2VDZo3PE+daB/gPWoQ9N4KerSL2yQXix4De0ceZS30v7YrFWlANFMjw7WfIg8dalBwHt658PLuM6jWeFSXNVyglGDYaC2MC/yhoMd1OMfEmR+WB6hyyEy6XfoC3AGnuIna+zZLwY2+oNUEyHV+sEnngG919x2JhXamwp8kJEbtYorLXLSrB41EBjcYi46cWVSv6og9M9t0IFhegW0Y2taROd3GPJX/SqXQ2CR/O9EdOrwBm7n9ofluu1WEU4fUvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2vRuOU/xI1EfXdgb0qCIV/aeeNnkNyZT1stg9fTIaWc=; b=u2vVJslo+bdmy03947fPLllfwRUaTKrvsvzK9D/8NXDaiZsY9i5g0lYv301yMKTKEgUlU+qoXh7cpITbb5IG1GCWcBQMm9MhBncNEs/kVUqy6m4/f5eZe2y/tnOSL8F8RtZIWgI1zeEl/jnaC9qnghHeWK5asdPdl8+S1dXa9E8oBU0UcEx5bJZdm/UQUbBC4pEzs9gW93tcroIn/JZLbBCWIUPJQ5CLdKtCl9NYukTrFIyX/Ut3QbT65thRX9iP7dChCfiN6vQr8ifL3OiaC60tnrj2JG74mgVhHob39JMgrA/vZGJjBlmf5RfVm5fKrG+eTJPCjd9H76rCZo9rAg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DB9PR04MB8091.eurprd04.prod.outlook.com (2603:10a6:10:245::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.19; Wed, 22 Nov 2023 08:53:16 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44%3]) with mapi id 15.20.7025.019; Wed, 22 Nov 2023 08:53:16 +0000 Message-ID: Date: Wed, 22 Nov 2023 09:53:14 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/8] Support APX Push2/Pop2 Content-Language: en-US To: "Cui, Lili" Cc: "Lu, Hongjiu" , "ccoutant@gmail.com" , "binutils@sourceware.org" , "Mo, Zewei" References: <20231102112911.2372810-1-lili.cui@intel.com> <20231102112911.2372810-7-lili.cui@intel.com> <3b49b7df-c32b-e1a5-9a60-7c58853776db@suse.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0003.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::13) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DB9PR04MB8091:EE_ X-MS-Office365-Filtering-Correlation-Id: 4a853749-ff43-4983-359b-08dbeb3877c1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SUju3HKhf2J+qtp5sR8Uabip7YySs0xNoC+rmotDg4rn2P6PX0bTAAmlkNs8klP/xYsqT29SI61zkoqBSkOx3XVMRuQczjX2cC3GL9F4j6NUgp1qTpCXcDRfwLct+X1zDskIHkKTkaJJgjUjRS55XrrsrNS4vecmjhcBQ7Fi1pvx+7xQGeQrWJSdE6URNGM/2xYB6TCP3k7BxM5j1MOZbDhDPdBtW9Qa6mPb+8Fpe/5yFZRZ1tWW3rZiRQdy8huJDoMJgN0PTl1cRUymRIeSI05K2xXss8+xdW8cEqANcgGFXc4S2WhzEAtrP2Y3Z4jhh5ZO8NiS7G1yS/+AzQ5hSDIQVDPvRyKdagch4nfDGfTyos96Ky01LozzDasWbedKAl6itf7qGFHVi3xIqt+UYBEeO+M+yfqCj/0uO6ijX7vlljYH3p5fwo9QnnfwOAEjr1Dnb1vbhpoplfyOf3UpN3LRvrQzbzGOEbgBcL5pIsqECWp41LmfTgqVBjxgWvggrxEGe9nM444Ie3aUQ/ySUJrm4UoYFwLZXiv9Rjf/oEJUbDo8yyLKI71V3x0ZvItSsY7NoY0sreQJ1+TGDHjw4XSN3esgG4zq0awD9pSNTLPkIRGd9fXi2oVEmkYK5MM/JTiEBWbvCnEZG925twGCoA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(366004)(136003)(346002)(396003)(376002)(230922051799003)(186009)(64100799003)(1800799012)(451199024)(31686004)(2616005)(26005)(6512007)(36756003)(31696002)(86362001)(38100700002)(5660300002)(2906002)(478600001)(53546011)(6506007)(54906003)(6916009)(8676002)(4326008)(316002)(41300700001)(6486002)(8936002)(66476007)(66946007)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TDZhZ2tQeE90cWNMM0NGMkF0QWhJUTJkWG5HanRNRlVMWW9mdlk0Qlg0Tita?= =?utf-8?B?WHRWYUZ5SjhMRXAyNk5QREpNb3U3YkVtdkhUZXJkUkQxVnVpRlRUbkZ2clRH?= =?utf-8?B?dUVpaVQwNjFFOUJCVTNMc1F4RWFWZEliZkpNYlJoSjVFaVEyaWN6SGYwKzl5?= =?utf-8?B?eUw4L2YybVE4SjRuMC8vZEtUb1IrUXlheHNibzdNeU5ocjk5YktwRVc5SVhQ?= =?utf-8?B?aEEzRVkrMjhFOHVabVpldDJySmU2QjdpMFBRSmVGT3JNajgxWFZtRHVJc2VL?= =?utf-8?B?OURHcTg0enp5RHFQV1cvK25CczJpMzdkRzJwVXpSdDVnWTAvb0xVWWdvYnFI?= =?utf-8?B?VGd0ZXVPc2hXZEhJbHNjSGZyYmIySFVSOTVHblIvQXhRZVlBQnRRQXRXSFI2?= =?utf-8?B?NURHTFp6VEplY21zSmZQSWdqbmFFaUs5UEkwMExYK0pMeUVDNmUzNEdHY0Rm?= =?utf-8?B?MXI0SjNHR0FROU5Ed0kzdXM4ZmhmK3JEUkphNFJEV2lGU3dKUDVSUExSRWtY?= =?utf-8?B?TTk0UnhuZDhQazdNdk9JbnNHQVVNSDFHRXF1VWxFQlVsb2syQTZ6akdyR3RB?= =?utf-8?B?V2lkMk9pYTFzcUo1dExER1gzeU4zdWMyOVdZQnJFTVBPcW1RUnVudEdHWXVI?= =?utf-8?B?SVNtU0JmeFJzdGh1TlVvR2JHYjJpcWtxM045MVFqQU5ZL2JKci9NVSsyMmx1?= =?utf-8?B?ZWpBaWNvK0NINzFpSEwyV3JhdXFjbXYzSkx5OXFwcGFuaWZMaG9icFo2NlBz?= =?utf-8?B?eWhYMVBDNno2KzZjQjk4NGN0QlVSQW8zblRVNEthWE1vRW9LanJ2RGRuNzBh?= =?utf-8?B?eGVwNi8yd0hqOEhsM2ZhWHZ6Z00wNXZyc0hOOEFkSEk1Y0Q2U0VOTiswaFhB?= =?utf-8?B?SHFmdk80NS9jSCtucTViQXhrclVBanppOHZOVjVsMzgrUjU2SnB6TGhmTHN5?= =?utf-8?B?Um5yWFE4cGR3dmhRNThKZ1hWV2NuRVpyR1NKck5qQzhhaDBlVC8xZ09oWUVx?= =?utf-8?B?SDc3Zy9KaXpNRGx2UlB3dEN0OFd3MzhTWG9uVmFBc1FPWGExd1Z3YTVOYmRt?= =?utf-8?B?VTVudDkxSGNUVWNMY0xPVWFla1pXNy9XSUNueGRxaWxicm1kVGpQTXpGeTY4?= =?utf-8?B?TTc2L1FWTmtqbU5KWmxMMldHV3ZLVVNoZEsySVNGbTZ2TkkwUG5ENUhuOC90?= =?utf-8?B?MVRFVm4zYnRvSWpWREwxYXVQSTlzb0M1MllSNjIrTUFzQXJvNFphb2dmTVN2?= =?utf-8?B?aG5uV0s3YkZpOEJ2bHB1bTdGeDJmUVVBR0I4RW51YjJ3aEtNNHVPSXNNbGN2?= =?utf-8?B?VVNOOUc3ckMvMjVldkZoNlZLcCtlQlZPY3FsNzE0NXpLajdoaEJOWEhkUTJn?= =?utf-8?B?UW5uVkVVVzhGck1OSmhCblI4SHpWeSt1LzcxQmt4RDd6cXhtREE5Q09Tdm1V?= =?utf-8?B?NXljaWxHaWpRejMxWldKOUdQb2YxemdQR2g3ek1TdyswTXB5WTdpZGtKRC9u?= =?utf-8?B?djQ0TFBxNnl5a091ZnFsMFpsMHRXa3ArNEJqWWFZbFk5UkFNQW9rQ2xJV1dk?= =?utf-8?B?WldCM3ZCcGRYQndPRVhLTEt3eVpXQThQU3lsck5lZXVUcUpMTWlUeXc3REtr?= =?utf-8?B?Rys0RlkyazUzVkUyVS9wWXhKdmpJMlFoVEk1Q083WGtKeUR4K1gydU5HdHdq?= =?utf-8?B?cmNlOXJ5Z0lwdVlNV0d2a0wwY2wxUi9IRzVmVy9Qd2k2SDFwUzFPcTc0dVZD?= =?utf-8?B?eXBWS1JsU0lLeWZmSnN5YWFjR0c1elFkdGVtUjkxZWpFS1ZQYzNHTTBZQ25a?= =?utf-8?B?YXZab1RsaHVoQ2p5VzhhQUZseUZrY0lyUzZZbmR2SmFydUZSazdZZGNCcUYr?= =?utf-8?B?MlNabHIwZUk2S0ozOWtSZEp4eHVzV3RyVnFNSnJwSmhaT1drV2g4UTEwZnlP?= =?utf-8?B?a04renRMUzdoR2x2RHVzaVhJT2t5Q3NKTVRwQ0xOYmI2OUZybU51VXRxbmdq?= =?utf-8?B?TmhaUitoNGhxT20rQVRGRVVZMHVGODFiekJmOVJvM2w1QUs5VHl3T0l4L1hF?= =?utf-8?B?MktBcmZGTnVBOGhXQ28vYzB2QWl4b0k1b2k0U0JadXpjc082aUlnVkpSRWhY?= =?utf-8?Q?0BaBabUwKIJJrKb9GmgJ5J+KF?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a853749-ff43-4983-359b-08dbeb3877c1 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2023 08:53:16.4048 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DOLwQqHsKNO+GXgHH7W30311pGGC5VHF8jH6bRQUYvRigoa8RltBOzSQ6/WTkECA9nalUHFNmQnwpEHrpmWcDA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8091 X-Spam-Status: No, score=-3026.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 22.11.2023 06:48, Cui, Lili wrote: >> On 02.11.2023 12:29, Cui, Lili wrote: >>> @@ -6854,6 +6858,24 @@ check_VecOperands (const insn_template *t) >>> } >>> } >>> >>> + /* Push2/Pop2 cannot use RSP and Pop2 cannot pop two same >>> + registers. */ if (t->opcode_modifier.push2pop2) >> >> I question this way of recognizing these two insns: You introduce a whole new >> table column here just to have two entries set this bit. >> This is cheaper by comparing the mnemonic offsets, as we do elsewhere in >> various cases. >> > > Done. > >> I also disagree with putting the check in check_VecOperands(): >> There's nothing vector-ish here. Either you put it straight in the caller, or you >> introduce a new check_APX_operands(). >> > > How about putting check_EgprOperands into check_APX_operands ? > > /* Check if EGRPS operands(r16-r31) are valid. */ > if (check_EgprOperands (t)) > { > specific_error = progress (i.error); > continue; > } > > /* Check if APX operands are valid. */ > if (check_APX_operands (t)) > { > specific_error = progress (i.error); > continue; > } Hmm, question and suggested code don't fit together. The suggested code certainly fits what I was suggesting earlier. >>> --- a/gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s >>> +++ b/gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s >>> @@ -30,3 +30,9 @@ _start: >>> .byte 0xff >>> #{evex} inc %rax EVEX.vvvv' > 0 (illegal value). >>> .byte 0x62, 0xf4, 0xec, 0x08, 0xff, 0xc0 >>> + .byte 0xff, 0xff >>> + # pop2 %rax, %rbx set EVEX.ND=0. >>> + .byte 0x62,0xf4,0x64,0x08,0x8f,0xc0 >>> + .byte 0xff, 0xff, 0xff >>> + # pop2 %rax, %rsp set EVEX.VVVV=0xf. >>> + .byte 0x62,0xf4,0x7c,0x18,0x8f,0xc0 >> >> This 2nd comment looks bogus. What is it that's being tested here? >> > > I think it should be # pop2 %rax set EVEX.vvvv' = 1111. It wants to test that pop2 has only one operand when decoding. But POP2 has two operands, one encoded in EVEX.vvvv. The use of %rsp as an operand is what I would think is being tested here, but then I don't see why the comment mentions EVEX.vvvv. Jan