From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2071.outbound.protection.outlook.com [40.107.21.71]) by sourceware.org (Postfix) with ESMTPS id 8AC9A3858C66 for ; Fri, 28 Oct 2022 06:53:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8AC9A3858C66 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kEoZf5aWADrGvFDJFVjHQZZwCBh2R7/FifY3fnPkQ22KN58qsQwuYBzHkWrvzYg9wlySWkTgjJ2ZIrLce03VZMjiCCivH8OVSHBa29o3K5ijiTLnI129uV7S9ByAr2+Jd1ugtQlkaDzZWOp26XUD8Nky0G5GiKSsxGy9trT3ajJ0MgCFzkSFMDThFxA0lxIp6yH8n78tn3IFf5iVHvLtSrz7Z8PJRtTsgBHP0Hvz/NueghdECYvqeYSN015LATzHbsa+IIALONAmLjDyK5a8vikajZRq7yJE68tlNG9TDRyKUlI6ZbHErLmLt/XyUUBcssqYzjXtQARYK54Kz3OivA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x9LnPqnFEO8AjUuYJYHPsyHIZ821Z7saeWNs6DM3g68=; b=Rvx4UsSfpuEyhC3dBpcdiYNF8nDGOi+C7k78XpilRvHXesov80q1znmYscsctcEiA4ylLz3UOsmXwNkdC3+jkIHaYpaL1y2cPL/0Iem42QnMXTeqwsdCn48juSyN3afV3vNF5oX3JqowChQjpPuF15LyL19tiaBRaGaKDgXA4/8zah4poQDJLFMks8ELztD114UlHJcs6XMEf1k8ZI9y5O5ll4+XnOgLAuGPS9mYKX65R9FWG820+JpmXKt3Ai2wLaJGvyeejOgWOncwtKU5rELf0RuVzOpbeHKWKi+U7IRJTifi4TAkkq+GzGIqGN1mYi+dC9NIgLl4L5Nn+GM93g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x9LnPqnFEO8AjUuYJYHPsyHIZ821Z7saeWNs6DM3g68=; b=Tc2PDswewj2vBrNQ2cjPIssl8qk9ivQ+YOm+I2qk+ng7D7hscbMkp9jeN1rEsVfpmLJuQbieDLdk0oizEbCNxp2JFyAdPwqUQ3tjjdBCdsG8sympV3m6+yD08cVI/34IO5ok3VDWBMCRomVLd7HQbBZtAdhQWmfww9/vLwKaawXJm+SJpFEpa3di+Q6a8DrozqhoC/YeNjb6FVgkt1WvVijgibFZIoF0JCz7yTVGbqYKxVe6Vzj6wGXSQHADZ02ttvJl4oIEFGaqAkcZUlB5arb6Ysc3bwMpq2UXS4v33LEZ3NSuh6dE6THgmy0H9IScp3twpZjS1b/vdrpUw5WFvg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7960.eurprd04.prod.outlook.com (2603:10a6:20b:2a8::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Fri, 28 Oct 2022 06:52:54 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Fri, 28 Oct 2022 06:52:54 +0000 Message-ID: Date: Fri, 28 Oct 2022 08:52:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 06/10] Support Intel RAO-INT Content-Language: en-US To: "H.J. Lu" Cc: "Jiang, Haochen" , "binutils@sourceware.org" , "Kong, Lingling" References: <20221014091248.4920-1-haochen.jiang@intel.com> <20221014091248.4920-7-haochen.jiang@intel.com> <1e6a7d9c-4b14-821e-cc46-453adbe6f183@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0136.eurprd06.prod.outlook.com (2603:10a6:20b:467::28) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7960:EE_ X-MS-Office365-Filtering-Correlation-Id: 3154eb4b-0342-4d81-b444-08dab8b109b8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QT7dwTFjbxBW6ulxwvYSNSE/hHzVtyIyu99uwgOGCshEm58N1MaXlYu/m2A/LDdYzH7fbmVddBixfVxixJp/+KTfUXn6fEp/kiIMp4aHlS+YSYAJvmXF5Y58quxPByi4njyrL+V0bzCXnG/G9Tm6/K/IQxJhFEdd3gv/ps7jznXpxo71fFfhE67vtxJ6rgpDuE9jqiU2+1PFAVi6logcjF8BHCJHlya7SKlSCKOXA+5vbe4+b0xzSIJSanh1+4jPWa24UXuCQ2TxYyY+W3IENKtyiak7k65wR5Fg019sLjrwD1BJMilSgKLgNEUVBSRhXbO3bfretJNxSvJ0mjEL2iBZZIBFur1LwKH8drTYUgGLDb2+bdmTbvwkI3Lwnh6oKl3SjMHUDUSlpHlIXqp9G9cczqZ+OdhMdfha7Nfd0JXvGWrdVB5Idqxp3YvGfuct2v07RKg05B362nCeIyrSMUw60rDsm2YWQe05H8anS5s0gCiVCMmnf4wCju8MOBW4U8NZCKGv48q58Sat9J6/DLocft2lTzcRLvXwSQG4eng3GmmRO7pIjJ+d4t0ZbfdYTsegQB+P4JsTs1ij5F0Bs3/3KNFpa/1ic6Nl20jEVXZBC/L2uNlqzAaDGQ0sDyt/PWCaJB0SYNcDZbojl27rsoV217fwqDFlPRKsV40QOXkeqjXvu8eh/BOMuiPmK1bZCMkllxqPFvWXqbulnKeF9CABXBti5iqLgJ/8ay/e8w3A58EAaUrQoOZQNagM9hJIVVSfBqKDI2R98ptmSGCrYEl+cDYxKkOlRj37P98e7kU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(396003)(346002)(136003)(39860400002)(376002)(451199015)(86362001)(66899015)(31696002)(36756003)(31686004)(38100700002)(2906002)(186003)(6506007)(478600001)(26005)(6512007)(2616005)(53546011)(83380400001)(6486002)(66556008)(54906003)(6916009)(316002)(8676002)(4326008)(66946007)(5660300002)(66476007)(41300700001)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bWpBTDY1WUdVaVB4cUJDNHBLVzZSUWRodjRqWThxOUNxY2ZwWlRmODkzYUpN?= =?utf-8?B?ZkxDWU00TXFNQno0cU9RZVRFcW1mbzRsTGVEL2IrL2FHakVIMWhPRGtDNk81?= =?utf-8?B?Zi9TVWRDU0RpbncvTFBURkt2Tm5IWE0vYlNHMTZIbngyVDZEN0syZVpjbEtu?= =?utf-8?B?emVnSlRxRzBHQWR3bWhNY2lleStOZnVYV0tmeVgrK2dFd0Z3bitzSzhHWGxJ?= =?utf-8?B?YUJkWHlQTUdPa3A5VGNJbkt3WEsxS3kxVjFrMVFKMkY4N3VoRi91blBaWkZv?= =?utf-8?B?ZVp4MVNWVGVUTGlDU0dpTVdvcThDTlRMbUFjMFJZTThaaURTOUtCUW1Xa0lu?= =?utf-8?B?WmtmZ1dxSnlHaTJkN25IS0pnc2tiU25ZSkcvTWN1MjUrbVJUWFFzQWRtWDFH?= =?utf-8?B?WVdlWHc4RkxKVkp0blQyUG9vRHY1WTlINC9PM3VUNjJNTTFhM2FUV3c4cmNS?= =?utf-8?B?bXg4d2lIRStBSnNtQWVRaE1UNjR3MitCMFFIVDEwajBsWGYrTzBkejFycVVa?= =?utf-8?B?L3lTWnkrUmRVWHlsMzZVMEs5UE9HbHkxRTV5bjFSK0x6VU1nQS8zZXZ5bUNC?= =?utf-8?B?ZTZXbnpxRHRHL2Y5N2ZOL25EZFRkK1BpR3lXQXcybEpKbjZVQ2FwQjRwOUgv?= =?utf-8?B?TmRERnlZMEZ1RzdwYU1pZ1JtTG4vbGU1UnZ3cHdxMlFxU21VWjZ6Nk9sQk1n?= =?utf-8?B?a1RIVC9IcDk2elN4ajdOWTFjaCtrcjZ0eGRmZFNNcGlEbU1HcEwyaW5ld29a?= =?utf-8?B?OFU0ZmZHMVR6OFZZbEEyNUo5emg5UTZSajUvdUw5cjAxVmZXNlFSSUNlcWJZ?= =?utf-8?B?b3ZtdVZ6ZXZoVnJLNi9pL1FlV1BYNVd2ZXZpWlRub2ZQR2NJQTRFZ3NiNFBF?= =?utf-8?B?MDNCY3U0RzNaVlpXcCs3M1ZqcGZqa3pTWVNDalZITGFKWkgrYkY5eHFtd3ov?= =?utf-8?B?SnNtMTVTNVJ4bnRnUk41Y3pFYkFqK1o5czRGcjY4a0hYSVpLRHFwRDNPTlov?= =?utf-8?B?OEtpU2lqcTVSYzBUQ2JuckZOaWNJNmxuM3hrbGhqdmhtSDZDTG9XNUgrVW8w?= =?utf-8?B?QzFpVlhReDRMdGsvYzFtY3RieFBjbnIxN2ZkVnNqb2VNTXRSYWtmd1dtSGZ0?= =?utf-8?B?NUxVOGVDMktybThyb2F1KzNoR0VaKzArUytNS2FITlQwNkdFTmcrbXBKN3Vq?= =?utf-8?B?Z2VYNjNMcGdVNHlwNG9nZ1ppV3RpTFFJVEwwTC9weGFHQWE5bW94cjJCNkh0?= =?utf-8?B?OVVkaGVQWTdoRzJsNjk3QzF6WVVJdzVHeDZ3YlRJWXVFblVZNDUzeXlIS0tS?= =?utf-8?B?ckJKbzlVMWhyTjZ3ZjQyVXRrSmhWTFYzd3pwR1ZWYlc5S3BaenpVSlZ5Z0ZX?= =?utf-8?B?QkNvSGxNQmI2aHZCckNhallidVNscUlNZTkwOURIQmxoMHozQ1prSlVSa0dT?= =?utf-8?B?RVorYlI4OGprNWpuWVN6akNHbmJKa0tGNFBtTUtidFdPbVcwQ0RVQjh0T0Na?= =?utf-8?B?aXpUYTVUSkZOZXJocGNHdmFzdFFITytYdnBNNlF5RklJaUZvZjhLeU5xR0tD?= =?utf-8?B?dmRUdmJ6V05ENEc0OWdtTHBsWDFQMmIzYzZ0TUw1QkF3bVo1Z2M5Q0ZIRUFl?= =?utf-8?B?czBEUWpURmpYMGZKdVo3cEc4SEI5WlFvOWZaeXZhcVRJcUhaNmVjeUtNaHUz?= =?utf-8?B?Y0ZCUWpiZ2g3U2RZZ0FpR3V3T2FZVlVqSlkwNlFKL29scGd0WmVrSmFpaDM3?= =?utf-8?B?MjFhUEhkd1hyaEFMR012bG1wNkRCdFI1dDBiYnNHL1hMQzNoMFdFWE9qU3lW?= =?utf-8?B?ZGc4RVdJL1hTQ3BRN1BuSVJzQzN6TXhoN1FYVGhIRmoyK09DMUVBS3RhQ2tO?= =?utf-8?B?c0ZSeXN6Mm42MEVQMzc4SkRyYkh1Qk9iZU51dmxweTZ0dkdnMXFKeUVmVzJa?= =?utf-8?B?cy9sZCtLMko1aU9wUFVKcEJJZjZkOWhmaFdIbW9lbTN0SWZFQ20zUzJqU0Nn?= =?utf-8?B?ZzRCNDg1OEhXREoxUWpXNHhSM3pnWFQvcitXMDJHelZxY09jVUNnUmh4TkR3?= =?utf-8?B?MGU2MkQ0SG9XVXZQT2lRcnl0MTZGS1NhQTB4Yy8rOGNabnc4MDE5YjNwc1BT?= =?utf-8?Q?v7eCWpWlQVIsn8QhkRKWQn+p7?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3154eb4b-0342-4d81-b444-08dab8b109b8 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 06:52:53.9887 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 86Up2CE6ZkySacpEMmDMKlNdU0LOY1mzPnDlCxVA0XRrpxtAV3uVX8IM/PEqxJQLCOA2TUr1JsHWYgm+m8BNTQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7960 X-Spam-Status: No, score=-3029.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 27.10.2022 20:46, H.J. Lu wrote: > On Wed, Oct 26, 2022 at 11:39 PM Jan Beulich wrote: >> >> On 27.10.2022 05:50, Jiang, Haochen wrote: >>>> -----Original Message----- >>>> From: Jan Beulich >>>> Sent: Wednesday, October 26, 2022 4:57 PM >>>> To: Jiang, Haochen >>>> Cc: hjl.tools@gmail.com; binutils@sourceware.org; Kong, Lingling >>>> >>>> Subject: Re: [PATCH 06/10] Support Intel RAO-INT >>>> >>>> On 26.10.2022 07:16, Jiang, Haochen wrote: >>>>>> -----Original Message----- >>>>>> From: Jan Beulich >>>>>> Sent: Tuesday, October 25, 2022 3:01 PM >>>>>> >>>>>> On 24.10.2022 07:56, Jiang, Haochen wrote: >>>>>>>> -----Original Message----- >>>>>>>> From: Jan Beulich >>>>>>>> Sent: Friday, October 14, 2022 10:38 PM >>>>>>>> >>>>>>>> On 14.10.2022 11:12, Haochen Jiang wrote: >>>>>>>>> +aadd, 0xf38fc, None, CpuRAOINT, >>>>>>>>> >>>>>> >>>> +Modrm|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|No_ldSuf,{ Reg32|Reg64, >>>>>>>>> +Dword|Qword|Unspecified|BaseIndex} >>>>>>>>> +aand, 0x660f38fc, None, CpuRAOINT, >>>>>>>>> >>>>>> >>>> +Modrm|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|No_ldSuf,{ Reg32|Reg64, >>>>>>>>> +Dword|Qword|Unspecified|BaseIndex} >>>>>>>>> +aor, 0xf20f38fc, None, CpuRAOINT, >>>>>>>>> >>>>>> >>>> +Modrm|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|No_ldSuf,{ Reg32|Reg64, >>>>>>>>> +Dword|Qword|Unspecified|BaseIndex} >>>>>>>>> +axor, 0xf30f38fc, None, CpuRAOINT, >>>>>>>>> >>>>>> >>>> +Modrm|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|No_ldSuf,{ Reg32|Reg64, >>>>>>>>> +Dword|Qword|Unspecified|BaseIndex} >>>>>>>> >>>>>>>> Why IgnoreSize? Instead I think you need CheckRegSize (assuming it >>>> does >>>>>>>> enough for Intel syntax memory operands - please double check; if not >>>>>> this will >>>>>>>> need fixing). >>>>>>>> >>>>>>> >>>>>>> For table, we aligned with CMPccXADD and added No_lSuf and No_qSuf >>>>>> since >>>>>>> the suffixes are not required. >>>>>> >>>>>> Which, as said, I consider wrong both here and there. >>>>> >>>>> I still agree with H.J.. Also I suppose the previous usage of suffixes are quite >>>>> messy and we should not stick on the confusing code. >>>>> >>>>> Keeping consistent with SPEC from now on to avoid confusion on that >>>> might >>>>> be a better solution for future. >>>> >>>> Same question to you then: Which spec? As said in reply to H.J., the only >>>> spec I'm aware of suggests prefixes ought to be used _whenever_ there's a >>>> sized memory operand [1]. If we want to deal with the present "mess", I >>>> think we ought to simply allow suffixes consistently. Please point out any >>>> other messy aspects beyond that. >>> >>> The default behavior for current ISA is when there is no suffix required, it won't >>> mention that. >> >> What is "current ISA" here? Looking over the whole set of insns which we >> support, it's the vast majority which behaves differently from what you >> say. It's been several times that I mentioned that we would better >> eliminate this inconsistency. >> > > There is no ambiguity in the RAO-INT spec which requires a suffix. > No suffix in A&T syntax is different from legacy instructions. But > it is consistent with the RAO-INT spec. The RAO-INT spec doesn't even know of AT&T syntax, so can't be taken as a reference when deciding what the behavior there should be. Jan