From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 32BA33858D39 for ; Thu, 18 Apr 2024 07:40:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 32BA33858D39 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 32BA33858D39 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713426011; cv=pass; b=lYIGs/9NWTsamIhP5FmzslIt7ltEfahsvQX/nbRlWWu7g8+tIqfu9/IhUBd2gdTn2rPbcs0dQyW4kSRVlIn1sy+rMUxULrpJj2K7REWeeYgAgSRyefe4eg/g9BQP5NfB+UZNhKrR2oMumqTZ5to3L5AWKcbQRI6SEY4e4nkkHR4= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713426011; c=relaxed/simple; bh=waoNykWhclKH4BEWlqd5cQXa3vArDh/wBog+xuYiNY4=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=A7DFmUpPu1RLOpe6zWHvRtgf2fNngi+rVdLE4Qc5e8/x87VjDwBGZRmn4s9ZUMIU9Sehv+K3Z98H02UxSXo9IKdcvxI3DW4aqrilXi5WvPO0Xgh0EZqyHWHl/v2LvJc8fNHYJoOFOi2k76TYpRsjYTzS0K1qxMcC6dOgnaLAZ9I= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43I3wl1E010035; Thu, 18 Apr 2024 07:40:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=ZLIobJmy1dqClie3KUYEs7rhdII4eP6WJza8r84F/FQ=; b=PveV7wj3FJuBkNIlcQEKzK5P33kTSiujeh9zOArQlUfTBmEte5jzz6fi35V6pozXxnW5 bjnISsBdCcfJepoxUuvopSX8IcFRmfJX3MsZLSpD43eKoO+mzNxHagZx2MMG0P9Xq2/M D4bzJVUlMyGI6YUaAr8kvRjtnDMA+n8f6elZ7Xu/rBWEJBhSEwqpL+SYZ91Vfbj2/tsw HksBQ6GL9mtv1FdO9hU8qJYjv4EPROfLE0qegAybkwzBzuZOw8J9NPQoOm2iILKdO7/k APx7uVrLR7X51aLzrthq1N5wmTrihOLfBe7wAyjIZlQ13zbsqtbS05KPG2tLsSQ/fnAN lQ== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3xfj3e9v8e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Apr 2024 07:40:06 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 43I7Y5sd012602; Thu, 18 Apr 2024 07:40:05 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2173.outbound.protection.outlook.com [104.47.58.173]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3xgkwj3y7p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Apr 2024 07:40:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AufTGybAasAgk2a5F/GZ73UHU++VuEAWbFTT2jC9+XQ1EniRv+TjEsObgR57KzL0wZ/NyVDupnXbG23XtiUDXtKK6mLdL717Cq4qeTrnOfUChW474FuuxgVAgwIX8H0dv4IPIPD2fgnjYtI6Oq+uFv5nHVUBPewbmfKr/j7oCa3nlJ7VS6QbZr2fa4sd1NXjMiNBL6KYJRmo5o9/cdBSQodfcEY0oV56s1TLUfVShtunMRx4WBYS3ma3k8F1XkwyNNcXeAiRnQ3TrdQzz1omkByPrQyWtf2W7sDSqTPjspD68jMi3WMuzCHAASwgdfYn599+REiIfSXUE5bJ1Ic8pA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZLIobJmy1dqClie3KUYEs7rhdII4eP6WJza8r84F/FQ=; b=gDHeAFl0SjgNn9V8GgjMyw4wHEv6vxJ/vwPXNreJ0XIqTCX8sYMR2z+m+VcXRiqXH0385x7iiQKipxBDm4Sss13h5+1V9SRzX01gQSRj6DF/HtUlhv3tcu28nikL0dF2iMA4ak3Y3/JC6NN/Jb7WMb95C9LX/awdTw+p2wGGIz0/vygV4UZPF3d/5bDHpoC+1e1bMIzxwxqNOu3p2IVdRbTP9x6Vs4aHv+2WyPZq7T0087KbHx4Y1f8OFq8aWKxSoyhhUcz+OmqVinzwwjTblXyG+DbN3r+r6rs3QTLNIQDLvRTYDloYp8B3Q5g3nmLUW06lauhVnUu/ed0EzE9uGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZLIobJmy1dqClie3KUYEs7rhdII4eP6WJza8r84F/FQ=; b=i9nz/yvjeyIeANlF/OfroDz+Smjy9lp9eZTHUa+cu98ab7ResWpIuPWUNqz1hpvRs5PNftZ5rGxpcvYNISDnHC0oSVFgeTWhduEJCU+EDuuOI820wyMyJW4+mN3225TM64oa9t7ZeYu6A+/XwkIv8mQ1JFXBP9Uw91F0buKbS6s= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by BY5PR10MB4273.namprd10.prod.outlook.com (2603:10b6:a03:205::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.49; Thu, 18 Apr 2024 07:40:02 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::6f0e:742a:270:889]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::6f0e:742a:270:889%5]) with mapi id 15.20.7452.049; Thu, 18 Apr 2024 07:40:02 +0000 Message-ID: Date: Thu, 18 Apr 2024 00:40:02 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 04/15] readelf/objdump: Display SFrame fixed RA offset as 'f' in dump Content-Language: en-US To: Jens Remus , binutils@sourceware.org Cc: Andreas Krebbel References: <20240412144718.4191286-1-jremus@linux.ibm.com> <20240412144718.4191286-5-jremus@linux.ibm.com> From: Indu Bhagat In-Reply-To: <20240412144718.4191286-5-jremus@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4P220CA0004.NAMP220.PROD.OUTLOOK.COM (2603:10b6:303:115::9) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|BY5PR10MB4273:EE_ X-MS-Office365-Filtering-Correlation-Id: acca861a-b07a-4477-d2ea-08dc5f7ac225 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vovGX6oF3Zcedy5u41xTbA+nXVoTcYDjNqb6LEk++r1p5ZUVRyvka2IJ33Y5XIlLe61S7yuDT1tcCCXGmET4Ihs4y46r2tucleXb4HU352rREbRGOcQNY4wTuvTRwgXr08Rxsks58R1r+BD2QOZSV7H7wqcVlf9IcHB2wJiJ5Okbl4oUFHUPjC8dByMt2mtD6I2CO0T+NPmskXO/2bq9fToK4PPE6ptUVIlu8P18Z1L0CaabWz73WTUjSBWY8/+GgUnPBglDF/xz5YVD1I3FEWfSt8Ijg5ObIZbr4TbGjJL/QEmzX04URni3+HQcJHhGrFuPynF/Pdv4AYGN6rD2feJrYtapMQV6TOhChkQ6VhdEn/HD/q3/7tXLUPEPEvnzQ6p1VOdKs1GEQWd0lmbBDvshIk0NHP9MyjbBMklRSYrq4UB2wA/E7bWYKX3qt62wLECUeAen/JDWwFE2S7aywgZCDf5E6zyjBZZS6kimVAJ0y6R6nCQMT67Bk9lA00oc4dX44bwvGyMmJVcr3LmdS+HL8+SSEo8s61yAHJoJklyXOKHV4MyhlAWnZoD1EV0vNnd7C41r24SddcEPdkRXm45cYCdAYyHNArpNBkhUFMXYjaPLOEXVmWN5R64rul1t0aYmzSBzqmR+4s7atMYJp0XeU5PYltLcksz0QcT/Gj0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(1800799015)(376005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?THVkc3RqK0JWTlRYL09DZm80R3lWRzZ0UER2TzdTZGVXN1R0ZjZITEVyTnJK?= =?utf-8?B?M0ptTjBjK3QxbDl5S0IySzczZlp6SXBhcnNHY3I0TmtPTWF1czExMlhWZUdJ?= =?utf-8?B?Mkw4SmM1VWNPZzZJZU9PZStENmpiQUlZY0VqdjhXbWh5SVh0TmxWcWJJdlhz?= =?utf-8?B?S3hkTW1NRTFudXNPTmRqZGtSM1JMeGhOaTdxdmY5d1orc29UcUZWMHhacGhY?= =?utf-8?B?a3ZlTjVqenZlemRUQTlvL0pCRGdtSHkzWHE2UVNqRnpEVVN2dzlaMnNPTE5S?= =?utf-8?B?VjRBQTVGU2xPZkM4elpyNXlrWW1IZXY1VytTNmxMcEFGNU5GTHNuV3hEQ3Vr?= =?utf-8?B?a0VjdW1iZXhsTmcyWHByYTFxOUtUQW9OQWlyYzlQTWxLU1krem14azAwdmZj?= =?utf-8?B?OFo5QVdYK1luVWVLMU00cmdqZmlRd0pxdkZTZis3SVVtNjNyaytQaUZRVlVr?= =?utf-8?B?K1Q4Q3p1OXRnc1dyRElkVFhoNlRKd1l0TEhDS0IveWhhVEMyWnltSFFybXls?= =?utf-8?B?TnREcHFLdzBEUjJ0QWp3UVBhNE4zU0YwR0YyWVRCUjBqTkJ3RHJUL3pzdkFw?= =?utf-8?B?K3RHL3g1b1Ezdk95ZkFpd240cVcwTUs2TTExQkhmNkFYbjdleEkxY3BJWjZa?= =?utf-8?B?VVBpeitoTWtCS3ZaemhDNFRJKzRNV3lnTmFxSXVwMnBVWVhKc3MxZWhHNkNr?= =?utf-8?B?WkYvZ3lKMVJqaDN2VmZWWm4wS0FGOFhrcUVOWm45WUtXRzV0d3dvNnRxcWZ2?= =?utf-8?B?OTBBVjV0ZUd5eldSRm52cHBGMll2L29hdzdQMWxjQ01vb1JmYjlyTk5TU2o2?= =?utf-8?B?SGJmMzVLRkZLS29mYzRVM014WTIyVXlkRklWUnQ0d3RiTnhrOURVR3JCU2ow?= =?utf-8?B?QXlRV0NodUVuTXNGbDVxQlpUNXpjS1kvUHRQWm8zdUpWaXIyYTV5S3pHT2NW?= =?utf-8?B?V1lwaWIvK0g1UXBYOVRJMm94ZXhPSUMyWGpCcnF6d3pUMC9CdExVVUsyYit2?= =?utf-8?B?UVNlZ1RtMWtMaXJFMmd1eTRsUWR4ODgrK1Z1YjFObFlqK281WVQ4RzJSRDAw?= =?utf-8?B?ZktjTHVBNUZqcEliKzFKOXE3cHdpTGc0Z1NLVmt3dWRFYmFvWHk0dFBlSWUy?= =?utf-8?B?WWtNMXFoSjJPWWtycW9OUjF4N0tkL0Evdks3UTNhaUNBM2I5eTZHYkNndytp?= =?utf-8?B?UVA5aWRVZmJtVkNDVHBnSEtIamhHd01mVitZTEF6eHpVSHhDd1BkeTRHSTAw?= =?utf-8?B?d1RpZmJnbDhSMWFDVmFOY3Q2Tk0yKzRvL1dQcWM5WlR6Unhua0MveVFtTFdz?= =?utf-8?B?SWUxSnd2WWFLTnYreCtoMTFsVXRpdnBZVFk5TDdNS3pycUttMUNSL0JreTRk?= =?utf-8?B?aWlocTV5M0hJZ3hCSmpUSVJrWnhvd0FRZHBUSDlEbFg1MVFsb3o5NlIwTnlp?= =?utf-8?B?c2NNWHB6WUFOeXV6WDQ0SThvcldlQkZnWmtHc0w4TzdKdnoxTTgvYzdxSVhI?= =?utf-8?B?MzJ2TFBNY3d0Q05jeHd6SFVPWDNqdi9SOVNJUSsrTG5RaUtVczk3aFJCam1v?= =?utf-8?B?b2ZBelJ3KzBGVU4zVkFMa3cvbGNaOWdkUWtpSXUrS29NeFBkcGl2Y2NidndT?= =?utf-8?B?MVdtVFRPOHRnRkcvdks4N1MyK2YvRkVORjdSbkZvQTIyNlhTZTJJMHhKY1Vr?= =?utf-8?B?YWkyaStJQkZTeU9idXdCb2ZVbWVLUm96dVlNb2tpWjNQRjR4UzJ5OXprSGIw?= =?utf-8?B?T2Y2V0lMemJsd2lCd3FFRk9nc2hiNFQvYThaa3FuSFVEV2FnWDEzWFExYkpL?= =?utf-8?B?YVl3NHk5K1l2SlpFVk9hdXl3UWg1L014SldRU204OS8zRnN6MVFpTkFJMjAv?= =?utf-8?B?ak9zQjRVQ1lENmUwcHRZSFNSVHhERW0yZmo4TmVMbDM0cjA5bmZxOVFsZFNw?= =?utf-8?B?TTJxREtJYmhITUpqbGRWa01HdGttbHNtRGRoRVFHZUk5Z05tTUlJYnRDNmQ3?= =?utf-8?B?ZDVVNXRmWmJ0ZlJOckJrczVoOUUrKzV3RFE5Um5LWjIzRWdBT1d1c3AwUGlY?= =?utf-8?B?VUR0TlZXUEIzNmRVQlJxWlBLN3NOQkZ3anp0VzJoWWk0N0crU2RkQjNOWHZR?= =?utf-8?B?LzZjdHNtNmhTdUZXb3ZIcm1iM2VCdkNCeUorT0ZxZUVXQ2o5WXZSZGZJRVBN?= =?utf-8?Q?H6ijlhLZOOwUOzFCyU1f9o4=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: pocxm4uSAk6tBZv8jZpBMN4CWXFIi5aN+1yaS0e/3uAEebeUhnD795Jg5FgDllkwFupIaCdg1adSh5DDMtNiPv/HTdGpGYT4ayOaHAK7MXxmD26I42mCzn2JPakzP826DWLgj/LfwSiNmTEm/1As97ScIxh5s0QesUkQzN/jvaYnYqhMdHPzhDjdU2Yry/9IHsoTL4C5z4fs32xayA4Dv3bJbzB+TQltfQ8EZWuckUlgDsORxH75iJbIQwgRDVTzoWVB3AvYUXF6VTuCE3inP9uCvRYrXmmDmxUaW1EsFByoNPEay3B+GqtGThxO0DOYY6xtCUpTtSPb5/oXnfR2DENAXBGSFLpxW0SS9KWTEbBmRtevvUwYDAxKZF7ANo3AnI6vDMKjF7grvKpKaRAkdYzW+px9dx5x/SrP7ZmGTd07pEPgvoix6hX4b7WFvZ7I6JKSJjq9rfTQ4UD8hQotFUP610LoqCQwyc3I2nrJjK2lsCC/U7B1y+5qk635C6L6TsyKqQzF9SQAC0iD14s6peoCbjKdaXdQAWDnGEpC8799+rseZ1NfUDjA1D1bpqNGVfx2LTvlOrRtrNXF4mmiyAVrca3kNUV7a9A4JOwYCIk= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: acca861a-b07a-4477-d2ea-08dc5f7ac225 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2024 07:40:02.8217 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YON3F2bRXkNF/i0H09B0GS9suf18rrJ2e2S5//pAaLJkxvnh5fTw2xBtezkZXDcEN5XlRVoyXuZtZaetPhgpig== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4273 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-18_06,2024-04-17_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 mlxlogscore=999 suspectscore=0 adultscore=0 phishscore=0 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404180053 X-Proofpoint-GUID: 4PsG9h-wv3PUnZMvj__C1Nj0pUCszj5- X-Proofpoint-ORIG-GUID: 4PsG9h-wv3PUnZMvj__C1Nj0pUCszj5- X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/12/24 07:47, Jens Remus wrote: > For the SFrame FRE frame-pointer (FP) offset from CFA a 'u' is displayed > if it is unavailable. > > For the SFrame FRE return-address (RA) offset from CFA a 'u' was > displayed if the ABI uses a fixed RA offset from CFA. By chance a > 'u' was also displayed if the RA offset is unavailable, as the string > buffer was not initialized after formatting the FP offset. Note that it > could not occur that the FP offset was erroneously displayed as RA > offset, as the SFrame format cannot have a FRE with FP offset without > RA offset. > > For the FRE RA offset display 'f' if the ABI uses a fixed RA offset > from CFA. Display a 'u' if it is unavailable. > > libsframe/ > * sframe-dump.c: Display SFrame fixed RA offset as 'f' in dump. > > gas/testsuite/ > * gas/cfi-sframe/cfi-sframe-common-4.d: Test for RA displayed > either as 'u' (if RA tracking) or as 'f' (fixed RA offset if no > RA tracking). > * gas/cfi-sframe/cfi-sframe-common-5.d: Likewise. > * gas/cfi-sframe/cfi-sframe-common-6.d: Likewise. > * gas/cfi-sframe/cfi-sframe-common-7.d: Likewise. > * gas/cfi-sframe/cfi-sframe-common-8.d: Likewise. > * gas/cfi-sframe/cfi-sframe-x86_64-1.d: Test for RA displayed > as 'f' (fixed RA offset), as x86-64 does not use RA tracking. > * gas/scfi/x86_64/scfi-cfi-sections-1.d: Likewise. > * gas/scfi/x86_64/scfi-dyn-stack-1.d: Likewise. > > ld/testsuite/ > * ld-x86-64/sframe-plt-1.d: Test for RA displayed as 'f' (fixed > RA offset), as x86-64 does not use RA tracking. > * ld-x86-64/sframe-simple-1.d: Likewise. > > Signed-off-by: Jens Remus LGTM. Thanks for your patch. > --- > > Notes (jremus): > Changes v2 -> v3: > - New patch. If the change in display of fixed RA offset as 'f' is > undesired the patch can be reduced to fixing the logic to display the > FP offset. > > .../gas/cfi-sframe/cfi-sframe-common-4.d | 4 ++-- > .../gas/cfi-sframe/cfi-sframe-common-5.d | 4 ++-- > .../gas/cfi-sframe/cfi-sframe-common-6.d | 4 ++-- > .../gas/cfi-sframe/cfi-sframe-common-7.d | 4 ++-- > .../gas/cfi-sframe/cfi-sframe-common-8.d | 2 +- > .../gas/cfi-sframe/cfi-sframe-x86_64-1.d | 8 ++++---- > .../gas/scfi/x86_64/scfi-cfi-sections-1.d | 10 +++++----- > gas/testsuite/gas/scfi/x86_64/scfi-dyn-stack-1.d | 10 +++++----- > ld/testsuite/ld-x86-64/sframe-plt-1.d | 8 ++++---- > ld/testsuite/ld-x86-64/sframe-simple-1.d | 16 ++++++++-------- > libsframe/sframe-dump.c | 8 +++++--- > 11 files changed, 40 insertions(+), 38 deletions(-) > > diff --git a/gas/testsuite/gas/cfi-sframe/cfi-sframe-common-4.d b/gas/testsuite/gas/cfi-sframe/cfi-sframe-common-4.d > index ca559bd0a029..8632613f532f 100644 > --- a/gas/testsuite/gas/cfi-sframe/cfi-sframe-common-4.d > +++ b/gas/testsuite/gas/cfi-sframe/cfi-sframe-common-4.d > @@ -17,7 +17,7 @@ Contents of the SFrame section .sframe: > func idx \[0\]: pc = 0x0, size = 12 bytes > STARTPC + CFA + FP + RA + > #... > - 0+0004 +sp\+16 +u +u + > - 0+0008 +sp\+32 +u +u + > + 0+0004 +sp\+16 +u +[uf] + > + 0+0008 +sp\+32 +u +[uf] + > > #pass > diff --git a/gas/testsuite/gas/cfi-sframe/cfi-sframe-common-5.d b/gas/testsuite/gas/cfi-sframe/cfi-sframe-common-5.d > index ee82053e13db..dd2c32d3d9fc 100644 > --- a/gas/testsuite/gas/cfi-sframe/cfi-sframe-common-5.d > +++ b/gas/testsuite/gas/cfi-sframe/cfi-sframe-common-5.d > @@ -17,7 +17,7 @@ Contents of the SFrame section .sframe: > func idx \[0\]: pc = 0x0, size = 12 bytes > STARTPC + CFA + FP + RA + > #... > - 0+0004 +sp\+16 +u +u + > - 0+0008 +sp\+24 +u +u + > + 0+0004 +sp\+16 +u +[uf] + > + 0+0008 +sp\+24 +u +[uf] + > > #pass > diff --git a/gas/testsuite/gas/cfi-sframe/cfi-sframe-common-6.d b/gas/testsuite/gas/cfi-sframe/cfi-sframe-common-6.d > index 9d54b98552bf..34390c46a074 100644 > --- a/gas/testsuite/gas/cfi-sframe/cfi-sframe-common-6.d > +++ b/gas/testsuite/gas/cfi-sframe/cfi-sframe-common-6.d > @@ -17,7 +17,7 @@ Contents of the SFrame section .sframe: > func idx \[0\]: pc = 0x0, size = 12 bytes > STARTPC + CFA + FP + RA + > #... > - 0+0004 +sp\+8 +u +u + > - 0+0008 +sp\+8 +u +u + > + 0+0004 +sp\+8 +u +[uf] + > + 0+0008 +sp\+8 +u +[uf] + > > #pass > diff --git a/gas/testsuite/gas/cfi-sframe/cfi-sframe-common-7.d b/gas/testsuite/gas/cfi-sframe/cfi-sframe-common-7.d > index 2b7fe3aec8f4..61efb9c4ed12 100644 > --- a/gas/testsuite/gas/cfi-sframe/cfi-sframe-common-7.d > +++ b/gas/testsuite/gas/cfi-sframe/cfi-sframe-common-7.d > @@ -17,7 +17,7 @@ Contents of the SFrame section .sframe: > func idx \[0\]: pc = 0x0, size = 12 bytes > STARTPC + CFA + FP + RA + > #... > - 0+0004 +sp\+8 +u +u + > - 0+0008 +sp\+8 +u +u + > + 0+0004 +sp\+8 +u +[uf] + > + 0+0008 +sp\+8 +u +[uf] + > > #pass > diff --git a/gas/testsuite/gas/cfi-sframe/cfi-sframe-common-8.d b/gas/testsuite/gas/cfi-sframe/cfi-sframe-common-8.d > index d654e1d0bcd4..d77645636b36 100644 > --- a/gas/testsuite/gas/cfi-sframe/cfi-sframe-common-8.d > +++ b/gas/testsuite/gas/cfi-sframe/cfi-sframe-common-8.d > @@ -17,6 +17,6 @@ Contents of the SFrame section .sframe: > func idx \[0\]: pc = 0x0, size = 8 bytes > STARTPC + CFA + FP + RA + > #... > - 0+0004 +sp\+16 +u +u + > + 0+0004 +sp\+16 +u +[uf] + > > #pass > diff --git a/gas/testsuite/gas/cfi-sframe/cfi-sframe-x86_64-1.d b/gas/testsuite/gas/cfi-sframe/cfi-sframe-x86_64-1.d > index c8b5e6adfea0..88b4cc63dbaa 100644 > --- a/gas/testsuite/gas/cfi-sframe/cfi-sframe-x86_64-1.d > +++ b/gas/testsuite/gas/cfi-sframe/cfi-sframe-x86_64-1.d > @@ -16,8 +16,8 @@ Contents of the SFrame section .sframe: > > func idx \[0\]: pc = 0x0, size = 25 bytes > STARTPC +CFA +FP +RA + > - 0+0000 +sp\+8 +u +u + > - 0+0001 +sp\+16 +c\-16 +u + > - 0+0004 +fp\+16 +c\-16 +u + > - 0+0018 +sp\+8 +c\-16 +u + > + 0+0000 +sp\+8 +u +f + > + 0+0001 +sp\+16 +c\-16 +f + > + 0+0004 +fp\+16 +c\-16 +f + > + 0+0018 +sp\+8 +c\-16 +f + > #pass > diff --git a/gas/testsuite/gas/scfi/x86_64/scfi-cfi-sections-1.d b/gas/testsuite/gas/scfi/x86_64/scfi-cfi-sections-1.d > index c45933b72edc..7c247e33a6e8 100644 > --- a/gas/testsuite/gas/scfi/x86_64/scfi-cfi-sections-1.d > +++ b/gas/testsuite/gas/scfi/x86_64/scfi-cfi-sections-1.d > @@ -16,10 +16,10 @@ Contents of the SFrame section .sframe: > > func idx \[0\]: pc = 0x0, size = 12 bytes > STARTPC + CFA + FP + RA + > - 0+0000 +sp\+8 +u +u + > - 0+0001 +sp\+16 +c\-16 +u + > - 0+0004 +fp\+16 +c-16 +u + > - 0+000a +sp\+16 +c\-16 +u + > - 0+000b +sp\+8 +u +u + > + 0+0000 +sp\+8 +u +f + > + 0+0001 +sp\+16 +c\-16 +f + > + 0+0004 +fp\+16 +c-16 +f + > + 0+000a +sp\+16 +c\-16 +f + > + 0+000b +sp\+8 +u +f + > > #pass > diff --git a/gas/testsuite/gas/scfi/x86_64/scfi-dyn-stack-1.d b/gas/testsuite/gas/scfi/x86_64/scfi-dyn-stack-1.d > index 6cd0484d5793..c6a9b53f4e09 100644 > --- a/gas/testsuite/gas/scfi/x86_64/scfi-dyn-stack-1.d > +++ b/gas/testsuite/gas/scfi/x86_64/scfi-dyn-stack-1.d > @@ -16,10 +16,10 @@ Contents of the SFrame section .sframe: > Function Index : > > func idx \[0\]: pc = 0x0, size = 87 bytes > - STARTPC + CFA + FP + RA > - 0+0000 + sp\+8 + u + u > - 0+0001 + sp\+16 + c-16 + u > - 0+0004 + fp\+16 + c-16 + u > - 0+0056 + sp\+8 + u + u > + STARTPC + CFA + FP + RA + > + 0+0000 + sp\+8 + u + f + > + 0+0001 + sp\+16 + c-16 + f + > + 0+0004 + fp\+16 + c-16 + f + > + 0+0056 + sp\+8 + u + f + > > #pass > diff --git a/ld/testsuite/ld-x86-64/sframe-plt-1.d b/ld/testsuite/ld-x86-64/sframe-plt-1.d > index 9d123a73826d..617fb9950acc 100644 > --- a/ld/testsuite/ld-x86-64/sframe-plt-1.d > +++ b/ld/testsuite/ld-x86-64/sframe-plt-1.d > @@ -19,12 +19,12 @@ Contents of the SFrame section .sframe: > > func idx \[0\]: pc = 0x1000, size = 16 bytes > STARTPC +CFA +FP +RA + > - 0+1000 +sp\+16 +u +u + > - 0+1006 +sp\+24 +u +u + > + 0+1000 +sp\+16 +u +f + > + 0+1006 +sp\+24 +u +f + > > func idx \[1\]: pc = 0x1010, size = 16 bytes > STARTPC\[m\] +CFA +FP +RA + > - 0+0000 +sp\+8 +u +u + > - 0+000b +sp\+16 +u +u + > + 0+0000 +sp\+8 +u +f + > + 0+000b +sp\+16 +u +f + > > #... > diff --git a/ld/testsuite/ld-x86-64/sframe-simple-1.d b/ld/testsuite/ld-x86-64/sframe-simple-1.d > index ce5f94386ac2..18c863938d39 100644 > --- a/ld/testsuite/ld-x86-64/sframe-simple-1.d > +++ b/ld/testsuite/ld-x86-64/sframe-simple-1.d > @@ -23,14 +23,14 @@ Contents of the SFrame section .sframe: > > func idx \[2\]: pc = 0x1020, size = 53 bytes > STARTPC +CFA +FP +RA + > - 0+1020 +sp\+8 +u +u + > - 0+1021 +sp\+16 +c-16 +u + > - 0+1024 +fp\+16 +c-16 +u + > - 0+1054 +sp\+8 +c-16 +u + > + 0+1020 +sp\+8 +u +f + > + 0+1021 +sp\+16 +c-16 +f + > + 0+1024 +fp\+16 +c-16 +f + > + 0+1054 +sp\+8 +c-16 +f + > > func idx \[3\]: pc = 0x1055, size = 37 bytes > STARTPC +CFA +FP +RA + > - 0+1055 +sp\+8 +u +u + > - 0+1056 +sp\+16 +c-16 +u + > - 0+1059 +fp\+16 +c-16 +u + > - 0+1079 +sp\+8 +c-16 +u + > + 0+1055 +sp\+8 +u +f + > + 0+1056 +sp\+16 +c-16 +f + > + 0+1059 +fp\+16 +c-16 +f + > + 0+1079 +sp\+8 +c-16 +f + > diff --git a/libsframe/sframe-dump.c b/libsframe/sframe-dump.c > index 493d052ce91f..69633d53a33a 100644 > --- a/libsframe/sframe-dump.c > +++ b/libsframe/sframe-dump.c > @@ -181,13 +181,15 @@ dump_sframe_func_with_fres (sframe_decoder_ctx *sfd_ctx, > printf ("%-10s", temp); > > /* Dump RA info. > - If an ABI does not track RA offset, e.g., AMD64, display a 'u', > + If an ABI does not track RA offset, e.g., AMD64, display 'f', > else display the offset d as 'c+-d'. */ > - if (sframe_decoder_get_fixed_ra_offset(sfd_ctx) > + if (sframe_decoder_get_fixed_ra_offset (sfd_ctx) > != SFRAME_CFA_FIXED_RA_INVALID) > - strcpy (temp, "u"); > + strcpy (temp, "f"); > else if (err[2] == 0) > sprintf (temp, "c%+d", ra_offset); > + else > + strcpy (temp, "u"); > > /* Mark SFrame FRE's RA information with "[s]" if the RA is mangled > with signature bits. */