From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2089.outbound.protection.outlook.com [40.107.7.89]) by sourceware.org (Postfix) with ESMTPS id 15B173858C54 for ; Wed, 18 Oct 2023 08:21:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 15B173858C54 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 15B173858C54 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.7.89 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697617320; cv=pass; b=oHkbdeo4s8BMGk4/wXp50AK+9cZrz5qtawvYlnO36td242hHghjKcrLXKQ77KzCEwqmszJxpFD6RsLMNRZMOgTOpiWZhI3pXVcynr6fJvJgKsG0m2rGIrBB6U3rdpUwOHaQf+7CYJqtmrf0hWO4iXO/P4zAUKLlAYKw9LzJBwmo= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697617320; c=relaxed/simple; bh=VSDsYSnS7BijLaeO6y591SLSHpQS+HQryDrclNs3dHU=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=Vi2SUzR5zkbF++dBMdnqDMUnlumhiiVOTraELwakS0awxOeSTCAZqiLy8zcvSCeZRP+mjhc4TfemBrvCqnSFD8UstXenH7sYTQFxahS0iaP8+hNoA6e8e2nU4qysQcTfqCDu6/zT1HILlp4xaiiQ3rybrXJ37Xgmm+Yuxjxk9NQ= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gI5WtbPPa5z/LvWvYvusKEIO9hzzv41MDkujQpEtFWedH7ad50oFI0E7JIDb7NDqgYDmzFyhCdrFI5ookUwZMdoxsaa0VwH4Z9nRIa5R1WpQOn7SM2YaQd1QixppRjTWh1REarkAsuHAOoNr9UAxPgcS0eg1IlWIj4/abnpRhUJclVVk65dxEpbwtMVJI+T9A8Whx1LoUbvNATrpDBahlKfCs9r3KXoFMU+4E8KaPIqCtxt5BQLTKCQRcgNecerRfLBDEccyRgI4vl5JqPr7oJe6XjzPNH10lMjpmL7+PQNl93J6nmoTs7LsQ8Mn2YCG2C49zoXMwu0yl13tzl0bgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gP1RNfdKCn37Nvp5dUy0Ut9rqtBEVe53Es3pqRKTjJE=; b=gpHYIPbeOd0p+P0CbeKuYMNRaL7UzlciV6mBWd1NaVF5WvXdF3FB+pOzJhHy4EVridoRdiQBMtqPUenXdE6nzWdVjQ4KVkx6E+ggz7yvimbHuBNeXVBuoq1tkxwL3xZdFWJYmQ34lk/KY5Gug72EOz5NYe554j/rBMJlFu7lxFPwrPqOaOKaFAYXO9hZcxyLc0/DAhcsABRLUhRdQ3qZCXUBPSBvro0UTs78DVFskuTJChmbJmuoHjgytKtH+InqhYznz/jEUUD9AT0ftdmkNArbhoCH9lifmB509sDc+8sMTER3TbD/q8nPU/fL3Jh/LzL0RO3UAbuvggquYqGVrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gP1RNfdKCn37Nvp5dUy0Ut9rqtBEVe53Es3pqRKTjJE=; b=3sgtzOzDIldgI+2LHtsda+4qAPTAioFzAJOHrb++ynAsitOKHROFqVfMp9gFWhEQss5Nlyn6b2bIIXJMPmDfQ9DnP0D4tPgAHNZxWwDli6RcnWwzEdsU7QL6+79dzyeEIjAUoUj2NVX4dc12sCIQ3ENWG5uWqQh1MaRs4K6zzEPFdyb7vbXkBdOU0897/4a/N81Pda9Cu3z4QsDEexZQyi2UdfWoXG+INSdZ1QgJu3TPYEuodKL6asweUv9KYk4hrImNK6/B2lvsBoomJ73JZoljDCwmY5OAJl/AxmvMSuAIGdVPET4opE3kuMeugiib5YVNnXmHLiPbmD6KZ8tFeQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAXPR04MB9373.eurprd04.prod.outlook.com (2603:10a6:102:2b5::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.36; Wed, 18 Oct 2023 08:21:55 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::d9c0:d907:4d2d:15b3]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::d9c0:d907:4d2d:15b3%7]) with mapi id 15.20.6907.022; Wed, 18 Oct 2023 08:21:55 +0000 Message-ID: Date: Wed, 18 Oct 2023 10:21:53 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 2/8] Support APX GPR32 with extend evex prefix Content-Language: en-US To: "Cui, Lili" Cc: "Lu, Hongjiu" , "binutils@sourceware.org" References: <20230919152527.497773-1-lili.cui@intel.com> <20230919152527.497773-3-lili.cui@intel.com> <9c3a051e-d7f2-26a7-8013-9b0081a54023@suse.com> <176bf162-764b-e103-2985-f1d5ffe3d869@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR4P281CA0001.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:c8::15) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAXPR04MB9373:EE_ X-MS-Office365-Filtering-Correlation-Id: e8722af3-e42f-426e-e22f-08dbcfb34a45 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MaaO44fMFM0PMNogOytezSYzt723+rOTVkCJs0/aAIWf/0MZactUQ7clEgBgrxut4JmVB+WVi4N3tSj7A929KcdTRAtTdpEbpYLCJMw1cao8ysbmPoyTT9tnXvfMwT8b8IDVTLFhk0l0DMUXIpCB5iVwiNvBrTdoeaBBpj72no73fktcA0jzUgTaHDFFb2Lo5249Ez8pgfOarMNd95sz+piWSIfwzuJqHOq2/c5+nsp3g3kLO/ozFmwdwD1k4zduRMphHrz0aAr8+0O3Wddh0Agboy5tTEDJKrd2LZpyfD7wUcjOhLEbcFTfYvfa1UFcYvyY0AzHkmkym+BehFKRG7Mfng3fqJDQGhPGFd2l/4jpO4brmjuzwqBETI/lfqIASyOSKpnwmospy3aAREpUHPnJRB3ZL+drnOqb/RiJ4723MHm1wUNM3VH9Ok29JwpGCyzTndKP8N+9jgx2DTRFFJcfUM4UQ08U1ILZw5W8jTeKJyq/zV/o10TryiN2Uxt3AQ3JSEqnNSy+fx/angWAbSZdqb9KdL6UOFVwRa2d8yRW14cqbEoFR4bjDeJ6Oj590Yf7UNx+187YXE8TNfkpeZXARqpyQAwNbfWVvDqFjCdFW7F0HoJsPGyzB7Y1SPp+VS/DYHm5p9dPCykH4bkxtw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(39860400002)(366004)(136003)(396003)(376002)(230922051799003)(1800799009)(186009)(451199024)(64100799003)(6512007)(31686004)(36756003)(66556008)(66476007)(66946007)(86362001)(31696002)(38100700002)(6916009)(83380400001)(53546011)(5660300002)(26005)(8936002)(2616005)(6506007)(6486002)(2906002)(54906003)(316002)(478600001)(41300700001)(8676002)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WW1neGRJUld2TldMTDNsOEVMSDFlaG5UM0UwWml1R2pkQ0hsbzMxbGNuSzEx?= =?utf-8?B?Nko5clZWKzJSKzRUcnVva2EzOW5RMVdWU3l5c1doQTdpdnhVSFhTc1JrMDZ2?= =?utf-8?B?ZXVMNURuQ3M3akdrRXJ4eGlMN2dqUFNyRnpXSHdHWUFRRThDeGpDTzNjT3J1?= =?utf-8?B?SVNnclNiS2V5Q0xlalg4c0o3YWVHSGkwMG4rUitJZGVKbzBCSjgxaUpaaVhW?= =?utf-8?B?VEpsTnlFZWRNMkxBdm9CYUdwQkdadzNYajBLZlpwUk5VM1V0bWMvNHN4VnRP?= =?utf-8?B?Sld6dUg5a3pqaGRnbFQ1TzF1TERuSmRRVjJwREg4THlQM1ozdHltZmluU2FP?= =?utf-8?B?SjNMb0p4b2orTHlCU1lReERFa3M3VUZNSjh6elBJUlNib3V3Wkh4QXFrQUhN?= =?utf-8?B?MmVpWi9nUGh0K1dYZW16Rkg3VGlOeU9CQ2VuUHArejBZa3o2U2F5a0pwODhL?= =?utf-8?B?MEJGM2dIWUFRRm5KS0Q3cWN1QkdNMUY0MSsvK1BRYXRoMzVncThERDlYNzJ4?= =?utf-8?B?di9LRUYvUFI0RW5wa3pOSUFvSXhaODQ4ajNmcnMxSW1GSVU4V0c0b0hHaWlE?= =?utf-8?B?dDdZZFFMamcvVWFKcXZHaXY4Q3JWbHRieUpwNFMrblZucjdTVk1OWUR5Z0kw?= =?utf-8?B?Z0drOSt0c21GWHhoT3NkMTRrWkpoRVdmZlBIQUlKTHdyUWpSTVBCYlhuakVw?= =?utf-8?B?Rm5wTGZ5bmI5QVJ0NWJOUXp1cHBYYUwrd1c0eXBySUVrcGNVR0p2eWF0WHZM?= =?utf-8?B?bU9idHJFcm84NHdWYXo4cXBmMi9aU3BBblVydWVNbWJuUHQ3M3RFb09PQzNP?= =?utf-8?B?ZEt1aVB3bDU2OVFlZVo5bzIySkR6ME5ieDJDL2MvNFVITFMvMmJhc2FwNWVM?= =?utf-8?B?VjI3WFRoOWRtakZyaGc4a3B5ZmhOZjdsNWJuM0czQlZiSDIxUFovbWtpKytD?= =?utf-8?B?VnVES0ZhT3l1SUFmcm9QeHpHemN5VzJtNkR3aTdUMG9uWnpHNGMwZ2NTOUlV?= =?utf-8?B?cjA3M1ZPM0FiYkZkVnhVcWZGZWJiWmJieXRHZ3RQcXFQc1ZSUU04WlZLUENl?= =?utf-8?B?bzF5alVrV1JUQTg0L2hkbUxMKzRGUkdDaXN5SlRwOHdVTWQzUWVKUEt4ZFlF?= =?utf-8?B?L3Y4WVI1Yng5VS9tVDN4cmxuMm1vQ05DRUlNY0l6czd2eVlhMlY5WnNWMlJZ?= =?utf-8?B?Y0ZOd1dFUHlQTG0zZ29GOGJXV3pMWjlCNndCSFRkZHNtSEZRUmx4VUphWSs3?= =?utf-8?B?L0VMdXRxVW5mK29QMDZadEtSMCtubkJXSXZQbHpRVFpEcXBpeVpIVDRKQW1u?= =?utf-8?B?SG9wK0lFMWloYS9wNGtOOVBQRlZZQ0xBR0tSUDdoWXJNZHdMR2VWNm11VHVx?= =?utf-8?B?NXhObmpJV0FwS0FVZml1eG9TL3A5QkhPa25yaURNLzRGVFZFT3pHM2ZyczUw?= =?utf-8?B?aERjRE42cEZUaVZNeTlrSXhtWW56RjlBQVFUYjJsZ3cwb3RiRG54Sm1BRytv?= =?utf-8?B?WVdwTUQ1QmRoSHpyTTVLa0xUVjZxUGp5Z0dpVzBQeW9OQmRzZTJQNkFSRDVP?= =?utf-8?B?WkZEanQ3MGpDWEx2RkwxNEErZk82RGtZZkpPWTBRM0RDRjZTMzRqWGo2N2lI?= =?utf-8?B?cjYwLzlVZ01GWXdTUHhoZXlpNHlqL2o5OXRzK3BvNWh4emt1VU5QTzBNLzhP?= =?utf-8?B?TTBPK2xFWTVLM3ZIa2JmNUNpdnNwR2pNTXRPUHpBRkFlcnA0TS9PQmFwc2lB?= =?utf-8?B?UjE2Y2FmaXdsczdmK0k3Q056WWZ6MlZlNzBjcC90L2VQeEd3bmNKWTl6RGlu?= =?utf-8?B?R3oycWVaeDBTbDBaSlBCb3RzMlJwRldsY01oZitpTjRpY204QWZTT3dQRENn?= =?utf-8?B?Q29JazU5RE8vbFNsY3JiaVJWWDlJRld5bTF0dVpvOGtuRXoweU1LS3JUZG1r?= =?utf-8?B?bGhDMzNtTHE1RnprMTUwMkc5OVI4YzNqRnl6bFNrWnNRaDV6VlJzdFFCZE9R?= =?utf-8?B?S1NEZ3NQT3pYb1U5QkVIeGNyTTFramZvZlQ2MGV3T0F2c0orNDJXajl0NENp?= =?utf-8?B?ZkJ4U1MrTUozQUVycEVLRVhZVm5USjBqcm9TY1M1ekovM0NxSXl2OFpYTDUr?= =?utf-8?Q?GY/uLlo18RWVFxCz9g4FsA+9G?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e8722af3-e42f-426e-e22f-08dbcfb34a45 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2023 08:21:55.6326 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rx8eeO6gvq4yWXYDwCtHRZqX0D6LkbLtTl9adKuZQoq9wM1HKcwd7dd3PIm/0NX4NHVBp17hRF4uERBm6RdGrg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9373 X-Spam-Status: No, score=-3028.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 18.10.2023 09:52, Cui, Lili wrote: > > >> -----Original Message----- >> From: Jan Beulich >> Sent: Wednesday, October 18, 2023 2:47 PM >> To: Cui, Lili >> Cc: Lu, Hongjiu ; binutils@sourceware.org >> Subject: Re: [PATCH 2/8] Support APX GPR32 with extend evex prefix >> >> On 18.10.2023 08:31, Cui, Lili wrote: >>>>>> Similary I don't think I can spot anywhere that you would check the >>>>>> other bits which need to be zero in extended EVEX. Nor Improper use >>>>>> of EVEX.x4 in certain pre-existing encodings (S/G insns at least; >>>>>> perhaps all >>>> others are okay). >>>>> >>>>> Sorry, I can't get you here, what are S/G insns, could you provide >>>>> more >>>> details here, thanks. >>>> >>>> S/G is scatter/gather (i.e. AVX2 and AVX512). >>>> >>> I think you mean EVEX.V4, scatter/gather has VSIB which needs to reuse >>> this bit (EVEX.x4 is EVEX.p[10] which is fixed value 1), For our current code >> we will reassign that bit and now I changed it to check the upper 16 registers >> of GPR32 , do you think it is ok? >>> >>> @@ -4252,7 +4252,7 @@ build_apx_evex_prefix (void) >>> if (i.rex2 & REX_R) >>> i.vex.bytes[1] &= 0xef; >>> if (i.vex.register_specifier >>> - && register_number (i.vex.register_specifier) > 0xf) >>> + && (i.vex.register_specifier->reg_flags & RegRex2)) >>> i.vex.bytes[3] &= 0xf7; >>> if (i.rex2 & REX_B) >>> i.vex.bytes[1] |= 0x08; >> >> First of all my comment was disassembly related; you stripped a little too >> much context for this to remain visible here. And then I think I did mean >> EVEX.x4 - as you say it needs to be fixed-1 in e.g. S/G insns, and the checking >> thereof is what I'm missing. >> > Ok , I will drop the encoder changes, and add an X4 check when instruction has vex_vsib* type in decoder. You understand though that I used the S/G insns as example only. I didn't do a proper check whether any others might also be affected. In particular ones not allowing for memory operands might be. Jan