From: "Martin Liška" <mliska@suse.cz>
To: Alan Modra <amodra@gmail.com>, Tom Tromey <tom@tromey.com>,
Mike Frysinger <vapier@gentoo.org>
Cc: Alan Modra via Binutils <binutils@sourceware.org>,
gdb-patches@sourceware.org
Subject: Re: [PATCH] Add startswith function and use it instead of CONST_STRNEQ.
Date: Mon, 22 Mar 2021 17:42:50 +0100 [thread overview]
Message-ID: <dbc2e30b-2031-1dec-def1-9e9a8d162901@suse.cz> (raw)
In-Reply-To: <20210322120652.GV6791@bubble.grove.modra.org>
On 3/22/21 1:06 PM, Alan Modra wrote:
> On Sun, Mar 21, 2021 at 08:13:06PM -0600, Tom Tromey wrote:
>> Alan> Yes, the following compiles. Fortunately all gdb files that include
>> Alan> gdbsupport/common-utils.h also include bfd.h by one means or another.
>>
>> Sorry, I misunderstood. I thought the proposal was to put the
>> function in ansidecl.h.
>>
>> gdbserver can't generally include bfd. Maybe it works sometimes, but I
>> imagine if you do a gdbserver-only build, bfd.h won't even be created.
>> (At least, it shouldn't be, because gdbserver doesn't require bfd.)
>>
>> So I think some other approach is needed. Either ansidecl.h, or a new
>> header; or rename either the BFD or GDB function and go from there.
>
> A new header would be best, I think.
>
>> I'm happy to implement it if you like.
>
> Yes, that way you'll get it done properly. :) Sorry for the breakage.
>
Hello.
I feel also responsible for the current compilation problems, I pulled the trigger.
Anyway for the sim failures. What about directly including <string.h> in bfd-in.h?
diff --git a/bfd/bfd-in.h b/bfd/bfd-in.h
index fda9fe0198e..d35e2ece516 100644
--- a/bfd/bfd-in.h
+++ b/bfd/bfd-in.h
@@ -38,6 +38,7 @@ extern "C" {
#include "diagnostics.h"
#include <stdarg.h>
#include <sys/stat.h>
+#include <string.h>
#if defined (__STDC__) || defined (ALMOST_STDC) || defined (HAVE_STRINGIZE)
#ifndef SABER
Or do I miss something?
Thanks,
Martin
next prev parent reply other threads:[~2021-03-22 16:42 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 14:20 [PATCH] [RFC] Come up with startswith function Martin Liška
2021-03-18 14:54 ` Tom Tromey
2021-03-18 15:26 ` Martin Liška
2021-03-18 18:00 ` Tom Tromey
2021-03-18 18:29 ` Hans-Peter Nilsson
2021-03-19 6:37 ` Alan Modra
2021-03-19 12:44 ` [PATCH] Add startswith function and use it instead of CONST_STRNEQ Martin Liška
2021-03-19 17:55 ` Hans-Peter Nilsson
2021-03-20 7:00 ` Alan Modra
2021-03-20 18:58 ` Tom Tromey
2021-03-21 13:12 ` Alan Modra
2021-03-22 2:13 ` Tom Tromey
2021-03-22 12:06 ` Alan Modra
2021-03-22 16:13 ` Luis Machado
2021-03-22 22:56 ` Alan Modra
2021-03-25 10:53 ` Luis Machado
2021-03-25 11:54 ` Alan Modra
2021-03-25 12:05 ` Luis Machado
2021-03-25 19:47 ` Luis Machado
2021-03-25 22:31 ` Mike Frysinger
2021-03-26 11:44 ` Luis Machado
2021-03-30 11:58 ` Luis Machado
2021-03-31 13:12 ` Martin Liška
2021-03-31 13:44 ` Luis Machado
2021-03-22 16:42 ` Martin Liška [this message]
2021-03-23 0:02 ` Alan Modra
2021-03-23 4:49 ` Mike Frysinger
2021-03-24 8:19 ` [PATCH 0/5] Start using startswith instead of strncmp Martin Liska
2021-03-18 14:16 ` [PATCH 2/5] Use startswith more for strncmp function calls Martin Liska
2021-03-22 11:12 ` [PATCH 1/5] Replace const_strneq with startswith Martin Liska
2021-03-22 12:33 ` [PATCH 3/5] Use startswith in gas subfolder Martin Liska
2021-03-22 13:56 ` [PATCH 4/5] Remove strneq macro and use startswith Martin Liska
2021-03-23 9:02 ` [PATCH 5/5] Use startswith in gdb subfolder Martin Liska
2021-03-31 20:26 ` Tom Tromey
2021-04-01 5:21 ` [PATCH 0/5] Start using startswith instead of strncmp Martin Liška
2021-04-01 12:47 ` Alan Modra
2021-04-01 13:03 ` Martin Liška
2021-03-31 20:18 ` [PATCH] Add startswith function and use it instead of CONST_STRNEQ Tom Tromey
2021-03-22 6:57 ` Mike Frysinger
2021-03-21 13:19 ` Alan Modra
2021-03-22 10:04 ` Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbc2e30b-2031-1dec-def1-9e9a8d162901@suse.cz \
--to=mliska@suse.cz \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).