From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 3E3EC38717ED for ; Sat, 10 Dec 2022 06:55:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3E3EC38717ED Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BA5FGKp018865; Sat, 10 Dec 2022 06:55:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=Wf6pFNh7TWkUnidZfTpq0p2Gxd1rf/ZORSHCr8gLHIE=; b=nXQazZvxaWWb53dZ5nqr3slHtKtLj+EUgxK1v+DwzO/MwKKMc4F4wTXxwvmRnOmwsy5L CF0Thwx5G7aEjN1pZWsPGOI4Lfy1ygfG4koHj2T8pMHgH68j+oUJft6Y5Rfpxa9C0klc ITsmL0sP+Pfe/2zQJvhwWaRsiDY6eHhQEsDFKFbPt4iZaU6a+YLqbwCsFSqswGZotFvl Vl8TsabRIIayG/A6sqms4nCvIM0JMHKTnDo5fYFiMoSw2uZBERLWDVG7ZZ78SmbcxtNg T8qm1xSfH1hdOIW8TLwCf8dYLAaehHjjTbK8MgMfhIiAjIOtxY9wSElHZvsUUSuKfE2+ Vg== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3mcghcg58h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 10 Dec 2022 06:55:34 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2BA4DXbT031230; Sat, 10 Dec 2022 06:55:33 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2100.outbound.protection.outlook.com [104.47.70.100]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3mcgj1efm6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 10 Dec 2022 06:55:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JijOTuFNlZRbLCntDYvMlA4BYbWshgtaus7gdqDWVjOFhc+Inkp8wRgzQu44/u1zNhgwCy5CK9WcF5T76E8NSqZ8mRP4mWTVP/GkxWvTtS6O9env5BrD8WpFEtxnLy3SF4QrjHQZWpQqqoWs2J0s20TP5D5S6g6ccEa2L2Wu4UVmDCpaFyGPmobzeLKEgXTJGBtcYqmqsFf2lre5jbwabq9DMKHhQXHhcqpOL+I2JOg+8hJ6idLeqwSG9TDDAWVveevGFVier9jgIJL6PvfsdZ7B1SURw22iPbX4jpFYSIa5ItFpoa/hikG8TJGRvRj6ovN+NkxWESupp1XEVcKPfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wf6pFNh7TWkUnidZfTpq0p2Gxd1rf/ZORSHCr8gLHIE=; b=B9LpbaET1TBkQVkii5bRDJV2ar6w5sYs8MS4dsf/WcyEQOxTt5RM3INM2skf+iadoE3ItoC4guuKt+zJGUc5rz7mdyE9GCJrCf1r2/SCntUjvNKxDXX9aA5m5ZOcETc7aHrdLR42JPsm9if6iANxGv0IcPLwMTH0NO2HJRZAlFjopAjamHJbHyqsS84r9cvHtYwrAcLF/wK+diHifEJNgdktVDf4OxKZaOJDXe57Oy2f6oRvWzsA+hbXry+zdGTV5c6/0Lom4vvOTs5gfaRl2KkyylmuBaEF/XCWOLgfCvkRF3BRXWalyFAi1KK52Ro0gAS19YljqtrtcqvtumxbRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wf6pFNh7TWkUnidZfTpq0p2Gxd1rf/ZORSHCr8gLHIE=; b=aD8OTFN0NYARjoZc5mlD5zkBkyMdRyNBEA1VUB89NRBQ9JwoBEsvVvZbEWHoXedLzIpOch3CiTq4Xrtb/Azj9csNDPeP/NxNY7XaRSx7YTcCrPaaxM5zrdQ1cZdh0slWejM9HtahGPXDvo/KrV0KYV+MZAtZfG11MO8wVC4Qtys= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by SJ0PR10MB4717.namprd10.prod.outlook.com (2603:10b6:a03:2ac::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.18; Sat, 10 Dec 2022 06:55:31 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::ee70:1952:4416:1bdc]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::ee70:1952:4416:1bdc%5]) with mapi id 15.20.5880.018; Sat, 10 Dec 2022 06:55:30 +0000 Message-ID: Date: Fri, 9 Dec 2022 22:55:27 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH 1/2] libctf: remove unnecessary zlib constructs Content-Language: en-US To: Mike Frysinger Cc: binutils@sourceware.org References: <20221209202118.4106688-1-indu.bhagat@oracle.com> <20221209202118.4106688-2-indu.bhagat@oracle.com> From: Indu Bhagat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW2PR16CA0045.namprd16.prod.outlook.com (2603:10b6:907:1::22) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|SJ0PR10MB4717:EE_ X-MS-Office365-Filtering-Correlation-Id: 09ff5f24-c5f2-4384-30e5-08dada7b86e3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fpSuEz+PYdJbp8YwV/OaRTwEuYXf94/JCjeF2SqK9VAUc6qledXgudsOCfZ2UTo7orJJm8GEzRAQ61DlTkonejeTvxZ6KHhahw6VLIOkpnXwkUKdo5upo94GlL5K67F1MutDB1fP7NrhZ+OHG70jS1Am619MZ3oreS1oJrCspOI8+2X4P3A7y7XFyy1YXKOAxwY+hpszz/6T0Fvrp2mVGrdZW6HoOQ4ZUl6Gx/QMomOHf1jZo/qO7WY0nYDUwVIOnrO8UA4iz6u565Y3yyCAaRMHpuigUKXZ2MCefASRiA+i95DrrkUv1TNKqNdHS9gP74PjOJXiRIMfFKpwQN6HqRkJn86GehnKDA15fatogWYrckIFNUk96w+CULt0hPjA9mfCyPr5O8y6uk8qIcKbELW6tySZz199/P321m8USIk7T0kA0NkoKTpjkLPw04VxO0O6cF96JOV/uX9B33mxX2ygLIqfX5s4Xi4q5huHG4YcrzvD26NJojqIX81r5cYc2DL+4JdCF6zrUXRULkz+HciYl7jM3CdXatvsvytQQgrZgi3doil/32plzpjODxg70fA2y9MJ5O20ZFn3Ts4Nh3rpes8UqeIPE1q4UP3dJkixg2hN78d15AdayJPIDDOCXeqZpjQLGfnVSrobDgx47b0NJ1GGeOynWx551MqC8uHd60oh1oxx2KDoIvPp79X6GKl2tSVuAI303cDfLmo4JEfmFOTllgSX/2gWNlZcSEaOQxPYbKECYi/lDcwpOcH3 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(346002)(39860400002)(396003)(136003)(366004)(451199015)(44832011)(2906002)(5660300002)(4744005)(31686004)(41300700001)(6512007)(478600001)(186003)(83380400001)(66946007)(66556008)(66476007)(36756003)(8676002)(8936002)(4326008)(2616005)(38100700002)(86362001)(6916009)(316002)(31696002)(6506007)(966005)(6486002)(6666004)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2k0WXNiSnhnM2oxMXpxN1U3a1BhRWppWXMyOWdqTXFwTDNvdGtLZ242MDZN?= =?utf-8?B?YWZRZUJ4MkpBRmx5dHdsRTZjQmdzNTBvWm5jbHFHamVyTDR4L0x0OHF2b3pG?= =?utf-8?B?REwvTUNMWkYzZkZkRUd2Ri8xQVNGYlNJQVNOSHQ4RXlsVEozUmpNMVJjUncz?= =?utf-8?B?c04vVVFDOEtPMTk5RjNCbTIwMERXZ2lveWplUm13Nm9uTU4vYnl1SmUzQWh0?= =?utf-8?B?NEF5NUQ1aWVGV004cUYwWWdmQU5wbzNCbUZrTDFlQmdGV3laNTBnTFp2Vklz?= =?utf-8?B?M210N05yN2wzaGlGVnRLbFV0V2RZU3NNek42Uk40WTliK3ZhWENvcm1xeGdu?= =?utf-8?B?VU1JditJYjV0Wk5QekdOc2Uxd0x0UXl5ekhEUk55KzBPVVNBMndsczBRaVdS?= =?utf-8?B?NFlDbmhPeXc4UUhuSURIWFJkdmRZZlBDMlNuWDhPa1JER3g5WE9NQ0ZTcVJq?= =?utf-8?B?RnBHVzh0TFBjMjRYUmswNGlFRW5WVkNoNXZuYWdlODNnQ29YdVNMYmxUWkFR?= =?utf-8?B?a3M0Tk4zRnJqNG8zKzNUNFlabkZCSTFrdHRCQjlhYkJHT3hrQldjQ0Z4UUNl?= =?utf-8?B?Wk4ySnUwSDRRTEZLMnFyWStkQXFHR0toeFdsL0M4YklnbXJsU1ZYcUowb0F0?= =?utf-8?B?djF3VEFyYUF6VFhuallUWDBNL3BFZG1udld2MWVsc0xrS2VESlpTK25DRk9O?= =?utf-8?B?b2Nsdkkxa3pTbVo1V2o0UTA0bnZNUzEvQjRyM2VKTWsvTXdsTGR6d1kzM3ho?= =?utf-8?B?dXQ0TVFleUVGY3F4OXpQUE5JUW1mK1VyWE9FS0l0MW9WWThSdVNSRTNFQUdo?= =?utf-8?B?TXJuQjRSRFI3WGN1alo2SC9Hd2w5WEozS3VXVk0xYzB4YmZhZGphNmp3cWxS?= =?utf-8?B?WW5TeUt4bUFCRE5SR2VhOUUveU5oTHExMHFzY2ZPU1ZoU1pDVjlYY0M2cmI2?= =?utf-8?B?RFVScjhxUG1sbG1pcHJ4M1RLLzJYejJhZTFJb3YrSitUdE96NThvWEdrOW5z?= =?utf-8?B?MnRDWVd0RmU2VldzdUNEaDJyL3pYa0M3Y3dLbGxVWlc2SUdLUUlvMWNJaHpo?= =?utf-8?B?UGZwNFk3MUxWWTNnRHY2RWlJR1piM3cva0RKOVByTGRONkwvUWpiTVo1VWlW?= =?utf-8?B?TWFOQ0VlWHJRZHJCRWIzUmFmanZrSWxMWVlXS2hkZHBqUGVSeEl6eTlWUXp4?= =?utf-8?B?ZjZNbGoxQmlvaW53a1dyN3pQK0laTGtBckRCRDVzQ3NqcVkwb0tqeDBMek9M?= =?utf-8?B?NlBDalEwWkJGZzJvWXZWd2VYeUlxZmZoQ043d3JQWGRkOGpDbGxoSGpwU0t6?= =?utf-8?B?aUpIbklwYVEvRUE0RnZqWnBYNWZ2YzR2M1B2clJyS2xLa3RITmphb1BOKzNM?= =?utf-8?B?REpMMVYxYk9TejdkbEVDZnYzTk9XL1hSQnZzaUM4Qmp3TlFpSXNoa2JUQkRU?= =?utf-8?B?cEFBYUVRU3VLZ2d2cEFXS0wvazYzQkZZT2k0NU1ldVhTTGNSODZ1Q3o3VHJy?= =?utf-8?B?enhBOTM2WWcvd1BiL1I3aEd6YzZDV1lLSEcxMnZWWlJHQmRmTmdsRHRCZnA0?= =?utf-8?B?TzdzWmtGaklUMEIzYWM1VE1SSmNsMUpyUnEvaEJTV1Z5WXplTDI5cnZHVmlJ?= =?utf-8?B?K1UvM0VuRWRxSHlkdjFrNGtUL3B0ekx6amtxSTdac3o1SEFzcjdEaUd4ejM0?= =?utf-8?B?Vlp1OGhjd2QyMSs5T2pmd04zL0VocWtUVzlRcWN2R1FxeUVhVUJ1UzNNNC9p?= =?utf-8?B?VUYxMWV1eS9QZ3pOemhSNXRZRTdHRmg3RWtRb25OaXpWOUpSUXp3SktjMDhE?= =?utf-8?B?NXFVdFUydlJ5WW4zbWx2dlZOUWRlNVZRSWlPYUlKa28rSENKOVlMeS9BQi8r?= =?utf-8?B?OGlONHRZdXdqRURUYm9ZdVB0KzJFaU9WdU01aWp0ZFFQQlNKVk5HS3IyZGsz?= =?utf-8?B?NUgzb01iSFRxM0duTThRWTU4TFNnWUJYaytlLzl0ZXFYY09IVHBNWkliY1Y3?= =?utf-8?B?ZGw4TGRocExwYzZXY09vNUhIR01nQUtrTnFJN2c4QWxDZ2QwazhhMjN5RlRM?= =?utf-8?B?SGhKR3Jmc3dBMzZrWW55TmgzbmdDdUkzUUErYjl4dlh5ZXJJM3p2aG1pbUNr?= =?utf-8?B?cHVVYmYvVmU2MnpQSlkrajBCVExSNGgvRksvTENaZDRlWjc1Q0VlNTVrTFVE?= =?utf-8?Q?ztr6ZY4R1CXwH3QDoQBLfk8=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 09ff5f24-c5f2-4384-30e5-08dada7b86e3 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2022 06:55:30.7715 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: r05Jt95aKcCsJ4jC7IQo4k80XtlEpGATlr+gi0b7ImYVljtrsIy5HrvVqhUmCGVJfmvtvOG2XTulj9TQiVdFLg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4717 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-10_02,2022-12-08_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 mlxlogscore=999 adultscore=0 malwarescore=0 phishscore=0 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2212100058 X-Proofpoint-ORIG-GUID: GE4VofMPq9OasD_heGa_LYIWSQZS9xY3 X-Proofpoint-GUID: GE4VofMPq9OasD_heGa_LYIWSQZS9xY3 X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/9/22 17:07, Mike Frysinger wrote: > On 09 Dec 2022 12:21, Indu Bhagat via Binutils wrote: >> -ZLIBDIR=`echo $zlibdir | sed 's,\$(top_builddir)/,,g'` >> -LDFLAGS="-L../bfd -L../libiberty $ZLIBDIR $LDFLAGS" >> +LDFLAGS="-L../bfd -L../libiberty $LDFLAGS" > > $ZLIBDIR is zlib related ... > >> -LIBS="-lbfd -liberty -lz $ZSTD_LIBS $intl $LIBS" >> +LIBS="-lbfd -liberty $intl $LIBS" > > ... but $ZSTD_LIBS is zstd related, not zlib. > > commit message only says zlib. > Oops, yes, the removal of $ZSTD_LIBS was unintentional. > also, you're still calling AM_ZLIB & AC_ZSTD which should be removed. > -mike AM_ZLIB cannot be removed at this time from libctf/configure.ac. There was a discussion earlier on this matter in context of using libtool and GDB: https://sourceware.org/pipermail/gdb-patches/2022-November/193771.html Regarding removal of AC_ZSTD, perhaps, yes. I will run some tests and send a separate patch. Thanks!