From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2084.outbound.protection.outlook.com [40.107.247.84]) by sourceware.org (Postfix) with ESMTPS id DFF23384600C for ; Thu, 23 Mar 2023 14:30:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DFF23384600C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AIhWB8gTfG8ztCNT4xQUsgV0YOrDMj2iPADLfF5HtFrYJV7RmnEXN7iYRQbcyC3t/1YO3Wab8Rw3G2D4C+37KLbFFiiap1mZlR07JLVIlyV7GZu5h4j6jvDB569ZPCvkN2MEGS7C++sudvNq9V1kibQwCFSAsESUeZVAr8wEqWM3luwN3IJwI81kwJaC2io0x3ulYQ8/hVyJHJ5kU4rIQ+8mxxY76uT4WIUfXHzknKaGodCZeQGlTsmEPd/9XHLInyKpV5mTJZCfLz4qPAIf+5t1Ejp2ybzkA26dKFDpv8n49xPcPyCCGxj2MwUaV1JsZiTqHj1izbkAHn+q1VE5HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QS07v3q2AVnFgVHFT/sxiEpJrsdtYWYAXhUFVL7tzqc=; b=E0d7L1GtiOWma944aKir5rrzq/JJ0ChPVTksLufCnfWlIuVi3OEBmRu2ZbGKOMaa9rHg9TN3kjlXllwUfi7lUuAZ1uCf14kg6NygEKw4pHpYbAKqaqoJtA9jGR+bPlPVSyTXE6Hs+D2QY77Efatb4swIAnhJM6GS/v7ob4d6SzWj3hzdexrnrdUe+JVKjDdlfLVbsF3NppsySRpd77n8EYj7C0v0Cts8gXrwnwDY6G2vDefe3P1/Hjq2jyhJCGVkDf/V5KgcygSXKMzCr9yVrqdZv7KcTWbe/GLJya8ZYUw5WXOxZfBWoNY0ApcQfRMzuDIMD4jr0K0kJxD8NFsI7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QS07v3q2AVnFgVHFT/sxiEpJrsdtYWYAXhUFVL7tzqc=; b=vjXQ4onJnKaKHmP3B1j1Hz0HS3+nq3c5Q9Nqm6onUtTSKSHT6u2Wd9eiIvnJG5uXxqzNaPFLRIXIuUhCStIZv0DiN5xPD2xKMq4frPKlbaNcCc86pCcPWkDm1mtnydzd3gMjW6PVqNRtQ1PnfLCXnTJpQ8enNki2z3g7k8m0MQ8RIhRDdnxm95OeJ6QcxjP/0o4FxPdeEW3pye5Hgszgbt1ygYNFlvd5/JkKqwL4eT9zeGKy0xUVeECSQMj1G5pZQHyiFnT0pX9t4bLMnPSguytoPKdaQmlXUMzTFPiT2paf43G6GI+Vt6A3P0N7lF3ChBiDsEw3E585qb74X5lIrw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7783.eurprd04.prod.outlook.com (2603:10a6:20b:2a4::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.38; Thu, 23 Mar 2023 14:30:17 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%5]) with mapi id 15.20.6178.038; Thu, 23 Mar 2023 14:30:17 +0000 Message-ID: Date: Thu, 23 Mar 2023 15:30:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Content-Language: en-US To: Binutils Cc: Richard Earnshaw , Marcus Shawcroft From: Jan Beulich Subject: [PATCH] Arm64/ELF: accept relocations against STN_UNDEF Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0117.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9d::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7783:EE_ X-MS-Office365-Filtering-Correlation-Id: c0431fa4-14ee-4b90-5efa-08db2bab1f78 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ey1Zz0i3XBz1fpYeoctYH1h3ITUCegid1UbUp1OgvDF4jXu2NGInjPAy2KcFJaWtbBH3i3iENEBzRHZZbm8eeKedh4TI75MN29Ve28T35FUaWMWqfAVEwcTrzsSnx5VXZc5fja++njj2NAL7qUss3R5xL2WLcxxXsRBywIuCvSmg6dzxOX/gECc6OtF2WL9l25Q/fW8biZ4rc2UBGOiV57Qly0X/I+HosJCc17PqzGN+vbGbkxrBeifYgFkGY3JNMF0QtnkEtD/pqlGNcBYtQ9y7JD3RI1zBVEHO19PEsmnsRKlDeqIcp+vjckvBqXKCDVel00FlUeV/e0GePgBdwJK2VIAwsznFuk1TFvTkVNRS65Y96+WCzi2eIn4MmhO1A1A16dbJG6gu6MAs/KB8jMtsG9eumHfhlHxeXGQpRZamcxTht8hYrEmMuwjJZdmQ07g1pdSKEHy596YtupN6XE333ydG3yenzmcf3JoAr3rnLsLCKISyA1q4H9q1yRwlxKoTmxDyYE/SKfy1dobo540F/r7+PX0V6XLbyNZfhHF0ogBOOXq7ZGseLoFagK4Zst3m/f6GtZ8/MmA3M6w7+c92c5BdsDUrpKR1L0qJxqZFH24K1wG/RE8iZ6pFU+r+7B3fikgdOQm1IzyZqFzJBW8B5iS3kFyk/H3BBlQyMApd/ytXiD7HqBZdIqNLoQ2gWlOrJuz6Kmo3gcEp9U8RMRpuNqgUNrqNo2eRcJe/wU0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(366004)(136003)(376002)(396003)(346002)(451199018)(36756003)(4326008)(86362001)(8676002)(6916009)(66946007)(66476007)(66556008)(8936002)(41300700001)(478600001)(6486002)(316002)(54906003)(2906002)(5660300002)(4744005)(31696002)(26005)(38100700002)(6512007)(6506007)(2616005)(186003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V29LNHZ0aTZ4bkt0enR4VVhwUk9VTVlzeVZvTlU5aDFkRUliKzhYZlBJUUJw?= =?utf-8?B?V2daODFwRFZsTzJFV1dMSnBLL1JLcEN5S2pJaHN6azJUUllzN3pocDIzS2xn?= =?utf-8?B?QVgwRUdpT1huUWdmZW5nT2lqZUgwakFWQjBzRlVwcGJRVFMwQitwUUViN1dO?= =?utf-8?B?cGs1M2VZNFIwSHBBOEpEd3c3dllQVzZyVWNwdjBoQmI5MUdZcEZZSDQ2eU1G?= =?utf-8?B?OGxNMDJ5NTdZWWN1Y0NSb1RKaFRxSmRLaXFhMm9RbC93REFSR3RhSG4vUzhm?= =?utf-8?B?SHJyUWc3TkNhQ0VBbzNNMWE2K3dscVY2VWkxTFNUK1dvYlNTRFpkMjk3alFk?= =?utf-8?B?RmFGelRZQlVWZDh2MVBSWSt4STlQSHNuL2JQT0wxYmUrczdBZkxGMEVvMmhN?= =?utf-8?B?QmtSN2ZlNWEzMkhBc0lpaVZuYkZvS05wOTRSemw5aFB0YW1DZXorY2ZlUkdr?= =?utf-8?B?bEhRZlFjZ3FlcXFJR2FycmlRQmxGSTdXdUVETEJRRkJBVWNPeE0vRDRTOHpL?= =?utf-8?B?dG5Td3AwSGhUbWxvYUgxWFRVTHJkSmpRam8vVytKS0xKZHNFM2lWdmVFcjRY?= =?utf-8?B?VE5vS09VZ0h3NjNPWnlYS2RkcUl0U2dhNmhRT3VYWlI5OVFPOFFpanZZZVJO?= =?utf-8?B?T1lBWjlzUm1uVTg3emQveWhJVHRzMm1uQllxaTBMK1VHMFF3OFRoRTV1U1No?= =?utf-8?B?ZWRQdS9Wa09vK2NtdnhCNEJVTHp0enAwc1BwVHFSenpRRFJhVHdkWVJ5Z3BI?= =?utf-8?B?UUEwNGN6SVFuTSt3b0dQajkwS2V0L2hBSTJhZTZVODE2NytWbGlMTkprSXFl?= =?utf-8?B?S3U5cTU3M2ZVbTErZ1lzZ2hScnVlWGw2b3p6NU91RkpEMU9HKzBtWm5vcDNi?= =?utf-8?B?UzMxQU12OXN6KzgvVzJveUJhaCsycko4MHRBYzRxRExiaUxCNkRYWmhNYVNG?= =?utf-8?B?TEFpVDlyN040U0JPbEV4SDQ3bVk4WDlyc0RYYUs5VTZiRCtMcEpoSklGcW81?= =?utf-8?B?bGIvTjhNL2c1ZVE5RzNhYnBFVUxmNE1QcTRmZG9RTThHRjZUR1lTTnVwYWVX?= =?utf-8?B?bVB0Q3ZCaHFMOTJ6MzEremU0RHV4ZWVaMEdMaUxabi96aU1vRTFQMTRFQmkw?= =?utf-8?B?dEQvREw4YXg1aVJIVmVLZjN2RHpLVThEb0FmelJ6b2lycUxZWGp5ZEEwOFhp?= =?utf-8?B?QWdaaFB2MitXMFNjZHcvcm1PbTlUNldNemJBRU1sa0RrZmpoSWxYVEJVcENj?= =?utf-8?B?WE1Oa2w2akpkVzh1R3kwVUw0eGM2L2p4NmpDeDdpTzFDcEhzcWI5dG8zb016?= =?utf-8?B?MHB1WUdpRU16Wi9IMUtZdUNjM0w2RWUyVDdMelFWNVlNY29BaHpGajVVOGo2?= =?utf-8?B?V1U3Qjg4M0RSRjJnOENXYWNpQVh4MUhiMTJrSW16OWZYMm5FNU1JcTVsS0VF?= =?utf-8?B?YzQrUUE1NE5KVFVLK3JQdmkyZzRoVnFpUWQzNUZkNmpvUjBtY2VrTCt0UCt1?= =?utf-8?B?OVVYSHpYR2xiRmJZL1piMytMRllZL2pZZUxSZm1ndzlJaktjMDFYR0pScHRt?= =?utf-8?B?OWdCejZUTlhtbVNxTjgwKzY4R2w5ekdMMktKVC96OTQ2MXhYYlJkbVBMcU9z?= =?utf-8?B?VzhOdkJBUDdZVFNlSTAxYVBwYXl2UmFmK3BNY0N2Zm1lZDJEZXRrWjl0alh0?= =?utf-8?B?V1RqbU9pYStkMU8vSGtxVzEramRtenl0VVZuTytZR3ZDUGM3OWo4UmdlcTJY?= =?utf-8?B?WE5zREVLM3VDa1RqTGNEaTBaUFhUTC9oSHA1blk5VVV0ZlNZYi8zWDg1UGdw?= =?utf-8?B?OTZFN25wZnJ6QXRYK2d1c3pTdG9MSnc2aytySjdCTzlucGovQlRCb1dhdFR1?= =?utf-8?B?cEUwcDJTM2pIblJzQWNvSFZOZ3VtdWJmKzB6TzJNcWpvcEFkRDh6S3hiUjJ6?= =?utf-8?B?Mi9mZVBjWXlkYkRPOGViQWJVZnRvVzV2N0tuTjNNS0lteWpxbU5iL1d5OXZT?= =?utf-8?B?dUptaml0L25JQTNjU0E3TmFLVndwdG4vdnNlRTc2YjhUN3JVQkF5SzNobW54?= =?utf-8?B?Wml3MmErcjUvNHRNYWhmSWtSK3NqaHZNS2s1QXJKWXJCYWVHUWMweUdMUkxv?= =?utf-8?Q?/mlzOPIevc0evrbmouDmXNvTa?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c0431fa4-14ee-4b90-5efa-08db2bab1f78 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2023 14:30:17.1691 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g2K9WBZGz95wtlEsKvy2L+DEocKFp2/c0QP9fS2qAcDwHl9Ewu8b/V/x2c9ZW7/5eBUmN37JnR0Mw2BAM5+EXQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7783 X-Spam-Status: No, score=-3028.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: While only a secondary issue there, the testcase of PR gas/27212 exposes an oversight in relocation handling: Just like e.g. Arm32, which has a similar comment and a similar check, relocations against STN_UNDEF have to be permitted to satisfy the ELF spec. --- a/bfd/elfnn-aarch64.c +++ b/bfd/elfnn-aarch64.c @@ -6779,8 +6779,12 @@ elfNN_aarch64_relocate_section (bfd *out /* An object file might have a reference to a local undefined symbol. This is a daft object file, but we - should at least do something about it. */ + should at least do something about it. NONE and NULL + relocations do not use the symbol and are explicitly + allowed to use an undefined one, so allow those. + Likewise for relocations against STN_UNDEF. */ if (r_type != R_AARCH64_NONE && r_type != R_AARCH64_NULL + && r_symndx != STN_UNDEF && bfd_is_und_section (sec) && ELF_ST_BIND (sym->st_info) != STB_WEAK) (*info->callbacks->undefined_symbol)