From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id 022F03858D33 for ; Fri, 2 Feb 2024 07:23:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 022F03858D33 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 022F03858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::635 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706858626; cv=none; b=jxarRPR2/oVwZSqqD/KGSbg4YDD383tpbnmfKrEi66WaH3jrr6K+7kBbFTAqHdz8IKWK++oEY9fFMJj+EdFr5lvFppGiIdw5+99guZTUO2L2bPGg5dytYIAM9eh2DT5alForB3AXna8kGUDEHHPzta2PFPxHzm6BNM6FHnoD7gY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706858626; c=relaxed/simple; bh=yXZq6NvitEAHuerUnA9pBBp9moj4zO0+tc+DbSGhR/U=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=LRcJYA7ZvXGH383I3FAbcFzFQghKV+muj1+NWgrdvGIicFwckxbyS6Yf3SO/13wvP46alZ0KExhWFec1Jybx+npx0QziR5dzgMH6rE8f/6nrBbfYRbi0ifGDF1oQhEQALz3BRJHMoS6OaulacAl0hBp/nyPRpbU3BdribDNgUIY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-a2d7e2e7fe0so92451266b.1 for ; Thu, 01 Feb 2024 23:23:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1706858623; x=1707463423; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=UWe3UF87tqIQbjblbaGVjMKcw2aqFrQwt2Rh+IrH9Ko=; b=cuyPUK3twKNPZ2Yx9nFqxt6vYgYj8Tb89b5mfUoJRDnyQs5HE03ZgdjhBmDplTME48 QcPA9Oj7XeUt1lqEDj8bs3QdZx2m35I3U/0p6WkvnqGxw5KLd4Ql5KQ/4efepF2D4u1T 6lyNLbV20sCqBkW+DM7UO7KCGjn7V3FNcYmjdv5utaY0mkUzOFoPtpfgJXiPRjtHleIE Hr6amKhLU5E4R1MxD2YDuTX2eXkcHM4e7qixXQqNW9GLDEWt7NcjtjhE4u5mYDjfyMr0 hDQXSw725XssEwdKkaMqg+YfpM+edDcnnv55aGYltLu/eDNZ3a+UGnOt6KFEJGWdVcmY wn9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706858623; x=1707463423; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UWe3UF87tqIQbjblbaGVjMKcw2aqFrQwt2Rh+IrH9Ko=; b=VeLoNkn/M4vVdRKkMDwEqqzH7HiK80t2navljuqOdnsSpjpWQd5ombhH841E9VVucb RoMvO5YNS9HHG8++tSo1dYIQF6cd3BtSK3cUVa6GdIhsVvdwDOmNtFW3NQPiRCZOE6uT 48cXXCcHjY8FbmHEWGkjO2nWPY5ztQoNu8esUNv2tvX9Tz1BZOn4PGGBSCio/QNFqQB8 wSEFXNN+lz9TlngLFaUV+xsgvqrutCarlDTPpnvE21BGvLwQan3FY/CxqHXUFuJ2ZLs2 qWItf684M8YIuuNvAiGTTruoXqBKVXtKl0456usls19+DTPzh9sxRAA3V7dWByTnaJJL 5QvQ== X-Gm-Message-State: AOJu0YxiqsLiFCBF818Sy96IZlQoPh0Zs1NtjNw/XOptjb0e7aOShodU +qfUQY3SQ/m88EBaVYV3UQ0u+I4PtXwBUisvEXblLsg405cXqRAN35gu/KAuig== X-Google-Smtp-Source: AGHT+IHXVd84n54lDI+BFO1dThjq+Ki6aAp5fuN732F4Leuym5ABMl5SEmTosJfLiXTpnthmTkrVJg== X-Received: by 2002:a17:906:e208:b0:a36:85b9:cd1b with SMTP id gf8-20020a170906e20800b00a3685b9cd1bmr1060480ejb.25.1706858623689; Thu, 01 Feb 2024 23:23:43 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCVlJL8uvrkZP716dEunIyYFbQjfNw6ZHY2JQC7So64ppc/zCkjHGlGN3hq/bRDMkJTrUuCkuhY7L5UTg9jcfIq549KRkkdBXQ== Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id rf14-20020a1709076a0e00b00a371c568978sm53435ejc.150.2024.02.01.23.23.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Feb 2024 23:23:43 -0800 (PST) Message-ID: Date: Fri, 2 Feb 2024 08:23:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86: Disallow APX instruction with length > 15 bytes To: "H.J. Lu" Cc: wwwhhhyyy333@gmail.com, binutils@sourceware.org References: <20240201224749.214439-1-hjl.tools@gmail.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20240201224749.214439-1-hjl.tools@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3025.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 01.02.2024 23:47, H.J. Lu wrote: > --- a/gas/config/tc-i386.c > +++ b/gas/config/tc-i386.c > @@ -11772,8 +11772,14 @@ output_insn (const struct last_insn *last_insn) > { > j = encoding_length (insn_start_frag, insn_start_off, frag_more (0)); > if (j > 15) > - as_warn (_("instruction length of %u bytes exceeds the limit of 15"), > - j); > + { > + if (i.tm.cpu.bitfield.cpuapx_f) > + as_bad (_("instruction length of %u bytes exceeds the limit of 15"), > + j); > + else > + as_warn (_("instruction length of %u bytes exceeds the limit of 15"), > + j); > + } Why would APX insns be different from others? IOW I continue to think that having a warning here is good enough, uniformly. And it's quite sad that with introducing APX the limit isn't raised, to accommodate all valid insn forms (not considering ones with redundant prefixes, of course). _That_ would then permit special casing APX here, in _not_ warning anymore. Jan