From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 6E465385E012; Wed, 25 Mar 2020 19:00:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6E465385E012 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id E19811E5F8; Wed, 25 Mar 2020 15:00:15 -0400 (EDT) Subject: Re: [PATCH] Support AT_BSDFLAGS on FreeBSD. To: John Baldwin , gdb-patches@sourceware.org, binutils@sourceware.org References: <20200325172548.5726-1-jhb@FreeBSD.org> From: Simon Marchi Message-ID: Date: Wed, 25 Mar 2020 15:00:14 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200325172548.5726-1-jhb@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US-large Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-27.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Mar 2020 19:00:17 -0000 Hi John, Could you please add a commit message that summarizes what this is (you can link to existing documentation) and what is the intent of this change? Are there some user-visible changes, what are they? Thanks, Simon On 2020-03-25 1:25 p.m., John Baldwin wrote: > include/ChangeLog: > > * elf/common.h (AT_FREEBSD_BSDFLAGS): Define. > > gdb/ChangeLog: > > * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_BSDFLAGS. > --- > gdb/ChangeLog | 4 ++++ > gdb/fbsd-tdep.c | 1 + > include/ChangeLog | 4 ++++ > include/elf/common.h | 1 + > 4 files changed, 10 insertions(+) > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index 5400a4e348..782e955358 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,3 +1,7 @@ > +2020-03-25 John Baldwin > + > + * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_BSDFLAGS. > + > 2020-03-25 Hannes Domani > > * windows-nat.c (windows_add_all_dlls): Fix system dll paths. > diff --git a/gdb/fbsd-tdep.c b/gdb/fbsd-tdep.c > index ffffb18700..54f5149e5c 100644 > --- a/gdb/fbsd-tdep.c > +++ b/gdb/fbsd-tdep.c > @@ -1597,6 +1597,7 @@ fbsd_print_auxv_entry (struct gdbarch *gdbarch, struct ui_file *file, > TAG (EHDRFLAGS, _("ELF header e_flags"), AUXV_FORMAT_HEX); > TAG (HWCAP, _("Machine-dependent CPU capability hints"), AUXV_FORMAT_HEX); > TAG (HWCAP2, _("Extension of AT_HWCAP"), AUXV_FORMAT_HEX); > + TAG (BSDFLAGS, _("ELF BSD flags"), AUXV_FORMAT_HEX); > } > > fprint_auxv_entry (file, name, description, format, type, val); > diff --git a/include/ChangeLog b/include/ChangeLog > index 3d26a570ca..3f3e3caa0f 100644 > --- a/include/ChangeLog > +++ b/include/ChangeLog > @@ -1,3 +1,7 @@ > +2020-03-25 John Baldwin > + > + * elf/common.h (AT_FREEBSD_BSDFLAGS): Define. > + > 2020-03-24 Martin Liska > > PR lto/94249 > diff --git a/include/elf/common.h b/include/elf/common.h > index 1c84ccb430..6741c34a00 100644 > --- a/include/elf/common.h > +++ b/include/elf/common.h > @@ -1251,6 +1251,7 @@ > #define AT_FREEBSD_EHDRFLAGS 24 /* e_flags field from ELF header. */ > #define AT_FREEBSD_HWCAP 25 /* CPU feature flags. */ > #define AT_FREEBSD_HWCAP2 26 /* CPU feature flags 2. */ > +#define AT_FREEBSD_BSDFLAGS 27 /* ELF BSD Flags. */ > > #define AT_SUN_UID 2000 /* Effective user ID. */ > #define AT_SUN_RUID 2001 /* Real user ID. */ > -- > 2.25.1 >