From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 0F52C3858D1E for ; Fri, 12 Jan 2024 12:36:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0F52C3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0F52C3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705062984; cv=none; b=N7YlVgEck4dNZekGcahi1S86b9EJbTieJsvaOQmZvhvl/hFOL4IiDwLqvi+F5W0NNUr5N9KGti0dkmgxpn7qJZQey5O5UHewJ7sg6LUqy+D9itS6GHJWStngUzbuvPE4GOriMAOtxfZWgxNAgMGPmCSu0daX0hWVTclYkkx6Qco= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705062984; c=relaxed/simple; bh=JM9E8AbIjURbJDw9D/c4O8KqigRkYbtdL8DNQr7cDUM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=CHdDHCC5MFazl9or6Btb/gcTXPtFt88dEuVKFZX6/uD3rE94BJxN679YUSKEEoU7EwN9rovrPgpTaMf55SlpZTvmGnVLQuq7mmrecOZ7I7tivPLwxTdeNjtbP/BsUpCHLuO8HAW8e3dcGaphwu2PYjMMHv4vZGu+OXpopVB2lW0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705062981; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Mxvj4/6dH2+ZiEN3T//SOFtm9e+9qcATZb1WiBYHdv4=; b=b9FNTOsKdNP08Gjd8/15wB3r1NzL1YDVc65TXT2CDtOkHQrd5yDjxWVQXU9OUBeaYam0z2 9Ydp9TAdCReTiPk07Zu1HWQ8oJsG35Nkszsj2tuPJT0nCzl3uGmlAXdUu6XRLsBwr66UP2 WenJEKa4rrvfcr9d9kHrbRqSE165148= Received: from mail-oi1-f198.google.com (mail-oi1-f198.google.com [209.85.167.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-542-coQ9ZLECNDmudrnoGrzM6A-1; Fri, 12 Jan 2024 07:36:20 -0500 X-MC-Unique: coQ9ZLECNDmudrnoGrzM6A-1 Received: by mail-oi1-f198.google.com with SMTP id 5614622812f47-3bd5882b0bcso2113247b6e.2 for ; Fri, 12 Jan 2024 04:36:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705062980; x=1705667780; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Mxvj4/6dH2+ZiEN3T//SOFtm9e+9qcATZb1WiBYHdv4=; b=Wbxa8YZA97yEgBIw+13FvxuwWsBXBeoMkW8o42Pu9MG1ZI/wwN+fRq5Ao7vnU/Sf9E QlExoKVl2S6Hvw2NxBRA6h/OayGc8b2BvaY5D8TISTYOcCfTk+b2J+Lwkl0ML4ENoWHW 55I57XbUNZCMbs2XDtFSjYHhn6QdE4Nb6ICq4MoKSjEbxFi+AX1rWIvjl9l3tztjFxqG gvMKtjLIcv/z7Rm4D0sTdq8Pkp8qKOyJ57QbswcTFQfbvaxoeqDs7sPRgITb00Zb74IU B9zQa3QAlHfQB/7ro66lwTfIW38i2h4WQEbAC4oGqYfeHcUzzdTrorhx6xGtgq0IFDnh 0EbQ== X-Gm-Message-State: AOJu0YyJwNNSoFOUi3cg2bh9wdbTY90SjhKibRqcLK7KZVm9l1lxTuem g2vWcH27IJ4LAmxClfDmEqdu1QfL75uQGZnkRF/69PqdJSQvKP5STEA23ts/P2qa/roFSdbgthd gzWQSWzv2eDtkwT5wK1w+DhqPWw== X-Received: by 2002:a05:6808:1183:b0:3bd:62f1:30b with SMTP id j3-20020a056808118300b003bd62f1030bmr499946oil.47.1705062979956; Fri, 12 Jan 2024 04:36:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IFhLE58hyXgaRyF7gXXT88fmvnPEOuZJAjKs9D4OXFql0s+F85QoGNaltClg0xPVfGJu24u+Q== X-Received: by 2002:a05:6808:1183:b0:3bd:62f1:30b with SMTP id j3-20020a056808118300b003bd62f1030bmr499940oil.47.1705062979706; Fri, 12 Jan 2024 04:36:19 -0800 (PST) Received: from [192.168.1.11] ([79.123.79.31]) by smtp.gmail.com with ESMTPSA id fe3-20020a05622a4d4300b0042994016b68sm1336334qtb.71.2024.01.12.04.36.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Jan 2024 04:36:19 -0800 (PST) Message-ID: Date: Fri, 12 Jan 2024 12:36:16 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] bpf: fix relocation addend incorrect symbol value To: David Faust , binutils@sourceware.org Cc: jose.marchesi@oracle.com References: <20240111202005.11209-1-david.faust@oracle.com> From: Nick Clifton Autocrypt: addr=nickc@redhat.com; keydata= xsFNBFm/2cUBEADkvRqMWfAryJ52T4J/640Av5cam9ojdFih9MjcX7QWFxIzJfTFYq2z+nb4 omdfZosdCJL2zGcn6C0AxpHNvxR9HMDkEyFHKrjDh4xWU+pH4z9azQEqJh331X7UzbZldqQo 16VkuVavgsTJaHcXm+nGIBTcUbl2oiTtHhmuaYxx6JTMcFjC7vyO5mLBw78wt52HBYweJ0Nj HBvvH/JxbAAULSPRUC61K0exlO49VFbFETQNG1hZTKEji95fPbre7PpXQ0ewQShUgttEE/J3 UA4jYaF9lOcZgUzbA27xTV//KomP0D30yr4e4EJEJYYNKa3hofTEHDXeeNgM25tprhBUMdbV RZpf2Keuk2uDVwc+EiOVri48rb1NU+60sOXvoGO6Ks81+mhAGmrBrlgLhAp8K1HPHI4MG4gH nrMqX2rEGUGRPFjC3qqVVlPm8H05PnosNqDLQ1Pf7C0pVgsCx6hKQB7Y1qBui7aoj9zeFaQg pYef+CEERIKEcWwrjaOJwK3pi9HFdxS0NNWYZj8HPzz/AsgTTQdsbulPlVq2SsctmOnL42CZ OCTppGYwl53CG/EqVY+UQBzFzJBaY8TJRFFYVEy5/HH4H11rMoZwqIkk71EOGU3X6mWlANRi kR3M4GhVITRzuaV69Fed+OeXcCmP94ASLfuhBR2uynmcHpBKpwARAQABzTtOaWNrIENsaWZ0 b24gKENoaWVmIEJpbnV0aWxzIE1haW50YWluZXIpIDxuaWNrY0ByZWRoYXQuY29tPsLBeAQT AQIAIgUCWb/ZxQIbAwYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQE/zvid2ePE9cOxAA 3cX1bdDaTFttTqukdPXLCtD2aNwJos4vB4LYPSgugLkYaHIQH9d1NQPhS0TlUeovnFNESLaV soihv0YmBUCyL4jE52FRoTjE6fUhYkFNqIWN2HYwkVrSap2UUJFquRVoVbPkbSup8P+D8eyd BbdxsY6f+5E8Rtz5ibVnPZTib7CyqnFokJITWjzGdIP0Gn+JWVa6jtHTImWx1MtqiuVRDapU hrIoUIjf98HQn9/N5ylEFYQTw7tzaJNWeGUoGYS8+8n/0sNbuYQUU/zwMVY9wpJcrXaas6yZ XGpF/tua59t9LFCct+07YAUSWyaBXqBW3PKQz7QP+oE8yje91XrhOQam04eJhPIBLO88g6/U rdKaY7evBB8bJ76Zpn1yqsYOXwAxifD0gDcRTQcB2s5MYXYmizn2GoUm1MnCJeAfQCi/YMob R+c8xEEkRU83Tnnw3pmAbRU6OcPihEFuK/+SOMKIuV1QWmjkbAr4g9XeXvaN+TRJ9Hl/k1k/ sj+uOfyGIaFzM/fpaLmFk8vHeej4i2/C6cL4mnahwYBDHAfHO65ZUIBAssdA6AeJ+PGsYeYh qs6zkpaA2b0wT4f9s7BPSqi0Veky8bUYYY7WpjzDcHnj1gEeIU55EhOQ42dnEfv7WrIAXanO P8SjhgqAUkb3R88azZCpEMTHiCE4bFxzOmjOwU0EWb/ZxQEQALaJE/3u23rTvPLkitaTJFqK kwPVylzkwmKdvd2qeEFk1qys2J3tACTMyYVnYTSXy5EJH2zJyhUfLnhLp8jJZF4oU5QehOaJ PcMmzI/CZS1AmH+jnm6pukdZAowTzJyt4IKSapr+7mxcxX1YQ2XewMnFYpLkAA2dHaChLSU/ EHJXe3+O4DgEURTFMa3SRN/J4GNMBacKXnMSSYylI5DcIOZ/v0IGa5MAXHrP1Hwm1rBmloIc gmzexczBf+IcWgCLThyFPffv+2pfLK1XaS82OzBC7fS01pB/eDOkjQuKy16sKZX6Rt57vud4 0uE5a0lpyItC2P7u7QWL4yT5pMF+oS8bm3YWgEntV380RyZpqgJGZTZLNq2T4ZgfiaueEV4J zOnG2/QRGjOUrNQaYzKy5V127CTnRg4BYF/uLEmizLcI3O3U1+mEz6h48wkAojO1B6AZ8Lm+ JuxOW5ouGcrkTEuIG56GcDwMWS/Pw/vNsDyNmOCjy9eEKWJgmMmLaq59HpfTd8IOeaYyuAQH AsYt/zzKy0giMgjhCQtuc99E4nQE9KZ44DKsnqRabK9s3zYE3PIkCFIEZcUiJXSXWWOIdJ43 j+YyFHU5hqXfECM6rzKGBeBUGTzyWcOX6YwRM4LzQDVJwYG8cVfth+v4/ImcXR43D4WVxxBE AjKag02b+1yfABEBAAHCwV8EGAECAAkFAlm/2cUCGwwACgkQE/zvid2ePE/dqQ/6ApUwgsZz tps0MOdRddjPwz44pWXS5MG45irMQXELGQyxkrafc8lwHeABYstoK8dpopTcJGE3dZGL3JNz 1YWxQ5AV4uyqBn5N8RubcA8NzR6DQP+OGPIwzMketvVC/cbbKDZqf0uTDy3jP65OFhSkTEIy nYv1Mb4JJl3Sq+haUbfWLAV5nboSuHmiZE6Bz2+TjdoVkNwHBfpqxu6MlWka+P98SUcmY8iV hPy9QC1XFOGdFDFf1kYgHW27mFwds35NQhNARgftAVz9FZXruW6tFIIfisjr3rVjD9R8VgL7 l5vMr9ylOFpepnI6+wd2X1566HW7F1Zw1DIrY2NHL7kL5635bHrJY4n7o/n7Elk/Ca/MAqzd IZxz6orfXeImsqZ6ODn4Y47PToS3Tr3bMNN9N6tmOPQZkJGHDBExbhAi/Jp8fpWxMmpVCUl6 c85cOBCR4s8tZsvGYOjR3CvqKrX4bb8GElrhOvAJa6DdmZXc7AyoVMaTvhpq3gJYKmC64oqt 7zwIHwaCxTbP6C6oUp9ENRV7nHnXN3BlvIgCo4QEs6HkDzkmgYlCEOKBiDyVMSkPDZdsspa+ K4GlU2Swi/BDJMjtDxyo+K0M81LXXxOeRfEIfPtZ3ddxBKPva1uSsuz+pbN9d1JY8Ko5T/h1 6susi2ReUyNJEJaSnjO5z13TQ1U= In-Reply-To: <20240111202005.11209-1-david.faust@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi David, > Relocations installed by the BPF ELF backend were sometimes incorrectly > adding the symbol value to the relocation entry addend, when the correct > relocation value was already stored in the addend. This could lead to a > relocation effectively adding the symbol value twice. > > Fix that by making bpf_elf_generic_reloc () more similar to the flow of > bfd_install_relocation in the case where howto->install_addend is set, > which is how it ought to behave. > > bfd/ > * bpf-reloc.def (R_BPF_64_ABS32, R_BPF_64_ABS64) > (R_BPF_64_NODYLD32): Set partial_inplace to true. > * elf64-bpf.c (bpf_elf_generic_reloc): Do not include the value > of the symbol when installing relocation. Copy some additional > logic from bfd_elf_generic_reloc. > > gas/ > * testsuite/gas/bpf/bpf.exp: Run new test. > * testsuite/gas/bpf/elf-relo-1.d: New. > * testsuite/gas/bpf/elf-relo-1.s: New. Approved - please apply. Cheers Nick