From: Jan Beulich <jbeulich@suse.com>
To: "Martin Storsjö" <martin@martin.st>
Cc: binutils@sourceware.org
Subject: Re: [PATCH v5] ld: Make archive member file extension comparisons case insensitive when cross compiling too
Date: Wed, 24 Aug 2022 12:29:27 +0200 [thread overview]
Message-ID: <de4513b6-a44a-8f8d-aef3-4504853849a0@suse.com> (raw)
In-Reply-To: <20220824100434.7797-1-martin@martin.st>
On 24.08.2022 12:04, Martin Storsjö wrote:
> @@ -1857,7 +1880,7 @@ gld${EMULATION_NAME}_unrecognized_file (lang_input_statement_type *entry ATTRIBU
> #ifdef DLL_SUPPORT
> const char *ext = entry->filename + strlen (entry->filename) - 4;
>
> - if (filename_cmp (ext, ".def") == 0 || filename_cmp (ext, ".DEF") == 0)
> + if (fileext_cmp (ext, "def") == 0)
> {
> pe_def_file = def_file_parse (entry->filename, pe_def_file);
>
The pre-existing code doesn't look safe here (and I did overlook the
lack of strrchr() here when writing my earlier reply). There's a
buffer underflow for file names shorter than 4 characters.
And I'm inclined to say that ".def" on its own isn't a .def-file, but
a file without any extension. (This applies to all other cases you
change as well.)
If I was touching all of this anyway, I'd be inclined to address both
issues as a "side effect" of the patch. But of course it's not a
requirement; it can easily be a separate, later patch. Or you could
also elect to switch to using strrchr() here (thus allowing code to
be dropped from the new function with callers all adding 1 to the
pointer they pass), but leave the "not really an extension" part
alone.
Jan
next prev parent reply other threads:[~2022-08-24 10:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 13:06 [PATCH v2] ld: Make library member file suffix " Martin Storsjö
2022-08-23 14:01 ` Nick Clifton
2022-08-23 14:19 ` Martin Storsjö
2022-08-23 14:23 ` Jan Beulich
2022-08-23 21:11 ` [PATCH v3] ld: Make archive member file extension " Martin Storsjö
2022-08-24 6:38 ` Jan Beulich
2022-08-24 8:23 ` [PATCH v4] " Martin Storsjö
2022-08-24 9:48 ` Nick Clifton
2022-08-24 10:03 ` Martin Storsjö
2022-08-24 10:04 ` [PATCH v5] " Martin Storsjö
2022-08-24 10:29 ` Jan Beulich [this message]
2022-08-24 10:46 ` Martin Storsjö
2022-08-24 10:46 ` Martin Storsjö
2022-08-24 10:47 ` [PATCH v6] " Martin Storsjö
2022-08-24 11:17 ` Jan Beulich
2022-08-24 12:25 ` [PATCH v7] " Martin Storsjö
2022-08-24 12:39 ` Jan Beulich
2022-08-24 12:56 ` Nick Clifton
2022-08-24 20:23 ` Martin Storsjö
2022-08-25 6:53 ` [PATCH v4] " Martin Storsjö
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de4513b6-a44a-8f8d-aef3-4504853849a0@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=martin@martin.st \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).