From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150042.outbound.protection.outlook.com [40.107.15.42]) by sourceware.org (Postfix) with ESMTPS id 4B27F38582BB; Tue, 19 Jul 2022 08:31:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4B27F38582BB ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=J4QjJhg3RYayfBiJRs9lwR+8d0iSDM8dC+0kEQpZ9iCd7/3pvqDm7wqibksh6+1/ZluSbGjhDqj48jl8qrLkysjZaeDreEMvsBE5BQlqCROPNPJjHF4uFo7Wex5sbj7sPwVbWuhR5MpPKxnvTGj8aZS+W+sZ7YpPOc/wZPbM72kmmHuemK8n+HdnOOLcSDNib1urEffP9sU0QqwrS6OhkauIjrhuTYcT4T4bZji0mnAkwkL1C0bIq3P66j1GRBsaB+InFun1GXjy9xEuXdHlFnsqOQRicSJQMKndhKLK3TO/thMw8hcZ77647eAsg9NNda2rCf9fDt0nORpEERi36g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qoOeJ3/f+fgC3jRWCoSbiMXXWaRnjr2MMaCBkxsYHUg=; b=Op3LUaTnWFVhb4fJInU2Rdj0WyH4hLjMg5VRSydGGGz1wj8qZhB339SfOpo0k0CM2hKQK1jQCFLiLljBIULJdJrhSs1/pEGHZNQGF64/jlFO4aeOhvYQKhIwPyREBezHAB4VJEl4rqUCAagARdOzPeiSde/w6T5CYs39yWfoPw6exuMB7J/rqSjCDPFJk0casALmag+iOnIFbCsRVSLaJYtqDj0Z2WjUJPh8d85HLR0D0nNB4JocsGT4cxiDPAMnPNbblSqyBdtuhhVf/sPBSUwJVrqnbDN+IU08Rxpd2OL/oV20zKTxuJpP9M3WoZ/8oJYu6QU0vUfndN/uWbclZQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from AM6P191CA0028.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8b::41) by AS4PR08MB7654.eurprd08.prod.outlook.com (2603:10a6:20b:4f0::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Tue, 19 Jul 2022 08:31:21 +0000 Received: from AM5EUR03FT056.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8b:cafe::d2) by AM6P191CA0028.outlook.office365.com (2603:10a6:209:8b::41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Tue, 19 Jul 2022 08:31:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT056.mail.protection.outlook.com (10.152.17.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Tue, 19 Jul 2022 08:31:21 +0000 Received: ("Tessian outbound fa99bf31ee7d:v123"); Tue, 19 Jul 2022 08:31:21 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: ce5ee96754706134 X-CR-MTA-TID: 64aa7808 Received: from 96c147649e32.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 227FE3FA-4999-44E7-AEAD-A9ABEC5F912D.1; Tue, 19 Jul 2022 08:31:14 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 96c147649e32.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 19 Jul 2022 08:31:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xb/oso3Mn/MwUuSLngUHAu2+1a0AIHbrqo3YKf+n4sB9dNKm/MVsdjxc8QKgKB45oFmHWn5TiA5JTukw0HtjMc0gIDdyxV5wkNjHaNXbV+HSRRibOr3ncayi5k08YB0g9RB/w5aAEX8BasdvOg/h1rw0u3sUaeLTWTJ4/9IpSf4CcUNs3Tk4jGSfY7JpGhFqtzQTossxuXO+IKsfzzgW9WorsjLjEWAB/BzysvY00uG7pD/1Lk2pC812ndxA18Ex2b5GZGLHoqv9cmRdgm3aTYsOnVUTjBeSS4YcotfiORsPYLqYJlrfmXOV3seOFcKtzPUvNv+rGXAYjvE1MphQ8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qoOeJ3/f+fgC3jRWCoSbiMXXWaRnjr2MMaCBkxsYHUg=; b=Yx3/JCy2m9RFZN3OXKLTcG1JdoifEP5Q0G+1aacF2W+sdyVtetr7uUDtTGWXKj9ToXgT+lMWMQGVHd5O9yOyGXV/EkZfdmY4Z8QxyYl29g/0b0c0HOfstKJY8QjhklqnlURfIwmJVHzAhP2DOjTrS7467+ejFVw0nCaY/WtIXhQwHRfJ3279Y3vhR/1GQDM52C2upMQ7lh4jPGgFiicavTHktQhJM0a14kr9HY23jHvVxIOxku8srwEXOJNKpwOwo649tTtf2+12cCJBn7OzHy6YyCZeMOoZ7+Zw+XayrF2kx/6lx2AwIcYuBH/qszXlM4jcl07RFskcRhCMb0dnJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3390.eurprd08.prod.outlook.com (2603:10a6:803:7d::27) by PAXPR08MB7230.eurprd08.prod.outlook.com (2603:10a6:102:1da::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Tue, 19 Jul 2022 08:31:13 +0000 Received: from VI1PR08MB3390.eurprd08.prod.outlook.com ([fe80::65f1:3b3b:c8ba:be81]) by VI1PR08MB3390.eurprd08.prod.outlook.com ([fe80::65f1:3b3b:c8ba:be81%5]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 08:31:13 +0000 Message-ID: Date: Tue, 19 Jul 2022 10:31:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] toplevel: Makefile.def: Make configure-sim depend on all-readline Content-Language: en-US To: Hans-Peter Nilsson , Luis Machado Cc: Hans-Peter Nilsson , binutils@sourceware.org, gdb-patches@sourceware.org References: <20220308192128.A2D462041A@pchp3.se.axis.com> <89285421-e99a-ec59-b913-8d7b95b0ee87@arm.com> From: Christophe Lyon In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0643.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:296::10) To VI1PR08MB3390.eurprd08.prod.outlook.com (2603:10a6:803:7d::27) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: d6f9c664-24d7-468b-be61-08da69610f43 X-MS-TrafficTypeDiagnostic: PAXPR08MB7230:EE_|AM5EUR03FT056:EE_|AS4PR08MB7654:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: FX0/wEiBuBFwK81fnHI1G/UgT960GGF94l7yNzBWkSEV3ddD+wZiIavZJfRGhcXcKRDL4GVpJkAdugfQdK6H+tiDAG52GU2q3+DTycxes+RuwkACxnSX04CEG3fhJyJSxNmu0rQqlzzYCh892S6592dZvWiI9RHMqW+UVSuzzApqn0F/uhiNlpEhMG7npJSykgwc7oTH4dwJtOSCkj3RQJEPnxl7uFQ4retmJ+YDD/453JMvclQ1UUIuLktIggHo0sYLuvUpN4xbsD+8xCZpBxZddK78wyflV0s3kotILonRLorHUR8wplinnKC/6tcqhpRc37+EqNeHCQ9VxFdQmVUXWQJxLcr/1I30afhGSN+rJ2Ndq38EqbY8kGMdExH7BKKAhlpX19PCJx4AWlcSCRqaHtnEDN/FbH8e79zRb3LuVuYoYA5Onu54HCB5CLAD3oX4DzG3dQBqiDK+ni5hKNHNKXX1lOG8/vaGsX6A4eD5VPukV87swAs0I6yn46bw1DWTTTJO3U010NjvivdNrFlJv8zpjBiDQ75vjNw6jO7zNr3O5Gaw3hLbXG8ZPNl8qhkpxZzip8UepU/p/p7+ZI3sC4gaH2mXfUs0CqRQwlbzn9G/2LpIWc1zKAHbb7OsRqQxnGgE//PECqKgBPRV1NyHYH+7c5CNdlVhayKr33Why/tt0tmfCu9PWszU2KBqwk7YeC/f9MMNWiDewIEB+O8cgdGb5xDix0ksytsFXSKgDrUUedzGMurJnhwPam/DUe2u4CRFcKYhoeWRfhkVZ00nt2LHa7lAJULOlSmjDxrySHGRDAHoVZUQd3l1v05ltRV4tKkb5miC/tJc7vHAZQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3390.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(376002)(346002)(396003)(366004)(39860400002)(136003)(478600001)(2616005)(6636002)(6486002)(6506007)(86362001)(316002)(41300700001)(31686004)(26005)(83380400001)(31696002)(6512007)(53546011)(110136005)(66556008)(66946007)(5660300002)(8936002)(44832011)(8676002)(66476007)(186003)(36756003)(2906002)(4326008)(38100700002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7230 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: feb3f77d-e99f-4ea2-7a80-08da69610a3d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fiNwjjMd9djcmoCtJ7RIrtcgcZaQy6ambfhcG4Bu39CzVRiA+Lw/NBqlDAAepD1K6LLwUdxqs8kaKqFClhRx216C03td7gdIB1xHx1+jFV/QMNkvjPmN2eaxZg5Pzk5XrYVPOkZ6ks1r46ZZTRNAKnzQBG29+/RofjRYA6H18adkjkupXkH/0YaR1Xziw408pykLGmlKmMWUc9DaU8ObGFUQ+sMNHl3h+X8CQxRu1iAQJATZPiEUu6tVv5k2jK07cqZZz4/x1vsvPzKwbR4XLhz0Aejr/LnnJqO7/3BzKO4ZJ0knMuBwUi1hZPIK21rtOmzzTj/QEG2Ya6KL+C9I+QhRIE9O40PcRt9MD1zO4VlM8s9DYlski1m67ghUiskmEQ/GxVaTkOOEnWAnx9ZlGMpwmUBQ4uzDFLvYc+sUsO2UIpfdyfyQ/B5zgYy6fwVSWmfniIwQ+6e+5l1utMIPgmd3F3wgKctx6hNjso1eBn0JXu3eqUFRuDsGzhs2lqpgfRjeWsV87tpYpib/4aDgZ2FofJA4RIwvMIYbkgxng4L/3lT2+xDg+PCIfRDlNZcCTAy1gf0DA8ZPzwex7uf64qJ159oXr23uxSt1WjBM4+cWem85jmpx8W3q9FTb3t9ns3HTSTmreWsXQojwcFSa0yEw0C4Z2Yhbh9+OaNNlVeibpROS9kdPfnE3f1P6LFb7ixVZyv9fNalBGRf2s63TnuEKeJ0JMF7kcd6QNCz3jAhA0RtL6EnOKtFegD06PNZaTWIEjXYTP5d/aTeZzH0Q8nKAJb+QkVSb+K+QiWjdmIwykTh5gmssfhfXl39pUMfsKOPjFq7TwlkACy1qhlMHcQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230016)(4636009)(376002)(346002)(396003)(39860400002)(136003)(36840700001)(40470700004)(46966006)(81166007)(356005)(82740400003)(450100002)(47076005)(40480700001)(70206006)(4326008)(8676002)(5660300002)(2906002)(8936002)(31696002)(86362001)(44832011)(336012)(186003)(2616005)(6636002)(478600001)(83380400001)(53546011)(70586007)(6486002)(6506007)(26005)(82310400005)(316002)(110136005)(6512007)(41300700001)(40460700003)(31686004)(36860700001)(36756003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 08:31:21.4407 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d6f9c664-24d7-468b-be61-08da69610f43 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7654 X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jul 2022 08:31:31 -0000 On 7/16/22 00:20, Hans-Peter Nilsson wrote: > On Tue, 12 Jul 2022, Luis Machado via Gdb-patches wrote: > >> Hi, >> >> On 3/8/22 19:21, Hans-Peter Nilsson via Binutils wrote: >>> Calling on "global maintainers" as per toplevel/MAINTAINERS >>> for "Makefile.*". >>> >>> Ok to commit? >>> >>> (If so, I'll also commit this change to the gcc repo, where >>> this dependency is normally unused, i.e. when source trees >>> are kept separate.) >>> >>> brgds, H-P >>> ----- 8< ----- >>> >>> Without this, a "make all-sim" without the equivalent of >>> libreadline-dev installed on the build system, won't >>> properly pick up the in-tree readline build, and you'll see: >>> >>> mkdir -p -- ./sim >>> Configuring in ./sim >>> configure: creating cache ./config.cache >>> checking build system type... x86_64-pc-linux-gnu >>> checking host system type... x86_64-pc-linux-gnu >>> checking target system type... cris-axis-elf >>> checking for x86_64-pc-linux-gnu-gcc... gcc >>> checking whether the C compiler works... yes >>> ... >>> checking for library containing tgetent... -ltermcap >>> checking for readline in -lreadline... no >>> configure: error: the required "readline" library is missing >>> make[1]: *** [Makefile:11188: configure-sim] Error 1 >>> make[1]: Leaving directory '/home/hp/sim/b' >>> >>> The sim dependency on readline is apparently (nominally) >>> valid as there's a readline call in sim/erc32/sis.c. >>> >>> 2022-02-21 Hans-Peter Nilsson >>> >>> * Makefile.def (dependencies): Make configure-sim depend on >>> all-readline. >>> --- >>> Makefile.def | 2 +- >>> Makefile.in | 2 +- >>> 2 files changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/Makefile.def b/Makefile.def >>> index a504192e6d72..8181a7aa97b5 100644 >>> --- a/Makefile.def >>> +++ b/Makefile.def >>> @@ -570,7 +570,7 @@ dependencies = { module=all-sim; on=all-intl; }; >>> dependencies = { module=all-sim; on=all-libiberty; }; >>> dependencies = { module=all-sim; on=all-bfd; }; >>> dependencies = { module=all-sim; on=all-opcodes; }; >>> -dependencies = { module=all-sim; on=all-readline; }; >>> +dependencies = { module=configure-sim; on=all-readline; }; >>> // Other host modules. >>> dependencies = { module=all-fastjar; on=all-zlib; }; >>> diff --git a/Makefile.in b/Makefile.in >>> index 2b77a4706947..843e150dac63 100644 >>> --- a/Makefile.in >>> +++ b/Makefile.in >>> @@ -63072,7 +63072,7 @@ install-strip-sid: maybe-install-strip-tcl >>> install-sid: maybe-install-tk >>> install-strip-sid: maybe-install-strip-tk >>> configure-sim: maybe-all-gnulib >>> -all-sim: maybe-all-readline >>> +configure-sim: maybe-all-readline >>> all-fastjar: maybe-all-build-texinfo >>> all-libctf: all-libiberty >>> all-stage1-libctf: all-stage1-libiberty >> >> I still see this, even with this patch applied. It seems sim requires >> libreadline-dev regardless. >> >> Based on the commit message, I'd expect that to not be the case anymore, >> right? > > That patch should have fixed occurrences of that particular > error. You saying "libreadline-dev" rather than "libreadline" > makes me think your error is different, kind of like half-way > picking up libreadline-dev from your system rather than the > sources. Either way, sorry, I have no clue ...unless you > configure with "weird" options like --disable-readline (in which > case the solution is "don't do that, then"). > I ran configure with --enable-targets=all, then 'make all-gdb', which fails to link sim in erc32: /usr/bin/ld: ../../readline/readline/libreadline.a(display.o): in function `_rl_move_cursor_relative': /tmp/mygdb/build/readline/readline/../../../binutils-gdb/readline/readline/display.c:2805: undefined reference to `tputs' [...] This is because there's none of termcap tinfo curses ncurses installed on the machine, which leads to TERMCAP_LIB= in sim/Makefile If termcap is actually required by sim, shouldn't configure fail if it is absent? Thanks, Christophe > brgds, H-P