From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2060.outbound.protection.outlook.com [40.107.21.60]) by sourceware.org (Postfix) with ESMTPS id CAFB13834E4D for ; Wed, 22 Jun 2022 06:23:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CAFB13834E4D ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MkWJQHn9HAEQxuB6MADte/S+LQ9FQmz/4Eldb1AXZlxo3PDj3d9xgqQI2oqi+R9WZEvyR0s8GWhHEhBOoRtdEiRe3mKbqZpOfQrsRAnOGlO1OjPpRzzom+nofjd2XpXN2+GnGDnwCUVGKpdMu0oTs6w6roCDBRRq6+6SrFSVW7WRUTJOnTNAEDyCb1GhzLRRSLmu24G9UV3Z/RSqCs6vUomXbDa/j71TkmTcXMo/t9rvX1PVnHzj1mXC3eoprvssS9p8q9IjxX1QjoHYetCKi8sTMJG2lImZOTn//0hRan/GxQq2ncLS3MqnI/k8qnGIj8W35ht11qKxNgb2OiLzlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BJFtP8bv89dpkp7pTkiT6kM8bPeBVOXkpYJPF3RLkWs=; b=c8TK583/5MqVc5nLb0PzUaYo6GL1B6lDCGLsiaj+X/PHzzKcO+3w95QMjfYJYQH4WPoIzAv1Rmt27eHtBdPTzDCgY7090oC8HzhEHs9OH3gDMne5ed4hJM/XahI3SJxpWQeMJSICpzELww9lJKy58K/jh+CpoJ8TS8H6q2d6IriejFVX/OQIkr+KOc0QCuzO9K10BKPrq8W8nLRZpMuTkwsZooeJEAvOqyFZEISn9lsYSZNEamLPCHbLOEvNLlxKl+vhXiN7ue+PdnCxBA7ebV2y+hC6sqUZWDnLwVwsUsL9EADpjxSbcH2R5ElK3c8+g9FUGMIC3IFkBpfGAMlACw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8949.eurprd04.prod.outlook.com (2603:10a6:10:2e0::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15; Wed, 22 Jun 2022 06:23:09 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5353.022; Wed, 22 Jun 2022 06:23:09 +0000 Message-ID: Date: Wed, 22 Jun 2022 08:23:11 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] x86: drop print_operand_value()'s "hex" parameter Content-Language: en-US To: Michael Matz Cc: Binutils References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P191CA0097.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8a::38) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 598bc140-5fdc-46b2-d383-08da5417ad14 X-MS-TrafficTypeDiagnostic: DU2PR04MB8949:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7cRbzXAogdp4NBkSbvLFwKWF8hstxZkXCgOytP9oRBIB655LtE5dxExfWIMceZDZcUw2DU6Krr0dJI66DL2UqxoaQOQQkwkE+xkcaddQ6VaAN2Elr783WxssUjDwaU+H6EYFDEYoCl3dP9xDm9Oj+5pRezsMQ6ELlZehz9bn7HJWNpM2gaOMB0k9AeB3L8W24PWM7RXocXS12bspzLG8OEhI+61icPGcK3MPC6KDhJ3xygTw17yDMPqmmQ/K8ptmonqaiqyKsCoHsQDDu1hN8KH6ph84W3ISTOzdCQrMNloWrdLmG/UpmAcL7jws8uVO7RaOR9zOpOJcxO7Fo3h3rSQOPadCIblcdR1hr1zsTh7qJbjfh3BT2h5gNniWAZwvqo1RGPEmJkMeS80rVTJhGpx5sBDa9uh9rviX/9YkH1e6NUbudVn0rwwK02T1X17f299Yut//IP/6ZAwX0GKQ2rXypXAGHW9W7Ms2RjpRKw5EmPXFb6tLVrZoyPlUkL43yJ/TKUZO2lYjCdbskVgZ89oh+luYmzgHFEIB8zfOni4xCrW0khbF6XB8O2kqbigXgox3f8sk4DxrXo5GVkLvu2aKCTH6+slHmK+Hz6sWUtmvkVMAZ/tjI646QC+ASFhzL+DE6LyS9XRS3ONrTCdk2KbSlEbPBfJiTfImIIP++Eed8fr6McS2Q4Pbxf+oDEmhzHiz5SRlF9wtnMuULynR45uVzG7DlN6bAYGOwQfEL3PI5fyWp/CvPnqTAo4QZuB3u39DZB5vjZCpZ9jFuTeO7IYVCH5XDA3stw08blwt38Q= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(376002)(346002)(136003)(366004)(396003)(39860400002)(6512007)(316002)(6666004)(478600001)(6916009)(41300700001)(26005)(53546011)(6506007)(6486002)(8936002)(2906002)(66946007)(4744005)(66476007)(8676002)(4326008)(66556008)(31686004)(5660300002)(2616005)(31696002)(38100700002)(86362001)(36756003)(186003)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cld1SStlZ0E4ZmZWOVlZWnB3KzRxK3UyY0NrVDhVTDZIeHJtaFVNV0ZFcStO?= =?utf-8?B?QnRZbEZRTGVNWUJ2RUVxZCtjckFoUC93STJWejV0dWJsU3E4VlVwVDUyczht?= =?utf-8?B?VnFPWkpseU91MDlUbzNmTmVnSUJhNkFQN21mWG1SL2FxZ0Z4VElhOVBlUVpC?= =?utf-8?B?TmgyaHl6L2YrQVJvZ3VrQWhUN1ZuVzBrdW1PcTc4ZEhtVDRqMHZXdXQ2cXhu?= =?utf-8?B?NnlPSnN3Z0M4SjYxZU5oNnhYY3NORjNVL3gxTUo0VlZaSUFMUXM1MXVJVGR0?= =?utf-8?B?WHU2YU13aXNFejA3Nm9wcjRwMVF0dWYrT3RyK1RGL3cxWnk5bUF4NG42aXNi?= =?utf-8?B?aGVBaHA4WTFWdFBDVDNoS09UWmh4SzB0NlVjU0Izdzhsb3RmRUN1bkx3VjR0?= =?utf-8?B?SnM3eDJiYWYrbTFuZTd5NmxHU0E5WC8vNTJYd2h6R3hGZ2ZKUU5YZXdNYnFn?= =?utf-8?B?Y28yaGpTbVd4NjFXaVdNOCtBR242bzNYOWFrelpMdm8wWmdZYmtSYzRzWjZk?= =?utf-8?B?YWVLeFpacSt3V0dMWmdTOEJRT3VzNmtpaVQrb3VuNFpCdmgvazN5eldwWUdp?= =?utf-8?B?TldwSGNmSUc4VmpkTkdVVFBYU1BEMTRmeFJmTTZBRTE3UERPNUZiVDk1Ulov?= =?utf-8?B?RFNaZFUzb1NyanROOWRhSDNaK1lTdlFVS2ZEVkhBWDZheTJkQTBBdDNFdEQ4?= =?utf-8?B?RWhSamVRaU1UVzh0b3hFV0lqbGFPVnQrZUFHamtlNEFrV1ZNT1ZkNHE1NytI?= =?utf-8?B?Yk9MRUxaR01BRnh0d1VldHFlakdSY1JtUWhTMHJBci95SDAvNlk3RXNIeGtU?= =?utf-8?B?ZHdOTXcxenovRmFoeEpENGtvN25pUmVCd3Budmc4UWUyTnlBZmlYUDVrNGM3?= =?utf-8?B?a1I4RUVWdTRGNjZSRGtIMm1vUUlSdC8rTzlhczlOSENMZjJpeVQ3YjRvVEtC?= =?utf-8?B?ZVFjMlZOTDFCbkdDY1dBTk9lWlZWTnZmdk1tODBJc1ZOcW14RWRuL0c4M2Vt?= =?utf-8?B?OSt3RUhEVFVhRlFVYis4YVpiS1lnaERpbkJJSGdzSTRab1g0TUxjMVIySTEr?= =?utf-8?B?b3N2TEtQUUFWK2JWMmFBNUpxbGxvQXlXVWs5K1BzMkNBTzRnS2pDQXh0R2J6?= =?utf-8?B?TGREQnVsNWdkVUcrUGdkNXlHTjQ3TVpKOTkzcmo1SExwT0ZXU3BuYXJ6QXZG?= =?utf-8?B?SFcybzQ5dWVhVGVybnNoTVBOanhkTEMxRUxZamNya0VQNFZFWXNhUTZUL3hB?= =?utf-8?B?ZU4wZEl2b0FWODZRNyt3QjRtQjNrbFBEMTN6alkzTkJ0VFRTZm5yaUpUbjc4?= =?utf-8?B?QXg4VCtGbEtyZnR4dHRqcFRyUHNWajBUVHErMGFtZDFxWlNreXBwREZCN2o3?= =?utf-8?B?VHB4VzFuU0RldGlZUzlDczV2Tzc4ZHdIZTRGRVlYNzZCSjhpOUQ4cmk4QnU5?= =?utf-8?B?QUZuSWxiNFZPdGVUZ1FRRlllN3FpQS9aMXp0NGpwdzBra25uTXh2NVJiZkp3?= =?utf-8?B?MFBTREphY1JXYTNnNi9wc2t0TFNEOEVCRlNEMks5eWdta01BNlUxUEtsTXZD?= =?utf-8?B?NVBvSTIyZ2p6UVAzemhxSXZITi9UWjhuMHVNdURFVVdOSlBKNE14aVVzOTJH?= =?utf-8?B?eHNnMjFMVm5wVkVjcDBjSlZJeTF4SGtwcmVNWG5LcEVoNmk3NHhCOCt5UnpE?= =?utf-8?B?VXViU2FFV0FLazFxL29SL3JQNGh6b2RHYkNReXVYamRldUhvaEUxK3VrZXhP?= =?utf-8?B?ZE95bGpzMWxKdG93SWl0V2U0SGlFdnZGUGVXMURBcUFjbGUxV24xOENDc2lX?= =?utf-8?B?ZUJSbW1xcExDN3NrRlRjNE1rVlBicC95SXMxWTByalUxeWlzaEExQ1dNZGk0?= =?utf-8?B?b2NZQTJja2F4dzhBa08ycWNsUXJZbWVwRW9YbWdqb21xTmhFdytUM0VOczNO?= =?utf-8?B?VWFibzhkZ0I3RzF2Z2lMNTFnVkxvaktpTXYzdWU1MHZ5TVlBREVwN2daSng4?= =?utf-8?B?bnJ1eEU0NDVVRnlaWGNHZGdTVjZxUFpTMXUvc25RNkY1aW80SEdPblpyTXFn?= =?utf-8?B?U0Uwd094L0xhanRVaVh0WWFucXJKdy9PY0FFWlN4aURCeWh1UGZyUW5rRDBX?= =?utf-8?B?V0VUK3VEam1sUmVWMjB1aTdZNHN4d3dsZVZWMElVQm5paDZqbTNJdUVGMzZa?= =?utf-8?B?Smd5ODJOdlVaMDVqVmZGenhXMU9tdGZxMlhHbWt3NXRaVTNLbFA3U0cvaExZ?= =?utf-8?B?K211SHo2d2l5VXRtYVluRWhLcVFlY21YRmd5dkM4NHp2dmZXUHhtWVcwWDNE?= =?utf-8?B?cnhESjZJMVh4TjdGRjF0WFV1N2YyZ25RbzlZS0kyL2JOTjBvM2JGdz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 598bc140-5fdc-46b2-d383-08da5417ad14 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2022 06:23:09.3963 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aOIXumAkIeSgEEqnnb9O8OvBjkEJwuYPAduKWykl/adKwu5pOI+fUcS7nGCnvELnOOck4SP3ovXAKnR1DK9Kgg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8949 X-Spam-Status: No, score=-3030.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jun 2022 06:23:13 -0000 On 15.06.2022 17:07, Michael Matz wrote: > On Tue, 14 Jun 2022, Jan Beulich via Binutils wrote: > >> For quite some time all callers have been passing 1 / true. While there >> fold the final oappend_with_style() calls. >> --- >> Instead of 0x%x I could see us using %#x, thus printing at least zero >> without the redundant 0x prefix. Thoughts? > > As you're asking for opinions, here's mine: in this case I think > consistency is better, I think there's no obvious reason to print > 0 but 0xa (for instance) > and not > 0x0 and 0xa > Sure, it's redundant, but IMHO that doesn't trump consistency. I see. Yet my point isn't merely consistency, but also readability. To me at least 0 is more easily recognizable as "zero" than 0x0. Indeed I would go as far as saying the same for 1...9 as well, just that there we'd need custom code whereas for 0 we have an easy way to omit the leading 0x. Jan