From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-96489-listarch-binutils=sources.redhat.com@sourceware.org>
Received: (qmail 64689 invoked by alias); 6 Apr 2017 16:22:45 -0000
Mailing-List: contact binutils-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <binutils.sourceware.org>
List-Subscribe: <mailto:binutils-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: binutils-owner@sourceware.org
Received: (qmail 64166 invoked by uid 89); 6 Apr 2017 16:22:44 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Apr 2017 16:22:43 +0000
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 1C6A84E4C5;	Thu,  6 Apr 2017 16:22:44 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1C6A84E4C5
Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=nickc@redhat.com
DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 1C6A84E4C5
Received: from [10.36.117.34] (ovpn-117-34.ams2.redhat.com [10.36.117.34])	by smtp.corp.redhat.com (Postfix) with ESMTPS id 8C2119E26E;	Thu,  6 Apr 2017 16:22:43 +0000 (UTC)
Subject: Re: [PATCH] [WebAssembly] Disassembler support
To: Pip Cet <pipcet@gmail.com>, binutils@sourceware.org
References: <CAOqdjBcc-R_Ba1yQoMddgijbFickSmWEn4zwYTokVrbYfD1Vig@mail.gmail.com>
From: Nick Clifton <nickc@redhat.com>
Message-ID: <df0250c1-8c7e-1003-682d-67857793e57a@redhat.com>
Date: Thu, 06 Apr 2017 16:22:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <CAOqdjBcc-R_Ba1yQoMddgijbFickSmWEn4zwYTokVrbYfD1Vig@mail.gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2017-04/txt/msg00061.txt.bz2

Hi Pip,

> opcodes/:
> 2017-03-31  Pip Cet  <pipcet@gmail.com>
> 
>     * Makefile.am: Add wasm32-dis.c.
>     * configure.ac: Add wasm32-dis.c to wasm32 target.
>     * disassemble.c: Add wasm32 disassembler code.
>     * wasm32-dis.c: New file.
>     * Makefile.in: Regenerate.
>     * configure: Regenerate.
>     * po/POTFILES.in: Regenerate.
> 
> gas/:
> 2017-03-31  Pip Cet  <pipcet@gmail.com>
> 
>     * testsuite/gas/wasm32/allinsn.d: Adjust test for disassembler
>     changes.
>     * testsuite/gas/wasm32/disass.d: New test.
>     * testsuite/gas/wasm32/disass.s: New test.
>     * testsuite/gas/wasm32/disass-2.d: New test.
>     * testsuite/gas/wasm32/disass-2.s: New test.
>     * testsuite/gas/wasm32/reloc.d: Adjust test for changed reloc names.
>     * testsuite/gas/wasm32/reloc.s: Update test for changed assembler
>     syntax.
>     * testsuite/gas/wasm32/wasm32.exp: Run new tests.  Expect allinsn
>     test to succeed.
> 
> include/:
> 2017-03-31  Pip Cet  <pipcet@gmail.com>
> 
>     * dis-asm.h: Add prototypes for wasm32 disassembler.

Approved and applied.

Note - there was one problem:

> +static void
> +parse_wasm32_disassembler_options (struct disassemble_info *info,
> +                                   char *opts)
> +{
 
The second parameter to this function is a const char * not a char *.
I fixed this as part of the check-in.

Cheers
  Nick