From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 983EF3858D37 for ; Wed, 22 Nov 2023 12:13:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 983EF3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 983EF3858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700655189; cv=none; b=EQvLAXmBrkOmqSk2dT6nA4nuL7URI+r0T5hS2v+/qHEDG1Ice2cf/CLl43iSOnXu6cmhaG98J+ipuhfktgj2H6GXWMnZO2Sqy/or6L//QIAhTTP3d33CACeFrBwc7bZz+HA1bN+OhEGXl1/T7EjMfwZA6lxDkOCKhEK4EOK7lrU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700655189; c=relaxed/simple; bh=qRfPRkzAyDeHSzQDowbuJ1OLSvpMXXEQ2NXD5PDEAgA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=ALytlqqBRmaFqCADuK09lM7z3ze5jPKHqWEiEa7ZGUdDyt4gWuPF8cHSgX7Cc32Kc9Oa2OOmQ1F3FSfMiv4GO1fDSEwkuhS7wGWd33DJl0wXlWOhoZNWl+6tAsvkGISKluH1rtg8aYObXuR//fAi8EJ4HtJmTtoem7CbqHHucdU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700655187; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=nsv2sfGD9Krv2ZvvJt0VUgTGU/9T4l/0ipcDk2m48aQ=; b=X1TzURyoyDEp1sJJmbAzCAo2OSL8MAj71BTwEpMn3DvKYbgI4BVKMydJU3/PROxguavtnk eu56kIuiKiT0A0qTyO1iEOldakz74hL0FniU/PbQ7UxmRBCI1CEO+O0xHqltBnNzIX9VRR ZQGTDGSZtSxNf8g8QHecHuFf+R7i+MA= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-583-Ff3Ro1MWMxKx2NJ47aobmQ-1; Wed, 22 Nov 2023 07:13:06 -0500 X-MC-Unique: Ff3Ro1MWMxKx2NJ47aobmQ-1 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-77d5f054f43so154970985a.3 for ; Wed, 22 Nov 2023 04:13:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700655185; x=1701259985; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nsv2sfGD9Krv2ZvvJt0VUgTGU/9T4l/0ipcDk2m48aQ=; b=PAY1qtvzvceGUWVkERenA5vko1PkcVRCHXrqUVNygwiZtZPq7vaaSHMEkFkLpYwNlN ZOx2WENzgqRAVjGcFGHCX282fC9XqRbCQbl0/IGdME8drYwOyMLF7vkkU5fJAvynDdK2 lLfQYu6fu8Cx8n1exPOaYdK9dJRO5rm1PeEORED6g5otNs3qs/9nurl85OJDP+GrqCxU LgqnZPlilkORAZn3JehCBbp2/qXpVnGXHkqIuv5qxL2zxkyj9rnfIaLB7oJ9dWl0dwiM Ucvypiw+dZFRv6JdJKVW5f2ufDE/VH+qw6lAe3SC7NHLZUSQ39LIqKC+6CsC1qjYDbdQ grGg== X-Gm-Message-State: AOJu0YyASZ9Gwkq1ZzqiEr5hS5n+ekslM+X994+chXmIhcwSdB47YQug jjUGXFXeXEMJyZS/+mCBnnKNn4hQvbeODajZA8GE4o815I7jH+btz/TEu7dNfK9ipO4fOgjRLeB 4U+L0xrcNqSP8ATKQ8Zm5SBIzgw== X-Received: by 2002:a05:620a:8f84:b0:774:35da:75ac with SMTP id ri4-20020a05620a8f8400b0077435da75acmr1759442qkn.55.1700655185325; Wed, 22 Nov 2023 04:13:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IGYlBxrgKYCNZXcpGbDtt4+m5D+M3zq+J/Bt5k6UxbrCbRkh4QIayU2E0z4rkA9qN0bkqHCfA== X-Received: by 2002:a05:620a:8f84:b0:774:35da:75ac with SMTP id ri4-20020a05620a8f8400b0077435da75acmr1759430qkn.55.1700655185094; Wed, 22 Nov 2023 04:13:05 -0800 (PST) Received: from [192.168.1.11] ([80.168.197.243]) by smtp.gmail.com with ESMTPSA id b27-20020a05620a271b00b00767da9b6ae9sm4427193qkp.11.2023.11.22.04.13.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Nov 2023 04:13:04 -0800 (PST) Message-ID: Date: Wed, 22 Nov 2023 12:13:02 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/6] s390: Add missing extended mnemonics To: Jens Remus , binutils@sourceware.org Cc: Andreas Krebbel References: <20231120140635.3642601-1-jremus@linux.ibm.com> From: Nick Clifton Autocrypt: addr=nickc@redhat.com; keydata= xsFNBFm/2cUBEADkvRqMWfAryJ52T4J/640Av5cam9ojdFih9MjcX7QWFxIzJfTFYq2z+nb4 omdfZosdCJL2zGcn6C0AxpHNvxR9HMDkEyFHKrjDh4xWU+pH4z9azQEqJh331X7UzbZldqQo 16VkuVavgsTJaHcXm+nGIBTcUbl2oiTtHhmuaYxx6JTMcFjC7vyO5mLBw78wt52HBYweJ0Nj HBvvH/JxbAAULSPRUC61K0exlO49VFbFETQNG1hZTKEji95fPbre7PpXQ0ewQShUgttEE/J3 UA4jYaF9lOcZgUzbA27xTV//KomP0D30yr4e4EJEJYYNKa3hofTEHDXeeNgM25tprhBUMdbV RZpf2Keuk2uDVwc+EiOVri48rb1NU+60sOXvoGO6Ks81+mhAGmrBrlgLhAp8K1HPHI4MG4gH nrMqX2rEGUGRPFjC3qqVVlPm8H05PnosNqDLQ1Pf7C0pVgsCx6hKQB7Y1qBui7aoj9zeFaQg pYef+CEERIKEcWwrjaOJwK3pi9HFdxS0NNWYZj8HPzz/AsgTTQdsbulPlVq2SsctmOnL42CZ OCTppGYwl53CG/EqVY+UQBzFzJBaY8TJRFFYVEy5/HH4H11rMoZwqIkk71EOGU3X6mWlANRi kR3M4GhVITRzuaV69Fed+OeXcCmP94ASLfuhBR2uynmcHpBKpwARAQABzTtOaWNrIENsaWZ0 b24gKENoaWVmIEJpbnV0aWxzIE1haW50YWluZXIpIDxuaWNrY0ByZWRoYXQuY29tPsLBeAQT AQIAIgUCWb/ZxQIbAwYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQE/zvid2ePE9cOxAA 3cX1bdDaTFttTqukdPXLCtD2aNwJos4vB4LYPSgugLkYaHIQH9d1NQPhS0TlUeovnFNESLaV soihv0YmBUCyL4jE52FRoTjE6fUhYkFNqIWN2HYwkVrSap2UUJFquRVoVbPkbSup8P+D8eyd BbdxsY6f+5E8Rtz5ibVnPZTib7CyqnFokJITWjzGdIP0Gn+JWVa6jtHTImWx1MtqiuVRDapU hrIoUIjf98HQn9/N5ylEFYQTw7tzaJNWeGUoGYS8+8n/0sNbuYQUU/zwMVY9wpJcrXaas6yZ XGpF/tua59t9LFCct+07YAUSWyaBXqBW3PKQz7QP+oE8yje91XrhOQam04eJhPIBLO88g6/U rdKaY7evBB8bJ76Zpn1yqsYOXwAxifD0gDcRTQcB2s5MYXYmizn2GoUm1MnCJeAfQCi/YMob R+c8xEEkRU83Tnnw3pmAbRU6OcPihEFuK/+SOMKIuV1QWmjkbAr4g9XeXvaN+TRJ9Hl/k1k/ sj+uOfyGIaFzM/fpaLmFk8vHeej4i2/C6cL4mnahwYBDHAfHO65ZUIBAssdA6AeJ+PGsYeYh qs6zkpaA2b0wT4f9s7BPSqi0Veky8bUYYY7WpjzDcHnj1gEeIU55EhOQ42dnEfv7WrIAXanO P8SjhgqAUkb3R88azZCpEMTHiCE4bFxzOmjOwU0EWb/ZxQEQALaJE/3u23rTvPLkitaTJFqK kwPVylzkwmKdvd2qeEFk1qys2J3tACTMyYVnYTSXy5EJH2zJyhUfLnhLp8jJZF4oU5QehOaJ PcMmzI/CZS1AmH+jnm6pukdZAowTzJyt4IKSapr+7mxcxX1YQ2XewMnFYpLkAA2dHaChLSU/ EHJXe3+O4DgEURTFMa3SRN/J4GNMBacKXnMSSYylI5DcIOZ/v0IGa5MAXHrP1Hwm1rBmloIc gmzexczBf+IcWgCLThyFPffv+2pfLK1XaS82OzBC7fS01pB/eDOkjQuKy16sKZX6Rt57vud4 0uE5a0lpyItC2P7u7QWL4yT5pMF+oS8bm3YWgEntV380RyZpqgJGZTZLNq2T4ZgfiaueEV4J zOnG2/QRGjOUrNQaYzKy5V127CTnRg4BYF/uLEmizLcI3O3U1+mEz6h48wkAojO1B6AZ8Lm+ JuxOW5ouGcrkTEuIG56GcDwMWS/Pw/vNsDyNmOCjy9eEKWJgmMmLaq59HpfTd8IOeaYyuAQH AsYt/zzKy0giMgjhCQtuc99E4nQE9KZ44DKsnqRabK9s3zYE3PIkCFIEZcUiJXSXWWOIdJ43 j+YyFHU5hqXfECM6rzKGBeBUGTzyWcOX6YwRM4LzQDVJwYG8cVfth+v4/ImcXR43D4WVxxBE AjKag02b+1yfABEBAAHCwV8EGAECAAkFAlm/2cUCGwwACgkQE/zvid2ePE/dqQ/6ApUwgsZz tps0MOdRddjPwz44pWXS5MG45irMQXELGQyxkrafc8lwHeABYstoK8dpopTcJGE3dZGL3JNz 1YWxQ5AV4uyqBn5N8RubcA8NzR6DQP+OGPIwzMketvVC/cbbKDZqf0uTDy3jP65OFhSkTEIy nYv1Mb4JJl3Sq+haUbfWLAV5nboSuHmiZE6Bz2+TjdoVkNwHBfpqxu6MlWka+P98SUcmY8iV hPy9QC1XFOGdFDFf1kYgHW27mFwds35NQhNARgftAVz9FZXruW6tFIIfisjr3rVjD9R8VgL7 l5vMr9ylOFpepnI6+wd2X1566HW7F1Zw1DIrY2NHL7kL5635bHrJY4n7o/n7Elk/Ca/MAqzd IZxz6orfXeImsqZ6ODn4Y47PToS3Tr3bMNN9N6tmOPQZkJGHDBExbhAi/Jp8fpWxMmpVCUl6 c85cOBCR4s8tZsvGYOjR3CvqKrX4bb8GElrhOvAJa6DdmZXc7AyoVMaTvhpq3gJYKmC64oqt 7zwIHwaCxTbP6C6oUp9ENRV7nHnXN3BlvIgCo4QEs6HkDzkmgYlCEOKBiDyVMSkPDZdsspa+ K4GlU2Swi/BDJMjtDxyo+K0M81LXXxOeRfEIfPtZ3ddxBKPva1uSsuz+pbN9d1JY8Ko5T/h1 6susi2ReUyNJEJaSnjO5z13TQ1U= In-Reply-To: <20231120140635.3642601-1-jremus@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Jens, > This patch series adds the following extended mnemonics (grouped by > function) to the s390 target architecture: > - jc, jcth > - lfi, llgfi, llghi > - notr, notgr > - risbhgz, risblgz > - rnsbgt, rosbgt, rxsbgt > > Additionally the patch series aligns the definition of optional last > operands to the specification in the z/Architecture Principles of > Operation. Option optparm is added to the following existing (extended) > mnemonics: > - risbg, risbgz, risbgn, risbgnz > - risbhg, risblg > - rnsbg, rosbg, rxsbg > > Patches 1-3 are preparatory changes. Patch 4 aligns the optional operand > definition. Patch 5 adds the missing extended mnemonics. Patch 6 corrects > an instruction name. > > Patch 1 implements an enhancement to use regular expressions with back > references to validate the disassembly of instructions with relative > addressing. This removes the need to update most relative addresses in > the golden master files the disassembly is checked against when > inserting new tests. > > Patch 3 enhances the definition of the operand indices, so that new > operands can be inserted into the operand table without having to > renumber any indices. This minimizes future hunks that insert new > operands, such as those introduced by patch 5. Patch series approved - please apply. Do these new instructions have a name to cover them as a whole ? I am thinking that it would be nice to have an entry in the gas/NEWS file that says something like "add support for the XXX extension to the s390x architecture". One other, minor thing. I tried to look at the documentation that you referenced in patch 5: > Add extended mnemonics specified in the z/Architecture Principles of > Operation [1] and z/Architecture Reference Summary [2], that were > previously missing from the opcode table. > [1] IBM z/Architecture Principles of Operation, SA22-7832-13, > https://www.ibm.com/support/pages/zarchitecture-principles-operation > [2] IBM z/Architecture Reference Summary, SA22-7871-11, > https://www.ibm.com/support/pages/zarchitecture-reference-summary I found that link [2] diverts to a "500: Internal Server Error" page and link [1] would not let me download the document without first registering for an IBMid, which I can do, but it is not really Open Source friendly... Cheers Nick