From: Jan Beulich <jbeulich@suse.com>
To: Binutils <binutils@sourceware.org>
Cc: "H.J. Lu" <hjl.tools@gmail.com>
Subject: Re: [PATCH 2/2] x86: omit Cpu prefixes from opcode table
Date: Tue, 13 Dec 2022 08:29:43 +0100 [thread overview]
Message-ID: <df934888-9d00-53d3-497b-1dabe24f867c@suse.com> (raw)
In-Reply-To: <90f8b494-64b2-fd9a-6b19-ded5f185ddd1@suse.com>
On 12.12.2022 14:14, Jan Beulich wrote:
> These enumerators can be used in only one specific field, and hence the
> Cpu prefix isn't needed ther for disambiguation / name space separation.
> ---
> RFC: I will admit that I'm not entirely happy with the result,
> specifically because of the purely numeric "identifiers" which we
> end up with now (e.g. 286 or 64). Since for things like AVX the
> change is (imo) a clear improvement, I wonder whether some hybrid
> approach might be best to take, or whether we could go with e.g.
> CpuI286 and CpuX64.
It was only early in the morning today when I realized that there's a
pretty simple way to address this: We can add
#define i386 386
etc to i386-opc.tbl (or alternatively something functionally equivalent
to i386-gen.c). Which is what I'm going to do then.
Jan
prev parent reply other threads:[~2022-12-13 7:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 13:10 [PATCH 0/2] x86: further opcode table line length reduction Jan Beulich
2022-12-12 13:12 ` [PATCH 1/2] x86: change representation of extension opcode Jan Beulich
2022-12-12 13:14 ` [PATCH 2/2] x86: omit Cpu prefixes from opcode table Jan Beulich
2022-12-13 7:29 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df934888-9d00-53d3-497b-1dabe24f867c@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).