public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Nicholas Vinson <nvinson234@gmail.com>
To: binutils@sourceware.org
Cc: Nicholas Vinson <nvinson234@gmail.com>
Subject: [binutils] libctf: Remove undefined functions from ver. map
Date: Thu, 28 Dec 2023 14:10:09 -0500	[thread overview]
Message-ID: <dfda42d963b25d850378908cba48533561fc5577.1703790579.git.nvinson234@gmail.com> (raw)

The functions ctf_label_set(), ctf_label_get(), ctf_arc_open(), ctf_fdopen(),
ctf_open(), ctf_bfdopen(), and ctf_bfdopen_ctfsect() are not defined. Their
inclusion in libctf/libctf.ver causes clang/llvm LTO optimizatiosn to fail with
error messages similar to

    error: version script assignment of LIBCTF_1.0 to symbol ctf_label_set
    failed: symbol not defined

This patch fixes the issue by removing the symbol names from libctf/libctf.ver

Fixes Gentoo bug 914640 (https://bugs.gentoo.org/914640)

Signed-off-by: Nicholas Vinson <nvinson234@gmail.com>
---
 libctf/libctf.ver | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/libctf/libctf.ver b/libctf/libctf.ver
index 0ff825d033b..08e1b27341f 100644
--- a/libctf/libctf.ver
+++ b/libctf/libctf.ver
@@ -80,9 +80,6 @@ LIBCTF_1.0 {
 	ctf_enum_name;
 	ctf_enum_value;
 
-	ctf_label_set;
-	ctf_label_get;
-
 	ctf_label_topmost;
 	ctf_label_info;
 
@@ -139,7 +136,6 @@ LIBCTF_1.0 {
 
 	ctf_arc_write;
 	ctf_arc_write_fd;
-	ctf_arc_open;
 	ctf_arc_bufopen;
 	ctf_arc_close;
 	ctf_arc_open_by_name;
@@ -165,10 +161,6 @@ LIBCTF_1.0 {
 	ctf_link_shuffle_syms;
 	ctf_link_write;
 
-	ctf_fdopen;                             /* libctf only.  */
-	ctf_open;                               /* libctf only.  */
-	ctf_bfdopen;                            /* libctf only.  */
-	ctf_bfdopen_ctfsect;                    /* libctf only.  */
     local:
 	*;
 };
-- 
2.43.0


             reply	other threads:[~2023-12-28 19:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-28 19:10 Nicholas Vinson [this message]
     [not found] ` <87bk828z6q.fsf@gentoo.org>
2024-02-27 15:05   ` Nick Alcock
2024-02-28  0:32     ` Nicholas Vinson
2024-02-28 18:14       ` Nick Alcock
2024-03-01  1:49         ` Nicholas Vinson
2024-03-01 17:46           ` Nick Alcock
2024-03-02  3:36             ` Nicholas Vinson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dfda42d963b25d850378908cba48533561fc5577.1703790579.git.nvinson234@gmail.com \
    --to=nvinson234@gmail.com \
    --cc=binutils@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).