From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C58AE3858414 for ; Mon, 31 Jul 2023 14:52:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C58AE3858414 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690815156; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HWuDcCxOFbhW9zx/ixfk9hu9iIzxUY9Pr9V5JPuLkV0=; b=HYOEqho8iDfhB7kINTyn9cgCc1LNCfnY4ptdq3C0AAWBebENi6BGiOjh9EEXn0Emr5dCu1 eInsJQwOzur/miFDu50o7xzRgwgMxhrhCQGMb6dx6+zsBAtGMlpm2c3fxbhaYcJo9p0b1G 4rw8kT94PyGK6BtkMxl2lHuOE80L1dI= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-68-6v0D6tR5P52TVnHFO9etRQ-1; Mon, 31 Jul 2023 10:52:35 -0400 X-MC-Unique: 6v0D6tR5P52TVnHFO9etRQ-1 Received: by mail-vs1-f70.google.com with SMTP id ada2fe7eead31-4475cacfffeso868720137.2 for ; Mon, 31 Jul 2023 07:52:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690815154; x=1691419954; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HWuDcCxOFbhW9zx/ixfk9hu9iIzxUY9Pr9V5JPuLkV0=; b=C2HB+W9Wdt1mPg5m0YW1tSHC+uvMhYxyywEc0xLMpQ82JgDYsHzvAS8jmFvWi/2qNF s8DLhDE9YZWtZwXy6SDNDkEILwL4UxAMaOdjf7P9C+MBAIUQdLmIPxolPmAIH/ScK82a K7K8xCsddSCeZg983CRlBg2B3ZNfdynqug2hYrUyYoVlPvTdLB6gbv0aAZjBt1XP9MgE 5e30IIh7J+lxpBNit4y9LiU0cmWnO3VYIoiD3ApTig7nh3aU5U6MvPMnsUezK37O4xFG LfHpSgWyiOTJF0QvqEMmGvpTmBb+bTm5LG3sdCHix6cFf7BhF0FuYot6GSMxHcfsyM3z aRAA== X-Gm-Message-State: ABy/qLZKvES8BZxk8ZsYSSzfcCE1goZsTufCJZPUXbnV+ciIYHfXhx5c 0+WYaFUmMFKUOefroJJLAiE0fzy09euBoXByCnJBAwoVwObx6spLnmlheQ/2OpMtDlPhAsuJPsT tm0opahdNOdZFm7VVVZ2PtcExcQ== X-Received: by 2002:a67:e3b1:0:b0:443:9037:d8e4 with SMTP id j17-20020a67e3b1000000b004439037d8e4mr203686vsm.8.1690815154218; Mon, 31 Jul 2023 07:52:34 -0700 (PDT) X-Google-Smtp-Source: APBJJlE6RVvam4u9BUOJXS5LPrFPGQxFlX2Qm+i+xP6wlVIWGjmR2KynvST9H4o/jqdCDOlOIum4fA== X-Received: by 2002:a67:e3b1:0:b0:443:9037:d8e4 with SMTP id j17-20020a67e3b1000000b004439037d8e4mr203672vsm.8.1690815153990; Mon, 31 Jul 2023 07:52:33 -0700 (PDT) Received: from [192.168.1.7] ([79.123.79.89]) by smtp.gmail.com with ESMTPSA id d19-20020a0cf0d3000000b0063d31b493e1sm3776221qvl.99.2023.07.31.07.52.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Jul 2023 07:52:33 -0700 (PDT) Message-ID: Date: Mon, 31 Jul 2023 15:52:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Paul Iannetta Cc: binutils@sourceware.org References: <20230721074956.7188-1-piannetta@kalrayinc.com> <7a676623-4084-c210-3dcd-37e813aeb32d@redhat.com> <20230724123338.r27dhowqkwzqgt4u@ws2202.lin.mbt.kalray.eu> <886f77cd-8cee-d530-64f0-c09cb9643a93@redhat.com> <20230726073623.eaczp74zhock7dj7@ws2202.lin.mbt.kalray.eu> <20230726212435.bd5zf3azsj55ejme@ws2202.lin.mbt.kalray.eu> From: Nick Clifton Subject: Re: [PATCH v2] kvx: New port. In-Reply-To: <20230726212435.bd5zf3azsj55ejme@ws2202.lin.mbt.kalray.eu> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Paul, > I've taken into account the points you raised in your review, Thank you very much. Just a couple more small issues: * The kvx-linux target does not appear to be supported by the assembler. In particular when running the gas testsuite I found messages like this: failed with: , no expected output FAIL: gas/kvx/kv3-1-insns-32 The linker and binutils testsuites also have failures with similar messages. I am assuming that "kvx-linux" is a valid configuration target. If not, then it ought to be rejected by bfd/config.bfd. * The copyright dates on some of the new files are wrong/old. For example ld/emultempl/kvxelf.em has: # Copyright (C) 2009-2016 Free Software Foundation, Inc. This ought to be "...2009-2023...". I have not checked all the other files in the patch, but if there any others will out of date copyright notices then I hope that you will fix them. Cheers Nick