From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by sourceware.org (Postfix) with ESMTPS id C55B33858402 for ; Tue, 30 Jan 2024 10:29:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C55B33858402 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C55B33858402 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::22e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706610563; cv=none; b=bNu2vMG3psJnNi1SclEadR5eBMnHLmTtp6ZBWJ5IOOpg2Uc1Y69+sxhLQfYf/S9jxu7uQ4IjatI9qU8w2u7yD+wkLCbs1ycIaHYt2alHQNUh8rnl+MT46Wg4y9RDb+yG5O4pH2yykcjU6XRdt9Vw6xMgAUArM2nxv5T1fiuAroQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706610563; c=relaxed/simple; bh=mml2YHx3yGWOhzZYh38x/lt+8m6EF5ZKkQjR65luCk8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=VMPaX1FrAamLNVJkKGe+NzgWNk+HYbttNtIKYDC9ZCQP5JKEGqA2QxAgSYNj0k97+NPDnbDL+spjxo1u0ZFHyZKy2dIN9PLy3PXISyEDXqfnesgYFGX0HQYIsQL7k+u7ABFPqRfU3lusP06/R/ZbkcBr8maxtGUTZhcudV05qA8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-2cf42ca9bb2so44875661fa.1 for ; Tue, 30 Jan 2024 02:29:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1706610559; x=1707215359; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Goxory7IPu+0ch8sD6YtM48dty8vMIxfI7lLCZUKOoc=; b=Qt9C7724vPQ9E/RraDbxvFe5deXxpLwlwT85VmoZ7HGKBU2VVUfpD020pNq1ksuJ/X IWk8hS96U+CrGoaYSeGCBRjch1ssQ2yo9eI9+LClYTLhZkRCwVBMAdiKVg5U0QYaS2Hz xOAQPEYHvoifWW3W6qmrE+nx6MKuK2DV66vbIEQfcLLQa6Z7x0jiKj0ts4AXhuGz6BqT rJY8DuxuWWL1yN0PJeo8A920fDRqfFy5I1NSubPaPp2aa7dR7To7s1DxOZZPaPHGLJ82 SGRFL0MBNLPy9Mw1FAv31BuafNEteYdFRPf5QwM3Vgzsja5PrTbMK3tKf7aAcxRtWHMX 5r0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706610559; x=1707215359; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Goxory7IPu+0ch8sD6YtM48dty8vMIxfI7lLCZUKOoc=; b=miicNIaGLLIqbwWmOL1VLCCDQFkyJt7K1oemmBryKj7M0rFTPuNpNkZSRcoO8aowCF /EtUvbBQOVNbt0IpDmtRs/7PW4Y3kdxVUHYYNdyh05A/qYkgZkPsk7KMoAabtxIulQ/Q XSTOaszAiRLl8Zxzws0Xqw497YDxc76Nnzt8iNk/3z3YvaFz7iVWg0z1U6lsbGJn1I2a TyWECK3q1F3AjQklTOC9hE+eKZ2wrbsEP9jcvS7fG00Ks04f0bjFkXS5KICe9shNuK6D uoGtZJHE0/qaErFOXM1L5QFEYx5evXWLGm38UxOwUQCecylRzXlXtAALBw1QpQEydyiY gwXQ== X-Gm-Message-State: AOJu0YxDXoR3RgcoI5KSkglk4EkoI2UvBPj1wIRR9/TVOHGOp3Evvu3N oVT0GbM1Aj9BBf2OjPrnajkyCfRjrme1Zy3s9Ga/ZYXrUAoJFED5a0FLc8BPCFHhPqsldPb4gzs = X-Google-Smtp-Source: AGHT+IHzjQtWYflyWVKevbCSwbJRNz4JQwn0zj6PVcCln4JrJMIxceSPC070e3EDZzntgwYFc2Lzcg== X-Received: by 2002:a2e:95d1:0:b0:2ce:865:83a5 with SMTP id y17-20020a2e95d1000000b002ce086583a5mr5105657ljh.45.1706610559276; Tue, 30 Jan 2024 02:29:19 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id j5-20020a6b3105000000b007c009d1d986sm435453ioa.27.2024.01.30.02.29.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jan 2024 02:29:18 -0800 (PST) Message-ID: Date: Tue, 30 Jan 2024 11:29:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH,V3] gas: x86: ginsn: adjust ginsns for certain lea ops Content-Language: en-US To: Indu Bhagat References: <20240126090005.3265355-1-indu.bhagat@oracle.com> Cc: binutils@sourceware.org From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20240126090005.3265355-1-indu.bhagat@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3025.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 26.01.2024 10:00, Indu Bhagat wrote: > @@ -5664,76 +5666,58 @@ x86_ginsn_lea (const symbolS *insn_end_sym) > { > offsetT src_disp = 0; > ginsnS *ginsn = NULL; > - unsigned int base_reg; > - unsigned int index_reg; > + unsigned int src1_reg; > + const reg_entry *src1; > offsetT index_scale; > unsigned int dst_reg; > > - if (!i.index_reg && !i.base_reg) > + if (!i.base_reg != !i.index_reg > + && (!i.index_reg || i.index_reg->reg_num != RegIZ)) Now this is odd - either you use the short form consistently, or you don't use it at all. In the former case if (!i.base_reg != (!i.index_reg || i.index_reg->reg_num == RegIZ)) or if (!i.base_reg == (i.index_reg && i.index_reg->reg_num != RegIZ)) or yet some substantially similar expression (I hope I got the transformations right, but in any event I expect you get the point). > { > - /* lea symbol, %rN. */ > - dst_reg = ginsn_dw2_regnum (i.op[1].regs); > - /* TBD_GINSN_INFO_LOSS - Skip encoding information about the symbol. */ > - ginsn = ginsn_new_mov (insn_end_sym, false, > - GINSN_SRC_IMM, 0xf /* arbitrary const. */, 0, > - GINSN_DST_REG, dst_reg, 0); > - } > - else if (i.base_reg && !i.index_reg) > - { > - /* lea -0x2(%base),%dst. */ > - base_reg = ginsn_dw2_regnum (i.base_reg); > - dst_reg = ginsn_dw2_regnum (i.op[1].regs); > + /* lea disp(%base), %dst or lea disp(,%index,imm), %dst. > + But exclude the case when %index is RegIZ, else a GINSN_TYPE_MOV of > + %rsi (GINSN_DW2_REGNUM_RSI_DUMMY) to %dst will be generated. Such a > + mov ginsn is imprecise, generate GINSN_TYPE_OTHER instead. */ The text starting with "But ..." gives the impression that the comment relates to subsequent code, where that further restriction would be enforced. Yet this relates to the containing if(), so you may want to make this more clear by e.g. adding "(as per above)". Maybe also with tense changed: "But, as per above, with the case ... excluded." Okay with suitable adjustments. Jan