From: Timothy Wall <twall@alum.mit.edu>
To: Nick Clifton <nickc@redhat.com>
Cc: binutils@sources.redhat.com, Jan Beulich <JBeulich@novell.com>
Subject: Re: gas/config/tc-tic54x.c's use of macro_struct and formal_struct
Date: Wed, 09 Mar 2005 14:04:00 -0000 [thread overview]
Message-ID: <e0862fad7997030c8148f8c50fb82fb6@alum.mit.edu> (raw)
In-Reply-To: <422EF27C.2000609@redhat.com>
Since it looks like I moved those structs into macro.h in the first
place to make them publicly accessible, I'm guessing the duplicated
code in the tic54x file pre-dates moving the structs into macro.h, and
was never properly cleaned up.
Please contribute a patch.
T.
On Mar 9, 2005, at 7:56 AM, Nick Clifton wrote:
> Hi Jan,
>
>> As I'm intending to add one or two elements to macro_struct (to allow
>> .purgem to free the memory allocated by .macro) I'd like to understand
>> what, if any, reasons there are for this file, in function
>> tic54x_macro_info, to redeclare these two structures instead of using
>> them (or even better their typedef equivalents) from the already
>> included macro.h.
>
> As far as I can tell this was an ill-advised piece of coding. The
> typedefs from macro.h should have been used as you suggested. Please
> feel free to contribute a patch to do just this.
>
> Cheers
> Nick
>
>
next prev parent reply other threads:[~2005-03-09 14:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-09 10:12 Jan Beulich
2005-03-09 12:44 ` Nick Clifton
2005-03-09 14:04 ` Timothy Wall [this message]
2005-03-10 8:01 Jan Beulich
2005-03-10 8:47 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0862fad7997030c8148f8c50fb82fb6@alum.mit.edu \
--to=twall@alum.mit.edu \
--cc=JBeulich@novell.com \
--cc=binutils@sources.redhat.com \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).