From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [IPv6:2001:470:683e::1]) by sourceware.org (Postfix) with ESMTPS id 968593857705 for ; Mon, 24 Jul 2023 09:17:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 968593857705 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1690190237; bh=aqUPqUJzWCanArrof0uX23cAmMfvUOvlU9fVlUP+Bso=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=TYmGQ5zknwmfjTkamorbz5DYZ4okh7Y3wcNWPklMykEV/cTkYDhW0qdNH9v/+s0KT gyGUVwrefrEPbQvxKpf+MCmFggCQGkUn+aZvjz/LyJAofMckE1czJb7h5sn6xngz3t e6Z71GZlvUII1ryYoSkezM9v+A/luNxxuaIR/pdQ= Received: from localhost.localdomain (xry111.site [IPv6:2001:470:683e::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 8D087668AD; Mon, 24 Jul 2023 05:17:15 -0400 (EDT) Message-ID: Subject: Re: [PATCH] LoongArch: ld: Simplify inserting IRELATIVE relocations to .rela.dyn From: Xi Ruoyao To: Nick Clifton , mengqinggang , binutils@sourceware.org Cc: xuchenghua@loongson.cn, chenglulu@loongson.cn, liuzhensong@loongson.cn, i.swmail@xen0n.name, maskray@google.com Date: Mon, 24 Jul 2023 17:17:13 +0800 In-Reply-To: <8bb20690-1d8a-9d00-5a95-99b287f39091@redhat.com> References: <20230719021721.776961-1-mengqinggang@loongson.cn> <8d4a1972d027cdef81d6fbba33d3fc97cc67305b.camel@xry111.site> <8bb20690-1d8a-9d00-5a95-99b287f39091@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,LIKELY_SPAM_FROM,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 2023-07-24 at 09:41 +0100, Nick Clifton wrote: > Hi Guys, >=20 > On 7/22/23 08:43, Xi Ruoyao wrote: > > > On Fri, 2023-07-21 at 11:53 +0800, mengqinggang wrote: > > > For consistency, this patch also needs to be merged into the 2.41 > > > branch. > >=20 > > +Nick. > >=20 > > But generally "consistency" is not a valid reason to backport a > > patch > > into the release upcoming very soon.=20 >=20 > I 100% agree with Xi here.=C2=A0 Unless there is a compelling, bug-relate= d > reason why the 2.41 branch should updated so close to a release date, > I will not approve any patch. These two patches https://sourceware.org/pipermail/binutils/2023-July/128421.html are bug fixes for relaxation and the bug seems severe. Is it ok to backport them? If not I guess the only choice will be removing -mrelax from the default and claiming relaxation is experimental for 2.41... --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University