* [PATCH][Binutils][AArch64] Add negative tests for Armv8.3-a complex number instructions.
@ 2019-02-05 16:26 Tamar Christina
2019-02-07 14:47 ` Nick Clifton
0 siblings, 1 reply; 2+ messages in thread
From: Tamar Christina @ 2019-02-05 16:26 UTC (permalink / raw)
To: binutils; +Cc: nd, Richard Earnshaw, Marcus Shawcroft
[-- Attachment #1: Type: text/plain, Size: 738 bytes --]
Hi All,
This patch just adds a few negative tests for the Armv8.3-a complex instructions.
These already do the right disassembly without needing a verifier, but adding
some tests to make sure that stays that way.
build on native hardware and regtested on
aarch64-none-elf, aarch64-none-elf (32 bit host),
aarch64-none-linux-gnu, aarch64-none-linux-gnu (32 bit host)
Cross-compiled and regtested on
aarch64-none-linux-gnu, aarch64_be-none-linux-gnu
and no issues.
Ok for master?
Thanks,
Tamar
gas/ChangeLog:
2019-02-05 Tamar Christina <tamar.christina@arm.com>
* testsuite/gas/aarch64/undefined_advsimd_armv8_3.d: New test.
* testsuite/gas/aarch64/undefined_advsimd_armv8_3.s: New test.
--
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: rb10665.patch --]
[-- Type: text/x-diff; name="rb10665.patch", Size: 5139 bytes --]
diff --git a/gas/testsuite/gas/aarch64/undefined_advsimd_armv8_3.d b/gas/testsuite/gas/aarch64/undefined_advsimd_armv8_3.d
new file mode 100644
index 0000000000000000000000000000000000000000..cb84f3823be626c8ccc1b5d6006613dd1a9440ba
--- /dev/null
+++ b/gas/testsuite/gas/aarch64/undefined_advsimd_armv8_3.d
@@ -0,0 +1,56 @@
+#as: -march=armv8.3-a
+#objdump: -dr
+
+.*: file format .*
+
+Disassembly of section \.text:
+
+0+ <.*>:
+[^:]+:\s+6ec3c441 fcmla v1.2d, v2.2d, v3.2d, #0
+[^:]+:\s+6e03c441 .inst 0x6e03c441 ; undefined
+[^:]+:\s+2ec3c441 .inst 0x2ec3c441 ; undefined
+[^:]+:\s+2e83c441 fcmla v1.2s, v2.2s, v3.2s, #0
+[^:]+:\s+2e03c441 .inst 0x2e03c441 ; undefined
+[^:]+:\s+2ec3c441 .inst 0x2ec3c441 ; undefined
+[^:]+:\s+6e83c441 fcmla v1.4s, v2.4s, v3.4s, #0
+[^:]+:\s+6e03c441 .inst 0x6e03c441 ; undefined
+[^:]+:\s+2ec3c441 .inst 0x2ec3c441 ; undefined
+[^:]+:\s+2e43c441 fcmla v1.4h, v2.4h, v3.4h, #0
+[^:]+:\s+2e03c441 .inst 0x2e03c441 ; undefined
+[^:]+:\s+2ec3c441 .inst 0x2ec3c441 ; undefined
+[^:]+:\s+6e43c441 fcmla v1.8h, v2.8h, v3.8h, #0
+[^:]+:\s+6e03c441 .inst 0x6e03c441 ; undefined
+[^:]+:\s+2ec3c441 .inst 0x2ec3c441 ; undefined
+[^:]+:\s+6f831041 fcmla v1.4s, v2.4s, v3.s\[0\], #0
+[^:]+:\s+6f031041 .inst 0x6f031041 ; undefined
+[^:]+:\s+6fc31041 .inst 0x6fc31041 ; undefined
+[^:]+:\s+2f431841 .inst 0x2f431841 ; undefined
+[^:]+:\s+6fa31041 .inst 0x6fa31041 ; undefined
+[^:]+:\s+2f831041 .inst 0x2f831041 ; undefined
+[^:]+:\s+2f431041 fcmla v1.4h, v2.4h, v3.h\[0\], #0
+[^:]+:\s+2f031041 .inst 0x2f031041 ; undefined
+[^:]+:\s+2fc31041 .inst 0x2fc31041 ; undefined
+[^:]+:\s+2f431841 .inst 0x2f431841 ; undefined
+[^:]+:\s+2fa31041 .inst 0x2fa31041 ; undefined
+[^:]+:\s+2f831041 .inst 0x2f831041 ; undefined
+[^:]+:\s+6f431041 fcmla v1.8h, v2.8h, v3.h\[0\], #0
+[^:]+:\s+6f031041 .inst 0x6f031041 ; undefined
+[^:]+:\s+6fc31041 .inst 0x6fc31041 ; undefined
+[^:]+:\s+2f431841 .inst 0x2f431841 ; undefined
+[^:]+:\s+6fa31041 .inst 0x6fa31041 ; undefined
+[^:]+:\s+2f831041 .inst 0x2f831041 ; undefined
+[^:]+:\s+6ec3e441 fcadd v1.2d, v2.2d, v3.2d, #90
+[^:]+:\s+6e03e441 .inst 0x6e03e441 ; undefined
+[^:]+:\s+2ec3e441 .inst 0x2ec3e441 ; undefined
+[^:]+:\s+2e83e441 fcadd v1.2s, v2.2s, v3.2s, #90
+[^:]+:\s+2e03e441 .inst 0x2e03e441 ; undefined
+[^:]+:\s+2ec3e441 .inst 0x2ec3e441 ; undefined
+[^:]+:\s+6e83e441 fcadd v1.4s, v2.4s, v3.4s, #90
+[^:]+:\s+6e03e441 .inst 0x6e03e441 ; undefined
+[^:]+:\s+2ec3e441 .inst 0x2ec3e441 ; undefined
+[^:]+:\s+2e43e441 fcadd v1.4h, v2.4h, v3.4h, #90
+[^:]+:\s+2e03e441 .inst 0x2e03e441 ; undefined
+[^:]+:\s+2ec3e441 .inst 0x2ec3e441 ; undefined
+[^:]+:\s+6e43e441 fcadd v1.8h, v2.8h, v3.8h, #90
+[^:]+:\s+6e03e441 .inst 0x6e03e441 ; undefined
+[^:]+:\s+2ec3e441 .inst 0x2ec3e441 ; undefined
diff --git a/gas/testsuite/gas/aarch64/undefined_advsimd_armv8_3.s b/gas/testsuite/gas/aarch64/undefined_advsimd_armv8_3.s
new file mode 100644
index 0000000000000000000000000000000000000000..c702a8084c8d7c8e2502c635d9d85258a18a9719
--- /dev/null
+++ b/gas/testsuite/gas/aarch64/undefined_advsimd_armv8_3.s
@@ -0,0 +1,70 @@
+# Generates tests to see if the following conditions make the instruction
+# undefined:
+#
+# 1) size == 0
+# 2) size == 3 && Q == 0
+#
+# These patterns can't be created by the assembler so instead manually encode
+# them from a starting pattern.
+.macro gen_insns_same opc
+ .inst \opc
+ .inst (\opc & 0xff3fffff) // size == 0
+ .inst ((\opc | 0xc00000) & 0xbfffffff) // size == 3 && Q == 0
+.endm
+
+# Generates tests to see if the following conditions make the instruction
+# undefined:
+#
+# 1) size == 0 || size == 3
+# 2) size == 1 && H == 1 && Q == 0
+# 3) size == 2 && (L == 1 || Q == 0)
+#
+# These patterns can't be created by the assembler so instead manually encode
+# them from a starting pattern.
+.macro gen_insns_elem opc
+ .inst \opc
+ .inst (\opc & 0xff3fffff) // size == 0
+ .inst (\opc | 0xc00000) // size == 3
+ .inst ((\opc | 0x400800) & 0xbf7fffff) // size == 1 && H == 1 && Q == 0
+ .inst ((\opc | 0xa00000) & 0xffbfffff) // size == 2 && L == 1
+ .inst ((\opc | 0x800000) & 0xbfbfffff) // size == 2 && Q == 0
+.endm
+
+# fcmla v1.2d, v2.2d, v3.2d, #0
+gen_insns_same 0x6ec3c441
+
+# fcmla v1.2s, v2.2s, v3.2s, #0
+gen_insns_same 0x2e83c441
+
+# fcmla v1.4s, v2.4s, v3.4s, #0
+gen_insns_same 0x6e83c441
+
+# fcmla v1.4h, v2.4h, v3.4h, #0
+gen_insns_same 0x2e43c441
+
+# fcmla v1.8h, v2.8h, v3.8h, #0
+gen_insns_same 0x6e43c441
+
+# fcmla v1.4s, v2.4s, v3.s[0], #0
+gen_insns_elem 0x6f831041
+
+# fcmla v1.4h, v2.4h, v3.h[0], #0
+gen_insns_elem 0x2f431041
+
+# fcmla v1.8h, v2.8h, v3.h[0], #0
+gen_insns_elem 0x6f431041
+
+# fcadd v1.2d, v2.2d, v3.2d, #90
+gen_insns_same 0x6ec3e441
+
+# fcadd v1.2s, v2.2s, v3.2s, #90
+gen_insns_same 0x2e83e441
+
+# fcadd v1.4s, v2.4s, v3.4s, #90
+gen_insns_same 0x6e83e441
+
+# fcadd v1.4h, v2.4h, v3.4h, #90
+gen_insns_same 0x2e43e441
+
+# fcadd v1.8h, v2.8h, v3.8h, #90
+gen_insns_same 0x6e43e441
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH][Binutils][AArch64] Add negative tests for Armv8.3-a complex number instructions.
2019-02-05 16:26 [PATCH][Binutils][AArch64] Add negative tests for Armv8.3-a complex number instructions Tamar Christina
@ 2019-02-07 14:47 ` Nick Clifton
0 siblings, 0 replies; 2+ messages in thread
From: Nick Clifton @ 2019-02-07 14:47 UTC (permalink / raw)
To: Tamar Christina, binutils; +Cc: nd, Richard Earnshaw, Marcus Shawcroft
Hi Tamar,
> 2019-02-05 Tamar Christina <tamar.christina@arm.com>
>
> * testsuite/gas/aarch64/undefined_advsimd_armv8_3.d: New test.
> * testsuite/gas/aarch64/undefined_advsimd_armv8_3.s: New test.
Approved - please apply.
Cheers
Nick
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-07 14:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-05 16:26 [PATCH][Binutils][AArch64] Add negative tests for Armv8.3-a complex number instructions Tamar Christina
2019-02-07 14:47 ` Nick Clifton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).