From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2059.outbound.protection.outlook.com [40.107.6.59]) by sourceware.org (Postfix) with ESMTPS id F11D03858C31 for ; Fri, 28 Apr 2023 12:57:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F11D03858C31 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XZx04uydravncm6eV+8ggmoGoL9IgMjKr6vUfEGh67QpJHsxQp5n+CEGd/EH8VTHKCSqtJU5Amjk/Jt+y/JNKX+8Z6StY8losVfg8EwCJs/tXid9FPvPKuLKAvCAtt87kVwnOBOBlkgG4Zm17drsizobu2fX85oHFnaIA8a0mIePv6S5sNeZO2rNTU3XAafQZ1zh+21cImsMqnsbkijptvGA7pSbFxAK/mVlBAZ2rku050AR6auPy6UsBNeUaSOjNNvzGwacmt6Ad5Xf4pUUhqjpBTe+Bv05PChOvCQGAOmn8w3NNNjKK7jQnKgZbWgI3py9nIlhFuTBH8HfE9N5iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+JdByghGjDVW2Ka2n/WeISFqmAS111rgbrjmW9lMY4s=; b=NUJeYr7qMd7MDM3V+1L517BCkz+YZ1j8VNnk/pj1aCMJ5FNmfHcQLOkxQL9st7PVaA2xHclrWDURio547bjMVSfGalTNppc0dOj+cjGbOElSI0MldPL8ndCalauK11JMVV2E8zzt+VMrdSK2kuS3nY7jFx6AI7jqbDjFv1C970Wi42U/mMPanyCbYZ1zvyyiceuwGyrc3nvt4p4NY3Gi9p03nwYTyUs5e2tOokf9H+rQ+d43bspiMB/j12cbdrFvluIjcKAgH5eQ4Ib3YaEVffVpoKQXwOfbK5ue3vhjeLLTzwr7+M8xOuKbwtGgoyOsPpvTRYj0hLXEJKDjIy4ZuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+JdByghGjDVW2Ka2n/WeISFqmAS111rgbrjmW9lMY4s=; b=pMFOqwSf2u2YJnyOpJYYuuyhyRc8dgiSWNY5EhAcCsaz4P16kr0+xvy5bilCUnxply7OTreKWuEGyDXqVW07J/CY+mEbIjN8QTOqS/6vQL0cG3KvuZO80qna7aB55rLWuIXRUV0isTA8lGmuuxFXssS57r1SWQqLh2Q0fPgZf76JNMLS0ls4JBHUs1iBfH3y3ONamwegc/MqZqE4TlKpWtUZNuGzwmeORJmhdY51IyMQN3Z8qQgzfLIbPkmG0g02Mf9CUz3m9g3sCnQBVgFWp6uGxET2uvRh+yLs12CruiErbyCVNyVcvzCva04hVADIR9J/bOuwuzD9Sufo4GpuEA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB9980.eurprd04.prod.outlook.com (2603:10a6:800:1d0::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.21; Fri, 28 Apr 2023 12:57:33 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6340.023; Fri, 28 Apr 2023 12:57:33 +0000 Message-ID: Date: Fri, 28 Apr 2023 14:57:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Content-Language: en-US To: Binutils Cc: Palmer Dabbelt , Andrew Waterman , Jim Wilson , Nelson Chu From: Jan Beulich Subject: [PATCH] RISC-V: tighten post-relocation-operator separator expectation Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0133.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB9980:EE_ X-MS-Office365-Filtering-Correlation-Id: 94f159b1-0e82-4d46-7ee2-08db47e82217 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2tR/8oTS+giylrCyA/byVeXJhQaqGkN8CzsMBsODgMLItkX3cbXycf+yaJjL8qwnDmTJffcybHWz7FDlvzwENzUhiujwB16ePj8a2/sIq2wOv2itKxm6yRxDMxX/hs2nH+RcxP6ItIEfLpALPxK5Pbp5u2LNr9Uh9eEY0JYEtZP8iQ9ve4W5A71C4niPij5r1mABcu+eNWaMcn5ZqP9OgZsrjAN8yQXyrhf/L7qYXooYCP3CvnLlhEc64+AF03cDRx00Qo8rQWQQqkMte9o5G67gQHPvd5p9+br1wAfYXXnidLD9BhfL3mvFq4Tz626vqFbZ7sPzAwONaHz1mbguOdcir/mAtZX92W9+a7bl2db1USHJIsmL0cVf4iuJKAQV3FRcWFuRGVvFTsnl1x/RWaqKue6xm6l4xwSanz3aEGnhiyFXk0RaGjGJlGE3U3XvB1lWms87I8jSLQxOSSwzcx3sFkszsGXba3RfJWYX/5tDntL4PGRLn0RlwZdUEVW9NOZgYOpP7QEFlOW7aKnVHgy4gKCGy9ZSPO0O58cYndQ5HVLPD3XqdGH6xjebrL+xsN/wLFYDYMAwKz3WLJmDJ0MJeGvEB3L50eAsnqnGK3farUJ+kOsDzlbDz10urzOfpFqlmzS2J0asBokuo4EYRA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(136003)(396003)(346002)(366004)(39860400002)(451199021)(31686004)(38100700002)(6506007)(41300700001)(6916009)(66946007)(54906003)(316002)(31696002)(86362001)(8676002)(66476007)(66556008)(8936002)(478600001)(36756003)(6486002)(4326008)(26005)(186003)(2906002)(6512007)(2616005)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZGtzVEZXUlhSeTR2SGhzWVVsME1IR0xFR2tFOTFDQmo4bmE4ZkI4SDBZVHZY?= =?utf-8?B?c3V1eXVjYWhodC9yT2g0RG1TZ1NGUGpTMmpaSzAvMVZXNmN6QkVxVlVjNGtP?= =?utf-8?B?bmRzOHU0OVBSVzdLL3VlNm1Wb0RTYjM4THFkbUFtc20vVEZMRi9zOUVGbEYx?= =?utf-8?B?Zm5sSkl3a0EvVW94bVJGM25od3FxTU1VSk8zTDh0N2paeFpKNUJkN3Q2ZG80?= =?utf-8?B?RFRENEJpZ1cveTVSQTUwb0lreWdvR0M1VGtiZzZJZGF0WnJOdWk3SGM3aVBz?= =?utf-8?B?bzRMU2pnZE5PV3NuNGdDSDJmaHJQUkxVb3ZCd0RwMysrMGUveE0xTVpvWnp4?= =?utf-8?B?cVNTZTJlMkx1TEFMTWZLQ3RCdU5FSVQvQk9rdE1FNzB1emFzay84Qk9uWGtP?= =?utf-8?B?QVp6Mno3Tng4c3ArQkRnZGI5dXo1dWVhNnlhbGh5K0pFcENtWVRhNFU3ZUda?= =?utf-8?B?amVNL045cXlBWTcwN05BbmlTUnYvU2RaOEFwbnVDYU5uMnhid0xqbUV0aFk0?= =?utf-8?B?OFFseFdOcnJ4NzNWNGZOL3hBMklickQ0RE9pWWk4UkZHaHhMYytDV3EyTWJx?= =?utf-8?B?WXBxRzFDdjA5VGVBektBSkFQYTc4R21RVkF2dUR2TUVjRmJtUUpyajdyVmY5?= =?utf-8?B?aENhWnZnZ3pZMHUxc2xjL2k2UVBDeE9NT3FqTGh3MnpCOVVtd0hldjBGUE5I?= =?utf-8?B?WVVCUzFNSHh3eWx3UklEa3FSUGwzVis4NllNeTdaVWY0ZkNRZEZaYmEvSElV?= =?utf-8?B?ckdyUS82MTB6azVnNTB1eG0wUm1GUGNyejA0RXE0SCtxaDNUNkxDTE8yZ2gw?= =?utf-8?B?eitIRldRMTlRbDA4czZkTFpsYkRzWGRHSUN5N3hRZm9sK3RIZzEzNlAwSkZV?= =?utf-8?B?ang3YWJQRVovN0UzSHkxSVIrSnVnMGtyajV1TVZhZ3gwNFl5Nm16RVJ0RVVU?= =?utf-8?B?WnJ6aTlDZG1KRENtTGxRMFlYb0ZwdEtpQmlJZ1MwSlgzcFlBakRBRTZUZzRr?= =?utf-8?B?Ym9YZnFmL1UrcGhDVjdIMGZsUkdBSDJEQVhySkJqczRaV0k4bHNwbm1vOC9C?= =?utf-8?B?eDhjRERHbWthUGlCbnJxMUQ0QTBObHkvMFlDT0tFdGhMZzN3eDU2VkcxZHZr?= =?utf-8?B?Wm9pNWVPYm5TZWJtVjhPc3VlVjd0WGVvbjlpV2N6bW4zeU8wdXdrUzhnM3cv?= =?utf-8?B?SFQ5NkRXVGd3K3RuTGZpZEJrNTdXRHR4WGJWODZTeGJmZjVraTViQ1M2R2JO?= =?utf-8?B?V3FYWTlmdmFRTDgyVnVuMmY1d3pBSjZuVXFMdUQrM2QweGY3b2JvR1NxVjhW?= =?utf-8?B?ZXR5QTNrZE5Ib21qSmZQUkJuZk5wcFh1bDZoRWFTOWZrSXFtSFVucTh1Y1k2?= =?utf-8?B?ZDQ2TEVZa0JwWm1lUFJKUHJ3S0pkaVNSTytBb2Zva252NGs5WDR6ck9uTFVl?= =?utf-8?B?dDlQdENIVFV5NlJPR29keHEzT2ZWYkpEeVV6aHRnTmh0WXg1b3p6VDVqdXBl?= =?utf-8?B?Zm5pT3QzM1BxeGhsK0RtdkdCZnRKSUgrUjBZRks1THdLVzJJcktET2Z6eWZp?= =?utf-8?B?bzcvYXh1S2xZMzZhSVFrU1FTOTlLQnIvT2hyQU5naWxtK2ZmbDhaWEdSUW40?= =?utf-8?B?clVSUXorbkpadVhBN2U4Z2hkanZ6M2JaY2duMjBUaS8xQzliV1Z5Ykx5WWRi?= =?utf-8?B?TnhHMnJRZDN6d0RHZWlXOW9VcEZpazdjSWFEYWFUeVFtSzBFUWJQK3h1aVh3?= =?utf-8?B?WVVXbHpYM3FibjJhZEN4VEEzZkErRVUvVmkvbytUSE53NS9OVTRzakdvV2x1?= =?utf-8?B?d0h4VzRzdjVLcy9UMy8vZHlvRXkyNU9aZW5sV2VZNFdTQnlLbHNHbEhEQ2ZW?= =?utf-8?B?YW1jUUlMMlNBWTlTSHJvQmU4NXFjZjJsTmhuVUsxNU1zN2loTC9jVDc4SHFR?= =?utf-8?B?SFQ5WXZQK09SN3k1Nm9yWEhqZExtN0U1aDB0RmxzYmNBUTYvNjNUUEJCaXZN?= =?utf-8?B?RHU4L3RkYzhSSzdoUlhXV2tkZFdqRDNsTEM0V3haZElCcHJNWjMxVWJoYllC?= =?utf-8?B?d0VxRHBUT1N6SE9TcmtsWE9QTDFHK2xXanNzMkhMSXExdmxIY1IrV255bFlU?= =?utf-8?Q?xYvKI/n/B0krZh+rXaH6u0RpU?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 94f159b1-0e82-4d46-7ee2-08db47e82217 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2023 12:57:33.5270 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uINsl2mc+YaVmGq1nh5M0yzpNmlU48zyJ3o9doqCm0kJUU1f6HJ/3mSWHo9SK5xaU2iFMmITCKG0FktQmTH7Aw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB9980 X-Spam-Status: No, score=-3027.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: As per the spec merely a blank isn't okay as a separator, the operand to the relocation function ought to be parenthesized. Enforcing this then also eliminates an inconsistency in that lui t0, %hi sym lui t0, %hi 0x1000 were accepted, but lui t0, %hi +sym lui t0, %hi -0x1000 were not. --- a/gas/config/tc-riscv.c +++ b/gas/config/tc-riscv.c @@ -2200,7 +2200,9 @@ parse_relocation (char **str, bfd_reloc_ { size_t len = 1 + strlen (percent_op->str); - if (!ISSPACE ((*str)[len]) && (*str)[len] != '(') + while (ISSPACE ((*str)[len])) + ++len; + if ((*str)[len] != '(') continue; *str += len; --- a/gas/testsuite/gas/riscv/auipc-parsing.l +++ b/gas/testsuite/gas/riscv/auipc-parsing.l @@ -3,3 +3,5 @@ .*: Error: illegal operands `lui x10,x11' .*: Error: illegal operands `auipc x12,symbol' .*: Error: illegal operands `lui x13,symbol' +.*: Error: illegal operands `auipc x14,%hi symbol' +.*: Error: illegal operands `lui x15,%hi symbol' --- a/gas/testsuite/gas/riscv/auipc-parsing.s +++ b/gas/testsuite/gas/riscv/auipc-parsing.s @@ -4,3 +4,6 @@ # Don't accept a symbol without %hi() for 'u' operands. auipc x12,symbol lui x13,symbol +# Don't accept reloc functions without parentheses. + auipc x14,%hi symbol + lui x15,%hi symbol