From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2066.outbound.protection.outlook.com [40.107.104.66]) by sourceware.org (Postfix) with ESMTPS id E3F713858D28 for ; Wed, 25 Oct 2023 06:02:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E3F713858D28 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E3F713858D28 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.104.66 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698213730; cv=pass; b=ZTiofRAC5RzXrTchX6X4UAZVMm4ZztAN+1QIlPK0lrZjkUAD9eMCgJzcVh9Qm11XvryTvp6itQMH6Gnw75ONycZmwN74oNKCUvBCeFlQR48HlSkvV2l1Qs1b59o67f60I17cKuTL1D0IvgdAg2pFr9wymBW7h+2ppFLASBIlLoI= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698213730; c=relaxed/simple; bh=QuKyjJW7f5il3+ny0/C6fr14mST05NGfDqmheJANbH4=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=TkHwZkE9kxdctRb431YEVlD5G7u/Fp6+vHnKsiSDpXSXnVB6Jv53k3Be3dJ6Dda/EsHvrpVPoG7ojoot/MWy5vLiwsEFrlmKvdALo2kPI10KftVg4EbF5IOG1HS5DmMGLQ9tGE+gezXCU6qz8CHD8zwvA0r1e7apH52CAOkmjgQ= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SK+2FwCGPhN0qFM1tTXq7oO3r44SgnrkJrSSbi5J8hSIkH1JPrv5yVvQGcx5X1368YUmAfAELELU6wbfY3qRZOgm91IyWsYURz7B/iSlEUAZl8lnh8/JephWPGuEagDb4Dy0PyYoxUo3mrWbo5p/FRW0djPkvAAeQcGx3YIR1nrnSygzfyVBYkoBfsBBpBKywqQbd5FC/n+aFJ2Mkkgm6Lyk25gda5OmjyapQF08pRjuMr/r0Zse7428GxVavLlTzCJh446dlNpqbS7MBMFJNtJxyYcsI4TsrLcROtRFunvEzoLKc+jwusUWjEI+FxifkqIAuOoCjG2P73d6SoTjLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gDvaIJ8Ud2v5jFGb9eUFAQbGvQ7rX4mjlBnrv0Dl8oE=; b=gOnbB1zEbSdVYiSH/P3VMs5Ifke7advwWKzrWTR2zJSBMFgytN4fGYCVrqB+N6WmIm/pvGSRnPvENSFgyK5QHHvmf4GnwhgiOIiYYu11i88F4uQ3A67JWYJQYPK1ppTh9TNrDAESyG5+jvmix6n9y2k0xE4VMYSCGqmJiFeh08nLnc6s3/BzRe7GDJ97TwlhNQhU6B8b8lcULk36bdmjOb99egOF+743cSo3RDESwHfhNV+7wRoyzS0B2CYtGGY1yqM26Hv7I9smapa4Yx6bNQniUh9G8TUX0bsRnkzVwMCS3CiinJQjOYt3Sm93bsNYNCSuIMt8tSvZpSU0QDHnxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gDvaIJ8Ud2v5jFGb9eUFAQbGvQ7rX4mjlBnrv0Dl8oE=; b=gGzLFDy9ZnH3xBKo1O9spQf7PUakACbt6vjzIiMs+nGNLjigZxStmcw8+jbwva1axcCEgU9nY4ApHEZ58kyWnbPN1r8lKubYbXBG8uKHBZvwjrRfk7iEImjYMLyW0BeSJn+YicUv03Zhsv+wpJwzHoTHbDqY77UB6qLrSDmHlE3F2k6lTOAQ47+gRSEZdbsoKF53m9Z+rMVmBsWaBDqGVbnXpzaOR0AYV3Zk3Ep8Qv4UHHFGsCn0Wndi1qWACoxG6rq0jdG3UJUK8yOcZhZSUsR3ZxSlSqnFRq9esPt2aoVuQi3C/6sP0b/eCmnkwl7nglU0tR7oZ1Dr1auhJioJfQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DB9PR04MB9773.eurprd04.prod.outlook.com (2603:10a6:10:4ed::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.14; Wed, 25 Oct 2023 06:02:05 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::d924:b650:a2ad:7b25]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::d924:b650:a2ad:7b25%3]) with mapi id 15.20.6933.011; Wed, 25 Oct 2023 06:02:05 +0000 Message-ID: Date: Wed, 25 Oct 2023 08:02:02 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v2] RISC-V: Add support for 'Zacas' atomic CAS Content-Language: en-US To: Nelson Chu Cc: Tsukasa OI , Binutils References: <1279cd5fe3d0b809a20e18ac61f817017cca7ec9.1697946848.git.research_trasio@irq.a4lg.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0078.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::19) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DB9PR04MB9773:EE_ X-MS-Office365-Filtering-Correlation-Id: 7c84c1d0-34e2-4ece-d319-08dbd51fe9cd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eJpihC5TAh4nMf8eIdpV1l0ierF6bFp7GiJfYCr2fmGG3bVP7gqgNSA9LVkfzi21RREc5HG0FrkdySdepNDI5Vr/XnQCqaTxV/fyjHezbrnHvnfCNyrbcQfW1v+KnTPlQPk+j1/NsJh7E4Yk5Z2KUIaHJANoRT4CCgqeYyAHMiFfyNpDn2LhRykBMTNK3pMXPRz3jSV2pJDdxtgVL75b71p4FmwFs5fGKxBjMIL+vBl+iGnNw6GdO6FtGPgMmEIxQ3aBYSWuxNKTjdxrQrMK3wIQ8lwxVstQguuFMZEmSVXr0hCv2D6bwCLyKxSNE9mh7q88wjgfxQlrWQTTQcoCPHNekWIB81PG6l8r+kCKA3PovNQIyaXNeL6N8h9yo6aoYesM6CqDT7mdDYPGgDIN0mwMK87XhkVdYwYp88Ar7mZH+ysmMmNCCn6AAxOF2H02QVQ4FFEzDcQdJn3WIdp+Drtej9EoET9a/BzW1vmZFBFY9bjVMQAlHdBGCvtsezOpkrepThmcsz8mj8LSeOuLT/MYAaM6cPYVt5bBa3DpOBpY35EFbJkcSRkop7O3Ij6SOkga6gXXlOikNkE+IbpDgEst/tQMdt5+h+TE8blt596NOGzlgdPaeDQ2OYOVRDIGS/0fZeIzNbqAowCGoS6pfw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(366004)(39860400002)(376002)(346002)(396003)(230922051799003)(64100799003)(186009)(1800799009)(451199024)(83380400001)(53546011)(6506007)(6512007)(6666004)(6486002)(26005)(316002)(478600001)(54906003)(66946007)(66476007)(6916009)(66556008)(86362001)(38100700002)(2616005)(31686004)(36756003)(31696002)(4326008)(8936002)(41300700001)(8676002)(2906002)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cTFiUGsrN09XUFRFQW9mQS9ZMjdxdDExT3NlaFFXL054K0h0d29LWFRaS09N?= =?utf-8?B?NzkyMXIybitqZlZnS1h0bEVBV29IQmdoMm4vOEFQUnZVd2JIaVRYRld6SEEy?= =?utf-8?B?ZjNLK0h5RTk1cGxqNGp4bzZqL2c3Sk1OVk12M0MwcnViNGg3dmVGVmRWejNP?= =?utf-8?B?Ny9yd3dCZ2plQVVSdnN4QlEyamRoOU4yOVZOa0Jnd3psY3VvUUlUK29rR1FR?= =?utf-8?B?U2ZQK045ZjNvTFpGUnd3bTF1TzhxVU1NVFBDMXQyYkpYTXIycmowa056SGxO?= =?utf-8?B?NHR0U2hTTG1PbDBOQzV1SUV3dklzWkwvUGdqY3BQU3QydWZ4bFNwaDBhRmpX?= =?utf-8?B?dkc3eVpnYXNJZFlsMkpTNWVqaUtVRktkWTBLczZWKzBKMzhmVVE2U3NzMFZF?= =?utf-8?B?NzZPQndlUGhTMzBYbGU3UW1xbENYSW1FRXQwODNiRW1IZnNhMXFOeHJSY3ZD?= =?utf-8?B?TzNNT0pES0lpRkdoTVJOZVYrcGJ4UmtJWndJNDQ2NEJxSCsvZk1qcitkSktm?= =?utf-8?B?UVk4bTdUSHBUVGFFV0I3M3BRTnhXbGE2L01RWGVTQkVKK2tpYWxlTFI5aTR0?= =?utf-8?B?ZzYwSE1kV3NXUTV0TTdiV3F5cUlTN3J0MTEwTVpNL2t6Y3ljRTV3b1diUzhH?= =?utf-8?B?L2tSbkFLT3pUaG5VVEhpbGg0MXR5WXZEc29VdnFkTjgrQVkrY3JkVUsxVk92?= =?utf-8?B?dGhDZ2pTZGtXRndTcXNzbS85djZRTmZUOTdMd1pRZEFhSEkwcmFTSmsxZ2dn?= =?utf-8?B?UmphS3BPc0h6M0tnSkZmVnA2YXdGaGdYWWFHa2FTZW9FaTJ2ekxuUDBHTUc1?= =?utf-8?B?RlpMMlBHczVua2ttRGd1Qnl3UEh0ZkxMYW9wbDd3ajJ2Zjdwc1oyUEJ0TjRj?= =?utf-8?B?dTZCNlFXRDluOVZRSHZIS0V6RDU2SlNWbGI0dE1yRFU2YktqTmRFMHlZREFj?= =?utf-8?B?amEzZFE5RXlzSVVvN0t5MWUrYmxSNEZTM1BlQ0NndXIzbmx6VXNtSnNtS2h1?= =?utf-8?B?SzdZUC94WXdkdlVCWUpNWDhLT05jaVdYODlhQjlNT09QTjBObFI2aktiRDVH?= =?utf-8?B?Wkp1VzZUNTdnRHZleDNVQUNuaTljbXhrZmRmTi8wSXdCSmFpVFIrRTRja2s5?= =?utf-8?B?ZWNQQ28zVG1jbE1vaVhNY3BicENvOHRkM1V2L25IbG1HejdyYTIvMURTYzcx?= =?utf-8?B?ZkNFbVRlT3ZVOVFPNHhFbWMrczZITmdXU2xjZngrUGxJRzhPVzRhM2NObUsz?= =?utf-8?B?dGFmaUZIUnV2Q3dzQVcvVFZEVlpNMElwc2xESlg4d0REbUIzMHpENzcwNlJK?= =?utf-8?B?Z1paYkRSOTZuckxQZEdMU2U5T2dXbit4S1QzV1V6UHY3cTFLSXcrWHFXakd4?= =?utf-8?B?dWkrYStoQnZHTGphL2thdEx3Qk04anZGcjA4VEFuSEJhL3g5QmYzTjNpUTQv?= =?utf-8?B?a1hGc3Q0T2xPakVxTzBKczB0UXdGdVBhb25YNjFER2tUQWNxUTZZcm84aW95?= =?utf-8?B?QzcxSkt4U2MvYUw3bW9Ca1RIbkNobm9NblhrZi81U1Z6MnZXVy90K0xQb09V?= =?utf-8?B?ZzV4OEVjTWJPQmlGNjF1OG5nbWpzcUpESzlnNjR0UW1Dc2RPSmE5b3kzaGZq?= =?utf-8?B?akZtV2wvTnNmOWxIMDc5alRySmlHRXp5TEhlYkZsQm5LM1dzNUZhUlRLSzVZ?= =?utf-8?B?MVJ0N2VuODYycmZSSys5TUY3MUxva25jajhKR2ltV2N4OVpsMFE4TWdnclBD?= =?utf-8?B?TzB0dWh5M2EvM2tBcTZoSmYrYXN3RlBSSEdTeFNVcy8yZXFXRVRPZVF5bUNE?= =?utf-8?B?SEZLNkxLbFVvZFNkMFkveTJXTHhqNS80b0Z0WGJvSTR1QTlPN2NndWpNQU95?= =?utf-8?B?bFExZ2FCbGlranBqMm1OVXpGRW4rczE3ZjN0ekQ4QjU5YTJ5MjVxMEw5My9r?= =?utf-8?B?WTBhbUJRUnRoaGpOL3dOcUpremVlN0wwbFNERlZET1pCWmkwRFE2QnBzM252?= =?utf-8?B?bnJkL0RyamJKc3d2bE0rQm94SnpTQlNWcUUxdUhiVm5aMndYekN2NVcrMEpq?= =?utf-8?B?MTErQlVMOTgxTmxiL0ZJa0J5TTFnOVRWVzJCc09LSk1ESnVGWWRRTFUvNm9K?= =?utf-8?Q?gCcUuOP3wXfEo1xt2bGErRzyI?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7c84c1d0-34e2-4ece-d319-08dbd51fe9cd X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2023 06:02:05.0904 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sWVa3DLCBSZrPC+EvbfdxFeLt/maOlM/HrQ8CbQ5hA7Q16+QeXvpKgwU0FXVXEohaJjEeffmzbXZqOXIHXzezQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9773 X-Spam-Status: No, score=-3028.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 25.10.2023 04:15, Nelson Chu wrote: > On Tue, Oct 24, 2023 at 2:03 PM Jan Beulich wrote: > >> On 24.10.2023 06:07, Tsukasa OI wrote: >>> As a single patch set, I think Gianluca's patch with a minor fix will >>> work perfectly. But, the concept of register pairs / register groups >>> are not specific to 'Zacas', that's what I'm talking about and the >>> reason I think Gianluca's patch set's match function will not be a long >>> term solution (actually, I found Gianluca's patch set after I wrote >>> mine, but that wouldn't change my opinion). >> > > As I said before, I don't know if we really need the constraint checks for > register groups in assembler or not. Or on the other hand, I don't know if > we really need the detailed register constraint checks for assembly > syntax. I remembered you completely unacceptable to fight back that you > don't care about hardware testing since you were doing toolchain, but for > those DV guys, they are also one of the users of toolchain. However, for > many things, lots of users are used to using some behaviors or code in the > toolchain. These behaviors are not wrong, maybe they are just not that > rigorous. Even though your idea may be beneficial to some people, it can > also cause problems for others. > > So, I was not rejecting your idea before, I was just trying to let you know > every change you made may cause trouble for others, especially that some > behaviors are established for many years. Since the rvv register group > checks were argued before and removed, I will suggest we just > remove the same checks for zacas. If other maintainers support that we > should also do these kinds of complicated constraint checks, then you can > ignore my comments. First, despite being sent To: me, I assume your reply was targeted at Tsukasa? Irrespective, while I'm not a RISC-V maintainer, I'd like to advocate in favor of these checks (uniformly wherever applicable). If they pose problems to certain people, let's have a command line option to suppress them. (To some degree these checks are related to a remark towards hint insns that I had raised quite some time ago: When doing things really strictly, I continue to be of the opinion that those should only ever be expressed as "hint", with their non-hint forms - e.g. some kind of ALU insn with x0 as destination - at least warned about. The main issue there obviously is how to pick among the many hint forms with just a single "hint" mnemonic.) Jan