From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 9963A3858D1E for ; Mon, 19 Dec 2022 21:11:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9963A3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BJIx6vt030197; Mon, 19 Dec 2022 21:11:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=VenG8YWTJRyd1vnM2aht0+XIT2lnBrhXAYuEV6TDTAo=; b=xMqrU6aKS0f6pmRx53Fbvo8LZ+1XCNNJgHtuLgwCTaIV0eRWNdlPkGsDk59H9l4yXJPd Qp1vxZWZwpk2bCVkKQcyFsZWAeDjK9Z894SRRvoZIBOALg/BxVcE5rWMIL4L6URpmLM+ 5FxP0hoqqBoVkkirqRtiUeGkkS7LUr+DB0+1Zh4fw10/YVVFve9C58que9BPxHSICUZx x4eqSS+nzI0w31WdVuq8p2eJBACsyvQzUjBym2bHrhVKE/WgYvBmNb3YXlkIJz89V4U3 Y9Yrql/UuV7pmJ6ingGR1koDG1wlm3dAhINqj32j/n85Yw/moHM36hUDjII0ZNrUalRT 6A== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3mh6tmuxq3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 Dec 2022 21:11:56 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2BJJgwZ6027658; Mon, 19 Dec 2022 21:11:55 GMT Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam04lp2046.outbound.protection.outlook.com [104.47.74.46]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3mh4743ap2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 Dec 2022 21:11:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Uk0gZU6ttvKjaRfI/7kEKHt5hWV9NkRPrLQrhaR5h0kh0NvjW/Vvd2HQYmEeXGjkjNMOGxpeJL2kNcpSngKPe1b3CDmPCzYtIVjPN5JsEjOqf3B19BJmqB6bbh4diypK+zHNvQuC9bo3N4fFLWkvA+GMvzdXk/v4SwbRqAH+nzOz4/mTRA6yyvsXd/92mL8ZwfrekuHzvBjp8RGDyTXJLA8FgwWIMybecQTlGJztTz/USI3wUfbURWMJpp1zJKSBgs/yw2b46BmPKoKvHMPD1YawJXr9EMQfblZBuWOcxqnkW/gll9B4VghR8pl9CRf8ZG3rtqMJTFxFkgfJqeoWUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VenG8YWTJRyd1vnM2aht0+XIT2lnBrhXAYuEV6TDTAo=; b=ctvP5Jeydn5yFC+ehM2jbMHAlCLtprUvYucwipR5vHZ7ZCuQGBglmcmfekUKF7YMNslFLMQ1ZYYLbzmQiWy9y905KvjARqaFSS1nACvSbpMHMY7/aaQxVdu36ftZ6fCPXhcWZnm8vLqScTJs0kInxtNoB+vmIUvNP8AcbsA6ffTvcFuMlNzIvNDts0xOwiJwJ3DWjl0tU/ecMZbQ5BZfi3dY378y6guJcxuiLfHLVYmG5w2FpLVPBlB9U5o3o3SGlUsXNblMJNbE/jsCoD37Xhn0IYZBy5EEyIX1adElmFkur4fVbfIATlXNn6Na0OjMHzoZC0HYBicqPXCHTpJAWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VenG8YWTJRyd1vnM2aht0+XIT2lnBrhXAYuEV6TDTAo=; b=Yv3JZ2pLpNx52uqDSDnX1MEGx5Eh0mFpqWR8UpdOzLBxaKNk1ASP2jWcBs0t1m0/Mc2zfU4nZKc5Hhk7whJoM8j+rJg/K0yEJbuhVsXSf0DCvxoI6S6JO+pvXzfot1fNhJ9FmJFdwCbQBMGXpoIZ1QE5j8igLJQSss7Fk7/NcTM= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by BN0PR10MB5320.namprd10.prod.outlook.com (2603:10b6:408:12a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Mon, 19 Dec 2022 21:11:52 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::ee70:1952:4416:1bdc]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::ee70:1952:4416:1bdc%5]) with mapi id 15.20.5924.016; Mon, 19 Dec 2022 21:11:52 +0000 Subject: Re: [COMMITTED, V2 0/5] SFrame: add support for .cfi_b_key_frame To: binutils@sourceware.org Cc: nickc@redhat.com References: <20221219202328.1442022-1-indu.bhagat@oracle.com> From: Indu Bhagat Message-ID: Date: Mon, 19 Dec 2022 13:11:53 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 In-Reply-To: <20221219202328.1442022-1-indu.bhagat@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DM6PR10CA0026.namprd10.prod.outlook.com (2603:10b6:5:60::39) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|BN0PR10MB5320:EE_ X-MS-Office365-Filtering-Correlation-Id: 4be7fe80-24f1-4767-c61c-08dae205a6b3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BSELjMURCvqIlJyIRINsIvyucSqqo9FvZWxqQ7e2Az8SZcRPQhyfXvQWBx9NSbMfTz7CKU8+UbC3ZG6fRl+AyXPRTBRS6nbTWj0ugfQS2KW4pnEMKANPClRZPLMMrF/9uKftRJ8PBH2ILzUVdoSHxjqjQrFDEDrEHOdFfl596I8XAhoJHIaN0gsLbHON9A15CGtknqT4z/tXrzSqrWfVgRi0kuy5AKKkQvf/aIPh3PiMQYOFurnjoR4/kLdgBVSpC7Tdjel/uo+h3Vil1dPOt5wcu4aKXFNMo1oEOQLgfhc6XVDKE0FoRNyOK9JAmUlzoHo9JBaNyKs50SfNEvHd5ywyqCnFYCpma1PLfqObP/gh12CKjz7tK3P7EKaK5DShLaacAWYm2xVpYdUP2rs1bqw9FP9tm4oMMgmF7aN/yCJyxSeEPlbpmmOqhXNxSX5IW+3b7ZwCuOg2Qorsz+5LbKbQVYO80FqjbTr6jjDUt1YHvpCaaZ0tu/+1PqIzioTP+xTgviS8jqzLfBiWPaFTpGh1ueAPcHXIwTXuWSbGVGh2QqxfaM7IuT+WQTvrObzqlW4rtV/gyoFtOQiLdjw8hrYpa7zOqXABK9ZoUp64EggzBGEsmzYHOqlPRa5mzCRxEx83iPLElUqO28z4yumM66gyUyXFakNr2jZTVad1X59UZflOKSVQze3jG79dBIMPi589RMSJ1WCGLiV3qG24qx6CijcxbLgEFJUIEvhd6DUOKG7sy2Q/8kRRrj7aIbiRuW50K/tRuFd11gfFArw00A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(39860400002)(366004)(136003)(346002)(451199015)(66556008)(66946007)(31696002)(86362001)(8676002)(4326008)(316002)(5660300002)(66476007)(36756003)(8936002)(2616005)(53546011)(41300700001)(6506007)(186003)(6512007)(83380400001)(6916009)(38100700002)(6486002)(478600001)(44832011)(2906002)(31686004)(142923001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MDAyNHJIeW1od29hL05CV2pJQnhRN3NEUk54c3FzQzZGSCt5YTM0L3dIejA5?= =?utf-8?B?Sm5uVUZ6a1FMajlNVytwd3duNVZkUmZGdFFoK085ZThMbzNJZXk1YzVBU0hk?= =?utf-8?B?UEdtRDBuZ3VuR2J0b0VGVEI1MmZxVWc2eVk3dzB3ckFDRWw4Y21hSWJMSk9K?= =?utf-8?B?TytvTnFERnVvR3ZPbldRbTZYYWdsL3dIOE9ZY2tOQU9ON3lrOVliNjJNaG81?= =?utf-8?B?L0FISG5HRzcrNm5zVHprTVBRb0h4K3V3L1ZidnVHb0hNRldMZGlsVWVMSXdx?= =?utf-8?B?Mm5McWsrRjFYV21UQWoxNEpWQ21rQlB6Y3RtUTZnSjNDRmM5N0hGZDkvcG1o?= =?utf-8?B?dlNvMG9UaWhlMHR1VnpiZkwyUUR4NW9aWEo5U3hEZjMvTmFaTGM0Y0Nra2hx?= =?utf-8?B?UUZZNThjMzBpZ1JxakRzd1c0MENIbEdGcHJ6QklxbWpUTHR6Q09Db1hqR3pW?= =?utf-8?B?THhuR05XS0dBMkdsRHNTNStBRE1QMjZvcG5uSHNqc3ZSMmdaK1N3aWppU25W?= =?utf-8?B?V2IvSjhsV2N5d1NNbm1PbkxRalk5bFBkdENKY3lYbjZiWU56cFZwMHZWWDZh?= =?utf-8?B?Nm41bytRR1F6eURWYit1WTJMU1hyVDFiTy9Sb1RTbEViUUlrVjJvOHZMZUgy?= =?utf-8?B?d25nSk1QMDZEMXg2eUZ4WHd6NDF4YXdtMk5UaXo0NUhPNktwMlh3VE9jQ2Nn?= =?utf-8?B?UktOTjVJT05LRmR3b2xHUlRuSWRUemFRTmFFaFZUZU5Xb00rblJyUDdualNN?= =?utf-8?B?SWFQd1daQkRXejZHVlp3R2xNWmlvc0V3ZWV2ZlJDWDhkQmJJS2JsVnhvYzVJ?= =?utf-8?B?YStCQnJEaWVtNG9pRnhYNHJXOTkrU0pKTGpXM3VzT1k3cXFqTWFWU0JBNCsv?= =?utf-8?B?VkUyUDlEd0l1WnliNGswbkgxVUNJYXpBVEhrNk15ZmkxUmtMQW9Jb3VCSU92?= =?utf-8?B?ekp5OU5VVGtycmFZMmw5cWU1QmVaV29iVlZwMjFGS2c2UUNNZytpTjFsek4y?= =?utf-8?B?MkpvSFk2NzZQWXJPMHZ1Unl3alV2Sk1vSk13dGNYQU5wbmpRdGllck9sUXFn?= =?utf-8?B?TzVudi92R2hEczlyQ1FKK3FFcG5HUWlHeXJzTGRHb0ljcXNDamtPMUM1REpi?= =?utf-8?B?azdJWnl2RVlFSWtMNktRQnhpSkFRaWQvektqMm1lTmJoV0dLUkdEajNzRzZ0?= =?utf-8?B?bHkzUEpqekYvWG5pVEZoazN2QWhmZ1dhUXl0OUR0U0FFUEtYemFidWlWQ3A1?= =?utf-8?B?SkpBbGtnVkNvZURkd1dhSFhKL1ZlSW5EdExQZFZvdldGUXplOW53a3lNZS96?= =?utf-8?B?MktmbzlJQVp0THl4eTI1UlpWVGQ3R2tqejRmR0plc2R0WHpIZE1FeDNnd05G?= =?utf-8?B?bXFTM1dCVVRmRDRrTW9GcG5zQjBDTiswbW9oMENKamF4THJQaXNtSXFkby9H?= =?utf-8?B?ek5tS0pHYXE0N1RzUE1rRDBFSjNDdU52dVBnOXFxdFZ6QkduRytRQ1FIUUNC?= =?utf-8?B?aXdEbXRZOUx5WlpVbllORkM1MSs2dlQ1a1hPdE0wTXVIc202L1AyYUVFYmFF?= =?utf-8?B?QlBTYnJ0RVl0anQ2VHkrQmpUQ0NZUXd3WXJjSlBpT3czdDZUa1RUNUxUa0Rm?= =?utf-8?B?akNLUVRCZzVaZUNtaDZHc2pCUXJTMHQwNWNnTHBOSUpXYVJHVWs4a0hPRkEw?= =?utf-8?B?MUpGUUpvbkMvWDRNd1FMaDNyU3pSai9IdlNnWDN0eGk2b3hXSFZzNEF3WVBW?= =?utf-8?B?TXZPMkt2MjFwOW80TThPYUUxeitMUVV0QTFCYkdzdjF0ZTRMMG5zSzMzdnBr?= =?utf-8?B?U3A4QmRWUmM5WTlqWUFiSkhZeXUzMUQwMGNNSlp1ME9ORXgxL3BSa0d2dERC?= =?utf-8?B?Z0xBVUdIdkhMVFlwMTRsZ2duTGVVNjY1TytTSmxsSVF0YTRUQVBBeFZaa3o1?= =?utf-8?B?c0w1ekRVNENhcW5CWkxhUFRKdEVobWFua3RwSGNiWVFBelNwSFlJMVp3YXFV?= =?utf-8?B?bVdpOVVTQ1YrdmlPMExIWDMzSTd1enNBZjlvOEk3bjNSL0dSRmlndStJUWhZ?= =?utf-8?B?QytoM1VrMFJVSVN0WUtFRzIrZUJKTlZCS3phbk5ETjlCNm1MenlRRlFHcUUr?= =?utf-8?B?d1hzaEJ2eEJDSVZoUzl6NG1VYTExSFJMek45UVBQbmc2a0M2Z1dYTmpwUmxU?= =?utf-8?Q?WUbFoJ47+LN3HSld0hDMmOA=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4be7fe80-24f1-4767-c61c-08dae205a6b3 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2022 21:11:52.8515 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 55Rq9v8yYW/xdprLxWsiud/WNVr+6LbkrPjTT1bfzUwNb+CxLgjTLFsUyb5VGixbOVClhzo/DSdvcc5rADmEbQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5320 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-19_01,2022-12-15_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=999 spamscore=0 phishscore=0 adultscore=0 bulkscore=0 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2212190187 X-Proofpoint-ORIG-GUID: yOUXOqkUMkrE1-Qrh5jYD_o0fv-H2ETE X-Proofpoint-GUID: yOUXOqkUMkrE1-Qrh5jYD_o0fv-H2ETE X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Er..no. This series is not committed yet. I meant to send this as [PATCH, V2] for approval before commit. Sending another email with the correct subject. Sorry about this Indu On 12/19/22 12:23 PM, Indu Bhagat wrote: > [Changes from V1] > - Rebased on latest trunk. > - Fixed the testcase as we now emit "[s]" marker for both mangled RA in > register and stack. > [End of changes in V1] > > Thanks > > ---------------------- > > Hello, > > This patchset adds support for handling the .cfi_b_key_frame assembler > directive to the SFrame format: SFrame format representation now allows to > encode which of the pauth A key / B key are used (for signing return > addresses on aarch64), and gas, readelf/objdump now allow for generation > and textual dump of this information. > > Testing notes: > > - Regression tested cross build of several targets on an x86_64 host and an > aarch64 host using a regression script that checks for failures in gas, ld, > binutils, libctf and libsframe. > - Regression tested native builds on x86_64 and aarch64. > - binutils/gdb try bot showed no new regressions. > > Thanks, > Indu Bhagat (5): > [1/5] sframe.h: add support for .cfi_b_key_frame > [2/5] gas: sframe: add support for .cfi_b_key_frame > [3/5] objdump/readelf: sframe: emit marker for SFrame FDE with B key > [4/5] gas: sframe: testsuite: add testcase for .cfi_b_key_frame > [5/5] sframe: doc: update documentation for pauth key in SFrame FDE > > gas/gen-sframe.c | 26 +++++++++++--- > gas/gen-sframe.h | 2 +- > gas/sframe-opt.c | 3 ++ > .../cfi-sframe-aarch64-pac-ab-key-1.d | 27 ++++++++++++++ > .../cfi-sframe-aarch64-pac-ab-key-1.s | 36 +++++++++++++++++++ > gas/testsuite/gas/cfi-sframe/cfi-sframe.exp | 1 + > include/sframe.h | 25 +++++++++---- > libsframe/doc/sframe-spec.texi | 8 ++++- > libsframe/sframe-dump.c | 19 ++++++++++ > 9 files changed, 135 insertions(+), 12 deletions(-) > create mode 100644 gas/testsuite/gas/cfi-sframe/cfi-sframe-aarch64-pac-ab-key-1.d > create mode 100644 gas/testsuite/gas/cfi-sframe/cfi-sframe-aarch64-pac-ab-key-1.s >