From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2041.outbound.protection.outlook.com [40.107.247.41]) by sourceware.org (Postfix) with ESMTPS id E39933858C52 for ; Thu, 19 Jan 2023 09:38:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E39933858C52 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kuaelZUir1A2WL7jrGmdtq/AeY3OqV51K9OC0LCEt276qRstq6OW+4SIbovNyBhaBeyAeFCjP7t2haN0wBhEtNfvBNVw0WBUXpiHgBkYsWsw5d0nz+xXXwb8it0z8x7Imh7FFxHuDZ2nD6k6I8zz4Aze33dTClC0D+OmJPGkP88IF/ZqusYPilbOc9rcWbwqUGAQfl/pBuBlCtlUIzoAwZroCoPXFlXgVnnh9myo+KK61mDatKppyohgpr0f6G4zM/knuZZGN4Wqq5+9XBkAVWiM6xClmVFbJr8jofVEO4YaOucadtewmR2Taf5yqehMwGL6PyY2HiX8N8o3GL4Gpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q5aSuuPTey/YqdRlkcLtsq+BokTztCQ3XAzNHGZcLTg=; b=NA3S0+/Q6fUD5otG3Y3zPUG7MrQCeC36rW/WvZAYuLtfZQVDr2JJ6CKgpSgyd3xnT5SyUNFKPEe+TSpjbqXalPV2s2yGGvTLEmDVCRG2/3Xe3Ho8vXH7hjTPyn2ZTEu4Vkme5QFbQnnASceYxRK4bO/VKAlCNQftGhbnP1+fZ+d1nKagVaBCLTQdAvl/nBbWcXoqZcjeiM7dVHMK0rlqHwMybjL6cOixRDa7YVBARcdHJzEJy5/Fq6/BkyyKGtuJ/9NgaBZ5NI42g+FKXFPNjZin2uvrj8yDeGINJT9nRfV0NwqjqNy88mlMzRtOzDJmJpyJ0l7bksROH/QMSNNCDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q5aSuuPTey/YqdRlkcLtsq+BokTztCQ3XAzNHGZcLTg=; b=Sj/vmWKdHT86E9gVPD5PoyCX//Vx5biNtJqD1Pemj7f/CubJ7ctSXLpIcoKoWY02Y9W1f48OpGQIHqKs2SImViPVueyJqF4PEra2Q1/Jy84sE9hGoC7OujMu1/hYvDQ8uBAEQU9Me99A3CHfGfpqIdptW/EF0XPD/fc36xDhj1omjlUpInfZQ8FpLwaXFp2OBsv/zw1l90iTWvuOnsnW58LvVIFym6Iv+QPlMM8Y5m3/qju82vTxYGHdh8iyBGWIjH3yLgPxE9/ouwe0kL99bey/NwVfWHYoER3shS3kWiC+ZkrCp5mLhLYwgudl8Gypm30HuIHIpbkhJr+bAl8m8Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB8030.eurprd04.prod.outlook.com (2603:10a6:102:cc::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.23; Thu, 19 Jan 2023 09:38:45 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.024; Thu, 19 Jan 2023 09:38:45 +0000 Message-ID: Date: Thu, 19 Jan 2023 10:38:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] Remove duplicate pe-dll.o entry deom targ_extra_ofiles Content-Language: en-US To: Khem Raj Cc: Jedidiah Thompson , Zac Walker , binutils@sourceware.org References: <20230119035126.1172654-1-raj.khem@gmail.com> From: Jan Beulich In-Reply-To: <20230119035126.1172654-1-raj.khem@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0142.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB8030:EE_ X-MS-Office365-Filtering-Correlation-Id: 0447f27e-8397-44df-2e10-08dafa00f511 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qvc4UYaW3F6SzoI2XpwXE1M401pw75vUfbDp6LyApOaxoIt6aSRPNkTkG7j0317h9rYCySgAqaj3mWty3YBFEFKE9nIBK+AN4Zh6aomnRIi0NymLox7kIUrttdo/iRQn/AmKAb356Lm7aJeH0Y+g7pfximFIoueS4VuUhab+BkDKL0KCzB8xqKslfymRN609/dOd7XO6bgRLcuRmFMNN1OsvAsbT/7V4UiEBu1H94982Oq4eDzD/NzrIZrRhKtdf2dB6VFWyThbsYKr1Uen/dbjT9mi1yZ5w4C3Et7mYs2XMCO+A+7FKDoq6cGVIZwQ8eOf2vuBARnq9yhglRVcmNDWkaNoVvtSQ83lfpdIpAQSPy5kyeU8I/IAgUZANQKhqNWoJ2WhgQiLXFXdgMVNgzcg3ay24opcH2ZCooglK0YGgHqMIblgBximAQPca03BXzHlZzj5QVrquBqMy8ILT9LeLcct+q82zgeq0u/I/+p93KEF0ImVIGgt+v7YXNOZhPXb7lvt3xwiDUOG87QcIpRx0WMhVmMvVtnilsjMBIIs/gpVN2O5RWx1sE9xzptMkasZy1LB908PTUrbFOe58Dm1dEDlQegQvfD/OHtIOTXHjnlWmXz3dmQoVQzp34q6WrJ3waUe9frSmIt+JZ6olcjQ5x1ZmvuC+z0grYJ5Vp93GE+56wXFvzmO5HkZvZiM4JRFMIDJ+LHsofq6sFjv6PtChg73j5XPSt1F6ET9OrNs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(136003)(396003)(39860400002)(366004)(376002)(451199015)(36756003)(2616005)(66476007)(4326008)(5660300002)(4744005)(66556008)(6506007)(6512007)(26005)(186003)(478600001)(8676002)(6486002)(66946007)(8936002)(53546011)(54906003)(6916009)(316002)(41300700001)(45080400002)(2906002)(38100700002)(86362001)(66899015)(31686004)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S0hQK3pZLy8wcW1maE5hSG9zZEtGcFhZeHMvUkFPOTZSaW5iTXFuSC85RHp3?= =?utf-8?B?V29CYTlVS2hZZ2lwNUdtMXgrZVNnUkVPZXg2by9XMFJKc0hUWEFwMXBaRXJC?= =?utf-8?B?RGhXL2t4Y0VLYW96dXdzZFV1T3JmdW9rZGQxYThCL0kybDJRbEc2bENzTTEx?= =?utf-8?B?cnFocStrWWlOczZnN2p5TVI4Q0grWFdpWURiOWM3M2trcXVsU0FFL3NnUkhW?= =?utf-8?B?ekJrbkZORGt5dzU0eEZTOFFTOGlWb09pM1dXcHRydkh4T20zNnc5Tjc2RnFp?= =?utf-8?B?TzcvaGttWC9XdElPLzJBWkN1ZWZrNVRhQTRjTW1Ma0MwUmsrZW02TkNsa1Q1?= =?utf-8?B?ZE9uRmxEd1pPT0t2dUVwSEU1WWthS01IS3JQcm1EcEppL3lPQ29ENUtMZW5W?= =?utf-8?B?VloxQXFzT0NJUXJ5V0FselRINTZOd1Vza1ZBQnZqdDFXTHpMK1g0VWtDYmtv?= =?utf-8?B?bVJBNkxEVmozUUZ4YyswT0lzT2tuelJkQW1lam0wTjhFMDc2cEZvV3M5RmJ0?= =?utf-8?B?bFpIeTV4MzNSbDNoVjBWSWdiRjdjVS9YUEIxemRHWDk3RkFScTRSaC9qUWYy?= =?utf-8?B?U0NMcC92NllGM0JQekE4UHdSZTRSTWRiTlcwZzFaZW84eGxHOExDVTE2dW9T?= =?utf-8?B?R1FCbVo0OTRxL3ZsUlB3NitQVEx5SVd5SzFaWjdBY09ocXJpakZQdjZRM092?= =?utf-8?B?dW1ieUJHVG53S083MzYvai95UFU1amMwM0xscUVjV0lIQnhUVmNPTUU3TXhN?= =?utf-8?B?WXl0YittMEdjM2ZCSHpSeEhyWFk1ZGMycmk1RDRNM1NiR2xqVmRuT3F0SVJU?= =?utf-8?B?eWVML2NDZERIWWJCcnZ3eWgraFFvcm90VkZtdFM1WkpNNzNsWkttem4zcmtY?= =?utf-8?B?YjZZWUFXczd0c1ljN3dJaHlpZmMxcW1RVGlhckFMRjJFOFJoemY2RTZ2ZmlK?= =?utf-8?B?S3VMQ3Z1YzIvSlZYUlU5Sk5iOG81RWhWM2lxeVpDTTFhTS9pOHVqYmtIaElX?= =?utf-8?B?dHlaYUVYTFA2M3hXbE5NcXgyOFlDNEtmemNHQWhIUVQ1N3RNamJ3UFNVN25w?= =?utf-8?B?c2ZlckZKeW1FN01Pa1EzRDFrVWw4QTRVS3UrdEp3d1I1YnllWDByM2R0UVhq?= =?utf-8?B?UHFDVWZEcGt3WEVjQWUrcFozcWdCWVZHM1V6WTFudjVSQjJJK1BaMDVtOE1h?= =?utf-8?B?d2pnMEJrWEtkeGl0dHJQd0tKTUdhcjJ5U3UvN0lRcVNtaC9Ra09sQXo2bWRK?= =?utf-8?B?QXRtOGpjL3Z2UTE5cXZGRFc3RGhMUk9CR2ZKYS9LWXViamNLeVZlWmJZTHB5?= =?utf-8?B?ZmMvd05XdGIxZ29SRHMvamJPek91dGFsZkh6Y1BJb0svVStjRzhoem52RkNW?= =?utf-8?B?TTQ1SlNuWEpUQ1lndWprUVBQY1B5alZmT2JQbUducDdjVjFRQndBam1QYVZB?= =?utf-8?B?Q08zTG5LemNEK1BPcG91NmlRN2ZlWFVSbThyU1NvbTVoSFhvYnhhcjRFdlp5?= =?utf-8?B?OEJpTmV3YnRGQithOFRhcDIzTDdxaG90eEluelRMNnBSY1l0TzZacHJwc01i?= =?utf-8?B?ZU9hYi9LV1ZNV1lOVnZPLzlrSmdQT2ovVElGMjJjUWtaTGhyUHJrWG9KMm1n?= =?utf-8?B?eEFidFg3L2pZcnh6WnR4MUhaakc4bDVwVmVYMXpoRjh6djhFTHY2Z0NLaEds?= =?utf-8?B?L0xMeXpqelAyRS8wREdlUDB2QjJjVDlZNWlaVVh4SUJPRWcrWXpnQllvS25j?= =?utf-8?B?aXpEZEpJL1FjOTJGTlNDejJoeGlYR2luWlpFZndnU1JuUzg1NTdKelY4a2t4?= =?utf-8?B?Y1g5TXpBdTNQYjRCVWsveTBzdUNnTDNJSTR6c3hXWktkek8xSHN5cEMwUkhm?= =?utf-8?B?d0ZTZXRaeVF3Z3ZzRGNLTmZpTVNBWXBFbWY1Z2R6d0duWW0zQk96L0R1dUZV?= =?utf-8?B?UkhXT1BvQjJpanN6cHhUSXRaQlp0QUFMbDAxQzUvVHFwZFlNSHZRdjFyUGlV?= =?utf-8?B?S1U0QjVGcUlSU1A2TGxnV1oyMXVQWHBMK09NVGZ4ampxb21ydUVxRTFJcGxp?= =?utf-8?B?VnRJR1B2NzF4K0FJc09NUldvOVJ1eFFvQyt4empvM01iWitEQlFXaEZ2TnR6?= =?utf-8?Q?VI09yqOHKzWPE+S3YH+kSZySF?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0447f27e-8397-44df-2e10-08dafa00f511 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2023 09:38:44.6865 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0sLnz8kU6OKV86QedD2RdLl8Q12lEW5kvhS3HcqZjsgyDtUWf/qNLbDnqHJ998w58wLj4GVGyDUwag6+FovbMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB8030 X-Spam-Status: No, score=-3028.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 19.01.2023 04:51, Khem Raj via Binutils wrote: > Commit c60b3806799abf1d7f6cf5108a1b0e733a950b13 added support for > aarch64-pe which introduced wrapper over pep-dll.c for x86_64 as well as > aarch64, on x86_64 it was added but the old object pe-dll.o needs to be > removed too, otherwise build fails with duplicate symbols from pe-dll.o > and pep-dll-x86_64.o Prior to said change pe-dll.o and pep-dll.o were also _both_ linked in. You want to explain why _that_ isn't necessary anymore (if that's really the case, which I doubt; instead I think your change breaks i386pe as specified via targ_extra_emuls). Otherwise the duplicate symbol errors (which, btw, I'm not seeing, so there must be more to it than you say) need dealing with another way. Jan