From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2045.outbound.protection.outlook.com [40.107.13.45]) by sourceware.org (Postfix) with ESMTPS id 7B64E3858019 for ; Fri, 24 Nov 2023 09:05:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7B64E3858019 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7B64E3858019 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.13.45 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700816708; cv=pass; b=Sl7ZBl3H31UlAYUd2tbLcfA681xB/Eib73zClGCsCYohgLYQkKj7sU6q5+w86MRRyJZbkEE6vKylSZ3PTR5E+rThxotsT0Eu+fWW+iEpwgxBbBcWInjVJndmHHt9HzKhyvC/+1OO/1GfyXwU+ABTqLHMRLBmjuoocSpbqx8njEc= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700816708; c=relaxed/simple; bh=QFLsaL/eSrJPQjdZKCKSr+qcRlTe/witf4ygf87hvxE=; h=DKIM-Signature:Message-ID:Date:Subject:From:To:MIME-Version; b=wvRuQXQ+XeRATkkHQcaNOCwrXm1xGwH/pDV9FzP/huqYeFktc1u8zYHz/g3zWfNt4N3gbm0XewWXI52HKx3R0d4fb4gJz5zOFdSzTjCVxN0H0qiJsHHR14gAISO9PBeBA98rvQnDwtezJ2A99cXiDqt1ITdBgZUonYi0h8lJcAE= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VJlYCAbU9sNFSFVDo5Wf774Qy+evus9XbAakVESVJvAmY5G5KXMBKyRbpawOIpzLhCIqLf27Uo8VbRDmvjSMyt+YPJF56Hb/ywzb2ZqFm40rvnU3rnDalvwEoNXVxO+oxipp6aiyON0kMT1jyYT4Xwjgof27k8QiiMYmIteAE94xFL60veiFU53jV6E4jTbbIMtckKMIh/Sbn2LD/k9TR+gRbhZdilMx+l4WpGhPETEX7C5UUzFJiA0h6B5Ik23kpvR1KpwA8g30bOxqKWNgU25mX0HF7Uh+Fzln900GnM4G74wURVuU1FrPF5g9Q3m8PTV08mhVqP/pDpRS7DAbOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n1xuXcFGeJpljOPNVPbl6+WCRtdDfJift+0WZUdh3PU=; b=gJweJMKhAsN8V8J0xCYdqObtReYLLCIEJn5v03+2WW/NSNrCMqdL1gUhML2D2684oXKEbQ80lcW/d11MQi5itPxyelIIqk3240pm6vSZhFI0sGxwoJksR3jV9IU3Y7S9apgq970CkRtl5+ROcYzs641Geo5cXPZWYyF44u6aJiBBrROBdvKHeYyskx73GCpMKjcN5oFemEsruePwELp9hzmCMuYEc/v9T0RclMp0/IRvIVkuZmQKGfjVjFjgrV+dLfei9y2uj5T7iYGJx/WH231gYD0nXpeiRZ992WHTV+FfHcVzCIakDp+X05OLXrH7O8qJyDOhJHx8nGt5zQuC7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n1xuXcFGeJpljOPNVPbl6+WCRtdDfJift+0WZUdh3PU=; b=aqoLkNT9M71HNSXCW7p7T893fyUZK9Crg21ERtYBWFPz+bPcgBzZbJJkGqNizVAol39MYvDhed/YlZXeW4FpyBFKFygmB/EFlHnERZFX93j/wpnOg1FJOXE1S2gVpQgzPdWcqMSiehQe0TKNAfLEiZhspcO7xQCbilKfaKhYDSgpKtSFPtV+ABskdAkexoWAntDpXFMY/KigL+tIEv6tNA23moDHtIns7HrP/nubsu6y8czzjkc54ulb77CZ/MVrZqN/34ZssPn4lDQ+lYkqSHKiXZLlTuoOAmqzbOPASNfc2ahugL0ItZPP6oAjkn5iY88DSWN0+trVyJ9e4h4+ww== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DB8PR04MB6778.eurprd04.prod.outlook.com (2603:10a6:10:111::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.14; Fri, 24 Nov 2023 09:05:04 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44%3]) with mapi id 15.20.7046.012; Fri, 24 Nov 2023 09:05:04 +0000 Message-ID: Date: Fri, 24 Nov 2023 10:05:03 +0100 User-Agent: Mozilla Thunderbird Subject: [PATCH 4/6] x86: i386_cons_align() badly affects diagnostics Content-Language: en-US From: Jan Beulich To: Binutils Cc: "H.J. Lu" References: Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR5P281CA0033.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:f3::10) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DB8PR04MB6778:EE_ X-MS-Office365-Filtering-Correlation-Id: b8e369c3-4cef-46a1-25f8-08dbeccc7277 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hYyWxYvnGzPxmT0DwmUeYRaUvDWzapP0W21fBSSd3UwOUdYhMylCStTlT/HYHf51yN3oIACFDKaI21X9EeAfDKDS+OCtnnLicOfD6wwt/hKjwxh9YZrmnvSkbHG0A1HYrGyTrIS0Yrvgp6kLOsq9eH94mVtJwWPmcuWO5kwrLyb8bLzbyrmhNUCQPqaaGEbQNWfv0bYnGKiHqNkD0k/K7oqbcoyc8/YCxmt5KkItnYHThHwKpsmmA2vMtC5pddY2AHHYnm/pes7+HLosoXvDYoyahujdEQJL/3hIJaBAXVl5z13G48chi+GElOak8ywQP0OdY4RhVGfpZmGAMtmMqMSZEZXnAjhZCnFE1t7T2Ioa0OsINc+FVJLXEMNRkuowVNjj4UC/eaqj05BoBpdEArLX2NaXgiO2faXTNwFN9X5ju81wE6gHiKx482qtsbOKPJXmwE9w9j2JGEMYI+le/bjpm+65IwpKAsCKzsjx8dYA/o/nA7lxt2juOrhUiAv5Vaz301sDod0CMO0xsk8Z96rwYOyeKerUQo8l0rfwUdZdewxg2s70YcBO4zAM24IeWkGxzMk+myX8OkfHLqSn61dALENzR71LDVnNBTmcYL7Y8FSFl77YVoBqwnctdFMUqm+pHD1pMkVpYmbhLce1+bnORb7KSfGVSvHj0J/udYDZvP6yu2nIFL6VJqcUPTEG X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(396003)(376002)(346002)(39860400002)(136003)(230922051799003)(230273577357003)(230173577357003)(1800799012)(64100799003)(451199024)(186009)(2616005)(2906002)(26005)(31696002)(5660300002)(86362001)(6512007)(31686004)(41300700001)(83380400001)(8676002)(8936002)(4326008)(6506007)(316002)(6916009)(36756003)(66946007)(66476007)(66556008)(478600001)(6486002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eUlTSHlCMkkwTG1QNkE5NzlscTZjOC8weW9JSHFEWlRkS2trMWlEcGcxSi9F?= =?utf-8?B?bVEyVDZ5bExOK3pXNEtWZ0gxeDArSlprVC91ZEpaeHJZMEhURHFHWDZWWUxW?= =?utf-8?B?Y1R4czhjT09RTzR2bkpWNFhBYS9oNG9xMUcvMlBPQ1VIbldXMWxzYlNKUUth?= =?utf-8?B?NEsyL295WC9LbWJEbTlLMURnMUtxNnZEZzRrVW1wS1hMb2kxTzdZSXlneHEv?= =?utf-8?B?KzJYTUcyblZvY3RjendFZEhncDdWUG0rWC9nZW5NNXorcVBNMGFDZW9yblpw?= =?utf-8?B?a0ZmMGx6MzdnNldRN2xkbmd5L0pCWTc5cDhsajU1SmFSQXphUDFJQ2JLcHNn?= =?utf-8?B?aWhRZmhlWFl6R1JkS21NeG1jY1lWN29SM2kvc29ZQ1BkTzFpdCs0QVEvQS9t?= =?utf-8?B?ZUQ4QXZmQ3hWUjBGaG9OT1R0V0Y2eE1aMG13QlRKbDJQSWpQZkpJSk8wWGlm?= =?utf-8?B?Ly9oSFp5aENBVVo5a1BiSGF2Y2UzZGtpNGFkN1VvekhlMndyTkc4NjRpQ05G?= =?utf-8?B?OUNOcEhZYzU3YXNkRzAvazljRHdhdGR0Ky9xelBacjBOcjdSeEdSOTY4TjJZ?= =?utf-8?B?M2hsdWtwZzRTajhRNXFEUHJBOVltSGZrSmI2MjcyUzNxYUhQNXErMTBlOEJN?= =?utf-8?B?dWZoTVZNdnVzMmdWRWNseGsybVJSWDhxTjR6bFNHR3Z6YUZFMDVzNXhiMk1J?= =?utf-8?B?K0htWkgxMWRWQ092clUzdWY4RmhZdzI2N09SWFFucEFBMEFDZUVqclIxNG1E?= =?utf-8?B?ZVZSc2d1YmZVQ3gxRXZURXVCTW9md20vczdiZkdBWXJNVGxNQ3ZJaldYZVph?= =?utf-8?B?bTJxSHJCL1EzRmI1SW5JdUF5aDRUVGgyU08zbmZtMzZzWXM2ZGs2WTMyRHRv?= =?utf-8?B?NGRQcE9ZMzRZYVN3K2hMb3k2VlJUMVNWUHd5d2pjeWlTazdabWt0OU82TzBU?= =?utf-8?B?aVZINHJDTHI5dTJBT2dSVGxSVG9HWXFOcFhjc0NLaGROc2JPd2NrY2JVQ0xY?= =?utf-8?B?QjdNUktzeUFmN0VOcHpuSmU3U2VoWVVad3huWFN3QnJSTzJqOTkrUExLK05P?= =?utf-8?B?bmhlT3UwdVhzWDNRaDV1VVNvazFjZTFKR29QeWdVRVlEdTV3K05rM2NFSXBK?= =?utf-8?B?OWo2RFFTcm04VGV2OHE4aCtWVndMcURqWFFBamdDZm4xYTd6anIrYit4YUVw?= =?utf-8?B?cmY4dHIzeHFKVS9ZS1VTdEhkSytLQWVlR3lkdTB3S0tkOWJPMlVWU1NmeDdZ?= =?utf-8?B?NkdGd3k0S0E0YWVENXZ5SGs2REY0d3JEUVMrT0ZlRFZVUjV1ZVc1cEVtRVdj?= =?utf-8?B?RVpVL2FHK2pndEk3MmxoaXRVb21TcklCK01NUUNFSDhhOXZpYTZ4MlY3cWVR?= =?utf-8?B?UTdCK0hNVnpBMWt2Nk40OGZXSmcyUHpmaWJHVTdVaVkyblhtejNBY0ZmUEVS?= =?utf-8?B?YzNZTkFmK1RsQzhxcHBrOVlmdWxPQU8yWlgwa01jM0xzM25vd254ZW5JWTJx?= =?utf-8?B?Z3ZRT2ZLUHc5OTBCS1JIT1FOb3BrVmF4cjJ4cDRaNHJxV0VTQ3d2QmIxZzZI?= =?utf-8?B?a1VWUmwvZ0RNcUlaSnE1OVY5bGhCeUJwZUdoNUhyZDVvdG1sdWVvTE84VWdD?= =?utf-8?B?SlFIU1FTbVA5UCt3azY1UFZGTm95VDRzYTJJVkNmdEQ1VFNlNGJQUXd0SDZy?= =?utf-8?B?WEZTMGxYdUxPOXcwVzBRZnlic21HNkhCdEQ4TitySjF2WjE4ODhBYTMvNlIw?= =?utf-8?B?Y20wcWxqMGsrdE90cDFtNk50K1ozcGFmMklOYXBqMmV2Wk5mN3JNaFdHbExv?= =?utf-8?B?emV5Qk9QYld5cUVhbHhkS1pyU2ZoTUEybTZ4YjMyWHJxTGludzFhTHVYM1Zi?= =?utf-8?B?TUc5a0ZtQXFlTWx4b0xxN1dkelVackF2QW1yeDdsemNQV3BLTzV5TC9IUzJy?= =?utf-8?B?ejlySXdtOFl1RGsvNGhlUUlaRkhCeEFtbmtzQ1BpK2pRKy9hRkFRNzZTdXgr?= =?utf-8?B?UGJEZnNGNHlGaHBIU1FRMTlFck84aUo1WkF4bEY0c0lyOXQ0WWFTZlBpQ0px?= =?utf-8?B?SlJnUDlKZWFaNjgxd2R6Q1cxeVhheFVKb2Q0cU51Q2huZFlpR2Q1V3dsSTMz?= =?utf-8?Q?Q2gjlhdLjNMRKUomEGBiwqjmT?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b8e369c3-4cef-46a1-25f8-08dbeccc7277 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2023 09:05:04.2127 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: W6hTKR8+J7OhLNT8rYx8pdfAwK/DdevygJlHhoB+F1PkF6EmeJojl2dxHc+C70MeDYduVWj5FYUrUgXs7ADODw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6778 X-Spam-Status: No, score=-3026.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Warning without knowing what's going to follow isn't useful, the more that appropriate warnings are emitted elsewhere in all cases. Not updating state (file/line in particular) also isn't helpful, as it's always the last directive ahead of a construct potentially needing fiddling with that's "guilty" in that fiddling being suppressed. --- Maybe the stray diagnostics are the reason why there is that questionable SEC_CODE check in the function (which for now I'm retaining there)? --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -15491,22 +15491,11 @@ i386_cons_align (int ignore ATTRIBUTE_UN struct last_insn *last_insn = &seg_info(now_seg)->tc_segment_info_data.last_insn; - if (last_insn->kind != last_insn_directive - && (bfd_section_flags (now_seg) & SEC_CODE)) + if (bfd_section_flags (now_seg) & SEC_CODE) { last_insn->kind = last_insn_directive; last_insn->name = "constant directive"; last_insn->file = as_where (&last_insn->line); - if (lfence_before_ret != lfence_before_ret_none) - { - if (lfence_before_indirect_branch != lfence_branch_none) - as_warn (_("constant directive skips -mlfence-before-ret " - "and -mlfence-before-indirect-branch")); - else - as_warn (_("constant directive skips -mlfence-before-ret")); - } - else if (lfence_before_indirect_branch != lfence_branch_none) - as_warn (_("constant directive skips -mlfence-before-indirect-branch")); } } --- a/gas/testsuite/gas/i386/lfence-byte.e +++ b/gas/testsuite/gas/i386/lfence-byte.e @@ -1,9 +1,6 @@ .*: Assembler messages: .*:5: Warning: `rep` skips -mlfence-before-ret on `ret` .*:7: Warning: `rep` skips -mlfence-before-ret on `ret` -.*:10: Warning: constant directive skips -mlfence-before-ret and -mlfence-before-indirect-branch .*:13: Warning: `rep` skips -mlfence-before-ret on `ret` -.*:17: Warning: constant directive skips -mlfence-before-ret and -mlfence-before-indirect-branch -.*:17: Warning: `constant directive` skips -mlfence-before-ret on `ret` -.*:20: Warning: constant directive skips -mlfence-before-ret and -mlfence-before-indirect-branch +.*:18: Warning: `constant directive` skips -mlfence-before-ret on `ret` .*:20: Warning: `constant directive` skips -mlfence-before-indirect-branch on `call` --- a/gas/testsuite/gas/i386/x86-64-lfence-byte.e +++ b/gas/testsuite/gas/i386/x86-64-lfence-byte.e @@ -1,9 +1,6 @@ .*: Assembler messages: .*:5: Warning: `rep` skips -mlfence-before-ret on `ret` .*:7: Warning: `rep` skips -mlfence-before-ret on `ret` -.*:10: Warning: constant directive skips -mlfence-before-ret and -mlfence-before-indirect-branch .*:13: Warning: `rep` skips -mlfence-before-ret on `ret` -.*:17: Warning: constant directive skips -mlfence-before-ret and -mlfence-before-indirect-branch -.*:17: Warning: `constant directive` skips -mlfence-before-ret on `ret` -.*:20: Warning: constant directive skips -mlfence-before-ret and -mlfence-before-indirect-branch +.*:18: Warning: `constant directive` skips -mlfence-before-ret on `ret` .*:20: Warning: `constant directive` skips -mlfence-before-indirect-branch on `call`