From: Jan Beulich <jbeulich@suse.com>
To: Binutils <binutils@sourceware.org>
Cc: Nick Clifton <nickc@redhat.com>
Subject: [PATCH] objcopy: check input flavor before setting PE/COFF section alignment
Date: Fri, 19 Apr 2024 11:27:13 +0200 [thread overview]
Message-ID: <e40a8e36-e79a-47df-8af4-4936e03752b6@suse.com> (raw)
coff_section_data() and elf_section_data() use the same underlying
field. The pointer being non-NULL therefore isn't sufficient to know
that pei_section_data() can validly be used on the incoming object.
Apparently in 64-bit-host builds the resulting memory corruption is
benign, whereas in 32-bit-host builds a segmentation fault occurs upon
de-referencing pei_section_data()'s return value.
---
Of course the value (first) being set on the input bfd is suspicious
in the first place: When copying e.g. ELF to PE/COFF, the option ought
to be similarly respected, yet clearly it can't be set like this then on
the incoming object. The change here is merely to address the testsuite
failures observed for Arm64 and RISC-V ("Check if efi app format is
recognized") as well as the (latent) memory corruption.
--- a/binutils/objcopy.c
+++ b/binutils/objcopy.c
@@ -4310,6 +4310,7 @@ setup_section (bfd *ibfd, sec_ptr isecti
if (p != NULL)
alignment = p->alignment;
else if (pe_section_alignment != (bfd_vma) -1
+ && bfd_get_flavour (ibfd) == bfd_target_coff_flavour
&& bfd_get_flavour (obfd) == bfd_target_coff_flavour)
{
alignment = power_of_two (pe_section_alignment);
next reply other threads:[~2024-04-19 9:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 9:27 Jan Beulich [this message]
2024-04-19 10:37 ` Nick Clifton
2024-04-22 7:15 ` Jan Beulich
2024-05-08 10:26 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e40a8e36-e79a-47df-8af4-4936e03752b6@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).