From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2089.outbound.protection.outlook.com [40.107.22.89]) by sourceware.org (Postfix) with ESMTPS id 9C42A3857C71 for ; Wed, 5 Oct 2022 07:25:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9C42A3857C71 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y5ZOx5kYFhB3avUgxaAT6I8grlrAcqmbyhxNYBPjd0kF0k+hydEvMAXNtZgGRL1QZWcUoqIyBRtS45cp+D4o7q7jvx2VbfwsbecU1Ul4Jgd1RBhwMwF3g0IGciIEh+Jacs0sUi5wRAPCcK3aU6lTlOqshV+0E534clWHWqAeqlfvbBMBt11Bwj5mZ7WevI0yw7ZQ5Z0cTNlm08zaZFaJK/xC7z/0ErQJfHOQFoeObzxdtlyIv8fcjVAHTAtzF/YiAlMIpRVNptpgncVj07S3mef4U6NSy9g6pwCFs4WiYuHkTxdEHFIsCgXMk8IiTcX6PBk7znNm/hbHuV8uKh/j2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IzzhW9VcDv/dhN+cZN/ISKt+HCtyP3GIgJsAWf7+1S0=; b=CaUdRSF4GuYr1YrSTUClcsi6p8sczL5Mf4twZtExSYQciwLZXVefUi58LKVc8D/+soJ8/BpBHttUBKZW/BXC6zqgWdW/QadKGL9GVbjvt1BCPvz8vL6RuPEvud8Xu2ZFVusKrUNb8Sbyr/C5m4PdJIPvDQDx8jP5jYZDUwLnzvW1gReDIacz2rW/cwjsKke1bXvM1BCU6OzHmzjAWwElSRR3HeIHz/S14epcqXqbdT60Px4FHkNMz+0jlbDPaohV0M1FSApIT4WiBhA0DbGfYbMfPQQyIEz7OMWDqHI9gK7fagnf36uX3rfcMtqlnsPqH3FRIR3CW9vmQfrTEN81rw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IzzhW9VcDv/dhN+cZN/ISKt+HCtyP3GIgJsAWf7+1S0=; b=2P78S7Jwa6Af+BxEPziaJx5Cw6zyipIj3QYX/JmXBN/Mo4fJ9f9pNchp+dGPzXNqLhqCqKN1mNUX0yFG4rwaM9PDrjvsUQi0G3DiZXSrBVxz4T5YTbEwGT1dWidiC1pTdEYVuncjZ1/dmmaekm6fKJML/rkY8k/il1CQE+HK1qeOP18wktT+rtc9pVkAmluICSBbqaMWl1dU8EI3TwsqUWD8MHNJWrptNdOVF2rq0ybeDqZRABm5wV4hy3/hSQ8n63lvsuxyAUgrEFqlt847hkIoPD5Su6E5yP+3H94JXG56738v6oGiw8uzQ1dOVdr61v2XUo9OhFXOvJIPn7wMew== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7751.eurprd04.prod.outlook.com (2603:10a6:20b:2a2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.32; Wed, 5 Oct 2022 07:25:29 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Wed, 5 Oct 2022 07:25:29 +0000 Message-ID: Date: Wed, 5 Oct 2022 09:25:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: [PATCH v3 6/7] x86-64: allow HLE store of accumulator to absolute 32-bit address Content-Language: en-US To: Binutils References: <20e2773a-2e47-869b-1900-709f8ad4cd6b@suse.com> Cc: "H.J. Lu" From: Jan Beulich In-Reply-To: <20e2773a-2e47-869b-1900-709f8ad4cd6b@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0028.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7751:EE_ X-MS-Office365-Filtering-Correlation-Id: 8792f836-236d-4600-510f-08daa6a2c613 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p7kPfshmQZ/SY+44X/wVlGQWiKfR8Jskw2I/Bgat6QQWRb86OahHaz7ecsNfqnURTO5lcMB4s22in5WalV8fhfPeQHQdlGy/VYDJ5hiTsnHs/4p9mPxSxQROCTeatnEUKf/X3/tdds4a/U9Xhj5Uyhz68MUHNPnEAFgVXazjZaj2TnOUXp21Mx31A5aIdUQYqcD2I89PBIBrMceiA7+lv7CpipMVGHNolh7D+I3pUULulK6pYshjit0YqfbxjbVmgokw04w9LMkYEAXE6U3vNdEQJcaOIXR91T2WmL1HldlbpZ5VkalmtjaukZ/XGEXauiwlkXZCTcBZxj/iy5UKi4tC8zdMFHudUgIm4M8f/tgiPFvk9KCMjbICB7ZugpdlO4eTviWlFvNbnvGtZZJ5GgL19rIuq9mVpX8TZPVnRG3M6EUdW4pawXpeX8nR6IQcgHA/0VmmZHbZfwgBNp82cK4Pw32VcltxrlGhRr8sK/CFPdaSacx9I8NGiC9HZw+lcvx2w7zukNvDueCrX62BQLSYVpM3tp7TGgW4pVTE2URZpw+17Ehk2tHzJG4I4bGpmj+QeJJofJgZee6lDXOk7g4G7UlkLWSF38dZ03DbeDXYX16xjvmbeI+rBLZcxm6bb/sZuWK0mqizfwg2+rM/a0/F1CIoixjD/0pfgOA3ZVA3aL94750x9QJ6uPRcCQstzFifXIXB61lTPTRqjGN/s/A8Hy/5prGaC/yPx2KB5FBmd5j7y3b9LsfRA4h1hucBybHAzZLRSn6fY3F1+G56HRIgb63c/tVnHra9ZMGefK8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(346002)(366004)(396003)(39860400002)(451199015)(31686004)(36756003)(31696002)(2906002)(5660300002)(2616005)(83380400001)(38100700002)(186003)(6666004)(6506007)(6512007)(6486002)(478600001)(26005)(66946007)(66476007)(4326008)(316002)(86362001)(8676002)(66556008)(41300700001)(8936002)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YS95SnZ1bm14a0d4YUE2VXZmMEFxVjJkN2huUm80aVpmK0NUT3BLS2xNZXRC?= =?utf-8?B?amEvQmk3L0NKQUp3cGQ5MTRZaXhPNWdOK1YwZTVSUksvaElXcS9YYzlvYzBq?= =?utf-8?B?MjBzc0FkOFl0Y0tpSHl3OGpoOWprakhBV0o4a3oyZDg4MTdjU081QlJWOHdZ?= =?utf-8?B?SDM1a0xRUzNaMlUwblNqWHIrRUJ4T0JhRkw4WWsveWRLbktmb0pwMUl4bFdK?= =?utf-8?B?S21rNFNYS2szRnV0bDdjeG5jU0tKMlROMlVieVdOakFlTVVwendGcEREQlB6?= =?utf-8?B?aWpMMUNwN09zcGkwSUEydTNpc2pWWTlnT1ErSDFUVWlVS3VGMDZRNEVlSjM2?= =?utf-8?B?b3FVN29SL0NCOEh5b0hkQXVFa1lxQlIwTEZuSzJzdUpEVW44UHVuQTRab01k?= =?utf-8?B?UENWMDhKdUF0SGUwUllkZlQydmVxMlZxUzQwUnNabm8zZjVoR3ZFVDNud0dn?= =?utf-8?B?bCtqRmk0Ty9xTC83bEVBZExSOFRadkhpTm84Z09ta3drbE1wTnFqT2krVzRB?= =?utf-8?B?WjB1U0M5OEhIbzFnMTV2N2ltbFBoUHFJU0lKY2FoeXRlcU9QWXVyTDU1bWpn?= =?utf-8?B?TklDTU91TWoyVUQvK1ZzWUI5ZVBVWlRtN2k1SEk0VWNGOEFtSGQwVXNOQzNO?= =?utf-8?B?d3JHZ205eG51ekxuTXVaRHBJeTNHeGNZSC8zNTg4dkRVcll6YzNIRGlIRGtO?= =?utf-8?B?Y0Z6SDdwNXErSWhPbmFsTDlKZGJ1R2JiV0tqbk9MbVd1NmJPMi9FWU9lMzgx?= =?utf-8?B?cnZLdnc3c2VQRGhDTlVobXJMd1A4T0hOZXlhM0NvNTM0d1ErcXdQcVNiQ1N0?= =?utf-8?B?WGdUUHR6VTJ1YkFwY3pkcS82ZWQxc2FtMW4zeVJUTlVHWFZuUFVrbnlnNzFZ?= =?utf-8?B?eDNJcjFJTHJvQXJEWU1WNkNobFFWMzUveUF0WU1iMXVkRlZ0MkdROXEzeDRl?= =?utf-8?B?Q3hJb3lvNXNHSTcwdmVrcmQxczRIT3M3dlVuelpNcUFKV3lBenJ2WGV6Qjlx?= =?utf-8?B?TFp0Qm5nQzNmYkN5V1NuM0tvNmlDQk5LK3ozanE1Sk00cDAvYUtYRm9jYVRS?= =?utf-8?B?OWdxYnpQd2FYZ3RNc2Vtb2ZHNExwMFZ4V0tPMWdPQ3hJSGRkYjVSa1g3UmE4?= =?utf-8?B?YnF5alpQNXlaVktvV1AwdU9wMUIxR3FXODY4dWluL2FGK3JYVjZIa2NySnpj?= =?utf-8?B?OVd4TVY2bk4ySnZYdnBaUko4VkMwamVmLyt5N2VXM1BvNVFudDRVOVdGSkJG?= =?utf-8?B?VGwxNlVQVjNraGE0MzRFVVVuNGpQQ1lMRWdPT1M1NGFpS2J4YXVEd1hVL05T?= =?utf-8?B?T21jVHFFSmJrYkhWT2hDWDg5UzRRSHpYdVFkVTlsdExickdhRFAwTlpXcnUv?= =?utf-8?B?U2tZRHUyU04wcUx3UHFIRVlyRWhGbENXZ2JqR1h3Sm9kRTZPOUJWak1mRU9V?= =?utf-8?B?TldyRnI4TVVuZE9sZUpsZ2NIZjVxTmljYWdERnhBNnlpa2dPM0t2ZEMzNlAy?= =?utf-8?B?cmUxZGhmVTZ1T3BoRE9qMDR6WktmNUpjMFlBWUxabit1WUNKNUgyU3NyZkRl?= =?utf-8?B?Q3lJdCs4cW9OeFBsWk41SFY3a1R0ditvSmFSbDBtWG9kSmVKOGtQZzNNL01w?= =?utf-8?B?Z21kMjJ5U0RCV3N6cXZvVGZ0bmJYMmk5S0Zab0xEa0NyRkJ0aFlSQmtoY0k5?= =?utf-8?B?NUdDRTVxZ2NJaVZZc3U5U2lPZXpRSXZPbkdPUFNvcDdyYWVWM09LM2VKMUJu?= =?utf-8?B?LzIyQWRwcERKaG9yaVpNZ2RTWUpLOVZza05tczJjRys0Ui85V2MrcjhCOTE1?= =?utf-8?B?Q2oyaEVpS0xFVUVaM3ZRTkpLaFJkVUlwZXJNL0d0THU3WmF2Z3NvcnZvTDIx?= =?utf-8?B?QmU1M1Y4bEs5YktFS1ZUU0VSOWxSbUJhdStsYng3MWNHNUFsTHFzTHVBT2d4?= =?utf-8?B?NFRZN3pCREEyUVY1eDJ0ZFV2T2QzK1ZFbTIzMTFPamQxdWxpNW5MZDhVYzhy?= =?utf-8?B?WVJGaDZMNDJVTndkSzYyWC9RLzAyeE9WQkVhTzFESVo3N1VqUlZPNW9VQTFS?= =?utf-8?B?WkNqUkxvT1JudlJsa0tkaW11N0JnczR1TzlLOUFhQ1V5dGFqZHZWOTQ2QXd0?= =?utf-8?Q?YmI0bT1YuEV3ElUNaeSTXREUH?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8792f836-236d-4600-510f-08daa6a2c613 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2022 07:25:29.1287 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YsfgJDQ7hAAXPGaTYsmnCNZnYCi7OG16mkRtNDsHl72Duz4h+cJpdxKaG3c7tHK0pDSV/9A2siXflwwQaVlzHg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7751 X-Spam-Status: No, score=-3029.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: In commit 1212781b35c9 ("ix86: allow HLE store of accumulator to absolute address") I was wrong to exclude 64-bit code. Dropping the check also leads to better diagnostics in 64-bit code ("MOV", after all, isn't invalid with "XRELEASE"). While there also limit the amount of further checks done: The operand type checks that were there were effectively redundant with other ones anyway, plus it's quite fine to also have "xrelease mov , %eax" look for the next MOV template (in fact again also improving diagnostics). --- v2: New. --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -6819,12 +6819,9 @@ match_template (char mnem_suffix) continue; /* xrelease mov %eax, is another special case. It must not match the accumulator-only encoding of mov. */ - if (flag_code != CODE_64BIT - && i.hle_prefix + if (i.hle_prefix && t->base_opcode == 0xa0 - && t->opcode_modifier.opcodespace == SPACE_BASE - && i.types[0].bitfield.instance == Accum - && (i.flags[1] & Operand_Mem)) + && t->opcode_modifier.opcodespace == SPACE_BASE) continue; /* Fall through. */ --- a/gas/testsuite/gas/i386/x86-64-hle-intel.d +++ b/gas/testsuite/gas/i386/x86-64-hle-intel.d @@ -425,6 +425,8 @@ Disassembly of section .text: [ ]*[a-f0-9]+: f0 f2 20 01 lock xacquire and BYTE PTR \[rcx\],al [ ]*[a-f0-9]+: f0 f3 20 01 lock xrelease and BYTE PTR \[rcx\],al [ ]*[a-f0-9]+: f3 88 01 xrelease mov BYTE PTR \[rcx\],al +[ ]*[a-f0-9]+: f3 88 04 25 78 56 34 12 xrelease mov BYTE PTR (ds:)?0x12345678,al +[ ]*[a-f0-9]+: 67 f3 88 04 25 21 43 65 87 xrelease mov BYTE PTR \[eiz\*1\+0x87654321\],al [ ]*[a-f0-9]+: f2 f0 08 01 xacquire lock or BYTE PTR \[rcx\],al [ ]*[a-f0-9]+: f2 f0 08 01 xacquire lock or BYTE PTR \[rcx\],al [ ]*[a-f0-9]+: f3 f0 08 01 xrelease lock or BYTE PTR \[rcx\],al @@ -476,6 +478,8 @@ Disassembly of section .text: [ ]*[a-f0-9]+: f0 f2 66 21 01 lock xacquire and WORD PTR \[rcx\],ax [ ]*[a-f0-9]+: f0 f3 66 21 01 lock xrelease and WORD PTR \[rcx\],ax [ ]*[a-f0-9]+: 66 f3 89 01 xrelease mov WORD PTR \[rcx\],ax +[ ]*[a-f0-9]+: 66 f3 89 04 25 78 56 34 12 xrelease mov WORD PTR (ds:)?0x12345678,ax +[ ]*[a-f0-9]+: 67 66 f3 89 04 25 21 43 65 87 xrelease mov WORD PTR \[eiz\*1\+0x87654321\],ax [ ]*[a-f0-9]+: 66 f2 f0 09 01 xacquire lock or WORD PTR \[rcx\],ax [ ]*[a-f0-9]+: 66 f2 f0 09 01 xacquire lock or WORD PTR \[rcx\],ax [ ]*[a-f0-9]+: 66 f3 f0 09 01 xrelease lock or WORD PTR \[rcx\],ax @@ -527,6 +531,8 @@ Disassembly of section .text: [ ]*[a-f0-9]+: f0 f2 21 01 lock xacquire and DWORD PTR \[rcx\],eax [ ]*[a-f0-9]+: f0 f3 21 01 lock xrelease and DWORD PTR \[rcx\],eax [ ]*[a-f0-9]+: f3 89 01 xrelease mov DWORD PTR \[rcx\],eax +[ ]*[a-f0-9]+: f3 89 04 25 78 56 34 12 xrelease mov DWORD PTR (ds:)?0x12345678,eax +[ ]*[a-f0-9]+: 67 f3 89 04 25 21 43 65 87 xrelease mov DWORD PTR \[eiz\*1\+0x87654321\],eax [ ]*[a-f0-9]+: f2 f0 09 01 xacquire lock or DWORD PTR \[rcx\],eax [ ]*[a-f0-9]+: f2 f0 09 01 xacquire lock or DWORD PTR \[rcx\],eax [ ]*[a-f0-9]+: f3 f0 09 01 xrelease lock or DWORD PTR \[rcx\],eax @@ -578,6 +584,8 @@ Disassembly of section .text: [ ]*[a-f0-9]+: f0 f2 48 21 01 lock xacquire and QWORD PTR \[rcx\],rax [ ]*[a-f0-9]+: f0 f3 48 21 01 lock xrelease and QWORD PTR \[rcx\],rax [ ]*[a-f0-9]+: f3 48 89 01 xrelease mov QWORD PTR \[rcx\],rax +[ ]*[a-f0-9]+: f3 48 89 04 25 78 56 34 12 xrelease mov QWORD PTR (ds:)?0x12345678,rax +[ ]*[a-f0-9]+: 67 f3 48 89 04 25 21 43 65 87 xrelease mov QWORD PTR \[eiz\*1\+0x87654321\],rax [ ]*[a-f0-9]+: f2 f0 48 09 01 xacquire lock or QWORD PTR \[rcx\],rax [ ]*[a-f0-9]+: f2 f0 48 09 01 xacquire lock or QWORD PTR \[rcx\],rax [ ]*[a-f0-9]+: f3 f0 48 09 01 xrelease lock or QWORD PTR \[rcx\],rax --- a/gas/testsuite/gas/i386/x86-64-hle.d +++ b/gas/testsuite/gas/i386/x86-64-hle.d @@ -424,6 +424,8 @@ Disassembly of section .text: [ ]*[a-f0-9]+: f0 f2 20 01 lock xacquire and %al,\(%rcx\) [ ]*[a-f0-9]+: f0 f3 20 01 lock xrelease and %al,\(%rcx\) [ ]*[a-f0-9]+: f3 88 01 xrelease mov %al,\(%rcx\) +[ ]*[a-f0-9]+: f3 88 04 25 78 56 34 12 xrelease mov %al,0x12345678 +[ ]*[a-f0-9]+: 67 f3 88 04 25 21 43 65 87 xrelease mov %al,0x87654321\(,%eiz,1\) [ ]*[a-f0-9]+: f2 f0 08 01 xacquire lock or %al,\(%rcx\) [ ]*[a-f0-9]+: f2 f0 08 01 xacquire lock or %al,\(%rcx\) [ ]*[a-f0-9]+: f3 f0 08 01 xrelease lock or %al,\(%rcx\) @@ -475,6 +477,8 @@ Disassembly of section .text: [ ]*[a-f0-9]+: f0 f2 66 21 01 lock xacquire and %ax,\(%rcx\) [ ]*[a-f0-9]+: f0 f3 66 21 01 lock xrelease and %ax,\(%rcx\) [ ]*[a-f0-9]+: 66 f3 89 01 xrelease mov %ax,\(%rcx\) +[ ]*[a-f0-9]+: 66 f3 89 04 25 78 56 34 12 xrelease mov %ax,0x12345678 +[ ]*[a-f0-9]+: 67 66 f3 89 04 25 21 43 65 87 xrelease mov %ax,0x87654321\(,%eiz,1\) [ ]*[a-f0-9]+: 66 f2 f0 09 01 xacquire lock or %ax,\(%rcx\) [ ]*[a-f0-9]+: 66 f2 f0 09 01 xacquire lock or %ax,\(%rcx\) [ ]*[a-f0-9]+: 66 f3 f0 09 01 xrelease lock or %ax,\(%rcx\) @@ -526,6 +530,8 @@ Disassembly of section .text: [ ]*[a-f0-9]+: f0 f2 21 01 lock xacquire and %eax,\(%rcx\) [ ]*[a-f0-9]+: f0 f3 21 01 lock xrelease and %eax,\(%rcx\) [ ]*[a-f0-9]+: f3 89 01 xrelease mov %eax,\(%rcx\) +[ ]*[a-f0-9]+: f3 89 04 25 78 56 34 12 xrelease mov %eax,0x12345678 +[ ]*[a-f0-9]+: 67 f3 89 04 25 21 43 65 87 xrelease mov %eax,0x87654321\(,%eiz,1\) [ ]*[a-f0-9]+: f2 f0 09 01 xacquire lock or %eax,\(%rcx\) [ ]*[a-f0-9]+: f2 f0 09 01 xacquire lock or %eax,\(%rcx\) [ ]*[a-f0-9]+: f3 f0 09 01 xrelease lock or %eax,\(%rcx\) @@ -577,6 +583,8 @@ Disassembly of section .text: [ ]*[a-f0-9]+: f0 f2 48 21 01 lock xacquire and %rax,\(%rcx\) [ ]*[a-f0-9]+: f0 f3 48 21 01 lock xrelease and %rax,\(%rcx\) [ ]*[a-f0-9]+: f3 48 89 01 xrelease mov %rax,\(%rcx\) +[ ]*[a-f0-9]+: f3 48 89 04 25 78 56 34 12 xrelease mov %rax,0x12345678 +[ ]*[a-f0-9]+: 67 f3 48 89 04 25 21 43 65 87 xrelease mov %rax,0x87654321\(,%eiz,1\) [ ]*[a-f0-9]+: f2 f0 48 09 01 xacquire lock or %rax,\(%rcx\) [ ]*[a-f0-9]+: f2 f0 48 09 01 xacquire lock or %rax,\(%rcx\) [ ]*[a-f0-9]+: f3 f0 48 09 01 xrelease lock or %rax,\(%rcx\) --- a/gas/testsuite/gas/i386/x86-64-hle.s +++ b/gas/testsuite/gas/i386/x86-64-hle.s @@ -442,6 +442,8 @@ _start: .byte 0xf0; .byte 0xf2; andb %al,(%rcx) .byte 0xf0; .byte 0xf3; andb %al,(%rcx) xrelease movb %al,(%rcx) + xrelease movb %al,0x12345678 + xrelease addr32 movb %al,0x87654321 xacquire lock orb %al,(%rcx) lock xacquire orb %al,(%rcx) xrelease lock orb %al,(%rcx) @@ -496,6 +498,8 @@ _start: .byte 0xf0; .byte 0xf2; andw %ax,(%rcx) .byte 0xf0; .byte 0xf3; andw %ax,(%rcx) xrelease movw %ax,(%rcx) + xrelease movw %ax,0x12345678 + xrelease addr32 movw %ax,0x87654321 xacquire lock orw %ax,(%rcx) lock xacquire orw %ax,(%rcx) xrelease lock orw %ax,(%rcx) @@ -550,6 +554,8 @@ _start: .byte 0xf0; .byte 0xf2; andl %eax,(%rcx) .byte 0xf0; .byte 0xf3; andl %eax,(%rcx) xrelease movl %eax,(%rcx) + xrelease movl %eax,0x12345678 + xrelease addr32 movl %eax,0x87654321 xacquire lock orl %eax,(%rcx) lock xacquire orl %eax,(%rcx) xrelease lock orl %eax,(%rcx) @@ -604,6 +610,8 @@ _start: .byte 0xf0; .byte 0xf2; andq %rax,(%rcx) .byte 0xf0; .byte 0xf3; andq %rax,(%rcx) xrelease movq %rax,(%rcx) + xrelease movq %rax,0x12345678 + xrelease addr32 movq %rax,0x87654321 xacquire lock orq %rax,(%rcx) lock xacquire orq %rax,(%rcx) xrelease lock orq %rax,(%rcx)