From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 399503858C50 for ; Tue, 23 Apr 2024 12:13:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 399503858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 399503858C50 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713874412; cv=none; b=wb6bgRICcl2e7Oo49a2W1iIHiTYSuXH4EywL+dXgLjSHR0Mut3vlaw9dy0qkN4WzhRwY0lCq4XCe7F2ZjbzypDUlgTcESmYhskhzLRASDd/yiUq1Po3pDi0A44uKzA3oIf1uUqpUOdc/caIOSmTwtbfRRJoMOmoORfbEMT+Hkx8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713874412; c=relaxed/simple; bh=zg6N6xcW9D7+T/Guk+AAT2Ov8Jfcv7Fa0g6kV5CrHf8=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=LRmonWo0VKYc299znKli9rfhpZywnFhwOQcrMbyvVrobOsSxdkUThDn3T30O2wXo5u/z3vtgvxpCXezdFzyGZ4zvFSMu3fDsP/WdJX3jew9M5c/y87YkV2kSlTwEfTKmWpapsVGzLgtfIEKCa5iSH9owcDEKg8vVH8LPNzZ0wyA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D9D27339; Tue, 23 Apr 2024 05:13:57 -0700 (PDT) Received: from [10.2.78.64] (e120077-lin.cambridge.arm.com [10.2.78.64]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5E5463F7BD; Tue, 23 Apr 2024 05:13:29 -0700 (PDT) Message-ID: Date: Tue, 23 Apr 2024 13:13:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] aarch64: Fix coding style issue in `aarch64-dis.c' To: Victor Do Nascimento , binutils@sourceware.org Cc: nickc@redhat.com References: <20240422093500.46611-1-victor.donascimento@arm.com> From: "Richard Earnshaw (lists)" Content-Language: en-GB In-Reply-To: <20240422093500.46611-1-victor.donascimento@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3497.4 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 22/04/2024 10:35, Victor Do Nascimento wrote: > Fix integer value being returned from boolean function, as introduced > in `aarch64: Remove asserts from operand qualifier decoders [PR31595]'. > --- > opcodes/aarch64-dis.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/opcodes/aarch64-dis.c b/opcodes/aarch64-dis.c > index b70e6da9eb7..e1c3f557874 100644 > --- a/opcodes/aarch64-dis.c > +++ b/opcodes/aarch64-dis.c > @@ -1038,7 +1038,7 @@ aarch64_ext_ft (const aarch64_operand *self ATTRIBUTE_UNUSED, > return false; > info->qualifier = get_sreg_qualifier_from_value (value); > if (info->qualifier == AARCH64_OPND_QLF_ERR) > - return 0; > + return false; > } > > return true; OK, thanks. R.