From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id 538EF385840D for ; Wed, 24 Apr 2024 08:27:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 538EF385840D Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 538EF385840D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::333 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713947277; cv=none; b=oeXagSM5I2IH0OHTal778pyiaP0ROKYl1GKOAGzwS6YO88JFS1AZykhy33IK8tYdxyf9vkwjRteh7bhp9hHoJ711sp67FIrqnlaI82tI/oBc3pSzxnN7okM8SjkVHkh36urNaP8ksfpS7l+zh+cTLp9z/Ckgz2SpMBXyyYHrpAo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713947277; c=relaxed/simple; bh=0ktln4lC3c+6a6KKEzPnRcqXZ6ZKeIfb8fYQgN6B54w=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=l7Y5lKVXrl75bMuW22JQC6J+LcInkNbbMFwhrAO7Y7fDPoylzi8vF8PcL91n/RUBN/mjwgCgjGhdq2Kv4vdzgvoKZH8xOD6J1V3QjSqKctM1oXoKjHJKTwKUs1SIC/n0ymvzIHHdOcjuGl65S2Fumc1LUJH9x/GvIA40LxDzSLc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-41b0bc4ce39so2437865e9.3 for ; Wed, 24 Apr 2024 01:27:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1713947274; x=1714552074; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=Wi7Gae6v9J4cmOBDn99TFXarMCtxJd7DC0ZbS416NzI=; b=EGnFmOxPd+KO2dYBjMr3IS6suoyRvafdRe00OYi5MQXFvFSXcoR3uFnnVPM/D7uJ9E d4/ZCPBdr7PyuUbUF4D0yjbGlgPr1R+p2QS6o7OJpF/h3/uhNXtkOWKsE19Qpj4Mla3v RrzsPDRwtgXOQfEnb9KwGKjkxA/eFVWB4tNBAKMtlRYjJ57ePJzd573Yhwx6LLeJB8XT HUKOB292jOGnranBeICmUceggFxfTGjdbuHzmVR0/iWVV8XkmrKNK6EoQvHxaYiZ6we2 loPzr29NDVNthbTlMN9LUce8sbFWuyS8Dxepdshi305vtEOAzCVjpPw2Qa+/TBUCac3C 4u2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713947274; x=1714552074; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Wi7Gae6v9J4cmOBDn99TFXarMCtxJd7DC0ZbS416NzI=; b=EYSZTBN/5J/QQjNYK8VA8qYKsms04dt+KFciYS4Kfeyomil7RcMeOdXtyJNfReA+Lt IUQPirqmM10kOWED7X9MKFzoUGXYrfEdRv9aKzxfiysWajn+PA0swfG+tdZG2llASOOC UahARhheKANtWVSRGPkVf3lgKPDJcHboO3QmGLxkbC7c5rmi0WsTEXO3HXmyoqL1YRY2 3gM8O7fSa8hBDFjqKBggQYJR7zUwl2uHUTsYRkweMpBe+pMPpuSiqLhYCgBc2IqEQz+p STzBStxye/vl8HHeN1VgUHn2mPRmA65lCthdGcqKVymrNQpJRtyuiGZrwfFTmlOVQSyI 0ChQ== X-Forwarded-Encrypted: i=1; AJvYcCUVc/HKRCbx3HHVRa3Z4FkNf1zOGZv+elQA+Zxn44ysv8IHEizw5o+UBECKgssh5rvG96D/B03u3RLgC1nD04E3Jt1qa/bJRQ== X-Gm-Message-State: AOJu0YxKOtyiB+annTtvVpXj5fEk/QdUiPkLfguqbAjQT5VJnU9ABbji qLmVFD4e3fClDowbYKsQglW9KqdSLkz80616TZSSksiAirwmAtuyp6EcTgxOcA== X-Google-Smtp-Source: AGHT+IH4VFYQJ6WY/G2+JSFbMbR6ftuUjou/lO1rQehpzh2uxhdTT13tqJEYa2V1gR6KIAd9o2g5ow== X-Received: by 2002:a7b:c049:0:b0:417:f993:c614 with SMTP id u9-20020a7bc049000000b00417f993c614mr1489933wmc.22.1713947273999; Wed, 24 Apr 2024 01:27:53 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id n7-20020a05600c500700b0041b0cb8b716sm874405wmr.39.2024.04.24.01.27.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Apr 2024 01:27:53 -0700 (PDT) Message-ID: Date: Wed, 24 Apr 2024 10:27:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] x86: Drop using extension_opcode to encode vvvv register Content-Language: en-US From: Jan Beulich To: "Cui, Lili" Cc: hjl.tools@gmail.com, binutils@sourceware.org References: <20240424072356.2433122-1-lili.cui@intel.com> <20240424072356.2433122-4-lili.cui@intel.com> <2e942a80-bb0e-486b-b97d-9baf95560ce9@suse.com> Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <2e942a80-bb0e-486b-b97d-9baf95560ce9@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3025.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 24.04.2024 10:19, Jan Beulich wrote: > On 24.04.2024 09:23, Cui, Lili wrote: >> @@ -3427,9 +3427,9 @@ uwrmsr, 0xf3f8/0, APX_F(USER_MSR), Modrm|Vex128|VexMap7|EVex128|VexW0|NoSuf, { I >> >> // APX Push2/Pop2 instructions. >> >> -push2, 0xff/6, APX_F, Modrm|VexW0|EVexMap4|Src1VVVV|ImplicitStackOp|No_bSuf|No_wSuf|No_lSuf|No_sSuf, { Reg64, Reg64 } >> -push2p, 0xff/6, APX_F, Modrm|VexW1|EVexMap4|Src1VVVV|ImplicitStackOp|No_bSuf|No_wSuf|No_lSuf|No_sSuf, { Reg64, Reg64 } >> -pop2, 0x8f/0, APX_F, Modrm|VexW0|EVexMap4|Src1VVVV|ImplicitStackOp|No_bSuf|No_wSuf|No_lSuf|No_sSuf, { Reg64, Reg64 } >> -pop2p, 0x8f/0, APX_F, Modrm|VexW1|EVexMap4|Src1VVVV|ImplicitStackOp|No_bSuf|No_wSuf|No_lSuf|No_sSuf, { Reg64, Reg64 } >> +push2, 0xff/6, APX_F, Modrm|VexW0|EVexMap4|DstVVVV|ImplicitStackOp|No_bSuf|No_wSuf|No_lSuf|No_sSuf, { Reg64, Reg64 } >> +push2p, 0xff/6, APX_F, Modrm|VexW1|EVexMap4|DstVVVV|ImplicitStackOp|No_bSuf|No_wSuf|No_lSuf|No_sSuf, { Reg64, Reg64 } >> +pop2, 0x8f/0, APX_F, Modrm|VexW0|EVexMap4|DstVVVV|ImplicitStackOp|No_bSuf|No_wSuf|No_lSuf|No_sSuf, { Reg64, Reg64 } >> +pop2p, 0x8f/0, APX_F, Modrm|VexW1|EVexMap4|DstVVVV|ImplicitStackOp|No_bSuf|No_wSuf|No_lSuf|No_sSuf, { Reg64, Reg64 } >> >> // APX Push2/Pop2 instructions end. > > The latest now is the point where a comment wants adding here, owing to > the fact that PUSH2 has no destination operands, while POP2 has no > source ones. Following the common pattern "mnem %,%" DstVVVV is > indeed appropriate here, but the anomaly for PUSH2 imo wants clarifying. > Okay with such a comment added. And then everything touched here also wants leaving alone in patch 1. There's no reason to touch stuff twice when once suffices. Plus it eliminates the need to add respective comment for POP2 there, which you'd then replace by said PUSH2-related comment here. Jan