From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80044.outbound.protection.outlook.com [40.107.8.44]) by sourceware.org (Postfix) with ESMTPS id A13813835767 for ; Wed, 22 Jun 2022 06:55:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A13813835767 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=akDQCljq8E+mgmHLZbxps3Bf96T+8rRX5AXejvOxx42dc1vSp0zEWSDuVZLagYscWoF0XqN/f12q6A7S4yQixZ9FJKCMIpDz80YvcQylNXGz6e/Mw4+oxt/dP59ymNUH9FMbHs/aBjywLTtep8AFSQrT661gRBm7XQasXS2p4GpUgpzyQYUk9NmSBIsN4bO2kM6hlB5mM86AAAFaj/GM0BTvAgAK2S4bvob4LiJtAw90qWkuqH1rVe9NgosKOJ+U/8oTgvXCpD2qUob75pzISHQfqe89WV/BBvQsmKJTMzGHJa5r+5KLJlwrdKu2H9jmwOWubwQXWwjj7d7OBGuypw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H+B3WpYmhuMMgx2tGUmkjl7AtmLG/oxj4ko+eBeYl7c=; b=OBXD7aMs6yHj7WsI1V7+QdUsfkc0jLYKxMfdoGprdbbNk7sXR3zyXDHAv2wUmh1Sl9LYxErWLLnlEWlm8fZGTb329uxXQLI4N1hFn0lzVpUBdDXANHgemayQs5rGCz8pYHiqG6AEN59kb6l+Gc5ooi3ss07Q3z94Enz3T+LkxEgAFWuPoYZUwXi2AnEqbUb+/zPCToCPN/Ii7tMk15Ul4xcHtInJITejMf3Gxw+EQtoFIZy85Dj8HbpwW88RPr5OOuH2Fg6bp9HkjLblQCdFE3Ip/u5dy5NL6jEbaL4+kx4JhWs4b8NfFBavV+YITdEqBeaLwEVMFGK8g4mbLD20zQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB6109.eurprd04.prod.outlook.com (2603:10a6:803:101::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15; Wed, 22 Jun 2022 06:55:47 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5353.022; Wed, 22 Jun 2022 06:55:47 +0000 Message-ID: Date: Wed, 22 Jun 2022 08:55:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: Are big tests allowed in binutils? Content-Language: en-US To: Dmitry Selyutin Cc: Luke Leighton , Richard Earnshaw , binutils@sourceware.org References: <12c9bf5c-e3b5-1260-16fe-1916ece7d904@foss.arm.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0518.eurprd06.prod.outlook.com (2603:10a6:20b:49d::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bc7ee5cc-9e7f-4c2f-ada8-08da541c3c34 X-MS-TrafficTypeDiagnostic: VI1PR04MB6109:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: g0ZzPf3YuZ9uoGlUb7l17AcmEqomFNcIAwZWWHXhs3r0BiG1l6Wc8TLO17ch1LimDGP8eSNgevlDwgmCEPbobBx0H4pup09W6vPF//9Q3ogi7MUBdnrLTvp5vO8qQ2w/uBVr10q6kbD+zwag3ls/pDNwn5koP7wBol4q34Ugs7UFVMlyB6LrEq8IYPV4HQ4MII5Ajq9QnFU2a9D7x/01WUGBArrOPBm7r0XanAnoK8pKcAW0jJabVjqhxtx0sbWZh0G/9ip6FBAi+b5d3LeeUezxPoTuhcGuXg+WwDEVvi0UllrsdnnFo2jEeAJUl1x0ESlfp8vhTJSrZFT7NIEv57KjguTjySfO1ZCW2tmP4ZJT4Z/lHSlo7vmoA3lasSyTtM31MvjbOe14AKanxYEPTCHp/nxLpeqKAW2OPLi2oFoDlgm6/6lQHD7ddtgAtDObAMJgcH6A3oOl017NMfFlnktsnEt1sqGTr5HeEodb3og6NPLcYuAsiTEtxJELkGv/Whgssp1/9KwmMKL3SGTlz/e/wfF5txihP3fb0nSqydN6wzlIbvHsoQp/PA4W8RpFMEiyi0ZPFUe9QVM/f49Flf6iw0N6y6rNONZgBaW6AXuyWdZeQ1p13q4Br3B1IewiAMmBrAkz7IkavxLbd8tnmxmDyn4+1l1Q/xR+fY9FBRLKct5a3qxF76Igkn1dwEJWZdzk5cXMncj1ySaouJe+HjM0wBpjr/pVa9sIAHQUIz1Qi0WE5RnoTgcb9YpY6kJI4oYjA57eSMyzshozxMK69fLYyHlm89+aJxc1nPoAtYo= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(136003)(39860400002)(396003)(376002)(346002)(366004)(2616005)(186003)(41300700001)(83380400001)(38100700002)(26005)(8676002)(4326008)(86362001)(66946007)(5660300002)(8936002)(2906002)(6666004)(53546011)(6512007)(66476007)(66556008)(6916009)(54906003)(316002)(478600001)(6486002)(36756003)(31686004)(6506007)(31696002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Rm10blFRc3FscFZyWVZkM1d5bVYwQ0wwbHB1ZGNydDdkNnBGb0xiYUw5QXBR?= =?utf-8?B?OVV4SStDNEdvQ2kvYzZsMkJnZkNQN0Jzci9PSHRHZWtjZ0xOR1Q4MERSWldT?= =?utf-8?B?RXovbFJYMUhLSG43cWNoR1p3d1hPUW16Y0E0Y3R0UEJoQUZqZ203SHdySEVm?= =?utf-8?B?dHA2YkJQM0IxcWppNDRwYklEbHV6S0dienNBaEx3YTZ6SW1KelZQMlVYL0Iv?= =?utf-8?B?SDdqMGxRa1NYWmJLK2ExVGZzWlZZbVY3OWE1N3l4OHQ0ODd1eU55OGVQSUo2?= =?utf-8?B?Q2pMbU5HZ3VBcmZuVkVCcTFHaWpZQWlZZGcvZnNPRWwvZkZHNVdsMUlQVlM0?= =?utf-8?B?QXgvZS8wdVpWclJLN0lwN1lrdFRmNmQxbzBmUEwzMWhZcUJlZnpOdngrSEpF?= =?utf-8?B?b1FjcVJvRzBBVi9NQTdNbHlSeURVbVcwOTVNeU5hSHoxNGM1NmxtYTJrOVhU?= =?utf-8?B?cFN3MmJYWG5PcmsxaUxTNEltZ2JCenBkQUQ5MlhEMWNVNllHTC9TN045Nm00?= =?utf-8?B?eVcveG1NKzdFenZncVVjbjN5R0FkSndUT3k2NFR4MGdOb2ZORGZ4L0Vyb3lw?= =?utf-8?B?aGZ0ZlFIWXNoNDFmNDZLTFcxWm44ZDlUdFdUYk1Jc2k1Y1pIeHlvK3AzdVA0?= =?utf-8?B?NUdCSEk1MzlFM21TeUh6UVNKa2FURXJpMytQU0NrZ2plRW8xZ0tYZlFUV1lW?= =?utf-8?B?d0V3anJnbGtVMGxQNk5hQ0dtTnpPMCtoemRyMzBYMzFVdTY1THR2eFUvOXJ5?= =?utf-8?B?VjNLZmJZYVJ1R0dwQ2E2NTF2YkovaEJNL0t1b3BhRXd2UDBZbUJFRFpZTEtS?= =?utf-8?B?M1B4NVRIMW14N1FZRk5WTUJNL3hiZnJZaXVZZkNhem5XelU1ZDJtK0xMSnFS?= =?utf-8?B?dnBUd3RGU1F1aDZvdlJhbCs0MHIxOTRCeko2SjZEUjc5aFlYbE9vL1p6NkdJ?= =?utf-8?B?T2llNElNYXpjRHlZNEdmOG1pZ09UUWpRMnZFdlI5ci9rS0x3S09oTXhHd2V1?= =?utf-8?B?OTVGbFM5cmw4ZUVlcVZMV25NZzBZalp2OWxBUks2WnAzeEM1THNQK0cyRC9B?= =?utf-8?B?Zzk1dlR3eWRhT1FibTMwOTNxZmZVUVVLYkQ0Z0NGUU9qZVVvUG1CWE0zaDlv?= =?utf-8?B?WUxMSGpoR0psVDZUVGl1VUhUenpGRy82K1IwRnNlSjg5MngvWng4NmNoc1l1?= =?utf-8?B?bFFTQjVqSHNObkhMeis0bEd3T2E1b2plTGRSSG1tQUFnYndhaDNyMlJtN1JN?= =?utf-8?B?aGw5RGxUclduMlFSMUxLNlk4NEdDclpuNHdFMUlSM1JWMHUyNVk4MkhZbWJq?= =?utf-8?B?WmZtbXN3d25QS2JKbDhGRVdLNkZaWi9oSk1iNWxGbVFoakp2aEJzOFRqcUFJ?= =?utf-8?B?dkp3dk1SMUtEL3FzMEh6NG9KekQzYkJpaEtQa0Z6bzdXRFFONGJtWG1VMi93?= =?utf-8?B?UUhlOEp2R1hVVVpNc0lJUlY2N29DWjZJYlRGdWliVXVDUitCc2FmSVpWS0wz?= =?utf-8?B?aVNuS3FnQlNqbWgwdGhkZ2xkYTZ1bms0Q2JVc3o3dW1xeHhGMGYyUWkrSldW?= =?utf-8?B?M0FjVUE5MXdrTnNialFnVkw5VWYxYm52ZGxLUkxZRktrQ1BKbDBxYUtKU2pu?= =?utf-8?B?d09DYkNBRjZ5K3NjTS9YdDYyYUo1TmxHZlJrUUhZNm83dlIwRU4wL2xZcmN4?= =?utf-8?B?cGVvUGFXWUY4VU9qeURCaEh1UnVYTEJuUzVVR29GcWx0N0VGc1g0eW1RcUxt?= =?utf-8?B?dnQ2N2RsZVl4TERjQkduYit3b0g4a0o3N2hZOWlSbkUyL0l3ZFB3dk1FMzFh?= =?utf-8?B?QzQ1Wk5GMk0wcUljeHNZaC9NbFcvU2d0MktHUTJ4NEtQVTZ0UnhYL2EzZTFi?= =?utf-8?B?TUQwUEd2ZGlCVUVacjNoSmJhVDBmWGNIY2Rub0ZGYVlxcVhhWkg3ak5nenNF?= =?utf-8?B?VlpKQTVUaGpWWWtsRHVET3NEZnpYbXVYTnlIZ3JOZlhLdWd1Vm42dHNDTkZF?= =?utf-8?B?YTFTQmJBdGZZUTM3dWd6a3pFeDRsa3BNbDdLNE83aVNvVmxFWVFLdkVidE1j?= =?utf-8?B?M2FRZWxLZUs1VDk5dHAvUVVIa2ttZUtON2tZKzBrRmV5UDVmaHdqVExLaFpB?= =?utf-8?B?Vnc5RnJKeXdPc1FDVzlMc1ZQZURPU0ZHTFFFeWNYS2p4U0JmQk9aeHl1ZEZ0?= =?utf-8?B?M2FGT0tHYUFiVXM3UUNaZ2g1Y1RlNXhjRG55eDcyQk5tSDRYQjlBcFR3L1Rm?= =?utf-8?B?aFVtM0svTGFxMHlKWU9rV1c0TERsdlpuczl3VkM4L1BVMk1CaExtSTg0bnBx?= =?utf-8?B?WnUxS0RhQlluemx4ZUo4amdOUU5QTGs4cUpic3hIMTEzbXlidW9NQT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bc7ee5cc-9e7f-4c2f-ada8-08da541c3c34 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2022 06:55:47.3811 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +hlWud3YovRfMJHX5EIgFQme3G+cSL/YRsH07Q4Oj3MsKrtsFIECEO7s1o+cHHxMnhOwV07cQQkdJC+bGR8dOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6109 X-Spam-Status: No, score=-3030.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jun 2022 06:55:53 -0000 On 21.06.2022 18:28, Dmitry Selyutin via Binutils wrote: > The tests there are already generated with this assumption in mind > already, they don't check all possible combinations (otherwise we'd > have ended up with ~4GiB per test, eh). > At the same time, they also check the operands together, basically > this is a bunch of nested for loops, where each loop checks several > predefined values for each operand. This (in particular "nested loops") doesn't sound like it's matching what Richard has suggested (which is a pattern I also generally try to follow). Taking his example and assuming that I properly interpret "several predefined values", your approach would result in FOO r0, r0 FOO r0, r15 FOO r15, r0 FOO r15, r15 i.e. one more test than necessary. Obviously the number of "excess" tests would grow (significantly) with the number of operands an insn has (while there would be no difference for single-operand insns). Jan > I want to write some code which generates a test generator for > binutils; this is the simplest option to avoid binutils depending on > our code (you for sure don't want it). > > This, however, is a big task, it requires many changes on our side, > and I don't have time for this right now. It's also blocked somewhat > with another task. > Good news is that I will undoubtedly do it, because we have a plethora > of scenarios which depend on auto-generation. > And yes, we do want to be good citizens, that's why I brought up the > whole auto-generation topic. :-) >