From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 801A43849AC5 for ; Fri, 19 Apr 2024 10:37:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 801A43849AC5 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 801A43849AC5 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713523037; cv=none; b=OxbAhrP0+fOwFhBi8hsg/qwHOzVoEisPGtjD+5c3/wSpqmAGQAMyh2qk+g+HHgtAfFOizqgBY30v0XTruGLKFervlHxLeeQdtjcBzaWVPLOUyIX9KLo+k/Yjfpn343E4sulDf+QftY3pPQ6BcVWH/afk44ZjXasg+VJjcbSHjg8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713523037; c=relaxed/simple; bh=YPaxKrHN83GEPBJfjga7YGFna7tMOZ9tL1wUSa+U9t4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=ULtCj60BubeDCFYOCfT+G8/K3kAjRc7juqXNwFxRdEW6IW5FM+ZagmPpVPL0LefLaKH9rLhvVgcKVlZPPfH+0Nnv/YJ9shaX+L4ugveQpbErPveJ3oAE3LzKkH3LBSG+Xtzdc1u410VFhMgoaruomjrOezclyjOavsYeF2d6g08= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713523033; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BO/KGdhslnKQaAPVWEcDSdjISe4IAtdJLS6g8x9Sl9w=; b=LMn6VQafn2TXhBitabrkSR13aPCiCf/qfDu6Wdq1BUozujFdugTotR+nqmtyFTDLwoOsZz 53Tm3IwZRTHKEYdqteGGOrt89CZippHWdZlHoPUZxXEL7DrnNlIynY2ABxn9xh+r8G6632 zkym5JI+xJKwAemkY7TuaNPH3uDFprk= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-144-CvG4iKaSN9SHN1g-dXxsuQ-1; Fri, 19 Apr 2024 06:37:12 -0400 X-MC-Unique: CvG4iKaSN9SHN1g-dXxsuQ-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6a05aaf9c6cso12721086d6.1 for ; Fri, 19 Apr 2024 03:37:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713523031; x=1714127831; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BO/KGdhslnKQaAPVWEcDSdjISe4IAtdJLS6g8x9Sl9w=; b=pVNHAj1CnUcC9z2hf206QxmYIseBcDC5ZH2jHkyvv/eMu8DryPwJ5uKWSGjvMzk7b7 BABZawfOldXM8TSh5NRdozRt+3+GrBF5GqjpmZg1ppBbcRcMvKGspiaHCFk+WdZyS/54 e7DmALhSHmZYV6dMgFh0qMT5tFRqE1DzjT8WFRsMbwOWl9X8Ss5at2REhSrqaOsm/W3n BsotCT6KxT2VUpEMkM49wkdvT/qb9GpPVx7mzAP1ueFmLzEuaurG5u/dvKTlVYC1O6kl pcwcmdj36wIhYGnoP+3bLgtyYdQXFBLfAMCTDzGupW3u6mo20L3+rlWECUlFJGhvcU56 GTcg== X-Forwarded-Encrypted: i=1; AJvYcCXlfcqal0liBD0pZ/Kq91dW6WBzwjuA+RyzL3uievDF8SNsE6DbP5Cciwte3zX5qwSAwgnEtouI4QbqdAWPtnJ6dbj4EagjuQ== X-Gm-Message-State: AOJu0Yye5GzHyO9EnGOVL+ow8E82oNC40qGIqppI9EEEcXbXYWK+GM/h 6Mv4lQWpjfF+cu5Xx+JNOyt8/bOvyQ1IBTMARmqmj7+jQ/IeHWWdsPufl9bWfHIIqEqjjwYCxZX zX2xo23w290dJjk8N0hh/Th18wGcIUb10WzgkyICEpRK21euaQN6hQHnXTICEa/g= X-Received: by 2002:a05:620a:5582:b0:78e:13f1:303e with SMTP id vq2-20020a05620a558200b0078e13f1303emr1745738qkn.54.1713523030843; Fri, 19 Apr 2024 03:37:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGbXLCcckBFyOfFTD89DWyEjvwqixS5VDISb3u0dxzywLo5CKvteDObnmzwVmrYQoINwojSiw== X-Received: by 2002:a05:620a:5582:b0:78e:13f1:303e with SMTP id vq2-20020a05620a558200b0078e13f1303emr1745729qkn.54.1713523030591; Fri, 19 Apr 2024 03:37:10 -0700 (PDT) Received: from [192.168.1.18] ([79.123.79.31]) by smtp.gmail.com with ESMTPSA id o22-20020a05620a0d5600b0078d5a756e61sm1466017qkl.60.2024.04.19.03.37.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Apr 2024 03:37:09 -0700 (PDT) Message-ID: Date: Fri, 19 Apr 2024 11:37:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] objcopy: check input flavor before setting PE/COFF section alignment To: Jan Beulich , Binutils References: From: Nick Clifton Autocrypt: addr=nickc@redhat.com; keydata= xsFNBFm/2cUBEADkvRqMWfAryJ52T4J/640Av5cam9ojdFih9MjcX7QWFxIzJfTFYq2z+nb4 omdfZosdCJL2zGcn6C0AxpHNvxR9HMDkEyFHKrjDh4xWU+pH4z9azQEqJh331X7UzbZldqQo 16VkuVavgsTJaHcXm+nGIBTcUbl2oiTtHhmuaYxx6JTMcFjC7vyO5mLBw78wt52HBYweJ0Nj HBvvH/JxbAAULSPRUC61K0exlO49VFbFETQNG1hZTKEji95fPbre7PpXQ0ewQShUgttEE/J3 UA4jYaF9lOcZgUzbA27xTV//KomP0D30yr4e4EJEJYYNKa3hofTEHDXeeNgM25tprhBUMdbV RZpf2Keuk2uDVwc+EiOVri48rb1NU+60sOXvoGO6Ks81+mhAGmrBrlgLhAp8K1HPHI4MG4gH nrMqX2rEGUGRPFjC3qqVVlPm8H05PnosNqDLQ1Pf7C0pVgsCx6hKQB7Y1qBui7aoj9zeFaQg pYef+CEERIKEcWwrjaOJwK3pi9HFdxS0NNWYZj8HPzz/AsgTTQdsbulPlVq2SsctmOnL42CZ OCTppGYwl53CG/EqVY+UQBzFzJBaY8TJRFFYVEy5/HH4H11rMoZwqIkk71EOGU3X6mWlANRi kR3M4GhVITRzuaV69Fed+OeXcCmP94ASLfuhBR2uynmcHpBKpwARAQABzTtOaWNrIENsaWZ0 b24gKENoaWVmIEJpbnV0aWxzIE1haW50YWluZXIpIDxuaWNrY0ByZWRoYXQuY29tPsLBeAQT AQIAIgUCWb/ZxQIbAwYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQE/zvid2ePE9cOxAA 3cX1bdDaTFttTqukdPXLCtD2aNwJos4vB4LYPSgugLkYaHIQH9d1NQPhS0TlUeovnFNESLaV soihv0YmBUCyL4jE52FRoTjE6fUhYkFNqIWN2HYwkVrSap2UUJFquRVoVbPkbSup8P+D8eyd BbdxsY6f+5E8Rtz5ibVnPZTib7CyqnFokJITWjzGdIP0Gn+JWVa6jtHTImWx1MtqiuVRDapU hrIoUIjf98HQn9/N5ylEFYQTw7tzaJNWeGUoGYS8+8n/0sNbuYQUU/zwMVY9wpJcrXaas6yZ XGpF/tua59t9LFCct+07YAUSWyaBXqBW3PKQz7QP+oE8yje91XrhOQam04eJhPIBLO88g6/U rdKaY7evBB8bJ76Zpn1yqsYOXwAxifD0gDcRTQcB2s5MYXYmizn2GoUm1MnCJeAfQCi/YMob R+c8xEEkRU83Tnnw3pmAbRU6OcPihEFuK/+SOMKIuV1QWmjkbAr4g9XeXvaN+TRJ9Hl/k1k/ sj+uOfyGIaFzM/fpaLmFk8vHeej4i2/C6cL4mnahwYBDHAfHO65ZUIBAssdA6AeJ+PGsYeYh qs6zkpaA2b0wT4f9s7BPSqi0Veky8bUYYY7WpjzDcHnj1gEeIU55EhOQ42dnEfv7WrIAXanO P8SjhgqAUkb3R88azZCpEMTHiCE4bFxzOmjOwU0EWb/ZxQEQALaJE/3u23rTvPLkitaTJFqK kwPVylzkwmKdvd2qeEFk1qys2J3tACTMyYVnYTSXy5EJH2zJyhUfLnhLp8jJZF4oU5QehOaJ PcMmzI/CZS1AmH+jnm6pukdZAowTzJyt4IKSapr+7mxcxX1YQ2XewMnFYpLkAA2dHaChLSU/ EHJXe3+O4DgEURTFMa3SRN/J4GNMBacKXnMSSYylI5DcIOZ/v0IGa5MAXHrP1Hwm1rBmloIc gmzexczBf+IcWgCLThyFPffv+2pfLK1XaS82OzBC7fS01pB/eDOkjQuKy16sKZX6Rt57vud4 0uE5a0lpyItC2P7u7QWL4yT5pMF+oS8bm3YWgEntV380RyZpqgJGZTZLNq2T4ZgfiaueEV4J zOnG2/QRGjOUrNQaYzKy5V127CTnRg4BYF/uLEmizLcI3O3U1+mEz6h48wkAojO1B6AZ8Lm+ JuxOW5ouGcrkTEuIG56GcDwMWS/Pw/vNsDyNmOCjy9eEKWJgmMmLaq59HpfTd8IOeaYyuAQH AsYt/zzKy0giMgjhCQtuc99E4nQE9KZ44DKsnqRabK9s3zYE3PIkCFIEZcUiJXSXWWOIdJ43 j+YyFHU5hqXfECM6rzKGBeBUGTzyWcOX6YwRM4LzQDVJwYG8cVfth+v4/ImcXR43D4WVxxBE AjKag02b+1yfABEBAAHCwV8EGAECAAkFAlm/2cUCGwwACgkQE/zvid2ePE/dqQ/6ApUwgsZz tps0MOdRddjPwz44pWXS5MG45irMQXELGQyxkrafc8lwHeABYstoK8dpopTcJGE3dZGL3JNz 1YWxQ5AV4uyqBn5N8RubcA8NzR6DQP+OGPIwzMketvVC/cbbKDZqf0uTDy3jP65OFhSkTEIy nYv1Mb4JJl3Sq+haUbfWLAV5nboSuHmiZE6Bz2+TjdoVkNwHBfpqxu6MlWka+P98SUcmY8iV hPy9QC1XFOGdFDFf1kYgHW27mFwds35NQhNARgftAVz9FZXruW6tFIIfisjr3rVjD9R8VgL7 l5vMr9ylOFpepnI6+wd2X1566HW7F1Zw1DIrY2NHL7kL5635bHrJY4n7o/n7Elk/Ca/MAqzd IZxz6orfXeImsqZ6ODn4Y47PToS3Tr3bMNN9N6tmOPQZkJGHDBExbhAi/Jp8fpWxMmpVCUl6 c85cOBCR4s8tZsvGYOjR3CvqKrX4bb8GElrhOvAJa6DdmZXc7AyoVMaTvhpq3gJYKmC64oqt 7zwIHwaCxTbP6C6oUp9ENRV7nHnXN3BlvIgCo4QEs6HkDzkmgYlCEOKBiDyVMSkPDZdsspa+ K4GlU2Swi/BDJMjtDxyo+K0M81LXXxOeRfEIfPtZ3ddxBKPva1uSsuz+pbN9d1JY8Ko5T/h1 6susi2ReUyNJEJaSnjO5z13TQ1U= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Jan, > coff_section_data() and elf_section_data() use the same underlying > field. The pointer being non-NULL therefore isn't sufficient to know > that pei_section_data() can validly be used on the incoming object. > Apparently in 64-bit-host builds the resulting memory corruption is > benign, whereas in 32-bit-host builds a segmentation fault occurs upon > de-referencing pei_section_data()'s return value. > --- > Of course the value (first) being set on the input bfd is suspicious > in the first place: When copying e.g. ELF to PE/COFF, the option ought > to be similarly respected, yet clearly it can't be set like this then on > the incoming object. The change here is merely to address the testsuite > failures observed for Arm64 and RISC-V ("Check if efi app format is > recognized") as well as the (latent) memory corruption. Thanks for fixing my oversight! Cheers Nick