From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150089.outbound.protection.outlook.com [40.107.15.89]) by sourceware.org (Postfix) with ESMTPS id 4A7293858434 for ; Thu, 5 May 2022 09:01:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4A7293858434 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=FXjvHWuTnIDz/hh2WLs02HW8+woTG8uMbC8Il2I2KF3qUgcVbjITJD2yx2080ijuZdRSEV84vj7fSktetztnzXdsrSqcKoVX96FL1e/2tVWdez3wHT8ATzJ15yjklYuq2aibOi97AZzH7Te+S8Omm7/VPhiVkTWhEiG/G8+m1d9B+Z3nF/wMy7GSrFNeAqf96qRRCB3Qw38xF84GyLTIX8+2PkzRpc1g5YSrHv7W0kUrM/eUjCMQYhf9gGzz/ZJx/h8OvK/ivoCX7wGtdP392aAnSKxS5DktXtTKQhs/CDssZcy0vQiDqAoU7fNGksUeZ7TE/UMZ02RT8uAWtQfuYA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B5gq8dCK1qypTL+mjMOv6vEvfSGbjas0hrge3M8XH48=; b=GvKmtkRH4i8VKbeeQV1LNJ5gYUYmKrSPI4Jx1ZPzD6gwSfJeyDBnxSZEm06f5bcZXH5PD75QyLJI7IIpfRYOzYWnltMxmV2OT0g0jdolV1jcdKiFdbuddoC5bbMEDN9bN8nYx9zINTWL2k8VXoq0ja3uBXNXHQmF8zRW2aWr5OMgDKcwA06JQAu/MMCgDiFpIpHdGhxrwiawmOVIgkp4t5au+OpzcO2/p9037M9wNzMUF523j/GKLmIvtevjcQyiVAq8z7C7Of7RqRqa94KHNutcq6+VlLd9tyaeGju1Rs1qPgBGJqRAbJQvycm7nOhBvKZGPW/f3xduHNdLcWJkxg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from AM6P195CA0087.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:86::28) by VI1PR08MB4383.eurprd08.prod.outlook.com (2603:10a6:803:fc::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Thu, 5 May 2022 09:01:21 +0000 Received: from VE1EUR03FT046.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:86:cafe::d9) by AM6P195CA0087.outlook.office365.com (2603:10a6:209:86::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13 via Frontend Transport; Thu, 5 May 2022 09:01:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT046.mail.protection.outlook.com (10.152.19.226) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Thu, 5 May 2022 09:01:21 +0000 Received: ("Tessian outbound facaf1373bbd:v118"); Thu, 05 May 2022 09:01:20 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: d076f131fc1f67b8 X-CR-MTA-TID: 64aa7808 Received: from a95b8b923b5a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7BBF5C76-392B-4F6A-A8E5-FF7984523654.1; Thu, 05 May 2022 09:01:12 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a95b8b923b5a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 05 May 2022 09:01:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b0hPlyos2D8YSFtVvJr3w9/qCLZWPx3F5IYmgFDOdb6+iIdTyGg4ANRPatp9M/e3UT7PyJH1H9vCaCCOLiWlRB7k+fPHCCLiassBmvvzvuB3Ow01YzN00vSM9IetDiXYOoQnrCmu+8ZfTrqDj/2mMfcmI0tuxOOiJSpyJvso9r6q2eA0GVw0tAJaLA//kKSOZ96qSCzGQsgfZeuHE3MpsPwvR8gJkAx0ZsIyxsJhTtBf6J/rFzBHJuirs7MRClN0r72uAdNrdUo5hwD/V9VAm7P1HqfPaMjTGr+jBSjuz4yYuFn7Cjl8rL7QOeyACjHRinA8LO+RYkCtDHrQL0rSyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B5gq8dCK1qypTL+mjMOv6vEvfSGbjas0hrge3M8XH48=; b=nOjSFNFAQfW4EgbR1CruT96Ds+b2nKdGZHYoWcim5/gNlwCcxznAlwPfe2j84jpSvxu5T/TvkDISH4OernOBfHHq/5T+FpXmBpscjDyyJCttlPZKqEYT8gxjdOm8fN+YPvbZEcz5/a3Mje8wwDwEesHDlHKUvKcGBcry6bob2z59bDp3rvNjMdjHQGhXvqUF5mQzdC7hIdN7Zv5thyPcgg63zjKMlEtUqj1BGUI2avH3jm9+ak8uVxn4uCNNrsApu+T2YR7/SdHZzNyRUGYFPIy6j81q7zq2EysSlpnGqnpAbmKOZ6tqYg8GSZA8kOgtDdE2Q9RdPxqi+PfsoPp08g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AM8PR08MB5570.eurprd08.prod.outlook.com (2603:10a6:20b:1d2::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12; Thu, 5 May 2022 09:01:10 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7080:6233:cf8f:a8a6]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7080:6233:cf8f:a8a6%7]) with mapi id 15.20.5206.025; Thu, 5 May 2022 09:01:10 +0000 Message-ID: Date: Thu, 5 May 2022 10:01:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] Don't define ARCH_cris for BFD64 Content-Language: en-US To: Alan Modra , Hans-Peter Nilsson Cc: binutils@sourceware.org References: <20220504075628.81292-1-luis.machado@arm.com> <88ada15d-c371-df10-368e-f1c9fb91c289@arm.com> <20220504143703.58AD620462@pchp3.se.axis.com> From: Luis Machado In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0154.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c7::11) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: b483063f-bc9a-4374-954b-08da2e75d2ec X-MS-TrafficTypeDiagnostic: AM8PR08MB5570:EE_|VE1EUR03FT046:EE_|VI1PR08MB4383:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 1FZVhPJUrie59b3tZMJI+0IqpZhxemKFH/z2TJGDw+NCt+MXRePNMDU5YgM6zaJ0QSOWhUoM9o48MLaLUZRyVrTHrlV2XwxeIRyQ4/LbTAKozvIz1YfBIORiwWeLZ65IFH2lb81ZsyHfganZFNpAv5bVIN4QJlPAoxSDY04RtUHbaB+uXgy7/mkmOk57arntJ3SgwG47v2r1+56NUT/g1Hbr2E217HQIyb31SOvfTVHFRKd5ZT1YhWOFXWFDixS56d6oqjLmhe32kgZSIVp3XtLx/kiHfotO98TXKhA9OHz2gLWbPGgFASIFeCWeql9Vy/fHwnjvwPlkaHzl2rN4oAtlfNDgDxvePI8x6pgePAPFLPdA1u/224IJrNAUj2OkmX7TFEg58ELQNCI+pevMlFM7FkS+kCzb+eF3+C/TSgujKUXQOA70HUZL/BpKR4ixVdeQ/H3IvL4qytMhvfFjIhyd00p9oqGZmnyDrSplwYNnreCIz/i7/1ojV/KtX8silOStQheW8AS0OpKerZAvYLffW4C6c/6R6p/a7v1KJffsEm8o2/YBvsvFQ9XncoSlUPmF5xOvWDtT2uTI9uPvkWtUHKTIDktM0n1fWudOeljRvqJCtcDg+/4jujigOLIJ9OaTpB8uXQ8rySLdvDCWqSzaH4FaFyNheezGz989fIsoVGCqMfihPf6CXGMeRRNE2RQFO0AFMTxfyOE3iuO2kxvnODKHo3zw6yIrH/W5OzA= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(6486002)(316002)(2616005)(186003)(83380400001)(66556008)(66946007)(4326008)(110136005)(36756003)(31686004)(508600001)(66476007)(8676002)(6512007)(5660300002)(38100700002)(86362001)(53546011)(44832011)(8936002)(26005)(2906002)(31696002)(6506007)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5570 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1ddc4515-06f7-47e8-b2ce-08da2e75cc8e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ggdnaq1wdD6R45WAQQAozrLjl9Y/O2oiQxjHVa4p6TN0gpQ2cjS1ZVN/dj8rv6471Sceluu48VNNOdHfI5/UDXwrPIObrbNINbCFEy5UW0kgP2gnWWKwvbv0Y2oF10MGQx5caNPjBN4tYziOKt/i7CKJkwUH/UZN1B1v5q+gc52mo/U5dVTR2vwdAwdtfR5/G9T6k3aeY5oMVZBvm0Sg/TdBKO0kafZWPGaTEEvKTKt1LnHu7GxakTOrFut0yyMhICSkG+SIHAx4q5EdyeuJCFyWmfAfozYe1z8Nl3p2Rpjq4rx01hKYov+cREY3c4PUK+v8d7wdo62T7/touCy0SxjOZQjyhKvpn4z8HerDXA0Rba9lchLnE9A1RK8oNlT+dNzxbA8xg1ZYRHbkIkG6Shw5Dmf+M8KisvPYxFd4E/P3nVvp75lJ3Iv7fUPeGTlJhEHMmtBcjkFtyeoHA6ZkUZZ0huo9kRetpq5VkKxfWo4weWNvkbKVdEga+6UbS8L9NM2LUnKWC6nuBC+efkxuz7hq5VbPQPnoOH4OXUYmNn2cGZ1EcobQDNiEn+09H+EAGfyRSIo++5Eq9IN3CwNIF3u2kU3gZjg6VSQXpDRPpx76aygFA6ikOtUWZ0iYWvAS2I+Wzhf9nW78/XplFLr1VZXZKr2QuAMnc6BsgVPr8UWKGYKNW0IwwSMvWss6g7YcKuNarOkjDA83Wp6j5Iwh5w== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(316002)(82310400005)(6512007)(8676002)(86362001)(186003)(83380400001)(44832011)(36756003)(47076005)(336012)(6506007)(26005)(356005)(5660300002)(81166007)(8936002)(2906002)(53546011)(31686004)(70206006)(31696002)(70586007)(2616005)(4326008)(36860700001)(110136005)(40460700003)(508600001)(6486002)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 09:01:21.0024 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b483063f-bc9a-4374-954b-08da2e75d2ec X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4383 X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, KAM_NUMSUBJECT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2022 09:01:26 -0000 On 5/4/22 23:37, Alan Modra wrote: > On Wed, May 04, 2022 at 04:37:03PM +0200, Hans-Peter Nilsson wrote: >>> From: Alan Modra >>> Date: Wed, 4 May 2022 10:39:58 +0200 >> >>> On Wed, May 04, 2022 at 09:15:43AM +0100, Luis Machado wrote: >>>> On 5/4/22 09:08, Alan Modra wrote: >>>>> On Wed, May 04, 2022 at 08:56:28AM +0100, Luis Machado via Binutils wrote: >>>>>> I believe it is a mistake to define ARCH_cris when BFD64 is defined. It is >>>>>> a 32-bit architecture, so should be placed outside of the BFD64 block. >>>>> >>>>> No. cris may be 32-bit but the bfd support requires a 64-bit bfd. >>>>> See config.bfd. >>>>> >>>> >>>> Interesting, I missed that. So I suppose GDB will need to move these cris >>>> files from ALL_TARGET_OBS to ALL_64_TARGET_OBS. >>>> >>>> I see opcodes/Makefile.am also puts the cris files into >>>> TARGET32_LIBOPCODES_CFILES. Is that a mistake? >>> >>> Hmm, maybe config.bfd is wrong. I see cris files in bfd/Makefile.am >>> BFD32_BACKENDS. Hans-Peter, do you know what is going on here? >> >> I didn't remember that I had changed anything 32/64-related >> in that area, so I had to consult git blame. The most >> recent change I did was in 2017, so whatever 32/64-changes >> is probably related to 56fbd041853a "Fix gas/22304 by >> forcing a 64-bit bfd for cris*-*" (TL;DR: expressions >> overflow). That commit *could* be slightly wrong; perhaps >> it shouldn't be wrapped in #ifdef BFD64? >> >> Adding CRIS files to BFD32_BACKENDS happened when the port >> was added, back in 2000. If it's wrong for a 32-bit target >> to be there, then I don't want to be right! :) > > OK, so this means we have two slightly different versions of cris > support. Configured to support cris directly with --target or > --enable-targets mentioning one of the cris tuples will always give > you a 64-bit bfd. On a 32-bit host configured with > --enable-targets=all you'll get a 32-bit bfd, and miss some support > for explicitly choosing and displaying targets. (The #ifdef comments > in config.bfd are used to generate targmatch.h, which gets included > into targets.c.) > > I'm going to apply the following, and Luis, please apply your > disassemble.c change. Pushed now. Thanks!