From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id B3C5A384CBA1 for ; Fri, 10 May 2024 10:34:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B3C5A384CBA1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B3C5A384CBA1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715337256; cv=none; b=FcC6AK7/P5gF2vpVCo4UgE7fYrN0uZeLVElai+VJtA+K1xrLe6hWsxU5xW0RG4h3rWkm8QteeUVvdSzeXWZVGBwmqp/QrL5yvndfPw84KPHsF5374c+DysI29Cw5ub1KmN1uGUQWKpUzwnwgR476/OAsCyuH2GebNQEitmSRAi4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715337256; c=relaxed/simple; bh=GXzFvu0E+JJtQFlRMxw1e3zX65PmyD2CLcK6BO5O8Qo=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=AJZpQa77qt763u8sp98dqauElhUmC+Hb53+dppCC6wrL83M3z1Zlmx7t1wZnNJ07OwcKOPivPum6AQ0JZ7uPkoGYAZChaiopkdqPyJ9wMUYUqh5W1g0MVZ7HNsUULLnZzk8jk/+roc8DQ2Vix1eZFatUuGOkkd7C7FYvMxfNt3k= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 87D3F106F; Fri, 10 May 2024 03:34:39 -0700 (PDT) Received: from [10.57.82.226] (unknown [10.57.82.226]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 856D33F641; Fri, 10 May 2024 03:34:13 -0700 (PDT) Message-ID: Date: Fri, 10 May 2024 11:34:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 4/4] aarch64: testsuite: share test utils macros and use them To: Andrew Carlotti , Matthieu Longo Cc: binutils@sourceware.org, Nick Clifton References: <20240227105917.295899-1-matthieu.longo@arm.com> <20240227105917.295899-5-matthieu.longo@arm.com> <9070737f-e2fa-e9c7-fba2-951d53287204@e124511.cambridge.arm.com> Content-Language: en-GB From: "Richard Earnshaw (lists)" In-Reply-To: <9070737f-e2fa-e9c7-fba2-951d53287204@e124511.cambridge.arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3491.3 required=5.0 tests=BAYES_00,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 04/03/2024 14:43, Andrew Carlotti wrote: > Indeed - this is just my preference at the moment, and I don't think it should > prevent this patch being merged (particularly since you're just homogenizing > existing macro usage). Plenty of other people have used the macros before you, > and must therefore have considered them to be beneficial. I see two main purposes of all these tests. The first is to allow some cross validation with other toolchains - manually staring at individual opcodes is a good way to frazzle your brain. The second is to ensure that we don't break things going forwards (introducing regressions). My main concern would be if the macros make it harder to do cross validation. If so, then that would be an argument against them, but as you say, we've already used them in multiple other tests. R.