From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) by sourceware.org (Postfix) with ESMTPS id 65BB63858D39 for ; Sat, 2 Mar 2024 03:36:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 65BB63858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 65BB63858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::72d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709350601; cv=none; b=ekDKa7p9h5oKFIS4E9OC139OBM9kMzn7cF7EZjmCL3H56+f6RROHE6sl8H9lajnI9BVKywgEeCk3P4EvQDeiRAidH8IUMFHOyhu6kWhfj2UTO6UN/Ya6pS7Gh4EmD/IdNXZsIeWmT4Cu/lhynZJjfTxw14cPkKVqO1vl9Mm+c3o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709350601; c=relaxed/simple; bh=pT4fccU2HMVxQF8aILdkHwagQcQgV2v+u6Wj7GG6hGE=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=LrIhTFN/PYTwIqSmbuSagH4cwH0RBpBK9u2+gqwL9GJXqjLqHUulgP9EC0DGfYVsKw9h0Fa56+seCS+AGtoP1/X0v6g0GiEpfpb5pr2P6HsCIFGarIfbKxF7E6OaNOv7AnhyI69noGe/MSakM7YR+xW2VAmFXLnqY6JpK6EeFP0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-qk1-x72d.google.com with SMTP id af79cd13be357-7881c3eacccso822385a.0 for ; Fri, 01 Mar 2024 19:36:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709350598; x=1709955398; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eE9+qc2MdlQJf/MOWTxx0ZG+rmw0JaDh+3s19+jjKc8=; b=Y1LiP0tHNg4m0S7zY5qs5wBJDcc1+Qs0e2UXcqnekjTct2BXH32bQoQsgMeWveJp4t t/rQDaGhbrU6JobHBRdaNc/WNkS31qT+Z0Xh/2FPZkn1A5cq/wGeorJG7aObbqSr/K4S +sweKcI14zWovf18dHYaN/SEE2V9Fw0+j1CbxRJxwhH3dicYP9Q1giLDpbLY5dcGLEi3 B750aeilZRby/Eq8cHB99UUo4jVbHJnRlrSQyJI+fZa5+5QmYavl5EzbugrytWdoNYzH XG5SrtaH9wrLZJ+6bUsoAFqX/GXduN3SQsv4kra2PK+v9LAaF+XAe2Z3/8WeptKdWh0d p2wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709350598; x=1709955398; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eE9+qc2MdlQJf/MOWTxx0ZG+rmw0JaDh+3s19+jjKc8=; b=v5iTmjMZTwJF64pgdbqh0i+8cJqHlj79Hvp3XIMFA0omw06StMMDulkHFZfQ0HfHsE k2g5KJNPn9Dcp8v1fKb/46SEA8qE4T/+2FEgFzcfPcz3CxIm926+Jp4OaRe5+ExawPXw oBX1vURsc5s7QNhigJ9hGummJ7zAJfAlAB93QMr0u3IyCfxKjGOLr+edgj1TpBMzL+V+ ixTLJekdTAROiRhgLy4a5x2PzfWlSHfIozLdn5abG6PwBYHFbH6cz52x/rkMC1S1HMDT 1PcTZygVecXVTtwC4FWMJ64piVnMXKRLIbN/fnx7MQobbC2xK1G3bXjbNiDnLx2gobk3 oq7w== X-Forwarded-Encrypted: i=1; AJvYcCWlBfrV4IZAMaJ3RP8pNvFdlvn2hwDGFpxqkYrp3RjlWFqYlV8dawKhC8BdArPCTleBOe/uvkS/dupIu+10/+QJOjg6+JCXKQ== X-Gm-Message-State: AOJu0Yy+fKVQygcGVrMBuhw7ckXe3ufpyt0MnoxScKRgRS0rRsrbq+pJ QfuKzgZ/tagdEDAncl0QCPwUJtfqMK57YY3bB/QZBP91fAJgkQgw X-Google-Smtp-Source: AGHT+IHtTdpif1If+sq0zLM8jW+m+4ENFCBqz36XB9qPADaX/sMuKgzTxgpOrrVf6Kn/yT7XPkgFSQ== X-Received: by 2002:ac8:4e46:0:b0:42e:b92e:1b65 with SMTP id e6-20020ac84e46000000b0042eb92e1b65mr3863151qtw.10.1709350598584; Fri, 01 Mar 2024 19:36:38 -0800 (PST) Received: from ?IPV6:2602:47:d95e:101:67f1:6ff3:a29e:2a6c? ([2602:47:d95e:101:67f1:6ff3:a29e:2a6c]) by smtp.gmail.com with ESMTPSA id j19-20020ac85c53000000b0042e7c95c5d6sm2297305qtj.18.2024.03.01.19.36.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Mar 2024 19:36:38 -0800 (PST) Message-ID: Date: Fri, 1 Mar 2024 22:36:37 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [binutils] libctf: Remove undefined functions from ver. map Content-Language: en-US To: Nick Alcock Cc: Sam James , binutils References: <87bk828z6q.fsf@gentoo.org> <877ciqvtgi.fsf@esperi.org.uk> <87v868qwvd.fsf@esperi.org.uk> <78f71dff-4190-41ba-bdfc-162e417ab638@gmail.com> <87a5nhn8tv.fsf@esperi.org.uk> From: Nicholas Vinson In-Reply-To: <87a5nhn8tv.fsf@esperi.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/1/24 12:46, Nick Alcock wrote: > On 1 Mar 2024, Nicholas Vinson spake thusly: > >> >> >> On 2/28/24 13:14, Nick Alcock wrote: >>> On 28 Feb 2024, Nicholas Vinson told this: >>> >>>> On 2/27/24 10:05, Nick Alcock wrote: >>>>> On 27 Feb 2024, Sam James said: >>>>> >>>>>> Nicholas Vinson writes: >>>>>> >>>>>>> The functions ctf_label_set(), ctf_label_get(), ctf_arc_open(), ctf_fdopen(), >>>>>>> ctf_open(), ctf_bfdopen(), and ctf_bfdopen_ctfsect() are not defined. Their >>>>>>> inclusion in libctf/libctf.ver causes clang/llvm LTO optimizatiosn to fail with >>>>>>> error messages similar to >>>>> This is definitely not right. They *are* defined, but only for some >>>>> libraries built from this version script. You can't just take them out. >>>> >>>> Could you point me to the definitions for ctf_label_set() and ctf_label_get() ? >>> Those two are long dead and gone and should indeed be removed from the >>> .ver script. (I wonder why Solaris's linker, which is just as picky >>> about version scripts referencing only symbols that actually exist, >>> never warned me about this.) >>> >>>> I do find definitions for the other so the other symbols, so I'll find >>>> a different way to handle those symbols in the version file. >>> Commenting them as /* libctf only. */ should be enough, I think. Only >>> one symbol seems to be missing, ctf_arc_open. The others are already >>> properly marked and should already be being excluded from the .ver >>> script for libctf_nobfd.so.) >>> >> >> I see what you're talking about in libctf/configure.ac. However, it's protected by a `test -n "$decommented_version_script"` check. >> Because ld.lld does not understand `-B local`, that variable remains empty and the lines in the version file containing /* libctf >> only. */ are not removed. > > Aha! GNU ld doesn't support that option either. This test was meant to > detect Solaris ld, which supports version scripts with similar "no > undefined symbols" limitations to what lld seems to here. I'd suggest > that configure test needs augmenting to catch lld as well when this flag > is provided (so specifying $LDFLAGS in whatever test you carry out). > I'm considering this thread closed. I have a new patch that solves the problem. I'll post it soon. Thanks, Nicholas Vinson