From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19413 invoked by alias); 19 Jul 2006 03:44:37 -0000 Received: (qmail 19400 invoked by uid 22791); 19 Jul 2006 03:44:36 -0000 X-Spam-Check-By: sourceware.org Received: from nf-out-0910.google.com (HELO nf-out-0910.google.com) (64.233.182.190) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 19 Jul 2006 03:44:35 +0000 Received: by nf-out-0910.google.com with SMTP id k26so130047nfc for ; Tue, 18 Jul 2006 20:44:32 -0700 (PDT) Received: by 10.78.139.5 with SMTP id m5mr106315hud; Tue, 18 Jul 2006 20:44:31 -0700 (PDT) Received: by 10.78.156.1 with HTTP; Tue, 18 Jul 2006 20:44:31 -0700 (PDT) Message-ID: Date: Wed, 19 Jul 2006 03:44:00 -0000 From: "Paul R. Nash" To: "H. J. Lu" , "Paul Nash" , binutils@sourceware.org Subject: Re: binutils-2.17: --cref broken? Extra warnings and corrupted data In-Reply-To: <20060719015355.GP18571@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20060717020350.GH18571@bubble.grove.modra.org> <20060717223053.GA11150@lucon.org> <20060718030409.GN18571@bubble.grove.modra.org> <20060719015355.GP18571@bubble.grove.modra.org> Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2006-07/txt/msg00248.txt.bz2 On 7/18/06, Alan Modra wrote: > On Tue, Jul 18, 2006 at 12:34:09PM +0930, Alan Modra wrote: > > On Mon, Jul 17, 2006 at 03:30:53PM -0700, H. J. Lu wrote: > > > --cref was broken by --as-needed. > > > > Ah. My bug then. > > This extends the horrible hack of saving the main symbol table to saving > the cref table too. I'm not proud at all of this hack for --as-needed. > Some day when I have a some time on my hands I'll look at implementing > a two-pass approach to loading --as-needed library syms. > Attempting to build this on 2.17, I encountered two problems: 1) I had to figure out bfd-in2.h so I could put that in my patch against the dist tarball. That wasn't hard, I got around it. 2) After that, building yields: gcc -DHAVE_CONFIG_H -I. -I../.././binutils-2.17/binutils -I. -D_GNU_SOURCE -I. -I../.././binutils-2.17/binutils -I../bfd -I../.././binutils-2.17/binutils/../bfd -I../.././binutils-2.17/binutils/../include -I../.././binutils-2.17/binutils/../intl -I../intl -DLOCALEDIR="\"/usr/local/i686/4.1.1-1b/share/locale\"" -Dbin_dummy_emulation=bin_vanilla_emulation -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Werror -O2 -pipe -fno-stack-protector -c ../.././binutils-2.17/binutils/size.c gcc -DHAVE_CONFIG_H -I. -I../.././binutils-2.17/gas -I. -D_GNU_SOURCE -I. -I../.././binutils-2.17/gas -I../bfd -I../.././binutils-2.17/gas/config -I../.././binutils-2.17/gas/../include -I../.././binutils-2.17/gas/.. -I../.././binutils-2.17/gas/../bfd -I../.././binutils-2.17/gas/../intl -I../intl -DLOCALEDIR="\"/usr/local/i686/4.1.1-1b/share/locale\"" -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Werror -O2 -pipe -fno-stack-protector -c ../.././binutils-2.17/gas/output-file.c ../.././binutils-2.17/ld/ldcref.c: In function `handle_asneeded_cref': ../.././binutils-2.17/ld/ldcref.c:242: error: structure has no member named `count' ../.././binutils-2.17/ld/ldcref.c:283: error: structure has no member named `count' make[4]: *** [ldcref.o] Error 1 Indeed, there is no count in my version of struct bfd_hash_table...actually there's no other usage of ".count" anywhere in ld at least. Is that mainline only? Thx... -PN