From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by sourceware.org (Postfix) with ESMTPS id B8C583858415 for ; Wed, 9 Mar 2022 14:39:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B8C583858415 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2111.outbound.protection.outlook.com [104.47.18.111]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-28-KMII_rtzPzSOmnLHJuPz7w-1; Wed, 09 Mar 2022 15:39:01 +0100 X-MC-Unique: KMII_rtzPzSOmnLHJuPz7w-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i+bJrUzrj8gOdGgNECin8jgY5wsV0r4ryXvbjRFMu1AaeeNw8fe7dGv30d5ROs1gNnRRIda/Cu65fJctZFFVDtO2w3EXZPbpLUDzqAK6psXNgJdvBHHKm/qdU9Rej3UhPjE/GKOvAh/C1HMmB5m6hBM2U6m0I/Lui5N73jGcoUSLRaUGKmPd47cuiP6q+3VjEYwUbaGDaltQmXV/vBDYWZUCCuQisMjH1rz/fNWNXU5aZybcDo0zzoKo3VqVuRHFGb3CpO1kvBlOn6j73cpyVlEhosqMzaXEbhiSU8h5zksO6XaGXaWp1q6tOv81uOacn0U3N9GD+ICLOZRGCiMa5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eCAWmc7HaIbGhuZzDelRgVLwhGghOLQEbv96o0r09Lo=; b=S0w7FfmXt8itkUTn8CSwZO98mjaOSqCwijSndtDajIXvPv8eY/7W6QhfBMI3guAvCa6Sw9+TGTgp9Z1RBTJZd32hs3Lh7lvKCgoox7r4wXbXmEu+DY9GhGGkaI0MP2cBit0I5YCG2StiMXZinCrw3bR34IZnrOLuT5GVVTHXb4NCJIQ+aEZu4HZ5QTA0YMcfXqb1yjPRU2BQAqIvunwSx6K9cHHX12mUjlTA9+aqgq1Wi9ucoTuAivSCQhgEW+3uQz3nO7I0W9GINvXRUDl7ZP3De48B5oHNm9fiJDtAZ8F6GaBflHTqSKANx6a4omJhfrQgdAwe1INof0oG9GEIvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by DB8PR04MB6764.eurprd04.prod.outlook.com (2603:10a6:10:10d::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.15; Wed, 9 Mar 2022 14:39:00 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5038.027; Wed, 9 Mar 2022 14:39:00 +0000 Message-ID: Date: Wed, 9 Mar 2022 15:38:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v2 1/3] x86-64/ELF: permit relaxed overflow checking for 32-bit PC-relative relocs Content-Language: en-US To: "H.J. Lu" Cc: Binutils References: <319f39e5-1f17-23ef-e3fa-2169876aa31c@suse.com> <5ac79eef-290c-5f77-2387-99be18e10ee8@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR0601CA0053.eurprd06.prod.outlook.com (2603:10a6:206::18) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 63174cde-c525-4d2f-4240-08da01da8c9e X-MS-TrafficTypeDiagnostic: DB8PR04MB6764:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9zQax4Fxbozo3zvv/MjbWnfbuV7aGHrjeGD5ANPiTulEH4NJVXonFekc5hzzmy79IK5IFsZ9QJrq2VGn4YIOrL/Uk8f2GYLFZb2MBXuQoFoXCHMdnpORnesZegHbMB8wm0TsIxBfHhL/sh8kDsJlXy4T91CgWUpA1DhKWIHoD0qQdaLRxD8/syvvM9MHa6C1wuRwbRfHIbJVOCn2qWmMGifCDJ8MAlhUgYU2tWIPT8HZ3TfbrosTH0ngvkup+HvIPsnuq2PSKVZHijW4aSm+WmVe3mh3c6byfaRFoGMwQOt0qEvsB5+5y8knGBrjumGatpR3+QY4luFUMUggnrzaomBmhQxp5C3fQYfsJZvIVRUJxPU1DBO7tadrfUlYJKiH1vU8IV58DgAtJNMDAO3aXXcLvdI7NRfZSyQCZ7uoWOgEeBMJHxOrEzbaTX33Fmw4OBCtaLff77sWVldxkCJi2GPjOdnA4z9tTJ1B91mPk10gJWUfIr06gqdDZreFqoNvpkjK2d2VG+VmnNgo6D/4Lna3OnN6g2iVHf5NWYF3N+q/6dGFAej30KYIEoyoWAXoK+eL29NpjaqSxWiHe1E4+Mo6Qzd+f33k46sJOEQkwHHLHek7mdHaz2IpKA4CBLvV4cNh32pnULInSJJDLjYYcLEugM76iqdENyk+lvGC9Dp6Yow1SwgIU8n3dyIxYAEcKAlGPqupelezM3D41SqZdY+KKBVHAOeigEdud7LgrWEdWWQ5rFMld5P7misb9AJW X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5600.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(2616005)(186003)(2906002)(26005)(316002)(508600001)(53546011)(6512007)(5660300002)(83380400001)(86362001)(6506007)(8936002)(6916009)(38100700002)(31696002)(36756003)(31686004)(6486002)(4326008)(8676002)(66556008)(66946007)(66476007)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b1B1OVhtaFdPRGFwc2F6N3IrRkx3MWl3dEN2SjZqREFiMTNURGNkWmZ1S1Zq?= =?utf-8?B?N1VCRTFyc2VJYzRGd1ZLQkQ1a0hpa1lxN3ZHZkpIOTB5VCs2cDdFSHlvVUU5?= =?utf-8?B?SVh0b29xalljZXl5ZTc4dytEaXdYWDk5d2luZmx5S0NEa05tVmZtOS9mdlhh?= =?utf-8?B?RGtPUStqRktVMWRSQXJ3cC9qKzVqWVFuNk12bStiTENoaXV2bzlmZ2ZNa29V?= =?utf-8?B?bjUrcmRHTll2UG91d2c5UG1RRmFqcGFxUG9FdlBSam1BYUtQdUNVK1A3Sjgz?= =?utf-8?B?UlIxamFIUjNlMFpZcTc3QkRQa1J0bk5yYTBIMW16YlB5cUswT3YyakxacFhC?= =?utf-8?B?T1FraWlBWDFmU21IdVJyTys3ZTVYZWVqa1BJRUdpUjRsME0wMWZ4Y3FjMWVq?= =?utf-8?B?VlVWY3ZBcWM2Y3lVU2FoRWlLTElnWUx0Y1JmdzQxRmFKOUtBQXB6dVZMWUgw?= =?utf-8?B?QWtLbm5VZStERVlGVTRoU2pZYzNLUFRDZEpzeTFFaUlwb3FObmw0cHVJT2Rs?= =?utf-8?B?NUk5eHQ5M2JUbVU2NDNhczlqN2gvZ1k0WUtXb1QvdEo4aEtWbyt4T1RxK0U4?= =?utf-8?B?Q3ZYcTJiMTNpNm0rQzU5YmRNSTR1QzQzYTIwVUhiOGtwNXJpUW9MdDU0SmJL?= =?utf-8?B?QTk5YUZPMmRFMFVRbzVQNnlSVVY2V3lHQlFEWjlpKy82UjFNcHRxcWJ3RGtk?= =?utf-8?B?Y2QvcHBOWlFxUUJaUEZWNDdEYkxEV251OWRWaWtXcHhpQk5LVVA1QW50ZUlF?= =?utf-8?B?aTlpQUM4Y0loNVlIRTdMQW9zbjhJaHg3cE5uS0xkdXRtZzZiSEZCMHhpOENo?= =?utf-8?B?eEE3U3l2Mzg4QWJVZkllaFZZVFZpNmwxREplcjVFYTZpbDFEVUlLUjBzQjVq?= =?utf-8?B?NVFWMFh2QTlDRE9nRnR6YUNvallHVkFsRk93aTdkeWxDanQwK2lRdjNZWTJs?= =?utf-8?B?eEhtRDJTczR1eGdabk9oeXk3dmVWWnZvbkdyR1ZOSUEvZHo3MFJ2bEpOTFZY?= =?utf-8?B?M1FKaGM2UkJWTzB1T2RTWnJVYVZoeTRoWmJZM1EvVUJuOFFhZ0RpTU1kUmV4?= =?utf-8?B?M2wxWTBzWDRkMTZQY25YZWZnaFBLclMreGEyMFFUdDE4RUxNdm10SXJxRENL?= =?utf-8?B?ME90d3VSYmNVVVNDbDlHYTNONWdNRFZ1UW1jT2l3TU94R3ZmajRmZWsrdVVo?= =?utf-8?B?Q1EwWktYak5PWEhsV1k2MllGak9NUEFoSnIxYVlDclJuaXdLcGdNZEZ3cThI?= =?utf-8?B?eTVuaDY2N0xHdXZCUXFsd2txVE82WEtLYmhCejE2OFBqWVJqQlZhVHljTGJU?= =?utf-8?B?V2sxVGVGQTZ0TVNyY2x4bFNuekxwWHh2aGkwREszeE1BYTJmWEU0dzdVSHBl?= =?utf-8?B?Y2VSZ2J6WE1PUDd5MVhxZFFqSFRTZkpsT2ZidXlKZXRCNXNwYnpkV20zZU5M?= =?utf-8?B?Z3cyTC9MQkczUEtWMkNvd2NGL1hQd1JPRE4xTWJ5YWZHRjZXMXJ1VTNpWFBx?= =?utf-8?B?b0hwdGl3d0pDQzdGb2tidWRTVWNWU3NxVmtkb3hnTGhXbk1GNThPNi9yZ05j?= =?utf-8?B?c3lTVTlWZ1FUQVY3UEtIOWdUUGNJOUF4QktQZTg1WDhWMVR6c0U5OFYzdkpi?= =?utf-8?B?c1F2dWJxQ09hcllOdWhpNWxhaWVGMmhyVSt6cUJ3cDJWa29uMEFoeXFpZXlx?= =?utf-8?B?U2pnMnRoaE96UjZyNmhnSDIxMTNuNTZNNnBNQ1RXNjRNZXc4TmVLOXhxL1pw?= =?utf-8?B?dk1lbVovdjJUM3NGa2hZSVlGR1N0WmY0bG55QUlwTXVJL0MvRmVPaHFZSGZR?= =?utf-8?B?Y1p2MFhZcUFaQVByUVhWd3FIUmdCUDIvcnI4RU1OeU5XcnRQMm03ZHhsaUw3?= =?utf-8?B?R3ZpNzdOZFcvY2RjYlZYYitIZXloQkhTNktRWXIzbCt3QVd4NE9nU24rNlQ5?= =?utf-8?B?K05GYm5UcVBiMXBqZmtIbk5zdHh1bEd3QTFtelAwRTl4cnlKRmhuSENzWVdO?= =?utf-8?B?dXV0YnNGZ1pjZHhqV3Y3SVRKbnBkREg0U1lweGFST3poY211QUhjc3lyT3Zn?= =?utf-8?B?UEJ0b1ZnNSs0OFlJci84dnNsYkphNVMwUkZ5RGR5QjJTa1gyNjBiV2tOMklx?= =?utf-8?B?MHEyL3phanIzL1VPU2hwb0RVeTVmc1FtWjhzTmdoT29sV2FDcmY5M1o0Zys4?= =?utf-8?Q?IQToC06MROMB8GbbmaMRhMk=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 63174cde-c525-4d2f-4240-08da01da8c9e X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2022 14:39:00.3932 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hOqWMml7yGYp4JtNqYN/buf53Hp6JXSfL5z9mmPfnjPr7CJNJQtm69xaVGgnYTvbTPz9TPgbKVxmLtI9aEA3XQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6764 X-Spam-Status: No, score=-3032.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Mar 2022 14:39:05 -0000 On 09.03.2022 15:27, H.J. Lu wrote: > On Wed, Mar 9, 2022 at 12:21 AM Jan Beulich wrote: >> On 04.03.2022 15:18, H.J. Lu wrote: >>> On Fri, Mar 04, 2022 at 02:34:58PM +0100, Jan Beulich wrote: >>>> --- a/ld/ld.texi >>>> +++ b/ld/ld.texi >>>> @@ -1372,6 +1372,12 @@ missing properties in input files. @opt >>>> the linker issue an error for missing properties in input files. >>>> Supported for Linux/x86_64. >>>> >>>> +@item lax-pcrel-relocs >>>> +Relax relocation overflow checks for certain 32-bit PC-relative relocations >>>> +which, when used by 32-bit code inside a 64-bit object, may require a >>>> +larger range of values to be considered valid. >>>> +Supported for x86-64 ELF targets. >>>> + >>> >>> I think the check should be turned on automatically. Can you use a GNU >>> property bit to tell linker that a larger range of values should be >>> checked for R_X86_64_PC32 >> >> I'm not convinced that would be desirable - the relaxed checking, after >> all, also affects relocations to 64-bit mode. Hence certain overflows >> won't be detected anymore. Therefore I'd expect people to make use of >> the new option only if they really have any affected relocations in >> 32-bit code. Additionally there's no way I can see to set such a >> property indicator when encountering the relocations in question only >> in data definitions, unless you wanted to tie the setting of the >> indicator to the mere use of .code{16,32} anywhere in the source (which >> would feel way to aggressive to me). IMO this level of control can only >> be achieved via command line option (without (a) becoming much more >> intrusive or (b) introducing new relocation types). > > A new relocation type sounds better. We've been there before with PC16 - there are enough arguments against introducing new types. I also never had the intention to propose ABI extensions. Jan